- Adding in a few missed references to Debian Jessie
- Noted instances where Jessie uses the same instructions as Trusty
- Debian Jessie includes Apache2.4 so needs to use those steps.
- Added Jessie to postgres server install
Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Ben Shum <bshum@biblio.org>
LP#1449283: fix auth when running under Apache 2.4
When running under Apache 2.4 using the stock configuration
derived from apache_24/eg_vhost.conf.in, protected
URLs such as https://eghost/reporter/ that are meant to
require valid EG staff credentials were not in fact
requiring authentication.
This patch does the following to fix this:
[1] Removes several uses of "Require all granted" that
was causing authentication to be ignored.
[2] Changes OpenILS::WWW::Proxy::Authen so that it always
sets the username in the Apache request object if
authentication was successful; it appears that starting
with Apache 2.4, authentication handlers must ensure
that a user name is set for a "Require valid-user"
directive to work.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Boyer [Mon, 2 Mar 2015 20:06:33 +0000 (15:06 -0500)]
LP#1427309 Fix Crash in Collections User Balance Summary
Previously a patron in collections that paid off all
transactions would cause a crash and stop processing
any balance summary file that they are supposed to
appear in. Now user balance summaries can be created
in full even if some users have a 0 balance.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Stephenson [Tue, 14 Apr 2015 14:43:49 +0000 (10:43 -0400)]
LP 1444130: Add max_chunk_size guards to Holds.pm.
Web staff client fixes introduced a bug in using the Clear
Holds Shelf checkin modifier. Commit 4ccbf980 added calls
to max_chunk_size on the client to use chunked responses for
better feedback during long operations. Thise works just
fine when a regular OpenSRF AppRequest is used, but leads to
a network error when AppSubrequest is used, as apparently the
xul client does with the Clear Holds Shelf checkin modifier.
This commit adds code to check if the client object can do
the max_chunk_size call when the max_chunk_size call is
made. This will prevent the network errors in cases where
the client is an AppSubrequest object and will still use
chunked responses when the client is capable of doing it.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
This commit moves the lost fine logic out of the lost processing
portion of Circulate.pm and into the new handle_fines() method.
This is accomplished through setting a new flag and lost
options hash on the main Circulator object.
This change improves the overall process flow, and in doing so
addresses a bug where overdue fines could be doubled if both
restore-overdue-on-lost-return and generate-new-overdues-on-lost-return
are enabled. Before this change, the new fines would generate before
the old fines were unvoided, which effectively circumvented the max
fines setting.
A secondary change made here is that stop_fines is also now being set
during the handle_fines() stage. This improves any case where overdues
are being set on checkin, particularly lost returns, as the stop_fines
will end up as the proper value of MAX_FINES or CHECKIN.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Fri, 20 Feb 2015 22:28:44 +0000 (17:28 -0500)]
LP#1443952 Move overdue restore above lost void/adjustment
If a person loses something and has their overdues voided/zeroed,
then pays for part of it, then returns the item, the part they
actually paid should apply to the overdues. In order for this to
happen, the overdues must exist *before* the lost fines are adjusted.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
LP#1442695: install purge_pending_users.srfsh to /openils/bin by default
Since purge_pending_users.srfsh is in the example crontab, it should
be installed to the Evergreen binaries directory (typically /openils/bin)
by default.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
LP#1442701: prune 'message_id' and 'single' CGI params from TPAC dashboard links
This patch fixes a bug where if one goes to the single patron
message view in TPAC, clicking on the 'Message' button in the
dashboard button bar does not return one to the list of messages, but
instead takes the user back to the single message the user was
viewing. This patch also prunes the CGI parameter from other
links in the patron dashboard.
Refresh the PO summary amounts (spent, encumbered, estimated) each time
an amount-changing event occurs. These include changing the lineitem
price, adding/removing a direct charge, and adding/removing copies via
the copy grid.
Note that adding/removing copies via the batch-updater alread causes a
page refresh, which updates the summary amounts.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Mon, 6 Apr 2015 18:54:55 +0000 (14:54 -0400)]
LP#1380803 Include direct charges in PO esimated price
Move the estimated PO price calculation into the middle layer, along
with the total encumbered and spent calculation. Add a new
PO.amount_estimated field for carrying the data.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
DOCS: Simplify release notes entry for AccessHandler
This commit trims down the AccessHandler docs to provide a simpler
introduction to the feature for use in the release notes. Also, a few
minor wording edits were made.
Bill Erickson [Mon, 6 Apr 2015 15:24:33 +0000 (11:24 -0400)]
LP#1436906 clean up PO direct charges on delete/cancel
1. Deleting a "direct charge" from a PO removes the linked fund_debit if
the fund_debit has not been paid (i.e. it's still encumbered).
If the debit has been paid, the charge cannot be removed, unless/until
the debit is re-encumbered by un-invoicing the charge.
2. When a PO is canceled, fund_debits linked to PO items are removed.
As above, if the debit has been paid (invoiced), the PO cannot be
canceled, unless/until direct charge debits are un-invoiced.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
LP#1435494: do not encourage <resultset_limit></resultset_limit>
An empty node in opensrf.xml gets parsed as an empty hashref,
not an empty scalar, so we'll use <resultset_limit>0</resultlet_limit>
in the suggested opensrf.xml config. This fixes an issue
noticed by Ben Shum during testing where reports could fail with
the following message:
DBD::Pg::st execute failed: ERROR: syntax error at or near "0"
LINE 43: ) limited_to_HASH(0x2a974f8)_hits LIMIT HASH(0x2a974f8)
^ at /openils/bin/clark-kent.pl line 243.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Galen Charlton [Fri, 20 Mar 2015 20:33:39 +0000 (20:33 +0000)]
LP#1435494: set limits on Clark Kent's resource usage
Clark Kent can sometimes consume more RAM, swap space, or CPU
than is reasonable or productive. For example:
- a badly constructed query with multiple Cartesian joins may
never terminate, potentially tying up a Clark child process,
pegging a CPU on the database server, and/or causing significant
scratch disk usage on the database server keeping a snapshot alive.
- a query that returns a very large number of rows can cause a Clark
child to bloat, and in extreme cases cause a OOM on the server
running Clark.
- a report that asks for a chart of an unreasonably large number of
rows can peg a CPU on the Clark server as GD::Graph attempts to
compute sub-pixel graph elements.
In each of these cases, a requested report may never finish.
This patch adds the ability set set some limits on Clark. These
limits can be set either in opensrf.xml for the settings service
to distribute or via command-line switches to clark-kent.pl:
Number of minutes to allow a report's underlying SQL query
to run before it gets cancelled. Default value is
60 minutes. If a report's query gets cancelled, the
error_text value will be set to a valid that indicates that
the allowed time was exceeded.
If set, truncates the report's output to the specified
number of hits. Note that it will not be apparent
to a staff user if the report's output has been
truncated. Default value is unlimited.
This patch also adds the ability for the concurrency
to be set via an opensrf.xml setting (//reporter/setup/parallel).
If both a command-line switch and an opensrf.xml setting
are supplied, the value set in the command line takes
precedence.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
This patch adds new CSS classes for pieces of the
patron message display, uses a preformatted display
for the message body, and fixes an HTML nesting error.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Galen Charlton [Tue, 31 Mar 2015 21:23:22 +0000 (21:23 +0000)]
LP#1442254: adjust how sending library set for messages created from notes
When creating a new user message from a public note, the library
of the workstation of the staff member who created the original
note is used if available from get_audit_info(). If it's not
available (e.g., if notes are added using direct SQL, the
home library of the note creator is used instead).
The biblios.net Z39.50 server has not been functional for years.
Remove it from the list of Z39.50 servers that we populate in a
default install of Evergreen.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Jason Stephenson [Tue, 24 Mar 2015 16:49:39 +0000 (12:49 -0400)]
LP 1435966: Clark Kent should write lock file after it forks.
Rearrange the code in clark-kent.pl so that the lock/pid file is
opened and written to after the reporter daemonizes itself. This
way, the pid in the file can actually be used to stop the running
reporter daemon.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Bill Erickson [Fri, 6 Mar 2015 16:04:01 +0000 (11:04 -0500)]
LP#1234220 Improve hold/copy ratio renewal messages
Display friendlier messages in the TPAC and staff client client when a
hold/copy ratio rule prevents a renewal.
This creates top-level ILS events for total/avail hold copy ratios,
since that's what best works with the staff client. The TPAC displays a
simple "item is needed for a hold" message, whereas the staff client
displays the raw event description, which is slightly more descriptive.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Remington Steed [Wed, 11 Mar 2015 21:23:57 +0000 (17:23 -0400)]
LP#1413624 Docs: Move Access Handler docs to official docs
This commit moves the new Access Handler doc file to the official docs
folder, adds the file reference to the root.txt, changes the main header
text for easier linking, adds the missing block delimiter lines around a
code block, and adds a blank line at the end of another doc file to
prevent the docs from running together.
Remington Steed [Wed, 21 Jan 2015 19:14:00 +0000 (14:14 -0500)]
LP#1413621 Docs: Minor changes to Apache Rewrite Tricks
This commit moves this doc file from TechRef into the official docs
area, adds it to the root.txt file, and adds line breaks for easier
viewing and editing of the file.
To properly integrate updated receipt template editor documentation
we origimally used invalid level 5 AsciiDoc headings. Asciidoc only
supports 4 levels of headings
Remington Steed [Fri, 6 Mar 2015 15:46:50 +0000 (10:46 -0500)]
Docs: 2.8 feature "Deleted flag for copy locations"
This commit documents the new 2.8 feature, the ability to delete copy
locations. It also updates the screenshot, and adds lines to document
other common features of the interface.
Yamil Suarez [Thu, 5 Mar 2015 17:26:38 +0000 (12:26 -0500)]
LP#1403967: show 'subject heading thesaurus' value release notes
The 'subject heading thesaurus' basically defines the issuing authority
that created the authority record. For example, a value of "a" means that
it came from LoC. A value of "n" means that it is a locally created
authority. Note that within the authority MARC editor the 'Subject
Heading Thesaurus' is stored/displayed in the 'Subj' fixed field.
Jason Stephenson [Wed, 18 Feb 2015 21:28:31 +0000 (16:28 -0500)]
LP#1424755: Org Unit Setting view permissions can be bypassed
Fix private org. unit setting leakage by forcing the $auth argument
to true if not passed in when open-ils.actor.ou_setting.ancestor_default
or open-ils.actor.ou_setting.ancestor_default.batch are called.
Other than a change to the desc of the public methods to reflect that
they now check permissions if permissions are required, there are no
required api changes to the back or the front ends.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Kathy Lussier [Mon, 2 Mar 2015 20:06:03 +0000 (15:06 -0500)]
lp1427331: Remove relator information from author links
Removes the display and linking of relator information from the author field
on the search results page. The display of subfield e was limiting the number
or results retrieved when clicking these links.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
It was decided that these changes caused too much potential for
confusion, and would be better served by a simultaneous change to
making 'granularity' case insensitive. Pulling back for now.
Bill Erickson [Mon, 11 Aug 2014 20:45:21 +0000 (16:45 -0400)]
LP#1287370: allow AutoGrid to persist filter state and page offset
By turning on a new AutoGrid option called urlNavigation,
the current filter and offset is stored in a URL parameter
called djgridops. This permits using the back button
to return to an AutoGrid page at the place in the search
results where the user left it.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Adam Bowling [Tue, 20 Jan 2015 21:54:11 +0000 (16:54 -0500)]
LP #1406350 Mobile Device Navigation Issue Fix for Shelf Browser
Currently, when a browser window is narrowed too much, whether
in a mobile browser, or on a desktop or laptop machine, the
"Previous Page" and "Next Page" navigation links disappear. The
only solution that seems to solve this is by removing the
"THEAD" element from the shelf browser table.
This patch removes that tag, adds a new row to imitate a new
border as existed before, and modifies the CSS in .../opac/
css/style.css.tt2 to address that difference.
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Yamil Suarez <yamil@yamil.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Josh Stompro [Tue, 13 Jan 2015 19:36:40 +0000 (13:36 -0600)]
LP#1205072 - Assorted fixes for action trigger granularity settings
- Added "weekdays" option to match up with example crontab file
- Change granularity example back to lowercase
- Change granularity labels to lowercase in the docs
Bill Erickson [Wed, 26 Nov 2014 19:31:41 +0000 (14:31 -0500)]
LP#1205072 A/T granularity UI sane default, honors case
Present A/T granularity options as untranslated, lower-case strings to
match the crontab examples. Also, honor alternate case variations for
granularity values so that "Daily" and "daily" are both seprate, valid
options.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Tue, 4 Mar 2014 16:31:13 +0000 (11:31 -0500)]
LP#1287791: Restrict authority browse to controlled subfields
Back in bug 1175308 I added some logic that improves the behavior
of the MARC editor's right-click authority popup. Now we need to
go a little farther and adjust that logic to be more careful about
which subfields it uses to browse for authority records. Specifically,
it should only use controlled subfields.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Pearl [Fri, 15 Mar 2013 19:04:37 +0000 (15:04 -0400)]
LP#1155313: Repair generation of label_sortkey for monograph_part entries
The evergreen.lpad_number_substrings function attempts to codify numeric
fields within labels. It does this by finding the strings, padding them
to a given size, and replacing them in the source string. For instance:
3 => 0000000003
15.4 => 00000000150000000004
Many database tables need to explicitly set the id sequence (often to
100) to provide room for stock data with static ids. This commit does so
for vandelay.merge_profile, and also updates the ids of any non-stock
profiles (both in the merge_profile table and in related settings).
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
In a previous commit, code was added for force summaries to be limited
to a certain type (to prevent cross type contamination of summaries).
This had the negative side-effect of preventing summaries on units, as
the units were not requesting a 'type' for their summary.
While we could force the unit code to send a type, it seemed generally
more flexible to restore the removed support for returning all summary
information in the absense of a requested type. This could lead to
cross-type summaries for units, but that is a larger issue altogether
(i.e. how we can properly support cross-type units at all).
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Kathy Lussier [Sat, 21 Feb 2015 14:50:13 +0000 (09:50 -0500)]
lp1373203: Allow users to escape metarecord holds
Provides a means for users to escape a metarecord hold if they accidentally
clicked the Advanced Hold Options link. A Basic Hold Options link will be
provided to allow the user to return to a title hold. If the hold starts as a
metarecord hold, the basic hold options link won't display since we don't know
which bib the patron wants.
Also fixes an issue where the hold cancel button always returned the user to
the previous screen. We will instead utilize the existing hold_source_page
parameter to identify the return page.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>