LP2051156 Mark Item as Missing Pieces barcode field too wide Prior to this change, the barcode input field was the full width of the screen and the submit button was below it. This small change makes it more consistent with other screens. Release-note: Fixes overly large barcode field on Mark Item as Missing Pieces page. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2047588 Correct placement of Save Notes button Moves Save Notes button in OPAC > My Lists > Edit Notes one column to the right so that it appears in the correct column when editing notes. Release-note: Fixes placement of Save Notes button in public catalog My Lists page Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2051879 Display Org Unit ID in Org Configuration This makes the numeric org unit ID visible in the Organizational Unit Configuration Interface. Release-note: Displays Org Unit ID in Org Config interface. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#2051944: Improve FMREC primary key column test FMRecordEditorComponent was depending on the @reporter:datatype to identify the primary key (identity) field for an FM class. Instead, it should check the field name against the @oils_persist:primary attribute of the <fields> element, which gets around the special case of org unit id having a declared datatype of "org_unit", and future-proofs against other possible edge cases. This commit does that. To test ------- [1] Update the Organizational Units page's form to include "id" as a visible field, a la bug 2051879. [2] Note that the form display a selector. [3] Apply the patch and recompile the Angular staff client. [4] This time, the OU ID should display as a read-only number. Release-notes: Makes it possible to display the org unit ID as a number on Angular record editor forms for editing org units Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP#1329872 - marc_export exit when required IDs are missing The marc_export script would handle being passed invalid or empty IDs as if you had the --all flag selected. So if you accidentally generated a file with a list of BIB id numbers that was empty and passed it to the script, you would end up with an export of all bibs in the system instead of an empty export. Testing Notes: === Before fix === Create an empty file, or a file that just contains "id". $ touch input1 $ echo "id" > input2 All these commands should result in a full export of all bibs. $ cat ./input1 | marc_export $ cat ./input2 | marc_export $ echo "id" | marc_export $ cat ./input1 | marc_export --pipe === After fix === Try the same commands as above, and the marc_export script should error out each time. Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP2047704 Patrons with Negative Balances - Grid Columns This adjusts the negative balances grid so that it shows the most useful columns by default and upon reset. (Before this change, resetting the columns showed ALL available columns.) It also adds local column sortability. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1803788 Gear icon for AngularJS grid settings menu Changes the icon for the grid settings dropdown menu in AngularJS screens from the default Bootstrap downward caret to the gear icon, to match the Angular grid buttons. Release-note: Ensures that both AngularJS and Angular grids use a gear icon for the grid settings menu. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#2056204: support "Form of item" in MARC editor for electronic resources This patch adds mappings to the Angular and AngularJS MARC editors so that the "Form" (form of item) fixed field positions in the 006 and 008 fields are recognized and (in the case of the 008) editable via the "Form" input when the record type is "m" (electronic resources/computer files). Release-note: Fixes problem where "Form" value could not be saved in MARC editor for electronic resources. To test ------- [1] Open a bib record of type 'm' (electronic resource) in the Angular MARC editor. [2] Change the form value with the input labeled "Form". [3] Note that the corresponding position in the 008 is not updated. [4] Apply the patch and repeat steps 1-3. This type, the change should stick. [5] Bonus: do the same testing in the AngularJS MARC editor. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2050227: Add release notes Add release notes about the IDL improvement and clean up to the Architecture section. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2050227: Fix IDL after validation with xmllint Fix "relteype" for "reltype" typo on line 1490. Remove redundant (and empty) retrieve permission on old line 7339. The above resolve errors reported by `xmllint --scheam fm_IDL.xsd fm_IDL.xml`: fm_IDL.xml:1490: element link: Schemas validity error : Element '{http://opensrf.org/spec/IDL/base/v1}link', attribute 'relteype': The attribute 'relteype' is not allowed. fm_IDL.xml:1490: element link: Schemas validity error : Element '{http://opensrf.org/spec/IDL/base/v1}link': The attribute 'reltype' is required but missing. fm_IDL.xml:7339: element retrieve: Schemas validity error : Element '{http://open-ils.org/spec/opensrf/IDL/permacrud/v1}retrieve': This element is not expected. Expected is one of ( {http://open-ils.org/spec/opensrf/IDL/permacrud/v1}update, {http://open-ils.org/spec/opensrf/IDL/permacrud/v1}delete ). fm_IDL.xml fails to validate Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2050227: Fix indentation in IDL Replace whitespace at the beginning of lines with tabs, using the vim and Emacs configuration of four spaces to a tab. Some comments and CDATA sections were also updated. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2050227: Improve IDL format Update line wrap and spacing based on the output of the libxml2 program used to identify and update the required fields in the previous commit. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2050227: Update fm_IDL.xml required fields Add the oils_obj:required="true" attribute to the IDL fields that are actually required by the database. A required field is one that derives from a base table column that has a "NOT NULL" constraint and does not have a default value. IDL objects that are virtual or read-only are skipped as are virtual fields. Fields that already have the oils_obj:required attribute set are not changed, even if the fields do not meet our criteria for being required. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#1869971: (follow-up) also apply HTML::Defang in the OPAC templates This patch ensures that HTML::Defang (via the defang_string() TT helper) is applied to the value of the OPAC custom CSS library setting. This provides additional protection in cases where questionable values predate these patches or if another means (such as direct database entry) is used to set the value of the setting. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
lp1869971 use HTML::Defang to clean incoming via org unit setting Release-note: Remove potentially harmful javascript from the opac.patron.custom_css library setting when it is saved and before it is shown to a user. Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2057432 Add shadows to dropdowns and active tabs Release-Note: Adds drop shadows to open dropdown menus and active tabs in the Angular staff interfaces to help set them apart from the contents of the page. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#2034617: improve how AngularJS handles logout BroadcastChannel messages This patch reduces the risk that if there are multiple tabs of the AngularJS staff client open, that logging out from one of them will cause a storm of logout messages on the eg.auth BroadcastChannel. If the open staff client tabs are all AngularJS, the result of that storm can freeze the user's browser. However, if one or more of the tabs are running the Angular client, the Angular tabs can _also_ make repeated open-ils.auth.session.delete calls at a high rate of speed, thereby degrading the availability of the open-ils.auth service. Testing involves opening up 4 or 5 tabs running the staff client, with at least three or four of them running the AngularJS client. It is strongly recommended that testing of this patch be done only on personal, isolated test Evergreen systems. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>