Dan Scott [Wed, 5 Oct 2011 03:04:15 +0000 (23:04 -0400)]
i18n: Fix es-ES illegal use of '%' in lang.dtd
The '%' character is used to include previously defined blocks in DTD
files; would be nice if translate-toolkit gave a more obvious error to
alert us to this rather than saying the en-US doesn't validate and
dying.
Dan Scott [Tue, 4 Oct 2011 18:40:44 +0000 (14:40 -0400)]
Slightly updated about.html for rel_2_1
Not sure we want to actually keep listing individuals in this file -
there's a lot more credit to spread around - but at least I can bring it
somewhat up to date with current info.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
1 - You have new DEBUG_CLIENT permission (after login)
This should work even on operator change.
Once a given debug interface is open you can change operator back.
2 - You have a client with the debug preference enabled
This causes the client in all places I touched to think you have DEBUG_CLIENT
This also allows debugging *before* login, including in the Standalone interface.
Debug functions I know of:
Debug box on login page (already protected by pref)
Debug items in Admin menu
Venkman
Javascript Shells
Inspector
Chrome List
CTRL+SHIFT+F7 debug box in overlays
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Adds support for a print_custom.js file and an org unit specified file.
If either exists and contains a print_custom function it will be called
before printing to allow for DOM manipulation.
If neither exists the print_win.js file will call all functions it has
defined.
In addition, if any code sets do_print to false the window will close
instead of attempting to print.
The print_custom function will receive the type of template used, if any.
This only applies to "Receipt Template" based print jobs, and the type in
question is the "Type" that shows in the template editor.
Functions defined in print_win.js:
print_init
Main function, checks for print_custom and does final printing
print_do_sums
Does summing of values.
print_check_alt
Does swapping out of template blocks with display:none styling.
print_check_noprint
Disables printing under certain circumstances.
For more information about usage of the print_do_sums, print_check_alt,
and print_check_noprint functions check the comments in print_win.js.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Default is "Only allowed to change username if it looks like a barcode".
There is a "Lock Username Changes" option to disallow username changing via
the OPAC entirely, useful if syncing usernames to an outside source.
There is also a username change limit disabling option that, if enabled and
the Lock option is disabled, allows the previous behaviour of unlimited
username changes.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
In TPac, enforce the "username can't look like a barcode" rule.
Add new setting for username validation. If set, usernames must match.
Add patron registration checks for usernames:
No spaces
If set, can look like a barcode (initial/no username picked)
If set, can look like a username
If both set, must look like one of them
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Alter backend to check password period, not just for password changes.
Add form elements for asking for current password to JSPac and TPac.
Add handling for said form elements where needed.
Add handling for "incorrect password" events in TPac.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Amount of time seed is valid
Amount of time to keep failure count in memcache since last auth event
Number of failures before locking out auth attempts
Also, remove seed from memcache once it has been used once.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
link asset.copy_template.status to config.copy_status in the IDL
If nothing else, this provides a dropdown for status in the copy
template editor (the one for Serials, under the admin menus, not the
one on the copy editing interface).
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 4 Oct 2011 03:22:27 +0000 (23:22 -0400)]
TPAC: Fix searchbar typo by closing div
Nesting of divs was thrown off, resulting in the footer appearing in the
wrong place in search results / record display / etc, with the result
that the footer inherited the 974px width instead of full 100% width.
Mike Rylander [Mon, 3 Oct 2011 19:01:26 +0000 (15:01 -0400)]
Correct Located URI visiblity
Located URIs should be visible when they exist at the search context org unit
or an ancestor thereof. However, before the change embodied in this commit,
they effectively acted exactly like copies, making records visible anywhere
within the context+depth range.
An example, using the stock example OU hierarchy:
* Before this change, a Located URI with an owner of BR1 would cause its
record to show up in a search at (or scoped to via a depth parameter) BR1,
SYS1 or CONS.
* Before this change, a Located URI with an owner of SYS1 would NOT cause its
record to show up in a search at (or scoped to via a depth parameter) BR1!
* After this change, a Located URI with an owner of BR1 will cause its record
to show up only in a search with a context OU of BR1, irrespective of depth
scoping.
* After this change, a Located URI with an owner of SYS1 WILL cause its
record to show up in a search with a context OU of BR1 or SYS1, regardless of
depth scoping.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Tue, 4 Oct 2011 01:58:17 +0000 (21:58 -0400)]
TPAC: Replace dashboard images with CSS
Also gets rid of a number of tables and a bunch of CSS definitions with
hard-coded widths that will cause trouble when longer translated terms
get dropped into place.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 30 Sep 2011 20:01:22 +0000 (16:01 -0400)]
TPac: Facets on results page
Show search facets along the left side of the results page. Clicking on
a facet re-runs the current search with the new facet appeneded.
Selected facets are styled to indicate they are selected. Clicking on a
selected facet removes that facet from the set of selected facets (i.e.
it backs out the facet).
TODO: update CSS to match default Evergreen skin
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Michael Peters [Mon, 3 Oct 2011 20:07:30 +0000 (16:07 -0400)]
Tweak the tab shape in TT OPAC
A slight modification to the "tab" elements throughout the OPAC to make them look more like tabs on a file folder. I
found the rounded off bottoms less attractive, so I flattened them out to flow more evenly with the rest of the page.
Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Mon, 3 Oct 2011 02:59:28 +0000 (22:59 -0400)]
TPAC: Simple CSS gradients for the header/footer
Firefox, Safari, Chrome, Opera, and the Android browser support
gradients. Use them. iOS 5 will support gradients. IE does not,
naturally, but support is promised for IE 10.
Including better IE support.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 30 Sep 2011 16:19:35 +0000 (12:19 -0400)]
TPac: propagate searches to advanced search page
The link that takes users to the advanced searc page now propagates
any existing (well, all) search URL params. The change required some
minor augmentation to the code that builds the advanced search form.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells posted a fix to the DEV list for receipt printing that allowed the
receipt printer to print UTF-8 characters. I used the ideas in that fix to
modify spine_labels.js. In spine_labels.js, the url passed to the preview in
preview_xul_192 was encoding the url with the javascript encode() function.
This function does not preserve UTF-8 encodings. I changed the function to
encodeURIComponent, and UTF-8 characters are now displayed properly by the
spine label printer code.
Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Thu, 29 Sep 2011 15:57:46 +0000 (11:57 -0400)]
Added missing Penalty module import for AssetCommon
The lack of import primarily affected the Action/Trigger MarkItemLost
reactor, which does not already import OpenILS::Utils::Penalty directly
or indirectly.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Thu, 29 Sep 2011 03:06:19 +0000 (23:06 -0400)]
Remove an installation step: Listen 443 uncommenting
Every distribution known to man ships Apache listening on port 443, so
installers always have to comment out the "Listen 443" directive - so
why not just comment it out ourselves and save a step in the
installation instructions?
Mike Rylander [Wed, 28 Sep 2011 19:45:36 +0000 (15:45 -0400)]
Provide proper hrefs for links back from report debugging pages
Reimplementation of a fix provided by Michael Peters. The originally submitted
patch included several fixes provided by an unrelated patch, and a regression
in build-time embedded tokens.
Original branch at: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/clark_kent_back_links
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Thu, 22 Sep 2011 16:51:22 +0000 (12:51 -0400)]
LP856567: Mark HTML report output as Unicode-encoded
Non-ASCII characters in report ouput that has been generated in HTML
format appears to be corrupted when viewed in a browser. This can be
manually corrected by switching the "Encoding" browser option, but it
would be better to include <meta charset='utf-8'> in the output HTML to
tell the browser directly.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Tue, 27 Sep 2011 16:22:38 +0000 (12:22 -0400)]
MFHD compression fails with pattern-less captions
The current code assumes that if you try to compress a range of
MFHD holdings, you actually have the necessary pattern information.
This commit introduces a very basic check to avoid the most common
failure case.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Fri, 23 Sep 2011 14:55:28 +0000 (10:55 -0400)]
LP857460: Get the generic class scheme when adding vols
In a default Evergreen instance, in the "Add Volumes" interface for a
bib record with both LC and Dewey call numbers, the list of call numbers
from which you can select appears to be limited to Dewey, even though
the "Bib Call #" field is populated with an LC call number.
The problem is that here we're grabbing the first entry from the
asset.call_number_classification table, and you might expect that to be
the "Generic" entry - however, it turns out to be the "Dewey" entry
because the entries are ordered alphabetically by .name(), not by
database ID. (You can test this be changing the name of "Dewey" to
"Vicious" and see that the "Generic" entry is chosen instead).
This commit changes the process to first search the acnc array for a
name() = "Generic"; and then if we don't find that, fall back to the
first entry in the classification scheme.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Dan Wells <dbw2@calvin.edu>
If a transit would be generated between the current library and another and
the appropriate setting is set for both end with the same value the transit
will be suppressed. If either end is set to an empty string then transit
suppression will be disabled, even if both ends are set to an empty string.
In addition, transits from other locations will be received when their
destination shares suppression with the current library.
circ.transit.suppress_hold will cause holds to go to the hold shelf instead
of into transit when in effect. Non-hold transits should not check it. This
should be useful when multiple parts of a library share a hold shelf, but
are split on the org tree.
circ.transit.suppress_non_hold will cause items to reshelve instead of
going into transit. Hold transits should not check it. This should be
useful when multiple parts of a library are in the same building and have
no need to transit items before reshelving/cataloging.
In order to suppress *all* transits both settings need to be set.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Some EDI translation fixes for troublesome input characters
This attempts to address enough of the issues in
https://bugs.launchpad.net/evergreen/+bug/812593 to move forward.
When the ? character appears in lineitem attributes for a PO that we
send off for EDI translation, the translator fails if that ? is the last
character of the string. This commit avoids that situation.
This commit also removes any Unicode characters from the JEDI (the input
to the translator process), as they're not going to make it to the
EDIFACT output anyhow, and will just confound the translator.
This commit also pre-escapes quotation marks in lineitem attributes so
that we don't produce invalid JSON for our JEDI.
This commit also destroys the death star.
Seriously, the right way to fix some of the issues people have had is
for somebody to learn Ruby and to address them either in edi_webrick.rb, in
edi4r, or in openils-mapper (wherever the issues may be). Working on
that.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 14 Sep 2011 18:25:41 +0000 (14:25 -0400)]
TPac: Page through search results on details page
Consistent with jspac, when you land on a record details page and you
got there from doing a search, let the user page through the search
results directly on the record detail page.
This also includes the necessary JS callbacks to support paging in the
staff client.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Mon, 19 Sep 2011 02:27:00 +0000 (22:27 -0400)]
TPAC: Add some style to MFHD holdings summaries
Simple grey background for the holdings summary header for each record;
add a TBODY element to the holdings table for validity; offset the MFHD
type by 1em to group entries under each holdings location.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 19 Sep 2011 01:12:23 +0000 (21:12 -0400)]
TPAC: Give MFHD summaries OU / depth awareness
Rather than returning all results and filtering on the client-side, as
we're currently doing in the JSPAC, teach the
open-ils.search.serial.record.bib.retrieve method to accept optional OU
& OU depth arguments and do the filtering in the query; cuts down on
network traffic and should be generally more efficient.
Note that in the absence of an explicit "depth" CGI param,
EGCatLoader/Record currently defaults to a depth of "0"; we could
teach it to look up & cache the depth of the "loc" param for the sake of
convenience & arguably more accuracy.
Also note that the sub/dist serial approach probably needs to be taught
similar method-side filtering, but I hope more knowledgeable brains will
work out what should happen with ssub.holding_lib / sdist.owning_lib.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
lp859190: make marc_stream_import always import non-matches
Fixes regression of (implicit, undocumented) functionality
introduced in commit da3a45344205. Current use case for
the streaming MARC importer for OCLC Connexion exports assumes
that non-matching records should always be added.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jeff Godin [Wed, 21 Sep 2011 20:41:19 +0000 (16:41 -0400)]
Fix: Current Bills thinks it is Bill History
This fixes LP 855894: Bills interface calls itself Bill History,
uses bills_historical receipt template
https://bugs.launchpad.net/evergreen/+bug/855894
At some point in development, the Current Bills and the Bill History
interface were in a unified file, with an xul_param of "current" used
to switch between the two.
Nothing currently sets the xul_param "current", so the Current Bills
interface (bill2.xul and bill2.js) was improperly:
* not hiding the xact_finish column
* using a caption label of "Bill History"
* using the bills_historical receipt template
The Bill History interface was okay -- "not current" was the default.
This commit removes the tests for xul_param('current') and uses the
appropriate code for each interface.
// this code in both bill2.js and bill_history.js:
var template = 'bills_historical';
if (xul_param('current')) template = 'bills_current';
// becomes:
var template = 'bills_current'; // in bill2.js
var template = 'bills_historical'; // in bill_history.js
Bill Erickson [Thu, 22 Sep 2011 15:10:09 +0000 (11:10 -0400)]
Stamped upgrade script for ACQ fund view repairs
At the heart of this change is the need to force acq.fund_debit_total to
return exactly 1 row per fund, instead of 1 per fund + encumbrance
value. However, such a change required rearranging a number of
dependent views.
Also added acq.fund_spent_balance to the set of views that needs
dropping and re-building.
Minor SQL format change to match surrounding code in schema file
See also https://bugs.launchpad.net/evergreen/+bug/800477
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Thu, 22 Sep 2011 05:11:06 +0000 (01:11 -0400)]
Password resets: avoid run-on subjects
The password reset template had a space on the first blank line after
the Subject: which lead to the first paragraph being tacked onto the
Subject line. Get rid of the space, and create an upgrade script ready
to roll.
Bill Erickson [Mon, 19 Sep 2011 22:18:41 +0000 (18:18 -0400)]
TPac: integrated patron password reset
Port the existing password reset functionality into TPac. This allows
us to leverage the TPac innards for localization. It also means there's
one less moving part. (and, incidentally, no more dojo for the form).
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>