working/Evergreen.git
2 years agoLP#1736269: Mark Missing Pieces is non-functional
Mike Rylander [Fri, 1 Jun 2018 17:50:21 +0000 (13:50 -0400)]
LP#1736269: Mark Missing Pieces is non-functional

In the work to separate the item service into a reusable component, a
reference to $scope was left hanging around.  This causes the service to die
before it can complete its work.  The code using $scope does seem to be
necessary, so we'll have the function accept an outer_scope parameter and
adjust the call sites.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP#1745462: avoid trying to validate empty fields
Galen Charlton [Thu, 25 Jan 2018 19:57:40 +0000 (14:57 -0500)]
LP#1745462: avoid trying to validate empty fields

This patch is the belt to the previous patch's suspenders and ensures
that the web staff client does not attempt to authority-validate headings
fields in the MARC editor if they're empty (i.e., no subfield values).

To test
-------
[1] In the web staff client, create a new bib. Ensure that at least one of the
    authority-controlled fields has no subfield values.
[2] Hit the Validate button.
[3] Note that the field(s) with empty headings show the tick
    mark indicating that they've been "validated".
[4] Apply the patch and repeat steps 1 and 2. This time, empty headings
    field should not be checked.
[5] Verify that validating headings that are not empty does continue
    to work.

Patch inspired by Mike Rylander.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP#1745462: guard against scanning entire authority table
Galen Charlton [Thu, 25 Jan 2018 19:40:47 +0000 (14:40 -0500)]
LP#1745462: guard against scanning entire authority table

This patch ensures that if, for whatever reason, a MARC editor headings
validation action includes a field whose subfield values are empty, it
ignores any cases where the normalized heading works out to NULL or the
empty string. Otherwise, the database can be asked to fetch the IDs
of most/all records in the database, and open-ils.cstore backend can be
asked to store the entire result set in memory.

To test
-------
[0] Ensure that statement logging is turned on in the PostgreSQL database.
[1] In the web staff client, create a new bib. Ensure that at least one of the
    authority-controlled fields has no subfield values.
[2] Hit the Validate button.
[3] Note that the following query is logged by the database:

SELECT "are".id AS "id" FROM authority.record_entry AS "are"
WHERE "are".control_set = '1'
AND "are".deleted = 'f' AND "are".simple_heading IS NOT NULL;

[4] Apply the patch and repeat steps 1 and 2. This time, note that
    no such query is recorded.
[5] Verify that validating headings that are not empty does continue
    to work.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP#1537228 Precat subsequent checkin shows route alert
Bill Erickson [Wed, 23 May 2018 15:54:34 +0000 (11:54 -0400)]
LP#1537228 Precat subsequent checkin shows route alert

Display the 'route to cataloging' alert every time a precat copy is
checked in, consistent with the XUL client, instead of displaying
it only with the first checkin.

As with the first checkin, if the alert is configured not to display,
it will not show.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP#1746566: Enable 500, 1K, and all rows in more patron grids
Galen Charlton [Tue, 27 Mar 2018 18:56:23 +0000 (14:56 -0400)]
LP#1746566: Enable 500, 1K, and all rows in more patron grids

This enables the allowAll option in the Patron Items Checked Out
and Other/Special Circulations grids.

To test
-------
[1] Apply the patch.
[2] Verify that the Patron Items Checked Out, Other/Special Circulations,
    Non-Catalogued Circulations, and Holds grids now include row
    count options 500, 100, and All.
[3] Verify that the Item Status grid now includes the additional
    row count options.
[4] Verify that when choosing the "All" row count that you are prompted
    to confirm loading all of the rows.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP#1746566: Enable 500, 1K, and ALL-the-Rows in patron grids
Cesar Velez [Wed, 7 Feb 2018 17:05:10 +0000 (12:05 -0500)]
LP#1746566: Enable 500, 1K, and ALL-the-Rows in patron grids

This adds to the Patron (non-catalogued) Items Out, Patron Holds, and
Item Status grids an 'allowAll' grid feature which will enable the 500,
1K, and ALL (really 10K) rows/pagesize. For the ALL option a modal has
been wired to that the action can be confirmed, since it might be a
very slow operation.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP#1745207: tie together copy_tag() and site() search filters
Galen Charlton [Mon, 22 Jan 2018 23:01:00 +0000 (18:01 -0500)]
LP#1745207: tie together copy_tag() and site() search filters

The copy_tag() filter will now restrict itself to records that
have copies that both have matching copy tags and a circ_lib
within the site() scope.

To test
-------
[1] Define two digital bookplate copy tags at two difference org units, e.g.,
    "BR1 Smith" at BR1 and "BR4 Smith" at "BR4".
[2] Arrange that a record has items in both BR1 and BR4, and assign the "BR4 Smith"
    copy tag to one of the BR4 items.
[3] On a separate record, set up a similar situation, but use BR1 instead.
[4] Enable the digital bookplate search option and do a bookplate search
    for "Smith" with the scope limited to BR1.
[5] Note that both of the records set up in #2 and #3 are included in the results
    set.
[6] Apply the patch and repeat step 5. This time, only the record set up in #3
    should be included.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP1742782 - fix display of cbox label in list of removable fields
Cesar Velez [Thu, 11 Jan 2018 19:12:55 +0000 (14:12 -0500)]
LP1742782 - fix display of cbox label in list of removable fields

The checkbox input element was being displayed in the middle
of the label text.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1738499: barcode completion for copy buckets
Jeff Davis [Tue, 6 Mar 2018 18:46:49 +0000 (10:46 -0800)]
LP#1738499: barcode completion for copy buckets

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP#1692116 - Action trigger validator fix for paid Long Overdue items
Michele Morgan [Thu, 14 Sep 2017 15:48:31 +0000 (11:48 -0400)]
LP#1692116 - Action trigger validator fix for paid Long Overdue items

Adds a check for a NULL xact_finish to the CircIsOpen validator. The
result is that overdue notification a/t events for Long Overdue items that
have been paid for, and the transaction closed, will be invalid.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agolp1739286 default search box in Z39.50
Jason Etheridge [Tue, 10 Jul 2018 23:46:04 +0000 (19:46 -0400)]
lp1739286 default search box in Z39.50

This change tweaks the layout of search fields in the web client Z39.50
interface and adds radio buttons for the default search field to auto-focus.
The behavior is "sticky" without the need for an explicit Save action.  If the
current default field is not present due to a given combination of selected
services, then no field will be focused by default.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP1736243: SMS Carrier Editing in Patron Editor
Jason Boyer [Mon, 9 Jul 2018 16:47:10 +0000 (12:47 -0400)]
LP1736243: SMS Carrier Editing in Patron Editor

The XUL Client treats many user setting entries as
quoted strings. Angular needs some help to recognize
that it needs to convert these incoming "strings"
to ints for use as the data model when editing. The
str-to-int directive gives it this hint.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoDocs: fixing physical characteristics wizard representation in consolidated docs
Jane Sandberg [Fri, 6 Jul 2018 22:49:07 +0000 (15:49 -0700)]
Docs: fixing physical characteristics wizard representation in consolidated docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding indexterms to physical characteristics wizard docs
Jane Sandberg [Fri, 6 Jul 2018 22:30:52 +0000 (15:30 -0700)]
Docs: adding indexterms to physical characteristics wizard docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: configuring fixed field dropdown menus
Jane Sandberg [Fri, 6 Jul 2018 22:30:20 +0000 (15:30 -0700)]
Docs: configuring fixed field dropdown menus

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: removing broken link
Jane Sandberg [Fri, 6 Jul 2018 22:23:27 +0000 (15:23 -0700)]
Docs: removing broken link

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP1779392: Stop sending broken queries
Jason Boyer [Fri, 29 Jun 2018 18:09:51 +0000 (14:09 -0400)]
LP1779392: Stop sending broken queries

It's possible to send invalid parameters to the
search.highlight_display_fields function which
wastes a db roundtrip and fills the logs with
errors. Checking to be sure there's anything in
the parameter will prevent both.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP 1772993: Ability to blank Age Hold Protection in Vol/Copy Editor.
Jason Stephenson [Thu, 24 May 2018 13:34:17 +0000 (09:34 -0400)]
LP 1772993: Ability to blank Age Hold Protection in Vol/Copy Editor.

Add the <NONE> option to the age-based hold protection field in the
web staff client Vol/Copy Editor.

To test:

1. Add a value for age-based hold protection to a copy.

2. Attempt to remove the value in the copy editor.  Note that the
   dropdown does not allow you to do so.

3. Apply this commit.

4. Repeat step 2.  Now there is a <NONE> option that removes the value
   from the copy.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
2 years agoForward-port 3.1.3 upgrade script
Dan Wells [Fri, 29 Jun 2018 16:42:05 +0000 (12:42 -0400)]
Forward-port 3.1.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoForward port 3.0.9 upgrade script
Dan Wells [Fri, 29 Jun 2018 16:41:26 +0000 (12:41 -0400)]
Forward port 3.0.9 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoDocs: Adding 3.1.3 release notes
Jane Sandberg [Thu, 28 Jun 2018 19:21:28 +0000 (12:21 -0700)]
Docs: Adding 3.1.3 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Adding 3.0.9 release notes
Jane Sandberg [Thu, 28 Jun 2018 19:19:22 +0000 (12:19 -0700)]
Docs: Adding 3.0.9 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1635386: Restore to xul colors and remove colors from class names
Kathy Lussier [Fri, 1 Jun 2018 13:51:07 +0000 (09:51 -0400)]
LP#1635386: Restore to xul colors and remove colors from class names

This commit restores the xul display where overdue items were highlighted
in red and long overdue items were highlighted in orange. Also removes
the colors from the class names since people may decide to use totally different
colors or style the rows in different ways.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoLP#1635386 Clarify and simplify row highlighting code
Dan Wells [Fri, 23 Mar 2018 21:21:36 +0000 (17:21 -0400)]
LP#1635386 Clarify and simplify row highlighting code

The existing code had a few functional problems for me.  In the process
of fixing them, I decided it best to also apply a number of small
refactorings.  Here is a list of changes in rough order of significance:

-Made the new CSS classes test and apply once per row rather than once
per cell

-Fixed the test case for overdues: we now just look for no checkin-time
+ no lost/long-overdue stop-fines (matches XUL test)

-Made the color and icon tests totally consistent, and also simplified
where possible

-Made the widened configuration header style (to accommodate status
column) functional again (it was using old 'statusicon' class)

-Made row highlight colors '!important' to avoid bad interactions with
alternating row color styles

-Changed status-cell (and statusCell) to status-column (and
statusColumn) for a little extra clarity

-Changed nested function name from 'rowClass()' to 'apply()' for greater
code distinction (i.e. avoid 'rowClass.rowClass()' calls, and instead
have 'rowClass.apply()')

-Removed some unused variable assignments from grid.js

-Cleaned up a few field attributes for necessity and consistency

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
2 years agoLP#1635386: Improve contrast for colors used in Bills interface
Kathy Lussier [Tue, 30 Jan 2018 20:51:13 +0000 (15:51 -0500)]
LP#1635386: Improve contrast for colors used in Bills interface

The contrast between cell contents and background colors did not
meet WCAG standards. This commit provides adequate contrast to
meet AA level of WCAG standards. The red and dark red background
colors are similar to what we saw in the XUL client. The orange
for long overdue is much lighter.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
2 years agolp1635386 Items Column & Styles for Bill Item Status
Kyle Huckins [Fri, 17 Nov 2017 23:54:53 +0000 (23:54 +0000)]
lp1635386 Items Column & Styles for Bill Item Status

- CSS classes for red, dark red, and orange eg-grid-cells.
- New parameter for eg-grid 'rowClass' to take an object with a function
to set the class of a cell, allowing such customizations as coloring based
on item fields.
- Implementation of 'rowClass' on the Patron Bills interface to display
colors indicating current Fines Stop reason, based on XUL client.
- New parameter for eg-grid 'statusCell' to take an object with a function
to programattically add status icons to a new "Status Icon" column. Said
column requires a boolean in the object in order to display.
- Implementation of 'statusCell' on the Patron Bills interface to display
glyphicons based on if the bill is for a circ that is lost, overdue, or long
overdue.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_bills_list.tt2
modified:   Open-ILS/src/templates/staff/css/style.css.tt2
modified:   Open-ILS/src/templates/staff/share/t_autogrid.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
modified:   Open-ILS/web/js/ui/default/staff/services/grid.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
2 years agoLP#1773832: Empty deleted records can be surfaced in search results
Mike Rylander [Wed, 20 Jun 2018 13:22:38 +0000 (09:22 -0400)]
LP#1773832: Empty deleted records can be surfaced in search results

There are cases where we avoid checking the deleted flag of bibs as an
optimization that avoids a JOIN in the search query.  However, for some
shapes of real-world data, particularly in upgraded instances, deleted
records can slip through.  This commit adds an explicit check for the
flag to all search queries.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Daniel Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP 1758160: Bump version in upgrade_log.
Jason Stephenson [Wed, 27 Jun 2018 20:08:17 +0000 (16:08 -0400)]
LP 1758160: Bump version in upgrade_log.

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP1758160_Deleting_patrons_can_exceed_staff_client_timeouts
blake [Tue, 10 Apr 2018 00:52:08 +0000 (19:52 -0500)]
LP1758160_Deleting_patrons_can_exceed_staff_client_timeouts

Added an index to action.usr_circ_history for much needed postgresql justice.
This will increase the speed when deleting patrons with large number of circulations.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoDocs: documenting --items option of marc_export
Jane Sandberg [Wed, 20 Jun 2018 21:33:25 +0000 (14:33 -0700)]
Docs: documenting --items option of marc_export

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: improving index terms for MARC import/export options
Jane Sandberg [Wed, 20 Jun 2018 21:33:25 +0000 (14:33 -0700)]
Docs: improving index terms for MARC import/export options

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoadded fields for hold notification preference to display
Jeanette Lundgren [Tue, 19 Jun 2018 19:21:50 +0000 (15:21 -0400)]
added fields for hold notification preference to display

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoDocs: fixing broken reference in cat manual
Jane Sandberg [Wed, 20 Jun 2018 01:44:47 +0000 (18:44 -0700)]
Docs: fixing broken reference in cat manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding info about item status screen
Jane Sandberg [Wed, 20 Jun 2018 01:44:16 +0000 (18:44 -0700)]
Docs: adding info about item status screen

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP1772444: Updating list of variables in bill template descriptions
Jane Sandberg [Thu, 7 Jun 2018 17:11:43 +0000 (10:11 -0700)]
LP1772444: Updating list of variables in bill template descriptions

Bill: repaired merge conflicts and applied some additional docs
consistency across the two billing templates.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP1772444: Add Patron Names to Bill Receipts
Jason Boyer [Mon, 21 May 2018 16:09:09 +0000 (12:09 -0400)]
LP1772444: Add Patron Names to Bill Receipts

The bills_current and bills_historical receipt templates
were missing patron information. This has been added to
match most other receipt templates (money_summary is not
included since it could potentially be stale).

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1774427 Parse DoB dates as whole dates
Bill Erickson [Thu, 31 May 2018 14:58:38 +0000 (10:58 -0400)]
LP#1774427 Parse DoB dates as whole dates

Fixes DoB parsing in the browser client patron edit interface by
creating date objects from a whole YMD date string instead of compiling
the date as collection of pieces.  Compiling dates from pieces (calling
setFullYear(), setMonth(), etc.) can have unexpected consequences,
because a change of month can result in a change of days as well, if the
number of days in the date object exceeds the capacity of the selected
month.

For example:

---
> d = new Date()
2018-05-31T14:59:26.186Z
> d.setMonth(1)
1520092766186
> d
2018-03-03T15:59:26.186Z
--

Parsing as Date(YYYY,MM,DD) instead avoids this kind of shuffling.

To test

[1] Log in to the staff client on the 31st day of the month :)
[2] Change a patron's DoB to a month that does not contain 31 days.
[3] Save patron and note on reload, the DoB shows the wrong value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: Minor corrections to "Borrowing items" section
Remington Steed [Thu, 14 Jun 2018 13:31:33 +0000 (09:31 -0400)]
Docs: Minor corrections to "Borrowing items" section

This commit fixes a number of small inconsistencies in wording (between
the docs and the interface) and formatting (e.g. making menu names bold).
Also, one sentence is expanded for clarity.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoLP#1740535: retrieve list of billing types
Galen Charlton [Thu, 29 Mar 2018 15:46:03 +0000 (11:46 -0400)]
LP#1740535: retrieve list of billing types

This patch changes how the web staff client retrieves the list
of billing types available for use by the Bill Patron modal. PCRUD
permissions on config.billing_type don't quite match how the
the set of billing types available to a staff user used to work
in the XUL staff client, so this patch uses the
open-ils.circ.billing_type.ranged.retrieve.all method instead.

To test
-------
[1] Log in as a Circulators staff user (assuming stock data
    and permissions).
[2] Try the Bill Patron dialog in the web staff client; note that
    no billing types are accessible.
[3] Apply the patch and repeat step #2. This time, it should
    include the miscellaneous billing type.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP1739271 - Fix Item Edit when Part Present
Dan Pearl [Thu, 7 Jun 2018 18:20:49 +0000 (14:20 -0400)]
LP1739271 - Fix Item Edit when Part Present

Cannot edit item or call number after mono part
assigned.  This was indeed a timing error where parts were referenced before
they were completely assigned to the structure in which they were to reside.
I have restructured the code to ensure the parts are available.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
2 years agoLP1770752: clicking 'update expire date' should flag field_modified
a. bellenir [Wed, 6 Jun 2018 13:41:06 +0000 (09:41 -0400)]
LP1770752: clicking 'update expire date' should flag field_modified

ensure user is warned that unsaved data may be lost when navigating away

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#16989634 - Changing z-index to 4 to allow active text boxes to pass under patron...
Geoff Sams [Mon, 4 Jun 2018 21:23:49 +0000 (16:23 -0500)]
LP#16989634 - Changing z-index to 4 to allow active text boxes to pass under patron tabs naturally.

Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP1775294: item status should show floating group name
a. bellenir [Wed, 6 Jun 2018 00:31:46 +0000 (20:31 -0400)]
LP1775294: item status should show floating group name

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1745422 - Removed three commented out lines from the code and signoff.
Michele Morgan [Wed, 16 May 2018 14:50:59 +0000 (10:50 -0400)]
LP#1745422 - Removed three commented out lines from the code and signoff.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1745422 - Add Parts column to Patron holds grids and detail view
Cesar Velez [Fri, 16 Feb 2018 16:01:23 +0000 (11:01 -0500)]
LP#1745422 - Add Parts column to Patron holds grids and detail view

The webstaff's patron ui did not have a display for the Part,
which will be fetched for any hold type "P" (monographic part).
This adds a Part column to the hold grids and inthe detail view
IF the hold type is P, it'll append the part.label in the same
field/well.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: Adding information about activating POs
BC Libraries Cooperative [Thu, 7 Jun 2018 19:00:00 +0000 (12:00 -0700)]
Docs: Adding information about activating POs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Reorganizing purchase order chapter
Jane Sandberg [Thu, 7 Jun 2018 18:55:07 +0000 (11:55 -0700)]
Docs: Reorganizing purchase order chapter

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1773404 Update root.adoc to show 3.1 release notes
abneiman [Tue, 29 May 2018 19:26:07 +0000 (15:26 -0400)]
LP#1773404 Update root.adoc to show 3.1 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
2 years agoForward port 3.1.2 upgrade script
Dan Wells [Mon, 4 Jun 2018 13:07:33 +0000 (09:07 -0400)]
Forward port 3.1.2 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoForward port 3.0.8 upgrade script
Dan Wells [Mon, 4 Jun 2018 13:06:55 +0000 (09:06 -0400)]
Forward port 3.0.8 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoDocs: Add bullet number images removed in 2.10
Remington Steed [Thu, 31 May 2018 17:59:30 +0000 (13:59 -0400)]
Docs: Add bullet number images removed in 2.10

These number images are used by the code callout feature of AsciiDoc,
used by the new Receipt Template Editor chapter (and possibly other
docs). I had renamed them in 2015, supposedly to prevent an ePub build
error, but that broke the code callout images. And since I cannot
replicate the ePub error now, I am renaming them back to their original
state, with sincere apologies to code callout readers everywhere.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Release notes entry for lp1732975
Kathy Lussier [Fri, 25 May 2018 21:12:59 +0000 (17:12 -0400)]
Docs: Release notes entry for lp1732975

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agolp1732975 Parts Column Not Populated
Kyle Huckins [Wed, 2 May 2018 17:47:04 +0000 (17:47 +0000)]
lp1732975 Parts Column Not Populated

- Retrieve Parts information in egItem

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/item/t_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/item.js

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: Add release note for bug 1707063 to 3.0 notes
Kathy Lussier [Fri, 25 May 2018 20:49:26 +0000 (16:49 -0400)]
Docs: Add release note for bug 1707063 to 3.0 notes

I missed the 3.0 notes in the earlier commit.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: Add release note for bug 1707063
Kathy Lussier [Fri, 25 May 2018 20:44:26 +0000 (16:44 -0400)]
Docs: Add release note for bug 1707063

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1707063: Naive ng-class test for last-column-modified
Mike Rylander [Mon, 29 Jan 2018 21:37:15 +0000 (16:37 -0500)]
LP#1707063: Naive ng-class test for last-column-modified

Instead of comparing a (potentially undefined) property of a column, we'll
just compare the column object directly when checking to see if a column
header should be highlighted for "last touched in editing mode."

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: Add release notes entry for lp1766379
Kathy Lussier [Fri, 25 May 2018 20:23:05 +0000 (16:23 -0400)]
Docs: Add release notes entry for lp1766379

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1766379: add spaces between terms in author link to prevent a broken search query
Jeff Davis [Wed, 16 May 2018 18:31:43 +0000 (11:31 -0700)]
LP#1766379: add spaces between terms in author link to prevent a broken search query

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: adding to 3.1.2 release notes
Jane Sandberg [Fri, 25 May 2018 20:23:40 +0000 (13:23 -0700)]
Docs: adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: correcting description of a bugfix
Jane Sandberg [Fri, 25 May 2018 20:14:12 +0000 (13:14 -0700)]
Docs: correcting description of a bugfix

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding to 3.0.8 release notes
Jane Sandberg [Fri, 25 May 2018 19:53:28 +0000 (12:53 -0700)]
Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP1750887: Copy Objects when Saving Copy Templates
Jason Boyer [Wed, 21 Feb 2018 18:59:44 +0000 (13:59 -0500)]
LP1750887: Copy Objects when Saving Copy Templates

Copy the callnumbers and statcats objects when saving
copy templates to prevent accidental and confusing
editing of in-memory copies.

cesardv: changed tabs to spaces.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1771422 Reset transiting hold copy status fix
Bill Erickson [Tue, 15 May 2018 20:12:12 +0000 (16:12 -0400)]
LP#1771422 Reset transiting hold copy status fix

Avoid modifying the copy status in the hold-reset API when it's passing
the copy off to the transit API for canceling the transit.  Let the
transit API handle the status instead.

This fixes a bug where resetting a transiting hold, and canceling its
transit, would leave the targeted copy in "in transit" status instead of
"canceled transit".

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1750630: use proper quoting to un-break Transit List print template
Lynn Floyd [Mon, 7 May 2018 17:43:01 +0000 (10:43 -0700)]
LP#1750630: use proper quoting to un-break Transit List print template

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1528909: Patron search clickable barcodes
Bill Erickson [Tue, 22 May 2018 15:18:01 +0000 (11:18 -0400)]
LP#1528909: Patron search clickable barcodes

Patron barcodes in the patron search grid are now click-able, making it
possible to quickly open multiple patrons in new tabs from patron search
by control-clicking (or middle-clicking) the barcode links.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1721148: In-house use shows copy status
Bill Erickson [Mon, 21 May 2018 18:22:32 +0000 (14:22 -0400)]
LP#1721148: In-house use shows copy status

Adds a Copy Status column to the In-House use checkout grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLp#1760859: Add Missing Images to Tranist and Hold Slips
Jeanette Lundgren [Mon, 14 May 2018 17:26:45 +0000 (13:26 -0400)]
Lp#1760859: Add Missing Images to Tranist and Hold Slips

Added new truck transit.png image for web client holds/transit dialog

Added holds.png img tag to t_hold_shelf_dialog.tt2

Added transit.png img tag to t_transit_dialog.tt2

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1759352: improve webstaff fix checkout specific due date UX
Cesar Velez [Fri, 30 Mar 2018 15:32:45 +0000 (11:32 -0400)]
LP#1759352: improve webstaff fix checkout specific due date UX

The Date Options dropdown UI added as a result of bug 1717025
hides the state of the "checkboxes" for custom due date and
the datepicker wasn't disabled when custom due date was disabled.
This addresses these UX issues, to that the user has visual feedback
as to the state of that option.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1751126: Make print holds shelf list aware of clear mode.
Jason Stephenson [Tue, 10 Apr 2018 14:51:24 +0000 (10:51 -0400)]
LP#1751126: Make print holds shelf list aware of clear mode.

We change the Print Full List button on the holds shelf view to be
aware of whether clear mode is active.  If clear mode is active, then
the list of holds to clear is printed.  If not, then the full holds
shelf list is printed.

This commit does not change the label of the print full list button.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1772417: (follow-up) improve I18N of the bucket title string
Galen Charlton [Fri, 25 May 2018 18:25:44 +0000 (14:25 -0400)]
LP#1772417: (follow-up) improve I18N of the bucket title string

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP1772417: Adding the bucket ID to the user bucket display
Jane Sandberg [Mon, 21 May 2018 16:28:39 +0000 (09:28 -0700)]
LP1772417: Adding the bucket ID to the user bucket display

To test:
1) Open a patron bucket.  Note that the bucket ID is not listed
in the bucket information section at the top of this screen.
2) Apply this commit.
3) Open the same patron bucket.  Note that the bucket ID is
listed in the bucket information section

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1752753: Guard against invalid timezone
Jeff Davis [Fri, 2 Mar 2018 00:55:46 +0000 (16:55 -0800)]
LP#1752753: Guard against invalid timezone

If the lib.timezone org setting is not a valid timezone, attempting to
use it can result in an internal server error in the OPAC.  Let's handle
the error with try/catch instead.

To test
-------
1. In Library Settings Editor, edit the "Library time zone" setting for
   Example Branch 1, setting the value to something that's not the name
   of a time zone (like "invalid" or "UTC-07:00").
2. In the OPAC, retrieve a record with holdings at Example Branch 1.
    You will get an Internal Server Error.
3. Edit the library setting to use a valid timezone name, like
   "America/Vancouver".
4. Retrieve the same record again. This time, the record will display
   properly.
5. Apply the patch and repeat steps 1 and 2; this time, there should
   be no internal server error.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoMoving upgrade script into place
Mike Rylander [Fri, 25 May 2018 18:12:25 +0000 (14:12 -0400)]
Moving upgrade script into place

Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoStamping upgrade script
Mike Rylander [Fri, 25 May 2018 18:11:02 +0000 (14:11 -0400)]
Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1768992: Add missing copy alert permissions
Jeff Davis [Thu, 3 May 2018 22:02:07 +0000 (15:02 -0700)]
LP#1768992: Add missing copy alert permissions

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1693035 Login timeout honors workstation org
Bill Erickson [Tue, 17 Oct 2017 16:40:11 +0000 (12:40 -0400)]
LP#1693035 Login timeout honors workstation org

Use the org unit linked to the provided workstation to collect the
login timeout org unit setting value during login.  Previously, all
checks defaulted to the global org unit.

This patch solidifies the precedence order for OUS lookups during login
like so:

1. Workstation org unit.
2. API org unit value.
3. Users' home org unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1746815: Fix sticky hold url param
Cesar Velez [Mon, 5 Feb 2018 22:45:22 +0000 (17:45 -0500)]
LP#1746815: Fix sticky hold url param

Renamed the hold_id url param from "id" to "hid" and prevent it from
sticking in url's where it not needed.

To test
-------
[1] Log in to the public catalog as a patron that has at least
    two hold requests.
[2] Go to the My Account holds tab and edit one of the holds.
[3] Rather than submit a change, click on the holds tab again.
[4] Note that /only/ the hold you were edit displays, and that the
    'id' URL parameter persists as you navigate through the public
    catalog.
[5] Apply the patch and repeat steps 1-3. This time, you should
    see all of the holds.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP1772017: Correctly Extract Cast from Records
Jason Boyer [Fri, 18 May 2018 13:12:37 +0000 (09:12 -0400)]
LP1772017: Correctly Extract Cast from Records

authors.tt2 has been using field 508 for cast display but
the correct field is 511 when ind1=1.

Testing note:

In the Concerto data set, the title "The rum diary" is a good test
record, as it has both a 508 field and a 511.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Adding to 3.1.2 release notes
Jane Sandberg [Fri, 25 May 2018 15:57:06 +0000 (08:57 -0700)]
Docs: Adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding to 3.0.8 release notes
Jane Sandberg [Fri, 25 May 2018 15:50:53 +0000 (08:50 -0700)]
Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1753005: Avoid copy alert error for call numbers with no copies
Mike Rylander [Wed, 25 Apr 2018 16:32:15 +0000 (12:32 -0400)]
LP#1753005: Avoid copy alert error for call numbers with no copies

When displaying the Holdings View tab for a bib in the web staff client,
if a volume record has no copies, a Javascript error gets thrown.

Item-less volumes still end up in svc.copies at this point, so at the
moment it is necessary to check whether copy_alerts actually exists.
Some renaming might also be in order to clarify that svc.copies doesn't
necessarily contain /only/ fleshed acp records.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoLP#1755220: Return value checking in offline session fetch
Mike Rylander [Fri, 4 May 2018 13:58:53 +0000 (09:58 -0400)]
LP#1755220: Return value checking in offline session fetch

We need to make sure that we receive the correct shape of data (array) rather
than that we simply got anything when fetching sessions.  In the case of an
expired session token, we'll receive an ILS Event object informing us of the
expiration where we'd normally see a list of sessions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1745240: Hold Alias Missing from Hold Shelf Slip
Garry Collum [Wed, 23 May 2018 23:47:56 +0000 (19:47 -0400)]
LP#1745240: Hold Alias Missing from Hold Shelf Slip

A patron's hold alias can be printed in the hold shelf slip using the variable patron.alias.  This patch just adds 'patron.alias' to the list of available options displayed at the top of the template. Also adds a colon before the patron's name fields for consistency.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1745232 - Bill History Receipt doesn't have Finish Date
Garry Collum [Thu, 24 May 2018 02:17:38 +0000 (22:17 -0400)]
LP#1745232 - Bill History Receipt doesn't have Finish Date

Adds xact.finish and xact.summary.last_payment to the example data.  Also adds xact.summary.last_payment_ts to the template body to indicate when the last payment was made.  Also adds a list of variables that can be used in the template in the template's description.

To test -
1. apply the patch
2. find a patron with billings, or add some billings to a patron record.
3. make payments on some of the billings using various methods.
4. go to billing history and print the history list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1743782 Copy Status not available in Check-In Screen
gcollum [Sun, 20 May 2018 17:18:18 +0000 (13:18 -0400)]
LP#1743782 Copy Status not available in Check-In Screen

Makes the status an available column to display in the Check-In screen.

To test:
1. Apply patch.
2. Go to check-in and display 'Status' as a column in the table.
3. Check-in various items that may be checked-out, catch a hold, not checked out, etc.

Signed-off-by: gcollum <gcollum@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1765731 - restore CN suffix and preffix in Holds Pull List
Cesar Velez [Thu, 19 Apr 2018 21:25:59 +0000 (17:25 -0400)]
LP#1765731 - restore CN suffix and preffix in Holds Pull List

Overly gung-ho removal of "redundant" fields/columns in bug
1728147 removed call number prefix and suffix as available columns
in the hold pull list grid in the web staff client; this will
restore them there.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoDocs: Adding to and reorganizing the 3.1.2 release notes
Jane Sandberg [Wed, 23 May 2018 22:52:56 +0000 (15:52 -0700)]
Docs: Adding to and reorganizing the 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Adding to and reorganizing the 3.0.8 release notes
Jane Sandberg [Wed, 23 May 2018 22:48:02 +0000 (15:48 -0700)]
Docs: Adding to and reorganizing the 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1765444: improve how MARC editor fetches fixed field metadata
Galen Charlton [Thu, 19 Apr 2018 15:44:42 +0000 (11:44 -0400)]
LP#1765444: improve how MARC editor fetches fixed field metadata

This patch fixes a problem where the web staff MARC editor would
make repeated and redundant calls to two Evergreen methods to fetch
data about fixed field positions and values if that metadata was
not already cached by local storage or Hatch.

In particular, this patch caches and returns the data retrieval
promises, ensuring that only one set of FF position and value
requests are made.

Prior to this patch, each eg-marc-edit-fixed-field directive, of which
there are 64, could end up invoking those methods when initializing
the editor for a record type that had not been previously seen.

To test
-------
[1] Clear all FFPosTable_* and FFValueTable_* keys from local storage
    (or Hatch).
[2] Retrieve a bib record in the web staff client. Note that up to
    64 calls each are made of open-ils.cat.biblio.fixed_field_values.by_rec_type
    and open-ils.fielder.cmfpm.atomic.
[3] Apply the patch and repeat steps #1 and #2.
[4] This time, note that only one call each are made.
[5] Verify that the fixed field inputs continue to work as expected.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1770478: Offline org unit tree can break
Mike Rylander [Tue, 15 May 2018 21:21:00 +0000 (17:21 -0400)]
LP#1770478: Offline org unit tree can break

A thinko in the org tree reconstruction for offline mode caused the tree to be
broken in some situations, when the orgs were not ordered strictly by ID in
the list stored in the browser's IndexedDB storage.  This commit removes that
requirement, and allows trees of any ID and storage ordering to be
reconstituted.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agolp1759327 Populate Copy Templates Floating Dropdown
Kyle Huckins [Tue, 1 May 2018 18:28:36 +0000 (18:28 +0000)]
lp1759327 Populate Copy Templates Floating Dropdown

- Add update watcher and call itemSvc.get_floating_groups within
egVolTemplate directive to properly populate dropdown when accessing
volcopy editor from local administration.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1749996: add option to remove floating in web client copy editor
Jeff Davis [Tue, 24 Apr 2018 21:00:07 +0000 (14:00 -0700)]
LP#1749996: add option to remove floating in web client copy editor

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agolp1760997 Holds Pull List Blank Fields
Kyle Huckins [Wed, 16 May 2018 17:00:26 +0000 (17:00 +0000)]
lp1760997 Holds Pull List Blank Fields

- Requires field data to be loaded into holds pull list grid
initially.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP1749994 Disable payment button pending payment amount
gcollum [Sat, 19 May 2018 00:10:49 +0000 (20:10 -0400)]
LP1749994 Disable payment button pending payment amount

Apply payment button on patron bills screen should be inactive if Payment
Received is blank

Adds a test to see if there is a value in Payment Received input box. The
Apply Payment button doesn't activate unless a billing or billings is
selected and a numerical value is in Payment Received.

To test.
1. Add some billings to a patron's account.
2. Click some of the billings to select them. Notice that the Apply Payment
   button is active.
3. Apply patch
4. Select some of the billings.  The Apply Payment button is not active.
5. Enter some values into Payment Received.  If values other than numbers
   are entered the Apply Payment button is not activated.  If numbers are
   added the button is activated.
6. Uncheck all of the billings to see that the activated button deactivates,
   if no billings are checked.

Signed-off-by: gcollum <gcollum@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1639022 Webstaff convert change to credit
Bill Erickson [Wed, 16 May 2018 21:24:05 +0000 (17:24 -0400)]
LP#1639022 Webstaff convert change to credit

Add support for converting change to patron credit in the patron bills
interface, consistent with the XUL feature.  When the
'circ.disable_patron_credit' org unit setting is applied, the option is
hidden.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Laura Sachjen <sachjenl@branchdistrictlibrary.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: updating 3.1.2 release notes
Jane Sandberg [Wed, 23 May 2018 01:00:31 +0000 (18:00 -0700)]
Docs: updating 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: updating 3.0.8 release notes
Jane Sandberg [Wed, 23 May 2018 00:55:03 +0000 (17:55 -0700)]
Docs: updating 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#14973322: (follow-up) allow profile-only patron searches
Galen Charlton [Mon, 30 Apr 2018 21:03:26 +0000 (17:03 -0400)]
LP#14973322: (follow-up) allow profile-only patron searches

This patch removes the implicit requirement introduced by the previous
patch that a field other than profile be used in the patron search.

For performance reasons, it might be good to mark permission.grp_descendants()
as stable.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP14973322: Search for Users by Profile
Jason Boyer [Fri, 20 Apr 2018 18:49:25 +0000 (14:49 -0400)]
LP14973322: Search for Users by Profile

Stop treating profile like a text value, instead
include users in the selected profiles and descendants.

To test
-------
[0] Search for users by last name (and / or first) and do not
    select a profile, take note of results
[1] Select the top of your permission group tree (Users, likely) and
    search again, results should be the same.
[2] Select a group further down the tree (Circulators, Administrators,
    Patrons, etc.) and repeat the search, there should only be results
    from that group and its descendants.
[3] Finally, select a group with no child groups. Results will only be
    that specific group.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1497322: add Perl live_t regression and unit tests for patron searching
Galen Charlton [Mon, 30 Apr 2018 20:14:52 +0000 (16:14 -0400)]
LP#1497322: add Perl live_t regression and unit tests for patron searching

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>