working/Evergreen.git
3 days agoDocs: LP1776977: Update lsa-address_alert.adoc and add images master
Gina Monti [Fri, 23 Jul 2021 13:08:52 +0000 (09:08 -0400)]
Docs: LP1776977: Update lsa-address_alert.adoc and add images

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 days agoUpdate lsa-address_alert.adoc
gmontimantis [Mon, 28 Jun 2021 16:53:25 +0000 (12:53 -0400)]
Update lsa-address_alert.adoc

https://bugs.launchpad.net/evergreen/+bug/1776977

The new address alert table is rearranged to match the web client.

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 days agoLP1908612 Bootstrap Opac - Limit to Available
Garry Collum [Mon, 10 May 2021 19:55:59 +0000 (15:55 -0400)]
LP1908612 Bootstrap Opac - Limit to Available

Adds the 'Show All Copies' and 'Show Only Available Copies' to the Bootstrap
Opac's copy screen.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 days agoDocs: Update apache_rewrite_tricks.adoc to further address LP1837753
Gina Monti [Thu, 8 Jul 2021 19:02:22 +0000 (15:02 -0400)]
Docs: Update apache_rewrite_tricks.adoc to further address LP1837753

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
4 days agoDocs: update glossary.adoc to add TLD definition per LP1837753
Gina Monti [Thu, 8 Jul 2021 19:05:10 +0000 (15:05 -0400)]
Docs: update glossary.adoc to add TLD definition per LP1837753

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
12 days agoLP1718782: follow up to fix failing test
Jane Sandberg [Wed, 14 Jul 2021 16:20:03 +0000 (09:20 -0700)]
LP1718782: follow up to fix failing test

LP1718782 added a missing fixed field, but failed to also add it to
the expected data in this pgtap test.  This commit updates the
expected data to also include a SRCE fixed field.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 days agoLP#1718782: stamp DB update
Galen Charlton [Tue, 13 Jul 2021 16:09:57 +0000 (12:09 -0400)]
LP#1718782: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
13 days agoLP1718782: Add the Srce fixed field to the Angular MARC editor
Jane Sandberg [Thu, 10 Sep 2020 18:35:22 +0000 (11:35 -0700)]
LP1718782: Add the Srce fixed field to the Angular MARC editor

To test:

1) Without using private browsing, open up a bibliographic record in
the Angular catalog MARC editor.
2) Notice that there is a gap between the ELvl and Audn fixed fields.
3) Apply this patch.
4) Open up the same bibliographic record, this time using private
   browsing (since the Angular MARC editor caches fixed field values).
5) Notice that the Srce fixed field is available between the ELvl and
   Audn fixed fields.
6) Notice that you can right click inside the fixed field to get a list
   of three possible values.
7) Repeat the test with different record types (e.g. BKS, SCO, VIS)

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
13 days agoLP1913807 Staff catalog shows preferred lib holdings counts
Bill Erickson [Tue, 6 Jul 2021 15:08:37 +0000 (11:08 -0400)]
LP1913807 Staff catalog shows preferred lib holdings counts

Always show holdings counts for the preferred library (when set) even
when the library is not directly in the search scope.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
13 days agoLP1910808 Staff catalog show call number
Bill Erickson [Mon, 5 Jul 2021 20:04:56 +0000 (16:04 -0400)]
LP1910808 Staff catalog show call number

In the search results page, show the first call number for each record
(sorting by label sortkey) that is owned either by the user's preferred
library or the search library.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
13 days agoLP1857060: Tests for ISBNs with 979 prefix
Jane Sandberg [Thu, 19 Dec 2019 23:54:18 +0000 (15:54 -0800)]
LP1857060: Tests for ISBNs with 979 prefix

Also includes a slight tweak to the Amazon AddedContent code to avoid
attempting to convert 979 ISBNs to ISBN-10s (which is not possible).

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
13 days agoLP#1910891: stamp DB update
Galen Charlton [Tue, 13 Jul 2021 14:28:12 +0000 (10:28 -0400)]
LP#1910891: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
13 days agoLP1910891: Add new booking perms to appropriate groups
Jane Sandberg [Sun, 10 Jan 2021 06:20:29 +0000 (22:20 -0800)]
LP1910891: Add new booking perms to appropriate groups

Steps to test:

1) Without this patch, create a reservation for a BR1 resource at BR1.
2) Log in as a circulator at BR1.
3) Go to Booking > Manage Reservations.  Note that you can't see your reservation.
4) Run this upgrade script.
5) Repeat steps 2-3.  Notice that you can now see the reservation.
6) Wipe your database and re-install it with the additions to the seed data
in this commit.  Repeat steps 1-3 and notice that you can see the reservation
as expected.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
13 days agoLP1895737: Add Curbside Appointments to Bootstrap OPAC
Jason Boyer [Wed, 10 Mar 2021 23:48:12 +0000 (18:48 -0500)]
LP1895737: Add Curbside Appointments to Bootstrap OPAC

Add support for requesting / editing / canceling curbside
appointments to the bootstrap opac.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1908722: stamp schema update
Galen Charlton [Mon, 12 Jul 2021 21:01:51 +0000 (17:01 -0400)]
LP#1908722: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1908722: add electronic resource links
Galen Charlton [Fri, 9 Jul 2021 21:10:31 +0000 (17:10 -0400)]
LP#1908722: add electronic resource links

This patch adds electronic resource links to the Show More Details
view in the Angular staff catalog, above the table of items.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 weeks agoLP1908722 Staff catalog Show More Details
Bill Erickson [Fri, 2 Jul 2021 20:57:40 +0000 (16:57 -0400)]
LP1908722 Staff catalog Show More Details

Adds a "Show More Details" (and "Show Fewer Details") buttons to the
Angualr staff catalog.  Similar to the TPAC, activating the button means
more holdings details are displayed in the search results page.

Adds a new workstation setting type called
'eg.staff.catalog.results.show_more'

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 weeks agoLP#1844169: add release note entry
Galen Charlton [Mon, 12 Jul 2021 15:44:48 +0000 (11:44 -0400)]
LP#1844169: add release note entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1844169: (follow-up) add navigation
Galen Charlton [Mon, 12 Jul 2021 15:43:29 +0000 (11:43 -0400)]
LP#1844169: (follow-up) add navigation

This patch adds a link back to the list of Search Filter Groups
from the page for editing a single group.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1844169: (follow-up) add validation to entry form
Galen Charlton [Mon, 12 Jul 2021 15:42:24 +0000 (11:42 -0400)]
LP#1844169: (follow-up) add validation to entry form

The Search Filter Group Entries modal now enforces
required fields client-side.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1844169: fix lint
Galen Charlton [Mon, 12 Jul 2021 15:07:24 +0000 (11:07 -0400)]
LP#1844169: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1844169: Compare query position against string
Kyle Huckins [Wed, 17 Mar 2021 19:48:44 +0000 (19:48 +0000)]
LP#1844169: Compare query position against string

Compare queryPosition against '0' rather than int 0, avoiding Angular
issues during build process

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1844169: port Search Filter Groups admin interface to Angular
Mike Risher [Tue, 17 Sep 2019 21:33:04 +0000 (21:33 +0000)]
LP#1844169: port Search Filter Groups admin interface to Angular

Port search filter groups admin from DOJO UI to Angular. Each search
filter group has its own edit page, from which you can edit search
filter group entries.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1362743 One modal at a time during batch checkin
Mike Risher [Wed, 6 May 2020 17:08:33 +0000 (17:08 +0000)]
LP#1362743 One modal at a time during batch checkin

Modify batch checkins so that only one modal pops up at a time.
When each one is dismissed the next one will appear.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP1913221: Don't display blank course section number in OPAC
Jane Sandberg [Tue, 2 Feb 2021 02:04:02 +0000 (18:04 -0800)]
LP1913221: Don't display blank course section number in OPAC

To test:

1) Use the Library Settings Editor to turn on the Course Materials
   Module.
2) In Local administration, go to the course reserves list.
3) Add several courses, some with section numbers, others without.
4) In the OPAC, use the Course Search function to search for the courses
   you just added.
5) Notice that the search results page has a place for section numbers,
   whether or not the course has one.
6) Click into some of the courses.  Notice that the course page also
   includes a place for section numbers, whether or not the course has
   one.
7) Apply this patch.
8) Repeat steps 4-6.  Notice that the blank "section number" areas no
   longer appear.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1920210: stamp schema update
Galen Charlton [Wed, 7 Jul 2021 14:47:58 +0000 (10:47 -0400)]
LP#1920210: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1920210: add release notes
Galen Charlton [Fri, 4 Jun 2021 20:31:12 +0000 (16:31 -0400)]
LP#1920210: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1920210: add auditor tables for acq.fund_debit
Jeff Davis [Thu, 1 Apr 2021 00:03:03 +0000 (17:03 -0700)]
LP#1920210: add auditor tables for acq.fund_debit

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1907296: stamp DB update
Galen Charlton [Wed, 7 Jul 2021 14:42:54 +0000 (10:42 -0400)]
LP#1907296: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1907296 Missing Workstation setting for staff cat item table
Michele Morgan [Fri, 9 Apr 2021 16:38:55 +0000 (12:38 -0400)]
LP#1907296 Missing Workstation setting for staff cat item table

Adds the ws setting type eg.grid.catalog.record.copies to allow users to
save grid preferences for the angular catalog item table.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP1928005 Bootstrap Opac: Current charges not aligned on mobile.
Garry Collum [Tue, 11 May 2021 19:43:34 +0000 (15:43 -0400)]
LP1928005 Bootstrap Opac: Current charges not aligned on mobile.

This patch removes the classes from the charges table that presents the table in a vertical format.
It wraps the table in a <div> that uses the table-responsive class.

To test add some charges to a patron record.
Bring that patron's account up in the opac and view the charges table in the smallest browser size
possible.
Notice that the table switches to a vertical format and the column names are mis-aligned.

Apply the patch.

View the table again.  The table should now be horizontal with all of the columns correct.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1929136: (follow-up) reduce bounce time to 500ms
Galen Charlton [Fri, 4 Jun 2021 20:17:33 +0000 (16:17 -0400)]
LP#1929136: (follow-up) reduce bounce time to 500ms

During testing, 500ms was enough to avoid excessive
PCRUD calls while still keeping the interface's display
of duplicate or missing barcode warnings responsive.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 weeks agoLP#1929136: delay barcode lookup on change in holdings editor
Jeff Davis [Thu, 20 May 2021 21:51:17 +0000 (14:51 -0700)]
LP#1929136: delay barcode lookup on change in holdings editor

In the Holdings Editor, any change to the barcode field results in an
immediate API call.  Thus, if you type the barcode "123456789", you
would get 9 separate calls: 1, 12, 123, 1234, 12345 ...

This commit adds a 1000ms delay to avoid excessive pcrud calls when
typing a barcode.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 weeks agoDocs: updates to library settings; filename fixes
Andrea Buntz Neiman [Thu, 1 Jul 2021 20:58:23 +0000 (16:58 -0400)]
Docs: updates to library settings; filename fixes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
4 weeks agoForward port the 3.6.3 to 3.6.4 db upgrade script
Jason Stephenson [Fri, 25 Jun 2021 17:05:49 +0000 (13:05 -0400)]
Forward port the 3.6.3 to 3.6.4 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>
4 weeks agoForward port 3.5.4 to 3.5.5 db upgrade script
Jason Stephenson [Wed, 23 Jun 2021 20:21:39 +0000 (16:21 -0400)]
Forward port 3.5.4 to 3.5.5 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>
4 weeks agoForward port 3.5.3 to 3.5.4 db upgrade script
Jason Stephenson [Wed, 23 Jun 2021 20:20:25 +0000 (16:20 -0400)]
Forward port 3.5.3 to 3.5.4 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>
4 weeks agoForward-port 3.7.1 version upgrade script
Jane Sandberg [Wed, 23 Jun 2021 16:38:00 +0000 (12:38 -0400)]
Forward-port 3.7.1 version upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 weeks agoupdate Czech translations for Angular staff client
Galen Charlton [Wed, 23 Jun 2021 16:11:33 +0000 (12:11 -0400)]
update Czech translations for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 weeks agoDocs: 3.7.1 release notes
Jane Sandberg [Wed, 23 Jun 2021 15:27:18 +0000 (08:27 -0700)]
Docs: 3.7.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 weeks agoDocs: 3.6 release notes
Jane Sandberg [Wed, 23 Jun 2021 15:02:43 +0000 (08:02 -0700)]
Docs: 3.6 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 weeks agoDocs: Release notes for 3.5.5
Jane Sandberg [Wed, 23 Jun 2021 14:31:08 +0000 (07:31 -0700)]
Docs: Release notes for 3.5.5

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 weeks agoLP#1930933: fix issue with over-escaping in search results title attributes
Galen Charlton [Mon, 14 Jun 2021 15:34:51 +0000 (11:34 -0400)]
LP#1930933: fix issue with over-escaping in search results title attributes

This patch fixes an issue where a record with a title containing the
word "hidden" can have its title, ironically enough, not show up
on public catalog search results.

To test
-------
[1] Create an OPAC-visible record whose 245 is something like:

    =245 04$aThe hidden one <script>alert('title!')</script>

[2] Search for the record in both the TPAC and Bootstrap skin. Note
    that the title isn't displayed.
[3] Apply the patch and repeat step 2. This time, the full title
    should be displayed.
[4] Verify that the OPAC does not display an alert box.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
6 weeks agoLP1910145 Angular Hold Detail Notes & Notifications
Bill Erickson [Mon, 4 Jan 2021 21:12:50 +0000 (16:12 -0500)]
LP1910145 Angular Hold Detail Notes & Notifications

The hold detail view now displays hold notes and hold notification
records.  Notes and Notifications may be created by staff.  Notes may be
deleted by staff.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
6 weeks agoLP#1887876 Checkout catalog doesn't load workstation prefs
Dan Briem [Fri, 17 Jul 2020 03:39:09 +0000 (23:39 -0400)]
LP#1887876 Checkout catalog doesn't load workstation prefs

The catalog under the Holds tab in the Checkout interface
doesn't load the default search or preferred library if
you haven't visited the main catalog page earlier in the
session.

This branch sets these settings as cookies in the
AngularJS wrapper for the catalog embedded in the Checkout
interface under the Holds tab.

Test:
1. Close browser, open browser, log into Evergreen
2. Admin->Workstation set search & preferred library
3. Open a patron record -> Holds tab -> Place Holds
4. Search for an item owned by your preferred library
5. Note the library's copies aren't separately indicated
6. Apply patch and repeat steps 1-5
7. Note the library's copies are separately indicated

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
6 weeks agoLP#1930088 Angular catalog: metarecord search returns no results
Dan Briem [Fri, 28 May 2021 16:58:27 +0000 (12:58 -0400)]
LP#1930088 Angular catalog: metarecord search returns no results

This adds a missing param to a call to get_one_record_summary
that's necessary after commit c07ce8.

To test, perform a search using the Group Formats/Editions checkbox
and you should see results.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP#1895738: stamp schema update
Galen Charlton [Fri, 4 Jun 2021 14:41:30 +0000 (10:41 -0400)]
LP#1895738: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agolp1895738 need eg.orgselect.hopeless.wide_holds
Jason Etheridge [Thu, 1 Oct 2020 15:45:44 +0000 (11:45 -0400)]
lp1895738 need eg.orgselect.hopeless.wide_holds

This fixes the following:

ERROR Error: Uncaught (in promise): No user or workstation setting type exists for: "eg.orgselect.hopeless.wide_holds".
Create a ws/user setting type or use setLocalItem() to store the value locally.

However, it exposes a different (harmless?) error within the /eg2 holds grid:

ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'ng-untouched': 'true'. Current value: 'false'.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP#1901893: (follow-up) add cellTextGenerator
Galen Charlton [Fri, 4 Jun 2021 14:07:40 +0000 (10:07 -0400)]
LP#1901893: (follow-up) add cellTextGenerator

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP1901893 Bucket column link tweak
Michele Morgan [Fri, 19 Mar 2021 17:31:06 +0000 (17:31 +0000)]
LP1901893 Bucket column link tweak

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP1901893 Carousel bucket should be linked from grid
Terran McCanna [Wed, 28 Oct 2020 22:41:27 +0000 (18:41 -0400)]
LP1901893 Carousel bucket should be linked from grid

Re-formats the bucket column content as a link that opens the
carousel's associated bucket in a new tab.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP#1778955: stamp schema update
Galen Charlton [Wed, 2 Jun 2021 15:24:00 +0000 (11:24 -0400)]
LP#1778955: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP#1778955: fixing upgrade script, removing duplicate function definition
Jane Sandberg [Thu, 6 Aug 2020 15:08:50 +0000 (08:08 -0700)]
LP#1778955: fixing upgrade script, removing duplicate function definition

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP#1778955: Remove our custom version of array_remove(anyarray,anyelement)
Mike Rylander [Fri, 22 Jun 2018 18:29:26 +0000 (14:29 -0400)]
LP#1778955: Remove our custom version of array_remove(anyarray,anyelement)

As of Postgres 9.3 there is a built in array_remove() function that is faster
than our custom version that uses unnest().  We should use that instead.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP#1908619: add a release notes sentence
Galen Charlton [Wed, 2 Jun 2021 15:08:09 +0000 (11:08 -0400)]
LP#1908619: add a release notes sentence

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP1908619 Adjustments to Staff Search Preferences Page
Terran McCanna [Tue, 5 Jan 2021 19:09:36 +0000 (14:09 -0500)]
LP1908619 Adjustments to Staff Search Preferences Page

Change 'Catalog Preferences' to 'Search Preferences' and
add a Return button at the bottom to make it more obvious how
to get out of the interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agoLP1922120: Add to carousel action in angular catalog
Jane Sandberg [Fri, 28 May 2021 02:32:27 +0000 (19:32 -0700)]
LP1922120: Add to carousel action in angular catalog

To test:

1) Create several manual carousels, and make sure they are
set to active.
2) Open a bib record in the Angular staff catalog.
3) Under Other Actions, choose the "Add to Carousel" action
4) Choose your preferred carousel.
5) Click Add to carousel.
6) Go back to carousel administration (or look at the carousel
itself), and confirm that the record has been added to the
carousel in question.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 weeks agodocs: fix typo in 3.6 release notes
Galen Charlton [Tue, 1 Jun 2021 14:27:35 +0000 (10:27 -0400)]
docs: fix typo in 3.6 release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 weeks agoDocs: radio monograph part selector in OPAC
Jane Sandberg [Sat, 29 May 2021 01:52:14 +0000 (18:52 -0700)]
Docs: radio monograph part selector in OPAC

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: add admin docs for multiple holds feature
Jane Sandberg [Sat, 29 May 2021 01:03:07 +0000 (18:03 -0700)]
Docs: add admin docs for multiple holds feature

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: Update migrating_your_data.adoc
Stephen Wills [Sat, 29 May 2021 00:30:07 +0000 (17:30 -0700)]
Docs: Update migrating_your_data.adoc

Signed-off-by: Stephen Wills <swills@beyond-print.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoUpdate librarysettings.doc
Stephen Wills [Sat, 29 May 2021 00:13:14 +0000 (17:13 -0700)]
Update librarysettings.doc

Signed-off-by: Stephen Wills <swills@beyond-print.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: LP 1751146 browser bookmarks toolbar
katiegmartin [Mon, 26 Oct 2020 16:07:15 +0000 (12:07 -0400)]
Docs: LP 1751146 browser bookmarks toolbar

Add tips for using the browser bookmarks toolbar in place of the XUL button bar

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: LP 1250528 change font size in browser
katiegmartin [Mon, 26 Oct 2020 15:21:52 +0000 (11:21 -0400)]
Docs: LP 1250528 change font size in browser

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: small follow-up tweaks to survey documentation
Jane Sandberg [Fri, 28 May 2021 22:51:09 +0000 (15:51 -0700)]
Docs: small follow-up tweaks to survey documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoUpdated Surveys Pictures
Lynn Floyd [Fri, 28 May 2021 15:21:18 +0000 (11:21 -0400)]
Updated Surveys Pictures

Updated images for Surveys.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDOC Addding Survey Administration
Lynn Floyd [Wed, 5 May 2021 20:42:44 +0000 (16:42 -0400)]
DOC Addding Survey Administration

Adding Survey Adminstration to Documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDOC Add message about version switching.
Rosie Le Faive [Fri, 28 May 2021 18:05:57 +0000 (15:05 -0300)]
DOC Add message about version switching.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoNew billing section added and the circulation nav menu updated.
Jennifer Pringle [Fri, 28 May 2021 19:32:26 +0000 (12:32 -0700)]
New billing section added and the circulation nav menu updated.

Billing docs come from Sitka's Evergreen manual.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDOC Elaborate on what Items and bib records are.
Rosie Le Faive [Fri, 28 May 2021 19:39:35 +0000 (16:39 -0300)]
DOC Elaborate on what Items and bib records are.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agodocs: glossary additions
Andrea Buntz Neiman [Fri, 28 May 2021 19:32:38 +0000 (15:32 -0400)]
docs: glossary additions

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
8 weeks agodocs: circ docs fixes
Andrea Buntz Neiman [Fri, 28 May 2021 19:14:28 +0000 (15:14 -0400)]
docs: circ docs fixes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
8 weeks agodocs: admin docs fixes
Andrea Buntz Neiman [Fri, 28 May 2021 18:37:13 +0000 (14:37 -0400)]
docs: admin docs fixes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
8 weeks agoDocs: Fixed antora landing page
blake [Fri, 28 May 2021 18:19:02 +0000 (13:19 -0500)]
Docs: Fixed antora landing page

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
8 weeks agoAdded Holdings Details Defaults to Holdings Editor section.
Jennifer Pringle [Fri, 28 May 2021 15:46:20 +0000 (08:46 -0700)]
Added Holdings Details Defaults to Holdings Editor section.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDOCS: Update auth proxy xml in docs to match example
Rosie Le Faive [Fri, 28 May 2021 14:41:49 +0000 (11:41 -0300)]
DOCS: Update auth proxy xml in docs to match example

Also, move file to better admin_local_setup folder and update nav

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: small asciidoc syntax fix
Jane Sandberg [Thu, 27 May 2021 17:23:01 +0000 (10:23 -0700)]
Docs: small asciidoc syntax fix

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: Update Navigation for Negative Balances
Lynn Floyd [Mon, 24 May 2021 20:26:25 +0000 (16:26 -0400)]
Docs: Update Navigation for Negative Balances

Adding Navigations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: Adding Negative Balances
Lynn Floyd [Mon, 24 May 2021 20:23:54 +0000 (16:23 -0400)]
Docs: Adding Negative Balances

Adding documentations for Patron with Negative Balances Screen.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: fix antora build asciidoc warnings
Jane Sandberg [Thu, 27 May 2021 16:20:19 +0000 (09:20 -0700)]
Docs: fix antora build asciidoc warnings

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoDocs: Adding more info about credit card payments
Jane Sandberg [Thu, 27 May 2021 15:45:11 +0000 (08:45 -0700)]
Docs: Adding more info about credit card payments

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 months agoLP#1856868: Remove deprecated open-ils.circ.renew.auto API
Jason Stephenson [Wed, 18 Dec 2019 18:11:55 +0000 (13:11 -0500)]
LP#1856868: Remove deprecated open-ils.circ.renew.auto API

The deprecated open-ils.circ.renew.auto API was removed.  You will
want to use open-ils.circ.renew with the auto_renewal option set
to 1.  This mainly affects those who have written custom code using
the open-ils.circ backend.

This removal was broadcast in the release notes for Launchpad bug
1835085: https://bugs.launchpad.net/bugs/1835085.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP#1913338: stamp schema update
Galen Charlton [Wed, 26 May 2021 20:23:23 +0000 (16:23 -0400)]
LP#1913338: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP#1913338: (follow-up) aria-hide the icon names
Galen Charlton [Wed, 26 May 2021 20:20:05 +0000 (16:20 -0400)]
LP#1913338: (follow-up) aria-hide the icon names

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP#1913338: Typo correction
Chris Sharp [Wed, 17 Feb 2021 15:26:47 +0000 (10:26 -0500)]
LP#1913338: Typo correction

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP1913338 Catalog search form visibility stickiness
Bill Erickson [Thu, 28 Jan 2021 15:32:11 +0000 (10:32 -0500)]
LP1913338 Catalog search form visibility stickiness

On pages in the Angular staff catalog where the search form is collapsed
by default, users may now also manually expand and re-collapse the form.
The last used choice will be sticky via new workstation setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP#1898114: (follow-up) adjust the style of the org selector
Galen Charlton [Wed, 26 May 2021 20:03:50 +0000 (16:03 -0400)]
LP#1898114: (follow-up) adjust the style of the org selector

This patch makes the new hold pull list org selector match
the selector on the holds shelf page.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP1898114: Add org selector to holds pull list
Jane Sandberg [Wed, 17 Mar 2021 02:37:00 +0000 (19:37 -0700)]
LP1898114: Add org selector to holds pull list

To test:
1) Go to the Holds Pull List
2) Try looking at the hold lists for all libraries where
you have the VIEW_HOLD permission.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agolp1902302 Opac. SMS and Carriers appear in Edit Holds Regardless of OU Setting.
Garry Collum [Fri, 30 Oct 2020 19:55:35 +0000 (15:55 -0400)]
lp1902302 Opac. SMS and Carriers appear in Edit Holds Regardless of OU Setting.

The SMS Number field and Default Carrier field display when editing an
individual hold in the opac, regardless of the 'Enable features that send SMS text messages' setting.
This patch rectifies that behavior.

To test.
Set the 'Enable features that send SMS text messages' to False.
Place a hold for a patron.
Login to the opac as that patron and view the holds.
Edit the hold, and notice that the SMS and Carrier fields are displayed.

Apply the patch.
Refresh the edit form.  The fields no longer display.

Set the 'Enable features that send SMS text messages' to True.
Refresh the edit form.  The fields now display.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP1901710: Properly nest HTML tags and TT2 directives
Jason Boyer [Fri, 30 Oct 2020 20:06:17 +0000 (16:06 -0400)]
LP1901710: Properly nest HTML tags and TT2 directives

This is a first pass at cleaning these up and the W3C's
HTML validator is a lot happier about some of the pages,
but the advanced search page at least needs some TLC.

I'm having trouble getting the shelving location selector
to appear at all and the aria complaints will require more
fixing.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP1916936-Bootstrap opac: item tags display as separate copies on small screen.
Garry Collum [Thu, 25 Feb 2021 21:02:50 +0000 (16:02 -0500)]
LP1916936-Bootstrap opac: item tags display as separate copies on small screen.

This fixes the display of item tags and item notes in the bootstrap opac.
It also cleans up some <a> tags that had class defined twice.

To test.
1. Add an item tag and an item note to an item.
2. In the bootstrap opac make the screen as small as possible.
   Notice that the display shows the tags and items as copies.
3. Apply the patch and repeat.  The tags and notes should be displayed with the item that they are associated with.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP1910288 Bootstrap opac: E-items lines always display in account summary.
Garry Collum [Tue, 5 Jan 2021 21:26:55 +0000 (16:26 -0500)]
LP1910288 Bootstrap opac: E-items lines always display in account summary.

The E-item summary of ckos and holds always display in the My Account Summary of the Bootstrap Opac
regardless of the ebook_api.enabled flag in config.tt2.  This fixes that issue.

It also sets both the ebook_api.enabled and ebok_api.ebook_test.enabled flags to default to false.

To test:
1. Set ebook_api.enabled in config.tt2 to false.
2. Look at a patron's account summary and notice that it displays the e-item lines.
3. Apply the patch.
4. The E-item lines are now suppressed.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP1920042 Bootstrap Opac: Simple Selector in Advanced Search
Garry Collum [Thu, 18 Mar 2021 17:49:32 +0000 (13:49 -0400)]
LP1920042 Bootstrap Opac: Simple Selector in Advanced Search

Fixes the simple selector in advanced search.

To Test:
1. Go to Administration - Server Administration - MARC Coded Value Maps
2. Assign the 'Is Simple Selector' option to some record attributes.
  In concerto:
     Lang - French, German
     Type - Musical Sound Recording
  Are good choices to test searching.
3. Notice in advanced search that these options no longer appear in the
   Language or Item Type search filters.
4. Apply the patch.
5. The simple selector options should now appear at the top of each search
   filter category.
6. Perform some searches using the simple selector options.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP#1923225: stamp DB update
Galen Charlton [Tue, 25 May 2021 14:33:28 +0000 (10:33 -0400)]
LP#1923225: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP#1923225: clean up some double-escaping of HTML in record display
Jeff Davis [Mon, 26 Apr 2021 21:33:51 +0000 (14:33 -0700)]
LP#1923225: clean up some double-escaping of HTML in record display

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoLP#1923225: have search highlighting stored procedure do HTML-escaping
Galen Charlton [Wed, 14 Apr 2021 18:30:39 +0000 (14:30 -0400)]
LP#1923225: have search highlighting stored procedure do HTML-escaping

This patch builds on the previous work to have the stored procedures
that produced highlighted and unhighlighted versions of display
attributes HTML-escape the source values, then adjusts the TPAC
and Bootstrap templates to avoid double-escaping.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1923225: fix handling of untruncated display fields in accordion
Jeff Davis [Tue, 13 Apr 2021 23:05:41 +0000 (16:05 -0700)]
LP#1923225: fix handling of untruncated display fields in accordion

A previous commit used the TT2 "html" filter to escape strings to which the
accordion macro is applied, but which don't get truncated.  But that's
incompatible with display fields, which contain embedded HTML and
therefore shouldn't be escaped in that way.  This commit uses
HTML::Defang on untruncated accordion input instead (which is consistent
with how truncated strings are handled by the same macro).

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1923225: avoid over-escaping ISBNs and ISSNs
Jeff Davis [Tue, 13 Apr 2021 22:56:34 +0000 (15:56 -0700)]
LP#1923225: avoid over-escaping ISBNs and ISSNs

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1928684 Catalog view holds tab sort by patron barcode error
Dan Briem [Thu, 20 May 2021 17:05:21 +0000 (13:05 -0400)]
LP#1928684 Catalog view holds tab sort by patron barcode error

This changes the Patron Barcode column name to ucard_barcode to
match the field name in the database.

Note: due to the name change, users who saved the column on the
grid will have to add it again.

To test:
1. Go to the View Holds tab on a record that has hold requests
2. Add the Patron Barcode column to the grid
3. Sort by the barcode column and note that it works
4. It's a good idea to test that the grid settings save properly

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 months agoDOCS LP 1857917 Update glossary.adoc to include IDL
katiegmartin [Mon, 24 May 2021 19:52:32 +0000 (15:52 -0400)]
DOCS LP 1857917 Update glossary.adoc to include IDL

LP bug https://bugs.launchpad.net/evergreen/+bug/1857917
Add IDL definition to glossary, with synonym link to Fieldmapper IDL & change anchor point for F heading

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>