]> git.evergreen-ils.org Git - working/Evergreen.git/commit
LP#2051944: Improve FMREC primary key column test
authorMike Rylander <mrylander@gmail.com>
Fri, 2 Feb 2024 15:45:46 +0000 (10:45 -0500)
committerTerran McCanna <tmccanna@georgialibraries.org>
Mon, 18 Mar 2024 17:09:37 +0000 (13:09 -0400)
commit9177891142710612c8f972258901891ea2e93a91
tree408d341424c353cd639f581280b69d60b2a6c4af
parent7b1aba121284897a0797a92538d226a0f90a9205
LP#2051944: Improve FMREC primary key column test

FMRecordEditorComponent was depending on the @reporter:datatype to
identify the primary key (identity) field for an FM class.  Instead, it
should check the field name against the @oils_persist:primary attribute
of the <fields> element, which gets around the special case of org unit
id having a declared datatype of "org_unit", and future-proofs against
other possible edge cases.

This commit does that.

To test
-------
[1] Update the Organizational Units page's form to include "id" as
    a visible field, a la bug 2051879.
[2] Note that the form display a selector.
[3] Apply the patch and recompile the Angular staff client.
[4] This time, the OU ID should display as a read-only number.

Release-notes: Makes it possible to display the org unit ID as a number on Angular record editor forms for editing org units

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Open-ILS/examples/fm_IDL.xml
Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts