]> git.evergreen-ils.org Git - working/Evergreen.git/commit
LP#2000270 Staff catalog lets staff pick invalid pickup locations
authorSteven Mayo <smayo@georgialibraries.org>
Fri, 8 Dec 2023 20:40:58 +0000 (15:40 -0500)
committerMichele Morgan <mmorgan@noblenet.org>
Tue, 26 Mar 2024 14:01:23 +0000 (10:01 -0400)
commit2ffac0373a030bf6783b77494948d6dd5066c26a
tree6b9a1d663bff461417afc2e18ee3b6e4089a2ff5
parent26ab893556a5a145136f327c71f0bfd9c0281067
LP#2000270 Staff catalog lets staff pick invalid pickup locations

Added new check to the hold component that disables the 'Place Hold(s)' button if the
pickup location is empty or from the list of orgs that are shown but not
valid pickup locations.

Also modified the org-select component to check if the org it has
selected is supposed to be disabled. When the org-selector
is required, it will have the relevant class applied and have a little
green or red slice. NOTE: The validity is applied in a somewhat hacky way that doesn't
appear to be the official Angular way. It might not signal properly if
used in a form.

Steps to test:
[1] In the staff client, go to Cataloging -> Search the Catalog
[2] Search for something attempt to Place a Hold on it
[3] Click on the Pickup Location input
[4] Use the arrows and press tab to select an illegal pickup lib
[5] Note the color on the input and the transparency of the button
[6] Select a valid pickup location
[7] Select a valid user for the hold
[8] Note the color on the input and transparency of the button

Release-Note: Prevents holds with an invalid pickup location selected from being placed in the angular catalog

Signed-off-by: Steven Mayo <smayo@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxOLI.org>
Open-ILS/src/eg2/src/app/share/org-select/org-select.component.ts
Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html
Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts