working/Evergreen.git
4 years agowebstaff: add print template and action for in-house uses list
Galen Charlton [Wed, 16 Nov 2016 08:07:22 +0000 (03:07 -0500)]
webstaff: add print template and action for in-house uses list

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: add support for per-template printer contexts
Galen Charlton [Wed, 16 Nov 2016 06:53:45 +0000 (01:53 -0500)]
webstaff: add support for per-template printer contexts

Per-template printer contexts can now be set, imported, exported,
and passed along to Hatch during printing.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: fix support of the disabled automatic print attempt type list
Galen Charlton [Wed, 16 Nov 2016 05:34:06 +0000 (00:34 -0500)]
webstaff: fix support of the disabled automatic print attempt type list

This patch ensures that the disabled automatic print attempt type list
setting is now honored. In addition, if bill payment receipts are
disabled via the setting, the "Receipt on Pay" and "# Copies" widgets
are not displayed on the bill payment page.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: fix misalignment of ‡ in MARC editor
Galen Charlton [Mon, 28 Nov 2016 16:55:24 +0000 (11:55 -0500)]
webstaff: fix misalignment of ‡ in MARC editor

This patch sets the font used to display the "‡" character in the
MARC editor to the same font used for input fields, fixing a
vertical misalginment that displayed in Chrome and Firefox
on some platforms.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: Clean up dojo idiom use for chome happiness
Mike Rylander [Mon, 28 Nov 2016 16:31:03 +0000 (11:31 -0500)]
webstaff: Clean up dojo idiom use for chome happiness

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: honor sticky-setting org by calling onchange handler; have newer holdings...
Mike Rylander [Wed, 23 Nov 2016 17:37:39 +0000 (12:37 -0500)]
webstaff: honor sticky-setting org by calling onchange handler; have newer holdings service requests cancel ongoing older ones

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: 2.11 Release Note corrections and clarifications.
Kathy Lussier [Thu, 5 Jan 2017 18:55:49 +0000 (13:55 -0500)]
Docs: 2.11 Release Note corrections and clarifications.

Fixes several typos in the 2.11 Release Notes and in the template for release
notes acknowledgements. Also resets the acknowledgements as TODOs for the
next release. Added clarification to the email checkout receipts to let users
know that email receipts are not available in the XUL client, but only in the
web client.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: Add "export non-imported records"
Remington Steed [Thu, 5 Jan 2017 15:03:48 +0000 (10:03 -0500)]
Docs: Add "export non-imported records"

This commit briefly describes the queue actions, summary and filter
sections of the Inspect Queue page in Vandelay, as well as explaining
the new "Export Non-Imported Records" action. This commit includes
updated screenshots.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 years agoLP#1651808: avoid a class of intermittent search failures
Galen Charlton [Wed, 21 Dec 2016 21:32:26 +0000 (16:32 -0500)]
LP#1651808: avoid a class of intermittent search failures

This patch fixes a bug where catalog searches can sometimes fail
with a PostgreSQL error that looks like this:

ERROR: type of parameter 56 (double precision) does not match that when preparing the plan (numeric)
CONTEXT: PL/pgSQL function search.query_parser_fts(integer,integer,text,integer[],integer[],integer,integer,integer,boolean,boolean,boolean,integer) line 319 at assignment

In particular, it ensures that the relevance values are coerced
to the Pg NUMERIC data type regardless of how the core query is
constructed; otherwise, it can sometimes end up as a double
precision value.  Because of how Pg backends cache query plans,
that change of type can result in the error above.

To test
-------
[1] (Optional) Configure the max_children values for open-ils.storage
    to permit only one drone, which in turn forces all catalog
    search requests to go through a single Pg backend.
[2] Set the default_preferred_language_weight opensrf.xml setting
    to 0.
[3] Perform a catalog search that has just a filter, e.g.,
    item_lang(eng).
[4] Perform a catalog search that includes search term, e.g.,
    cats
[5] The second search should fail.
[6] Apply the patch and try steps 3 and 4 again; this time, both
    searches should work.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agofixing formatting in supercat docs
Jane Sandberg [Tue, 20 Dec 2016 18:07:46 +0000 (10:07 -0800)]
fixing formatting in supercat docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoDocs: Adding information about Supercat and UnAPI
Jane Sandberg [Tue, 20 Dec 2016 17:32:34 +0000 (09:32 -0800)]
Docs: Adding information about Supercat and UnAPI

4 years agoLP#1586509 Bug fix to LP#1352542 caused extraneous blank line to appear in
Dan Pearl [Thu, 2 Jun 2016 19:17:44 +0000 (15:17 -0400)]
LP#1586509 Bug fix to LP#1352542 caused extraneous blank line to appear in
spine label.  This affected LC call numbers that had only one cutter number
plus additional text following.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1594937 Fix off-by-one display of closed dates
Dan Scott [Mon, 12 Dec 2016 21:13:00 +0000 (16:13 -0500)]
LP#1594937 Fix off-by-one display of closed dates

The switch to toISOString() to format dates introduced an off-by-one error in
the closed dates display, showing one extra day of closure due to the timezone
being ignored in toISOString().

toLocaleDateString() is the future of locale-sensitive date formats. In XUL,
because it is an old version of Firefox, it lacks locale sensitivity, but for
the purposes of the web staff client it's a good base to build on as even
Internet Explorer supports the locale and options arguments as of IE 11.

And for the immediate purposes of showing the right dates in the closed dates
editor, it works.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoLP#1432753 Restore "All day" verbiage to Closed Dates editor
Dan Scott [Mon, 12 Dec 2016 20:39:08 +0000 (15:39 -0500)]
LP#1432753 Restore "All day" verbiage to Closed Dates editor

Commit ede7e78925 replaced the JSAN calls to util.date.formatted_date() with
inline date/time handling, in the process returning times with granularity to
the minute instead of to the second. This resulted in the test for "all day"
closings always failing.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoDocs: LP1268054 add patron purchase request doc
Jane Sandberg [Fri, 9 Dec 2016 05:31:25 +0000 (21:31 -0800)]
Docs: LP1268054 add patron purchase request doc

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoDocs: Making sure that image filenames don't include . character, as this can cause...
Jane Sandberg [Thu, 1 Dec 2016 18:47:20 +0000 (10:47 -0800)]
Docs: Making sure that image filenames don't include . character, as this can cause some versions of a2x to fail

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoDocs: fixing missing anchor
Jane Sandberg [Thu, 1 Dec 2016 18:32:41 +0000 (10:32 -0800)]
Docs: fixing missing anchor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP#1522599 add visual indicator for an expired patron
Billy Horn [Wed, 5 Oct 2016 17:41:33 +0000 (10:41 -0700)]
LP#1522599 add visual indicator for an expired patron

Add checkAlerts to getPrimary
Add alert styling to index patron for any active alert
Add alert styling to expire date in patron summary

Signed-off-by: Billy Horn <bhorn@catalystdevworks.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: Allow ACQ catalog and link-to-record, er, links to work in a browser
Mike Rylander [Tue, 22 Nov 2016 15:03:16 +0000 (10:03 -0500)]
webstaff: Allow ACQ catalog and link-to-record, er, links to work in a browser

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: language tweak in Bill History receipt
Jason Etheridge [Tue, 22 Nov 2016 12:41:25 +0000 (07:41 -0500)]
webstaff: language tweak in Bill History receipt

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: add import and export of print templates
Galen Charlton [Wed, 16 Nov 2016 02:36:15 +0000 (21:36 -0500)]
webstaff: add import and export of print templates

The workstation print template page now has Import
and Export buttons to import or export any customized
templates from/to JSON files. Toasts are emitted
on import success or failure and export failure (if
there are no customized templates to export).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: teach egJsonExporter about generators
Galen Charlton [Wed, 16 Nov 2016 02:20:24 +0000 (21:20 -0500)]
webstaff: teach egJsonExporter about generators

This patch adds an attribute called 'generator' to the eg-json-exporter
directive as an alternative to using 'container' to pass a JavaScript
object. 'generator' should be a function that returns a promise with
the data to be exported.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: tweak default Hold Shelf List print template
Jason Etheridge [Mon, 21 Nov 2016 13:57:58 +0000 (08:57 -0500)]
webstaff: tweak default Hold Shelf List print template

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: fix template ref for Holds for Bib Record
Jason Etheridge [Mon, 21 Nov 2016 13:09:19 +0000 (08:09 -0500)]
webstaff: fix template ref for Holds for Bib Record

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: alphabetize entries on acq admin splash page
Galen Charlton [Tue, 15 Nov 2016 23:43:53 +0000 (18:43 -0500)]
webstaff: alphabetize entries on acq admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: improve column collapse on acq admin splash page
Galen Charlton [Tue, 15 Nov 2016 23:42:15 +0000 (18:42 -0500)]
webstaff: improve column collapse on acq admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: improve column collapse on server admin splash page
Galen Charlton [Tue, 15 Nov 2016 23:38:39 +0000 (18:38 -0500)]
webstaff: improve column collapse on server admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: improve column collapse on local admin splash page
Galen Charlton [Tue, 15 Nov 2016 23:30:33 +0000 (18:30 -0500)]
webstaff: improve column collapse on local admin splash page

With this patch, when the local admin splash page is displayed
on small screens, the three columns are stacked better. E.g.,

A  D  G
B  E  H
C  F

becomes

A
B
C
D
E
F
G
H

rather than

A
D
G
B
E
H
C
F

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoadd Print Bills to Bill History
Jason Etheridge [Thu, 17 Nov 2016 20:38:17 +0000 (15:38 -0500)]
add Print Bills to Bill History

FIXME: duplicated a code chunk, should probably refactor into a shared printBills
FIXME: disable actions or make otherwise obvious that they only work on selected rows

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: fix Payment Method in receipt
Jason Etheridge [Thu, 17 Nov 2016 19:39:22 +0000 (14:39 -0500)]
webstaff: fix Payment Method in receipt

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: toast on volume/copy template save and delete
Galen Charlton [Tue, 15 Nov 2016 22:14:54 +0000 (17:14 -0500)]
webstaff: toast on volume/copy template save and delete

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: fix a couple thinkos is vol/copy template editor
Galen Charlton [Tue, 15 Nov 2016 21:59:21 +0000 (16:59 -0500)]
webstaff: fix a couple thinkos is vol/copy template editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: tweaks to egPrint
Galen Charlton [Tue, 15 Nov 2016 20:40:39 +0000 (15:40 -0500)]
webstaff: tweaks to egPrint

This patch attempts to unbreak receipt and CSV printing
by fetching and injecting the print CSS into a style element,
as a link element in the print div doesn't seem to get
processed.  It also automatically clears the content
of the print div so that after you print a receipt, the
browser print command will print the page, not the receipt.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff transit list: switch to egGridFlatDataProvider
Galen Charlton [Tue, 15 Nov 2016 19:27:20 +0000 (14:27 -0500)]
webstaff transit list: switch to egGridFlatDataProvider

This gets us sorting "for free", or at least more easily than
with a custom-written data provider.  The following fields
are marked sortable for now:

- barcode
- title
- source library
- destination library
- send date/time

Because egGridFlatDataProvider gives us flattened hashes, not
fieldmapper objects, various tweaks were required to compensate.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agobetter idea with Check Number
Jason Etheridge [Mon, 14 Nov 2016 21:44:25 +0000 (16:44 -0500)]
better idea with Check Number

unset default Check Number, disable widget if not Check Payment,
and disable Apply Payment button if Check Payment with invalid Check Number

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: default Check Number to 1
Jason Etheridge [Mon, 14 Nov 2016 21:03:56 +0000 (16:03 -0500)]
webstaff: default Check Number to 1

instead of 0, so that it doesn't speedbump payments (of any type)

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoAllow system printing to work normally by delaying stylesheet inclusion
Mike Rylander [Fri, 4 Nov 2016 17:55:23 +0000 (13:55 -0400)]
Allow system printing to work normally by delaying stylesheet inclusion

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoimplement item attributes editor AKA volume/copy template editor
Galen Charlton [Fri, 4 Nov 2016 17:17:24 +0000 (13:17 -0400)]
implement item attributes editor AKA volume/copy template editor

Add a specialization of the volume/copy editor that is restricted
just to managing volume/copy templates; this can be accessed
at the path /eg/staff/cat/volcopy/edit_templates.  A link is added
to the local administration splash page with the label "Volume/Copy
Template Editor"

In attempt to improve terminology, on the local administration page,
the previous "Copy Template Editor" is now called "Serial Copy Template
Editor".

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoPut the toaster at the bottom right everywhere
Mike Rylander [Fri, 4 Nov 2016 17:25:31 +0000 (13:25 -0400)]
Put the toaster at the bottom right everywhere

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: CSS tweak for chrome/webkit
Jason Etheridge [Fri, 4 Nov 2016 14:26:42 +0000 (10:26 -0400)]
webstaff: CSS tweak for chrome/webkit

Specifically, in the Copy Location Group interface, make sure the disabled
position textbox in the New location group dialog is visible within Chrome.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: CSS tweak for chrome/webkit
Jason Etheridge [Fri, 4 Nov 2016 14:18:25 +0000 (10:18 -0400)]
webstaff: CSS tweak for chrome/webkit

Specifically, in the Copy Location Group interface, make sure the disabled org
selector in the New location group dialog is visible within Chrome.

This also happened with Custom Org Unit Trees, and if we run across it again,
I'll put more effort into injecting this more globally for the embedded Dojo
interfaces.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: CSS tweak for chrome/webkit
Jason Etheridge [Fri, 4 Nov 2016 13:55:10 +0000 (09:55 -0400)]
webstaff: CSS tweak for chrome/webkit

Specifically, for Custom Org Unit Trees, make sure the "OPAC" selection in the
disabled combobox is not too light to see in Chrome.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: implement patron merge interface
Galen Charlton [Tue, 25 Oct 2016 21:23:13 +0000 (17:23 -0400)]
webstaff: implement patron merge interface

This patch adds a 'Merge Patrons' button to the patron
search grid. If the user selects two patron records, the
button can be clicked to present a dialog that allows
the user to pick a lead record and confirm a merge of the
patrons.

This patch also adds an egPatronSummary directive that
uses the existing patron summary template with a couple
modifications.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoProtect XUL-ish code when not running under XULRunner
Mike Rylander [Tue, 25 Oct 2016 18:38:05 +0000 (14:38 -0400)]
Protect XUL-ish code when not running under XULRunner

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoadd limit and sorting to transit list fetch
Galen Charlton [Tue, 25 Oct 2016 18:17:54 +0000 (14:17 -0400)]
add limit and sorting to transit list fetch

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: provide login type options for operator change
Mike Rylander [Thu, 20 Oct 2016 20:57:54 +0000 (16:57 -0400)]
webstaff: provide login type options for operator change

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agochanges to transit list interface
Galen Charlton [Thu, 20 Oct 2016 17:08:58 +0000 (13:08 -0400)]
changes to transit list interface

* convert barcode column to hyperlink to item status
  page (and remove the 'Item Status' action; note that
  default double-click action remains going to the
  item status page)
* convert title column to hyperlink to record details page
* add 'Add Items to Bucket' button
* add 'Edit Item Attributes' button

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: Acquisitions Administration
Jason Etheridge [Tue, 18 Oct 2016 17:48:50 +0000 (13:48 -0400)]
webstaff: Acquisitions Administration

FIXME:

* Acq Admin -> Distribution Formulas -> Formula Detail Page : render problem, no uncaught exceptions
* Acq Admin -> Funds : TypeError: openils.XUL.localStorage is not a function

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: various Acq menu entries
Jason Etheridge [Mon, 17 Oct 2016 21:15:12 +0000 (17:15 -0400)]
webstaff: various Acq menu entries

* Purchase Orders
* Create Purchase Order
* Claim-Ready Items
* Open Invoices
* Create Invoice

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: Load MARC Order Records
Jason Etheridge [Mon, 17 Oct 2016 20:12:02 +0000 (16:12 -0400)]
webstaff: Load MARC Order Records

FIXME:

TypeError: openils.XUL.localStorage is not a function
at vlagent.js:56

Having trouble working around this.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: various Acq menu entries
Jason Etheridge [Mon, 17 Oct 2016 18:36:25 +0000 (14:36 -0400)]
webstaff: various Acq menu entries

* My Selection Lists
* New Brief Record
* Patron Requests
* MARC Federated Search
* Load Catalog Record IDs

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agotweak to vlagent.js
Jason Etheridge [Mon, 17 Oct 2016 18:14:40 +0000 (14:14 -0400)]
tweak to vlagent.js

Otherwise, within "General Search", we'll get this error:

TypeError: openils.XUL.localStorage is not a function from vlagent.js:6

FIXME: brittle workaround?

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: first Acq menu-entry and embedded UI
Jason Etheridge [Mon, 17 Oct 2016 17:53:36 +0000 (13:53 -0400)]
webstaff: first Acq menu-entry and embedded UI

* General Search

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: tweaks to transit list
Galen Charlton [Mon, 17 Oct 2016 22:20:04 +0000 (18:20 -0400)]
webstaff: tweaks to transit list

- filter out transits that have been received, thus matching
  previous XUL functionality
- remove the Receive Date/Time column, as it is superfluous
- display the time component of the Send Date/Time

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: implement some workstation preferences
Galen Charlton [Mon, 17 Oct 2016 21:34:30 +0000 (17:34 -0400)]
webstaff: implement some workstation preferences

- Default search library
- Preferred library
- Advanced search pane

Because AngularJS has no way of adding HTTP request headers to
user interactions with the contents of an iframe, the search
library and preferred library are passed to TPAC via two new
session cookies, eg_pref_lib and eg_search_lib.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoWebstaff: implement Operator Change (and Operator Restore)
Mike Rylander [Thu, 6 Oct 2016 16:00:18 +0000 (12:00 -0400)]
Webstaff: implement Operator Change (and Operator Restore)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1467663 webstaff: login requires valid workstation
Bill Erickson [Wed, 28 Sep 2016 16:22:44 +0000 (12:22 -0400)]
LP#1467663 webstaff: login requires valid workstation

Hide the workstation selector when no workstations are registered.
After successful login, direct the user to the new workstation admin
page to create a new workstation.

After successful login with an invalid workstation, direct the user
to the workstation admin page, issuing a 'remove' command to un-register
the offending WS.  On the WS admin page, the user can create a new
workstation or select from their existing workstations.

Any attempt to access a browser client interface (minus the WS admin
page) without a valid workstation will cause the page to redirect to
the workstation admin page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1467663 webstaff: dedicated workstation admin page
Bill Erickson [Wed, 28 Sep 2016 16:21:56 +0000 (12:21 -0400)]
LP#1467663 webstaff: dedicated workstation admin page

Adds a new standalone workstations admin page, accessible from the main
Workstation Administration page.

Adds the ability to delete a workstation by name both within the page
and via URL (with permission).

Fixes the "Use Now" button so that it actually logs the user out before
redirecting to the login page with the desired workstation
pre-selected.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agomake egAudio respect eg.audio.disable
Galen Charlton [Tue, 13 Sep 2016 21:21:51 +0000 (17:21 -0400)]
make egAudio respect eg.audio.disable

This patch also removes some console.debug noise.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: Add reports menu option
Mike Rylander [Mon, 12 Sep 2016 16:43:45 +0000 (12:43 -0400)]
webstaff: Add reports menu option

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: Supply a back link on tabular report output
Mike Rylander [Mon, 12 Sep 2016 15:30:07 +0000 (11:30 -0400)]
webstaff: Supply a back link on tabular report output

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP1537214 Staff Initials in Patron Notes
Kyle Huckins [Wed, 19 Oct 2016 18:59:57 +0000 (11:59 -0700)]
LP1537214 Staff Initials in Patron Notes

Add Initials field to new note dialog when
Require Staff Initials option is active.  Notes with
initials will use the following format:
          "Note [Initials]"

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_new_note_dialog.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/app.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: consolidating some duplicate language
Jane Sandberg [Sat, 19 Nov 2016 16:56:33 +0000 (08:56 -0800)]
Docs: consolidating some duplicate language

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoDocs: Incorporating overlay/merge profiles documentation from Evergreen in Action...
Jane Sandberg [Fri, 18 Nov 2016 04:25:36 +0000 (20:25 -0800)]
Docs: Incorporating overlay/merge profiles documentation from Evergreen in Action + new 2.11 feature

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP#1621799: disable checkout for inactive patrons
Billy Horn [Tue, 4 Oct 2016 21:45:30 +0000 (14:45 -0700)]
LP#1621799: disable checkout for inactive patrons

Add search_barcode variable to patronSvc
Add function fetchedWithInactiveCard to patronSvc
Add check to disable checkout for fetchedWithInactiveCard

Signed-off-by: Billy Horn <bhorn@catalystdevworks.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1528916 Patron Holds Ready/Total
Kyle Huckins [Tue, 4 Oct 2016 16:01:02 +0000 (09:01 -0700)]
LP#1528916 Patron Holds Ready/Total

Switch order or patron_stats().holds.ready and
patron_stats().holds.total in t_summary and patron
index.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/index.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_summary.tt2

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: documenting new authority features
Jane Sandberg [Fri, 18 Nov 2016 01:02:46 +0000 (17:02 -0800)]
Docs: documenting new authority features

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years ago2.10.7-2.10.8 schema upgrade script
Galen Charlton [Wed, 16 Nov 2016 20:18:28 +0000 (15:18 -0500)]
2.10.7-2.10.8 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoupdate 2.10.8 release notes
Galen Charlton [Wed, 16 Nov 2016 20:07:04 +0000 (15:07 -0500)]
update 2.10.8 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoupdates to 2.11.1 release notes
Galen Charlton [Wed, 16 Nov 2016 20:05:54 +0000 (15:05 -0500)]
updates to 2.11.1 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1488655: stamp schema upgrade script
Galen Charlton [Wed, 16 Nov 2016 19:55:02 +0000 (14:55 -0500)]
LP#1488655: stamp schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1488655: fix MR remapping upon fingerprint change
Galen Charlton [Fri, 28 Oct 2016 15:42:52 +0000 (11:42 -0400)]
LP#1488655: fix MR remapping upon fingerprint change

This patch ensures that if the fingerprint of a bib changes, the
bib will be moved to a new metarecord as opposed to ending up
as a member of more than one metarecord.

To test
-------
[1] Note the metarecord that a bib belongs to.
[2] Change the bib so that its fingerprint changes -- with stock
    cbf settings, editing the 245$a should suffice.
[3] Note that it is now a component of two metarecords.
[4] Apply the patch.
[5] Repeat step 2 or force a reingest. The bib should now be part
    of exactly one metarecord.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoLP#1488655: regression test for metarecord remapping
Galen Charlton [Fri, 28 Oct 2016 15:40:52 +0000 (11:40 -0400)]
LP#1488655: regression test for metarecord remapping

This patch contains pgTAP tests for verifying that when
the fingerprint of a bib is changed, it remains part of
exactly one metarecord (as opposed to being part of both
its old and new MRs).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoDocs: Adding 2.11.1 point release notes
Kathy Lussier [Wed, 16 Nov 2016 19:40:51 +0000 (14:40 -0500)]
Docs: Adding 2.11.1 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: Adding 2.10.8 point release notes
Kathy Lussier [Wed, 16 Nov 2016 19:16:51 +0000 (14:16 -0500)]
Docs: Adding 2.10.8 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1618183: more work backporting update to rel_2_10
Galen Charlton [Wed, 16 Nov 2016 17:18:29 +0000 (12:18 -0500)]
LP#1618183: more work backporting update to rel_2_10

This patch tries to ensure that if somebody running 2.10.8 (or a
later 2.10.x) attempts to upgrade to 2.11.1 or later  using the
monolithic version upgrade scripts, the presence of the es-ES locale won't
abort the 2.10.7-2.11.0 update.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1618183: placeholder schema update
Galen Charlton [Wed, 16 Nov 2016 17:14:35 +0000 (12:14 -0500)]
LP#1618183: placeholder schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoforward-port 2.10.7-2.11.0 schema update
Galen Charlton [Wed, 16 Nov 2016 17:03:41 +0000 (12:03 -0500)]
forward-port 2.10.7-2.11.0 schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1618183: make upgrade not die if es-ES locale already exists
Galen Charlton [Wed, 16 Nov 2016 16:56:16 +0000 (11:56 -0500)]
LP#1618183: make upgrade not die if es-ES locale already exists

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1615736: stamping schema update
Galen Charlton [Wed, 16 Nov 2016 16:46:40 +0000 (11:46 -0500)]
LP#1615736: stamping schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1615736 - Add an index on the usr field of action.usr_circ_history.
Josh Stompro [Mon, 29 Aug 2016 19:07:48 +0000 (14:07 -0500)]
LP#1615736 - Add an index on the usr field of action.usr_circ_history.

Improve the performance of looking up a users circ history by adding
an index on action.usr_circ_history( usr ).

To test for performance improvements time doing a search for a particular
users history before and after the index is created.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1612873 - Fix text of notice message for history migration.
Josh Stompro [Tue, 16 Aug 2016 14:55:21 +0000 (09:55 -0500)]
LP#1612873 - Fix text of notice message for history migration.

The notice text that was outputed for every 10000 circs processed
was labeled as users, which made the output confusing.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoRevert "webstaff: add template for patron merge dialog"
Galen Charlton [Tue, 15 Nov 2016 21:35:30 +0000 (16:35 -0500)]
Revert "webstaff: add template for patron merge dialog"

Whoops, sorry.

This reverts commit afbda31bf6ffb065f3c1b1c85c0caddc0fcbc583.

4 years agowebstaff: add template for patron merge dialog
Galen Charlton [Tue, 15 Nov 2016 21:34:02 +0000 (16:34 -0500)]
webstaff: add template for patron merge dialog

This had been skipped by mistake.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP 1639250: Install Excel::Writer::XLSX from deb on Wheezy.
Jason Stephenson [Fri, 4 Nov 2016 14:24:40 +0000 (10:24 -0400)]
LP 1639250: Install Excel::Writer::XLSX from deb on Wheezy.

Change Open-ILS/src/extras/install/Makefile.debian-wheezy from the
deb, libexcel-writer-xlsx-perl, instead of via CPAN.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
4 years agoLP#1640153 Fix abort-transit-copy-status.t perl test.
Chris Sharp [Tue, 8 Nov 2016 01:06:03 +0000 (20:06 -0500)]
LP#1640153 Fix abort-transit-copy-status.t perl test.

Fixes added by bug 1613374 changed the behavior of canceled
transits so that the test written for bug 1306666 stopped working.
Accounting for the new "Canceled Transit" status fixes the test.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoFix purge_user_activity.pg live test
Chris Sharp [Tue, 8 Nov 2016 00:10:06 +0000 (19:10 -0500)]
Fix purge_user_activity.pg live test

The purge_user_activity.pg test inserts rows into actor.usr_activity
in a random date order, but the changes in bug 1570909 created a trigger
that overwrites the previous entry for a transient type, causing the
test to fail.  We reorder the usr_activity rows so that the most recent
row will be in place.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP 1628966: View Temporary/My Lists from Record Summary
Christine Morgan [Thu, 6 Oct 2016 15:58:20 +0000 (11:58 -0400)]
LP 1628966: View Temporary/My Lists from Record Summary

This commit adds a link to the record summary screen in the public
opac that allows access to a temporary list or, if logged in, all your
lists.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP1638921 List display broken in 2.11
blake [Thu, 3 Nov 2016 15:42:24 +0000 (10:42 -0500)]
LP1638921 List display broken in 2.11

The badges feature added more data to an array which broke bib_record_list_via_search
Taking the first item in the array instead of the last item fixes the issue.
Thanks to miker and Dyrcona!

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Mike Rylander <miker@esilibrary.com>
4 years agolp1629075: Hide Permalink in Staff Client
Christine Morgan [Thu, 29 Sep 2016 20:50:24 +0000 (16:50 -0400)]
lp1629075: Hide Permalink in Staff Client

This will hide the permalink in the staff client catalog.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1584807: Clicking column header should not unsort list
Kathy Lussier [Tue, 24 May 2016 00:09:34 +0000 (20:09 -0400)]
LP#1584807: Clicking column header should not unsort list

Clicking column headers in My Account cycled through ascending order,
descending order, and then unsorted. But unsorting a list after clicking a
header is unintutive to the user. Instead, it should toggle between ascending /
descending order.

Test plan
* Using the concerto dataset, log in as user 99999395984 / maes1234
* Go to the Items Out area of my account and click the title column header to
sort the list.
* The list will first sort alphabetically in ascending order, on a second click
will sort alphabetically in descending order, and, on a third click, will
return to the default sort order.
* After loading the patch, clicking the column header should only result in
sorting in ascending and descending order.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1620750 Prevent log warning for uninit var in checkin_retarget()
Dan Scott [Tue, 6 Sep 2016 17:53:02 +0000 (13:53 -0400)]
LP#1620750 Prevent log warning for uninit var in checkin_retarget()

If the retarget_mode variable is not initialized, then a warning is generated
in the logs every time an item is checked in. Avoid the warning by
short-circuiting before testing the value in the regex.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1624491 Avoid uninit var prox_cache during holds processing
Dan Scott [Fri, 16 Sep 2016 17:49:01 +0000 (13:49 -0400)]
LP#1624491 Avoid uninit var prox_cache during holds processing

open-ils.circ was logging a prox_cache hash value before it is
guaranteed to have been initialized. Instead, log messages _after_ they
have been initialized.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1282751 Credit card payment balance owed rounding fix
Bill Erickson [Thu, 15 Sep 2016 19:13:47 +0000 (15:13 -0400)]
LP#1282751 Credit card payment balance owed rounding fix

Avoid using Perl's int() when summing owed/paid totals for display in
the TPAC credit card payment form, since this can lead to rounding
errors.

A simple example of why we should not use int() when summing floating
point numbers:

perl -e 'print "no match\n" unless ((8.29 * 100) == int(8.29 * 100))';

Furthermore, use the relatively new fpsum() utility function for summing
floating point numbers so we can avoid having multiple versions of the
summing logic floating (*cough*) around (*cough cough*).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoDocs: Update base system requirements for Evergreen
Ben Shum [Mon, 24 Oct 2016 16:05:31 +0000 (12:05 -0400)]
Docs: Update base system requirements for Evergreen

These memory values are woefully out of date for modern Evergreen installations.

Recommending also at least 2 GB of RAM for client workstation, though honestly,
more is probably better there too.

Also adding specific Linux distributions supported by this community instead of
just Linux.

And dropping specific Windows versions (especially since two out of the three
are no longer supported by Microsoft).

Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agoDocs: add mpm_prefork config for Apache 2.4 systems
Dan Scott [Sun, 2 Oct 2016 21:28:05 +0000 (17:28 -0400)]
Docs: add mpm_prefork config for Apache 2.4 systems

We had only documented the Apache 2.2 stanzas for mpm_prefork, so include a
section for 2.4 that uses MaxRequestWorkers and MaxConnectionsPerChild. Given
the memory leaks that we have seen, suggest lower settings for these two values
(assuming that most sites will be serving a public catalogue instead of using a
separate discovery layer).

Also fix the weird formatting where Debian instructions were indented under a
Fedora section.

Also use dots for ordered bullets instead of renumbering all of the bullets
again.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoDocs: set up default action_trigger_filters.json file
Dan Scott [Sun, 2 Oct 2016 14:04:04 +0000 (10:04 -0400)]
Docs: set up default action_trigger_filters.json file

Given that action_trigger_runner.pl looks by default for a file called
action_trigger_filters.json, instruct people to create that file when they are
first setting up their system.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoLP#1623955: Keep periods in subject links
Kathy Lussier [Thu, 29 Sep 2016 17:50:40 +0000 (13:50 -0400)]
LP#1623955: Keep periods in subject links

The subject links in the record summary were stripping periods, changing
headings that contained N.Y., for example, to NY in the subsequent search
string. Since normalization at index time replaces the period with a space,
clicking the subject links did not successfully retrieve all relevant
results.

Test plan:
Click the Subject link for a record that has New York (N.Y.) in its heading and
has no other instances of ny in the keyword index. This record will not be
retrieved when you click the link. After loading the patch, the record will be
successfully retrieved, along with other records that contain New York (N.Y.) in
their subject headings.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1494750 - Extra closing curly bracket in style.css disables following css
Josh Stompro [Fri, 19 Aug 2016 20:31:11 +0000 (15:31 -0500)]
LP#1494750 - Extra closing curly bracket in style.css disables following css

Which is the .sort_deemphasize class, so the modification of the non-filing
characters never happens in the sort results.

Test Plan:

Needed: Patron account with checkout history that contains titles with
non filing characters.

Before change, view the checkout history and sort by title.  Note that the
leading non filing characters look the same as the rest of the title.

After change, view the checkout history and sort by title.  Note that the
leading non filing characters now have a different style than the rest
of the title.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1526159 Webstaff Items Out includes overdue, etc.
Bill Erickson [Fri, 23 Sep 2016 17:56:42 +0000 (13:56 -0400)]
LP#1526159 Webstaff Items Out includes overdue, etc.

Items Out tally in patron summary (side-bar) is now consistent with the
Items Out value displayed along the top of the patron UI.  It now includes
overdues and optionally lost/claims-returned total.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>