working/Evergreen.git
4 years agoWebstaff: implement Operator Change (and Operator Restore)
Mike Rylander [Thu, 6 Oct 2016 16:00:18 +0000 (12:00 -0400)]
Webstaff: implement Operator Change (and Operator Restore)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1467663 webstaff: login requires valid workstation
Bill Erickson [Wed, 28 Sep 2016 16:22:44 +0000 (12:22 -0400)]
LP#1467663 webstaff: login requires valid workstation

Hide the workstation selector when no workstations are registered.
After successful login, direct the user to the new workstation admin
page to create a new workstation.

After successful login with an invalid workstation, direct the user
to the workstation admin page, issuing a 'remove' command to un-register
the offending WS.  On the WS admin page, the user can create a new
workstation or select from their existing workstations.

Any attempt to access a browser client interface (minus the WS admin
page) without a valid workstation will cause the page to redirect to
the workstation admin page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1467663 webstaff: dedicated workstation admin page
Bill Erickson [Wed, 28 Sep 2016 16:21:56 +0000 (12:21 -0400)]
LP#1467663 webstaff: dedicated workstation admin page

Adds a new standalone workstations admin page, accessible from the main
Workstation Administration page.

Adds the ability to delete a workstation by name both within the page
and via URL (with permission).

Fixes the "Use Now" button so that it actually logs the user out before
redirecting to the login page with the desired workstation
pre-selected.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agomake egAudio respect eg.audio.disable
Galen Charlton [Tue, 13 Sep 2016 21:21:51 +0000 (17:21 -0400)]
make egAudio respect eg.audio.disable

This patch also removes some console.debug noise.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: Add reports menu option
Mike Rylander [Mon, 12 Sep 2016 16:43:45 +0000 (12:43 -0400)]
webstaff: Add reports menu option

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agowebstaff: Supply a back link on tabular report output
Mike Rylander [Mon, 12 Sep 2016 15:30:07 +0000 (11:30 -0400)]
webstaff: Supply a back link on tabular report output

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP1537214 Staff Initials in Patron Notes
Kyle Huckins [Wed, 19 Oct 2016 18:59:57 +0000 (11:59 -0700)]
LP1537214 Staff Initials in Patron Notes

Add Initials field to new note dialog when
Require Staff Initials option is active.  Notes with
initials will use the following format:
          "Note [Initials]"

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_new_note_dialog.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/app.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: consolidating some duplicate language
Jane Sandberg [Sat, 19 Nov 2016 16:56:33 +0000 (08:56 -0800)]
Docs: consolidating some duplicate language

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoDocs: Incorporating overlay/merge profiles documentation from Evergreen in Action...
Jane Sandberg [Fri, 18 Nov 2016 04:25:36 +0000 (20:25 -0800)]
Docs: Incorporating overlay/merge profiles documentation from Evergreen in Action + new 2.11 feature

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP#1621799: disable checkout for inactive patrons
Billy Horn [Tue, 4 Oct 2016 21:45:30 +0000 (14:45 -0700)]
LP#1621799: disable checkout for inactive patrons

Add search_barcode variable to patronSvc
Add function fetchedWithInactiveCard to patronSvc
Add check to disable checkout for fetchedWithInactiveCard

Signed-off-by: Billy Horn <bhorn@catalystdevworks.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1528916 Patron Holds Ready/Total
Kyle Huckins [Tue, 4 Oct 2016 16:01:02 +0000 (09:01 -0700)]
LP#1528916 Patron Holds Ready/Total

Switch order or patron_stats().holds.ready and
patron_stats().holds.total in t_summary and patron
index.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/index.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_summary.tt2

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: documenting new authority features
Jane Sandberg [Fri, 18 Nov 2016 01:02:46 +0000 (17:02 -0800)]
Docs: documenting new authority features

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years ago2.10.7-2.10.8 schema upgrade script
Galen Charlton [Wed, 16 Nov 2016 20:18:28 +0000 (15:18 -0500)]
2.10.7-2.10.8 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoupdate 2.10.8 release notes
Galen Charlton [Wed, 16 Nov 2016 20:07:04 +0000 (15:07 -0500)]
update 2.10.8 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoupdates to 2.11.1 release notes
Galen Charlton [Wed, 16 Nov 2016 20:05:54 +0000 (15:05 -0500)]
updates to 2.11.1 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1488655: stamp schema upgrade script
Galen Charlton [Wed, 16 Nov 2016 19:55:02 +0000 (14:55 -0500)]
LP#1488655: stamp schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1488655: fix MR remapping upon fingerprint change
Galen Charlton [Fri, 28 Oct 2016 15:42:52 +0000 (11:42 -0400)]
LP#1488655: fix MR remapping upon fingerprint change

This patch ensures that if the fingerprint of a bib changes, the
bib will be moved to a new metarecord as opposed to ending up
as a member of more than one metarecord.

To test
-------
[1] Note the metarecord that a bib belongs to.
[2] Change the bib so that its fingerprint changes -- with stock
    cbf settings, editing the 245$a should suffice.
[3] Note that it is now a component of two metarecords.
[4] Apply the patch.
[5] Repeat step 2 or force a reingest. The bib should now be part
    of exactly one metarecord.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoLP#1488655: regression test for metarecord remapping
Galen Charlton [Fri, 28 Oct 2016 15:40:52 +0000 (11:40 -0400)]
LP#1488655: regression test for metarecord remapping

This patch contains pgTAP tests for verifying that when
the fingerprint of a bib is changed, it remains part of
exactly one metarecord (as opposed to being part of both
its old and new MRs).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoDocs: Adding 2.11.1 point release notes
Kathy Lussier [Wed, 16 Nov 2016 19:40:51 +0000 (14:40 -0500)]
Docs: Adding 2.11.1 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: Adding 2.10.8 point release notes
Kathy Lussier [Wed, 16 Nov 2016 19:16:51 +0000 (14:16 -0500)]
Docs: Adding 2.10.8 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1618183: more work backporting update to rel_2_10
Galen Charlton [Wed, 16 Nov 2016 17:18:29 +0000 (12:18 -0500)]
LP#1618183: more work backporting update to rel_2_10

This patch tries to ensure that if somebody running 2.10.8 (or a
later 2.10.x) attempts to upgrade to 2.11.1 or later  using the
monolithic version upgrade scripts, the presence of the es-ES locale won't
abort the 2.10.7-2.11.0 update.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1618183: placeholder schema update
Galen Charlton [Wed, 16 Nov 2016 17:14:35 +0000 (12:14 -0500)]
LP#1618183: placeholder schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoforward-port 2.10.7-2.11.0 schema update
Galen Charlton [Wed, 16 Nov 2016 17:03:41 +0000 (12:03 -0500)]
forward-port 2.10.7-2.11.0 schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1618183: make upgrade not die if es-ES locale already exists
Galen Charlton [Wed, 16 Nov 2016 16:56:16 +0000 (11:56 -0500)]
LP#1618183: make upgrade not die if es-ES locale already exists

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1615736: stamping schema update
Galen Charlton [Wed, 16 Nov 2016 16:46:40 +0000 (11:46 -0500)]
LP#1615736: stamping schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1615736 - Add an index on the usr field of action.usr_circ_history.
Josh Stompro [Mon, 29 Aug 2016 19:07:48 +0000 (14:07 -0500)]
LP#1615736 - Add an index on the usr field of action.usr_circ_history.

Improve the performance of looking up a users circ history by adding
an index on action.usr_circ_history( usr ).

To test for performance improvements time doing a search for a particular
users history before and after the index is created.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1612873 - Fix text of notice message for history migration.
Josh Stompro [Tue, 16 Aug 2016 14:55:21 +0000 (09:55 -0500)]
LP#1612873 - Fix text of notice message for history migration.

The notice text that was outputed for every 10000 circs processed
was labeled as users, which made the output confusing.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoRevert "webstaff: add template for patron merge dialog"
Galen Charlton [Tue, 15 Nov 2016 21:35:30 +0000 (16:35 -0500)]
Revert "webstaff: add template for patron merge dialog"

Whoops, sorry.

This reverts commit afbda31bf6ffb065f3c1b1c85c0caddc0fcbc583.

4 years agowebstaff: add template for patron merge dialog
Galen Charlton [Tue, 15 Nov 2016 21:34:02 +0000 (16:34 -0500)]
webstaff: add template for patron merge dialog

This had been skipped by mistake.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP 1639250: Install Excel::Writer::XLSX from deb on Wheezy.
Jason Stephenson [Fri, 4 Nov 2016 14:24:40 +0000 (10:24 -0400)]
LP 1639250: Install Excel::Writer::XLSX from deb on Wheezy.

Change Open-ILS/src/extras/install/Makefile.debian-wheezy from the
deb, libexcel-writer-xlsx-perl, instead of via CPAN.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
4 years agoLP#1640153 Fix abort-transit-copy-status.t perl test.
Chris Sharp [Tue, 8 Nov 2016 01:06:03 +0000 (20:06 -0500)]
LP#1640153 Fix abort-transit-copy-status.t perl test.

Fixes added by bug 1613374 changed the behavior of canceled
transits so that the test written for bug 1306666 stopped working.
Accounting for the new "Canceled Transit" status fixes the test.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoFix purge_user_activity.pg live test
Chris Sharp [Tue, 8 Nov 2016 00:10:06 +0000 (19:10 -0500)]
Fix purge_user_activity.pg live test

The purge_user_activity.pg test inserts rows into actor.usr_activity
in a random date order, but the changes in bug 1570909 created a trigger
that overwrites the previous entry for a transient type, causing the
test to fail.  We reorder the usr_activity rows so that the most recent
row will be in place.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP 1628966: View Temporary/My Lists from Record Summary
Christine Morgan [Thu, 6 Oct 2016 15:58:20 +0000 (11:58 -0400)]
LP 1628966: View Temporary/My Lists from Record Summary

This commit adds a link to the record summary screen in the public
opac that allows access to a temporary list or, if logged in, all your
lists.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP1638921 List display broken in 2.11
blake [Thu, 3 Nov 2016 15:42:24 +0000 (10:42 -0500)]
LP1638921 List display broken in 2.11

The badges feature added more data to an array which broke bib_record_list_via_search
Taking the first item in the array instead of the last item fixes the issue.
Thanks to miker and Dyrcona!

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Mike Rylander <miker@esilibrary.com>
4 years agolp1629075: Hide Permalink in Staff Client
Christine Morgan [Thu, 29 Sep 2016 20:50:24 +0000 (16:50 -0400)]
lp1629075: Hide Permalink in Staff Client

This will hide the permalink in the staff client catalog.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1584807: Clicking column header should not unsort list
Kathy Lussier [Tue, 24 May 2016 00:09:34 +0000 (20:09 -0400)]
LP#1584807: Clicking column header should not unsort list

Clicking column headers in My Account cycled through ascending order,
descending order, and then unsorted. But unsorting a list after clicking a
header is unintutive to the user. Instead, it should toggle between ascending /
descending order.

Test plan
* Using the concerto dataset, log in as user 99999395984 / maes1234
* Go to the Items Out area of my account and click the title column header to
sort the list.
* The list will first sort alphabetically in ascending order, on a second click
will sort alphabetically in descending order, and, on a third click, will
return to the default sort order.
* After loading the patch, clicking the column header should only result in
sorting in ascending and descending order.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1620750 Prevent log warning for uninit var in checkin_retarget()
Dan Scott [Tue, 6 Sep 2016 17:53:02 +0000 (13:53 -0400)]
LP#1620750 Prevent log warning for uninit var in checkin_retarget()

If the retarget_mode variable is not initialized, then a warning is generated
in the logs every time an item is checked in. Avoid the warning by
short-circuiting before testing the value in the regex.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1624491 Avoid uninit var prox_cache during holds processing
Dan Scott [Fri, 16 Sep 2016 17:49:01 +0000 (13:49 -0400)]
LP#1624491 Avoid uninit var prox_cache during holds processing

open-ils.circ was logging a prox_cache hash value before it is
guaranteed to have been initialized. Instead, log messages _after_ they
have been initialized.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1282751 Credit card payment balance owed rounding fix
Bill Erickson [Thu, 15 Sep 2016 19:13:47 +0000 (15:13 -0400)]
LP#1282751 Credit card payment balance owed rounding fix

Avoid using Perl's int() when summing owed/paid totals for display in
the TPAC credit card payment form, since this can lead to rounding
errors.

A simple example of why we should not use int() when summing floating
point numbers:

perl -e 'print "no match\n" unless ((8.29 * 100) == int(8.29 * 100))';

Furthermore, use the relatively new fpsum() utility function for summing
floating point numbers so we can avoid having multiple versions of the
summing logic floating (*cough*) around (*cough cough*).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoDocs: Update base system requirements for Evergreen
Ben Shum [Mon, 24 Oct 2016 16:05:31 +0000 (12:05 -0400)]
Docs: Update base system requirements for Evergreen

These memory values are woefully out of date for modern Evergreen installations.

Recommending also at least 2 GB of RAM for client workstation, though honestly,
more is probably better there too.

Also adding specific Linux distributions supported by this community instead of
just Linux.

And dropping specific Windows versions (especially since two out of the three
are no longer supported by Microsoft).

Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agoDocs: add mpm_prefork config for Apache 2.4 systems
Dan Scott [Sun, 2 Oct 2016 21:28:05 +0000 (17:28 -0400)]
Docs: add mpm_prefork config for Apache 2.4 systems

We had only documented the Apache 2.2 stanzas for mpm_prefork, so include a
section for 2.4 that uses MaxRequestWorkers and MaxConnectionsPerChild. Given
the memory leaks that we have seen, suggest lower settings for these two values
(assuming that most sites will be serving a public catalogue instead of using a
separate discovery layer).

Also fix the weird formatting where Debian instructions were indented under a
Fedora section.

Also use dots for ordered bullets instead of renumbering all of the bullets
again.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoDocs: set up default action_trigger_filters.json file
Dan Scott [Sun, 2 Oct 2016 14:04:04 +0000 (10:04 -0400)]
Docs: set up default action_trigger_filters.json file

Given that action_trigger_runner.pl looks by default for a file called
action_trigger_filters.json, instruct people to create that file when they are
first setting up their system.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoLP#1623955: Keep periods in subject links
Kathy Lussier [Thu, 29 Sep 2016 17:50:40 +0000 (13:50 -0400)]
LP#1623955: Keep periods in subject links

The subject links in the record summary were stripping periods, changing
headings that contained N.Y., for example, to NY in the subsequent search
string. Since normalization at index time replaces the period with a space,
clicking the subject links did not successfully retrieve all relevant
results.

Test plan:
Click the Subject link for a record that has New York (N.Y.) in its heading and
has no other instances of ny in the keyword index. This record will not be
retrieved when you click the link. After loading the patch, the record will be
successfully retrieved, along with other records that contain New York (N.Y.) in
their subject headings.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1494750 - Extra closing curly bracket in style.css disables following css
Josh Stompro [Fri, 19 Aug 2016 20:31:11 +0000 (15:31 -0500)]
LP#1494750 - Extra closing curly bracket in style.css disables following css

Which is the .sort_deemphasize class, so the modification of the non-filing
characters never happens in the sort results.

Test Plan:

Needed: Patron account with checkout history that contains titles with
non filing characters.

Before change, view the checkout history and sort by title.  Note that the
leading non filing characters look the same as the rest of the title.

After change, view the checkout history and sort by title.  Note that the
leading non filing characters now have a different style than the rest
of the title.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1526159 Webstaff Items Out includes overdue, etc.
Bill Erickson [Fri, 23 Sep 2016 17:56:42 +0000 (13:56 -0400)]
LP#1526159 Webstaff Items Out includes overdue, etc.

Items Out tally in patron summary (side-bar) is now consistent with the
Items Out value displayed along the top of the patron UI.  It now includes
overdues and optionally lost/claims-returned total.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1565009 Webstaff patron search progress bar
Bill Erickson [Fri, 2 Sep 2016 21:01:35 +0000 (17:01 -0400)]
LP#1565009 Webstaff patron search progress bar

Displays a progress bar while waiting for results from a patron search
in the browser client.  Bar only displays when a server-side search is
required.  (It's not displayed for cached searches, etc.).  Results grid
is hidden while the progress bar is visible and vice versa.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1629029: Fixed missing space in line 11
Jim Keenan [Thu, 29 Sep 2016 17:22:15 +0000 (13:22 -0400)]
LP#1629029: Fixed missing space in line 11

Signed-off-by: Jim Keenan <jkeenan@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1618992 Webstaff checkin UI bib title link repair
Bill Erickson [Fri, 16 Sep 2016 21:16:53 +0000 (17:16 -0400)]
LP#1618992 Webstaff checkin UI bib title link repair

Fix bib record title link in browser staff checkin grid so that clicking
on the link directs the user to the bib record page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1618992 Webstaff checkin error handler repairs
Bill Erickson [Fri, 16 Sep 2016 21:15:37 +0000 (17:15 -0400)]
LP#1618992 Webstaff checkin error handler repairs

Fix typo in browser staff checkin error handler which resulted in null
errors any time a checkin failed instead of gracefully handling the
error.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1618992 Work log checkin/user sanity checks
Bill Erickson [Fri, 16 Sep 2016 21:14:42 +0000 (17:14 -0400)]
LP#1618992 Work log checkin/user sanity checks

Avoid attempts to log user information during checkin when no user
information is available.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#802700 Sort funds by code and year
Remington Steed [Thu, 29 Sep 2016 15:05:18 +0000 (11:05 -0400)]
LP#802700 Sort funds by code and year

This commit applies Bill Erickson's change from bug #1227344 to the fund
selector that appears on the Selection List (picklist) screen when you click
"Copies" to reveal the line items table. (Bill also mentioned this in
bug #1266471.)

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoAdd a simple Item Information test for SIP server
Dan Scott [Fri, 23 Sep 2016 19:18:32 +0000 (15:18 -0400)]
Add a simple Item Information test for SIP server

Useful if you want to check the ability of the server to return Unicode
response.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoDocs: Minor fixes for 2.11 Release Notes
Kathy Lussier [Fri, 23 Sep 2016 17:37:42 +0000 (13:37 -0400)]
Docs: Minor fixes for 2.11 Release Notes

Fixed a header level as well as some minor typos in the 2.11 release notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoCreate/consolidate release notes for 2.11
Dan Wells [Thu, 25 Aug 2016 22:08:07 +0000 (18:08 -0400)]
Create/consolidate release notes for 2.11

Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agosmall typo fix in 2.10 release notes
Galen Charlton [Thu, 22 Sep 2016 00:27:42 +0000 (20:27 -0400)]
small typo fix in 2.10 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoForward port 2.9.7 to 2.9.8 db upgrade script.
Jason Stephenson [Wed, 21 Sep 2016 19:58:33 +0000 (15:58 -0400)]
Forward port 2.9.7 to 2.9.8 db upgrade script.

Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoschema update script: 2.10.6 -> 2.10.7
Galen Charlton [Wed, 21 Sep 2016 19:13:56 +0000 (15:13 -0400)]
schema update script: 2.10.6 -> 2.10.7

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Adding 2.10.7 point release notes
Kathy Lussier [Wed, 21 Sep 2016 17:35:14 +0000 (13:35 -0400)]
Docs: Adding 2.10.7 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: Adding 2.9.8 point release notes
Kathy Lussier [Wed, 21 Sep 2016 17:19:02 +0000 (13:19 -0400)]
Docs: Adding 2.9.8 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: 2.11 Release Notes updates
Kathy Lussier [Wed, 21 Sep 2016 16:42:42 +0000 (12:42 -0400)]
Docs: 2.11 Release Notes updates

Updates to the 2.11, including: adding a note about Ubuntu Xenial support,
adding acknowledgements for translators and for some who were missed in the
first iteration of Release Notes, slimming down the activity metric release
notes entry and moving the original, detail-rich entry to the TechRef directory.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1623541: Booking will fail if its router isn't called "router"
Mike Rylander [Wed, 14 Sep 2016 14:44:15 +0000 (10:44 -0400)]
LP#1623541: Booking will fail if its router isn't called "router"

The circ code checks to see if the booking app is running, and if not, it
skips some booking-related logic. This is a useful performance enhancement
where booking is not in use. It does this by asking the OpenSRF router if
the "open-ils.booking" app has registered with it. Most of the time the
OpenSRF router will be called, unimaginatively, "router" but when it's not,
booking will not be considered by the circ module even if it's running.

Instead of assuming "router" we should simply look up the router's name.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoDocs: improving documentation for catalog searching widgets
Eva Cerninakova [Tue, 20 Sep 2016 17:36:30 +0000 (10:36 -0700)]
Docs: improving documentation for catalog searching widgets

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP#1624846 Add charset declaration to TPAC print output
Dan Scott [Sun, 18 Sep 2016 13:16:27 +0000 (09:16 -0400)]
LP#1624846 Add charset declaration to TPAC print output

Non-ASCII characters were printed incorrectly in some browsers, such as
Firefox, that still default to ISO-8859-1 encodings in the absence of a
specifically declared encoding.

Our output encoding will always be UTF-8, so declare it.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1624025 - Add 'is_available' field to config::copy_status
Chris Sharp [Thu, 15 Sep 2016 18:28:09 +0000 (14:28 -0400)]
LP#1624025 - Add 'is_available' field to config::copy_status

The fix to bug 1464709 overlooked a necessary place to define
the newly added 'is_available' column to the config.copy_status
table.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoDocs: 2.11 release note fixes
Kathy Lussier [Wed, 14 Sep 2016 16:47:16 +0000 (12:47 -0400)]
Docs: 2.11 release note fixes

2.11 release note entries edited for clarity, grammar, spelling and style.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoDocs: Adding acknowledgements to the 2.11 release notes
Kathy Lussier [Wed, 14 Sep 2016 14:53:30 +0000 (10:53 -0400)]
Docs: Adding acknowledgements to the 2.11 release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1620803 Add missing workstation passthru to AuthProxy
Dan Wells [Tue, 13 Sep 2016 17:40:43 +0000 (13:40 -0400)]
LP#1620803 Add missing workstation passthru to AuthProxy

The AuthProxy.pm login function was not passing through a possible
'workstation' parameter to auth_internal's 'session.create' method.
Without this, all login's end up with a workstation set to the user's
home_ou, which can affect things including opt-in and transit
behaviors.

While not needed for the initial 'user.validate', it seems cleaner
and simpler to just bring it over when constructing the initial
$args hash.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoTranslation updates - po files
Dan Wells [Fri, 9 Sep 2016 13:37:31 +0000 (09:37 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1436987: webstaff - fix patron search form
Galen Charlton [Mon, 7 Mar 2016 17:42:51 +0000 (12:42 -0500)]
LP#1436987: webstaff - fix patron search form

This patch ensures that the patron profile and
search OU values are retained when going from a patron
search to a single record and back to the patron search.

To test the fix for this bug:

[1] Search for a patron using the expanded patron search fields,
    making sure to select values for the profile and search
    OU dropdowns.
[2] Open a record, then click "Patron Search" to return to the
    search form.
[3] Verify that the profile and search library are set and
    that the same patron records are retrieved.

This patch includes elements from a patch originally written
by Victoria Lewis <vlewis@catalystitservices.com>

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1413352 Brief record price sets lineitem price
Bill Erickson [Thu, 2 Jun 2016 19:27:06 +0000 (15:27 -0400)]
LP#1413352 Brief record price sets lineitem price

Propagate lineitem MARC 'price' attribute value to the lineitem
estimated_unit_price field.  This allows users to apply a lineitem
price directly from the ACQ Brief Record interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoSIP manual testing formatting cleanup
Dan Scott [Tue, 6 Sep 2016 01:34:20 +0000 (21:34 -0400)]
SIP manual testing formatting cleanup

The extra ** in the sample SIP lines was distracting. Also, it wasn't clear
which password to use when $password was used twice, so disambiguate it to
identify user vs. SIP password.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoLP1613374: Release notes formatting fix. user/berick/clean-auditor
Chris Sharp [Wed, 31 Aug 2016 11:14:49 +0000 (07:14 -0400)]
LP1613374: Release notes formatting fix.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoStamping upgrade script for Spanish locale seed data
Dan Wells [Mon, 29 Aug 2016 21:38:10 +0000 (17:38 -0400)]
Stamping upgrade script for Spanish locale seed data

Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1618183: Add Spanish to config.i18n_locale
Ben Shum [Mon, 29 Aug 2016 19:37:48 +0000 (15:37 -0400)]
LP#1618183: Add Spanish to config.i18n_locale

Add Spanish to this table so that it is an option for supported translations.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1618136 Fix webstaff IDL2js.js test failures
Jeff Godin [Mon, 29 Aug 2016 16:58:27 +0000 (12:58 -0400)]
LP#1618136 Fix webstaff IDL2js.js test failures

Fix webstaff test failures due to an invalid IDL2js.js file by adding
newly-required preprocessing to the support script that generates that
file when running tests.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoStamp 0999 upgrade; remove merge conflict markers
Bill Erickson [Fri, 26 Aug 2016 21:00:20 +0000 (17:00 -0400)]
Stamp 0999 upgrade; remove merge conflict markers

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoforward-port 2.10.5-2.10.6 schema update script
Galen Charlton [Fri, 26 Aug 2016 00:47:47 +0000 (20:47 -0400)]
forward-port 2.10.5-2.10.6 schema update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoforward-port 2.9.6-2.9.7 schema upgrade script
Galen Charlton [Fri, 26 Aug 2016 00:06:25 +0000 (20:06 -0400)]
forward-port 2.9.6-2.9.7 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Add Additional 2.9.7 Acknowledgments for Testing/Signoff
Jason Stephenson [Thu, 25 Aug 2016 21:29:12 +0000 (17:29 -0400)]
Docs: Add Additional 2.9.7 Acknowledgments for Testing/Signoff

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Adding 2.9.7 Release Notes
Jason Stephenson [Thu, 25 Aug 2016 21:26:19 +0000 (17:26 -0400)]
Docs: Adding 2.9.7 Release Notes

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Adding 2.9.6 Release Notes
Kathy Lussier [Wed, 15 Jun 2016 17:04:23 +0000 (13:04 -0400)]
Docs: Adding 2.9.6 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agolet the 2.10.6 release notes be free of errorr
Galen Charlton [Thu, 25 Aug 2016 23:56:42 +0000 (19:56 -0400)]
let the 2.10.6 release notes be free of errorr

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agofirst pass at 2.10.6 release notes
Galen Charlton [Thu, 25 Aug 2016 21:04:41 +0000 (17:04 -0400)]
first pass at 2.10.6 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoTranslation updates - newpot
Dan Wells [Thu, 25 Aug 2016 21:55:36 +0000 (17:55 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoTranslation updates - po files, part 2
Dan Wells [Thu, 25 Aug 2016 21:01:05 +0000 (17:01 -0400)]
Translation updates - po files, part 2

Missed the *new* po files in the previous commit.  Number of new
translations for Spanish now stands at 9000+ (wow!).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1095280: i18n - Add templates to update_pofiles
Ben Shum [Wed, 24 Aug 2016 20:33:18 +0000 (16:33 -0400)]
LP#1095280: i18n - Add templates to update_pofiles

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1095280: i18n - Add new templates for translation to Makefile
Ben Shum [Wed, 24 Aug 2016 13:32:47 +0000 (09:32 -0400)]
LP#1095280: i18n - Add new templates for translation to Makefile

Add various source and output files for new templates directories for i18n
along with make targets and other copy commands.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1095280: i18n - Move existing templates closer together in Makefile
Ben Shum [Wed, 24 Aug 2016 13:25:27 +0000 (09:25 -0400)]
LP#1095280: i18n - Move existing templates closer together in Makefile

In the interest of making it easier to edit, move all the lines
for generating i18n translation files for Open-ILS/src/templates/*
closer together.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoTranslation updates - po files
Dan Wells [Thu, 25 Aug 2016 19:27:56 +0000 (15:27 -0400)]
Translation updates - po files

Translations have been significantly increased.  In particular, Spanish
has received a huge update with over 8,000 new translations, Czech has
received a sizeable update of over 800 translations, and additional
smaller updates have been added for Arabic, French (Canada), and
Armenian.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1617017: make another TPAC string translatable
Galen Charlton [Thu, 25 Aug 2016 18:03:38 +0000 (14:03 -0400)]
LP#1617017: make another TPAC string translatable

"Export List" in hold_history.tt2

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1613709: Make DOB validation alert failure translatable.
Jason Stephenson [Thu, 25 Aug 2016 15:57:42 +0000 (11:57 -0400)]
LP#1613709: Make DOB validation alert failure translatable.

The alert message about an invalid DOB being entered in the OPAC
patron registration is not translatable.  The solution, suggested by
Eva Cerninakova, is to wrap the string in the l() template function to
make it so.  That is what this branch does.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1616882: mark another string as translateable
Galen Charlton [Thu, 25 Aug 2016 15:11:00 +0000 (11:11 -0400)]
LP#1616882: mark another string as translateable

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1616882: mark string as translateable
Galen Charlton [Thu, 25 Aug 2016 15:05:25 +0000 (11:05 -0400)]
LP#1616882: mark string as translateable

This patch makes the "Branch relationship" string in TPAC
available to be translated.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1613374 - Canceled Transit status Release Notes
Chris Sharp [Thu, 25 Aug 2016 11:15:11 +0000 (07:15 -0400)]
LP#1613374 - Canceled Transit status Release Notes

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP 1583608: The make_release script always makes a db upgrade script.
Jason Stephenson [Mon, 30 May 2016 17:01:45 +0000 (13:01 -0400)]
LP 1583608: The make_release script always makes a db upgrade script.

Alter make_release to always create a db upgrade script, even when no
actual db upgrades need to be applied.  The minimal script created
will at least set the upgrade version in config.upgrade_log.

Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoDocs: Some missing release notes for 2.11
Kathy Lussier [Wed, 24 Aug 2016 23:43:44 +0000 (19:43 -0400)]
Docs: Some missing release notes for 2.11

We were missing release notes for some of the new fields added to client
interfaces as well as one of the new SIP features.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoStamping upgrade scripts for aged circs display branch
Mike Rylander [Wed, 24 Aug 2016 22:32:02 +0000 (18:32 -0400)]
Stamping upgrade scripts for aged circs display branch

Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1497335 Show Last Few Circs patron retrieve options
Bill Erickson [Wed, 24 Aug 2016 21:01:01 +0000 (17:01 -0400)]
LP#1497335 Show Last Few Circs patron retrieve options

In the Show Last Few Circulations window (XUL), disable the "Retrieve
Last Patron" button when the most recent circulation is aged.  Disable
the "Retrieve All These Patrons" button when all circulations displayed
are aged.

Fixes a sort bug in open-ils.circ.copy_checkout_history.retrieve.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1497335 Aged circ display release notes
Bill Erickson [Wed, 3 Aug 2016 19:18:59 +0000 (15:18 -0400)]
LP#1497335 Aged circ display release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1497335 Item details shows aged circs (XUL edition)
Bill Erickson [Wed, 3 Aug 2016 18:45:39 +0000 (14:45 -0400)]
LP#1497335 Item details shows aged circs (XUL edition)

* Item Status -> Circulation History now displays aged circulations as
  appropriate, showing "<Aged Circulation>" in lieu the patron's name.

* Item Status (and others) -> Show Last Few Circulations, ditto above.
  Also, the 'Add Billing' button is disabled when displayed with an aged
  circulation row.

* Copy -> Retrieve Last Patron action now includes aged circulations
  when looking for the most recent circulation.  When the most recent
  circ is an aged circ, the UI reports "Item XXX circulation is an aged
  circulation and has no linked user".  Among other things, this means
  the 3rd from last circ will not be confused as the 2nd to last circ
  when the 2nd to last is aged.

* Mark Item Damaged will warn if the circ in question is aged.  This is
  just a sanity check and should never happen in reality, since the UI
  only supports this option on checked out items (i.e. active circs).

Signed-off-by: Bill Erickson <berickxx@gmail.com>