Evergreen.git
4 hours agoLP#1924185: use preferred name before legal name in My Account master
Jeff Davis [Tue, 27 Apr 2021 18:25:50 +0000 (11:25 -0700)]
LP#1924185: use preferred name before legal name in My Account

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 hours agoLP#1924185: use preferred name in patron summary
Jeff Davis [Tue, 27 Apr 2021 17:35:18 +0000 (10:35 -0700)]
LP#1924185: use preferred name in patron summary

When available, the preferred name is used as the main name in the
patron summary (rather than as a less-prominent field beneath the main
name).  The legal name is displayed further down in the summary, just
after the ID fields.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 hours agoLP1881607 stamp upgrade script
Jane Sandberg [Sun, 16 May 2021 03:38:08 +0000 (20:38 -0700)]
LP1881607 stamp upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 hours agoLP1881607 E-resource relationship labels
Bill Erickson [Mon, 25 Jan 2021 20:03:11 +0000 (15:03 -0500)]
LP1881607 E-resource relationship labels

Display the relationship designation for 856 URL's in the staff catalog.

See Second Indicator:

https://www.loc.gov/marc/bibliographic/bd856.html

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 hours agoLP1881607 Angular catalog located URIs
Bill Erickson [Wed, 23 Sep 2020 15:15:22 +0000 (11:15 -0400)]
LP1881607 Angular catalog located URIs

Display in-range located URIs in the staff catalog record summary pane.

Also applies a fix to the staff catalog to clear cached record detail
summaries on new searches to ensure the correct org-scoped version of
the record summary is retrieved on each new navigation to the detail
page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 hours agoLP1881607 Angular catalog e-resource links display
Bill Erickson [Mon, 1 Jun 2020 16:32:21 +0000 (12:32 -0400)]
LP1881607 Angular catalog e-resource links display

Display electronic resource links (MARC 856's) in the Angular staff
catalog.  The extraction logic, which matches the TPAC, has been put
into its own API.

To test in concerto, navigate to:

/eg2/staff/catalog/record/208

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 hours agoLP1906825 Flesh acqcr on PO search
Tiffany Little [Fri, 12 Mar 2021 15:52:19 +0000 (10:52 -0500)]
LP1906825 Flesh acqcr on PO search

Fleshes the cancel reason column on PO searches.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chrisy Schroth <chrisy.schroth@kentonlibrary.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 hours agoLP1873539 Active column in SMS carrier configuration
Garry Collum [Fri, 15 Jan 2021 22:38:35 +0000 (17:38 -0500)]
LP1873539 Active column in SMS carrier configuration

This fixes the lack of values displaying in the Active column of the
SMS Carrier configuration screen.  (Administration->Server Administration->SMS Carriers)

To test apply the patch.
Go to the Carrier Configuration screen and note that the 'Yes' and 'No'
boolean values now display for the Active column.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 hours agolp1615800 Accessibility on Patron Pages
Mike Risher [Mon, 20 Jul 2020 22:10:55 +0000 (22:10 +0000)]
lp1615800 Accessibility on Patron Pages

Modify patron search, patron search results, and patron edit pages so
that they are compatible with screen readers. aria-labelledby can be
used to associate input fields with their labels.

(Rebased to master)

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/src/templates/staff/share/t_patron_search_form.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 hours agoLP1891699 Ang grid column picker sorting
Bill Erickson [Fri, 14 Aug 2020 18:49:24 +0000 (14:49 -0400)]
LP1891699 Ang grid column picker sorting

Angular grid column picker displays colums in the following order:

1. Visible colums first, sorted alphabetically.
2. Non-visible columns second, sorted alphabetically.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
35 hours agoLP1895660: Booking.pm, Search/Biblio.pm
Jason Boyer [Wed, 21 Oct 2020 20:29:25 +0000 (16:29 -0400)]
LP1895660: Booking.pm, Search/Biblio.pm

Argument "whatev_strings" isn't numeric in numeric eq (==) at ...

A couple places that use == to compare strings. Numbers are == to
each other, but strings are eq to each other.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1895660: Proxy.pm Proxy/Authen.pm
Jason Boyer [Tue, 15 Sep 2020 20:14:38 +0000 (16:14 -0400)]
LP1895660: Proxy.pm Proxy/Authen.pm

Checking perms LOUD_NOISES for user 123 at location 321

So? I have changed these to use $logger->debug though they can
maybe just be removed entirely?

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1895660: Search/Authority.pm
Jason Boyer [Tue, 15 Sep 2020 19:37:09 +0000 (15:37 -0400)]
LP1895660: Search/Authority.pm

Argument "" isn't numeric in numeric ne (!=)

One of the "fun" things about perl and its type system is that
it uses different operators to compare strings vs comparing numbers...

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1895660: AppUtil.pm
Jason Boyer [Tue, 15 Sep 2020 19:12:57 +0000 (15:12 -0400)]
LP1895660: AppUtil.pm

substr outside of string

unique_unnested_numbers expects a list of pg arrays, but if its given
an empty results list it tries to remove { and } from an undefined value.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1895660: HoldTarger.pm
Jason Boyer [Tue, 15 Sep 2020 18:00:54 +0000 (14:00 -0400)]
LP1895660: HoldTarger.pm

"order_by" object in a query is not a JSON_HASH or JSON_ARRAY;no ORDER BY generated

json_query and CStoreEditor search_* functions don't want a string field name,
they work with hashes or arrays thereof.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1895660: EGCatLoader/Search.pm
Jason Boyer [Tue, 15 Sep 2020 13:41:30 +0000 (09:41 -0400)]
LP1895660: EGCatLoader/Search.pm

CGI::param called in list context from ...
this can lead to vulnerabilities

For any call to $cgi->param that happens in a list context we need
to verify 2 things: 1, that it is intentional (otherwise use scalar())
and 2, that we don't use the results in an unsafe manner.
For those situations where it's safe and a list is expected (join,
foreach, etc.) there is a $cgi->multi_param() that behaves the same way
but does not issue a warning on use in a list context.

An assumption was made that there will only be a single 'query'
parameter (see _prepare_biblio_search_basics) but if that should
instead be run through a join() that function will need to be updated.

For more details about the potential issues read
https://metacpan.org/pod/distribution/CGI/lib/CGI.pod#Fetching-the-value-or-values-of-a-single-named-parameter

Note that this change will likely require additional testing to
be sure there are no surprises.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1895660: Course.pm
Jason Boyer [Tue, 15 Sep 2020 13:28:57 +0000 (09:28 -0400)]
LP1895660: Course.pm

"my" variable $results masks earlier declaration in same scope

my $var should only be used once within a block.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1895660: Biblio.pm
Jason Boyer [Tue, 15 Sep 2020 13:08:28 +0000 (09:08 -0400)]
LP1895660: Biblio.pm

Odd number of elements in anonymous hash

The type key is missing from some param descriptions,
leaving things uneven.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1895660: SuperCat.pm
Jason Boyer [Tue, 15 Sep 2020 13:00:15 +0000 (09:00 -0400)]
LP1895660: SuperCat.pm

"my" variable $U masks earlier declaration in same scope

AppUtils is 'use'-ed and assigned to $U at the top of the file
and shared among the rest of the modules already.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1895660: Silence Perl Warnings
Jason Boyer [Tue, 15 Sep 2020 12:50:26 +0000 (08:50 -0400)]
LP1895660: Silence Perl Warnings

There are many perl warnings in make check and the day-to-day
logs when using Evergreen. This branch aims to address the
warnings and to make reviewing easier each file will be
individually committed with a small rationale for the changes
though it is assumed that this branch will be largely squashed
away if / when committed.

Booking.pm: Possible precedence issue with control flow operator
The precedence of 'or' is significantly lower than '||', so much so
that it can be less than the precedence for assignments.
Replace 'or' with '||' since they're equivalent in this case anyway,
and also add parens for flavor.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP#1917944k: (follow-up) fix ng lint issue
Galen Charlton [Fri, 14 May 2021 21:26:43 +0000 (17:26 -0400)]
LP#1917944k: (follow-up) fix ng lint issue

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1917944-Hold Pickup Library sometimes Empty
Garry Collum [Thu, 18 Mar 2021 19:56:04 +0000 (15:56 -0400)]
LP1917944-Hold Pickup Library sometimes Empty

Checks to make sure that the opac.default_pickup_location in usr_setting
has a value.

To test.
1. The patron must have a opac.default_pickup_location set to ""
2. Place a hold for this patron.
3. Notice that the pickup location is blank.
4. Apply the patch.
5. The hold pickup location should now be filled with the patron's home library.

To re-create this in concerto you may have to tweak the usr_setting table.
1. Assign a default pickup location to a patron.
2. Find the id field for the above in the usr_setting table.
   select * from actor.usr_setting;
3. Update the setting.
   update actor.usr_setting set value = '""' where id = <the id number>;

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1925725 Relabel copy location filter to shelving location
Andrea Buntz Neiman [Fri, 23 Apr 2021 18:31:20 +0000 (14:31 -0400)]
LP1925725 Relabel copy location filter to shelving location

Changes the labeling of the all copy locations filter to say "All Shelving Locations" instead, reflecting current practice.

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP1926310 Record bucket batch edit destination
Bill Erickson [Tue, 27 Apr 2021 15:23:02 +0000 (11:23 -0400)]
LP1926310 Record bucket batch edit destination

Record Bucket => Batch Edit now opens the new Angular MARC Batch Edit
interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP#1927527: (follow-up) add comment
Galen Charlton [Fri, 14 May 2021 21:05:51 +0000 (17:05 -0400)]
LP#1927527: (follow-up) add comment

Just in case there's a question in the future, make it clear
that the case where the context OU is the root OU is special.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
35 hours agoLP#1927527 Catalog: Root OU shelving locations do not display
Dan Briem [Tue, 11 May 2021 00:08:42 +0000 (20:08 -0400)]
LP#1927527 Catalog: Root OU shelving locations do not display

When the top level org unit is selected in the staff catalog you
only have the option to search all shelving locations.

This allows you to filter on the root org unit's shelving
locations, which is the same behavior as the OPAC.

To test:
1. Make sure the top level org unit has shelving locations
   (Local Administration->Shelving Locations Editor)
2. In the staff catalog, select the top level org unit
3. Click the three dot icon next to the query text input
4. The root org unit's shelving location options display

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 days agoDocs: fixing a typo
Jane Sandberg [Thu, 13 May 2021 14:44:35 +0000 (07:44 -0700)]
Docs: fixing a typo

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 days agoIntroduce documentation on how to contribute docs
blake [Mon, 10 May 2021 13:20:41 +0000 (08:20 -0500)]
Introduce documentation on how to contribute docs

This commit adds several screenshots and the basic outline on contributing
to the Evergreen documentation

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 days agoLP1908440: Stamp Upgrade Script
Jason Boyer [Tue, 11 May 2021 23:42:31 +0000 (19:42 -0400)]
LP1908440: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
4 days agolp1908440 editing the photo url in the staff client
Rogan Hamby [Wed, 24 Mar 2021 13:12:07 +0000 (09:12 -0400)]
lp1908440 editing the photo url in the staff client

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Seth Erickson <serickson@tds.lib.mn.us>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
4 days agoLP#1892435 - Add Release Note
Jason Boyer [Tue, 11 May 2021 14:00:15 +0000 (10:00 -0400)]
LP#1892435 - Add Release Note

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
4 days agoLP#1892435 Splash page catalog searches don't work with spaces
Dan Briem [Mon, 10 May 2021 02:27:38 +0000 (22:27 -0400)]
LP#1892435 Splash page catalog searches don't work with spaces

On older versions of Apache's mod_rewrite, splash page catalog
searches are escaped in JavaScript and escaped again during the
redirect to the Angular locale path, so searches with special
characters result in a search that's still encoded.

Test on Ubuntu 16.04.7, Apache 2.4.18, EG 3.6+. A splash page
catalog search for Harry Potter results in a search for
Harry%20Potter.

Add the NE (noescape) flag to the Angular locale path redirect
in /etc/apache2/eg_vhost.conf as indicated in this example file.
A splash page search for Harry Potter then works as expected.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
4 weeks agodocs: Antora search index limit to master plus new switch
blake [Thu, 15 Apr 2021 19:28:54 +0000 (14:28 -0500)]
docs: Antora search index limit to master plus new switch

This provides a new option for generate_docs.p:

--antora-ui-repo-branch

where the user can optionally specify a branch on our UI repo for testing

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoupdate release notes for 3.7.0
Galen Charlton [Wed, 14 Apr 2021 19:04:16 +0000 (15:04 -0400)]
update release notes for 3.7.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoupdate version upgrade script for 3.7.0
Galen Charlton [Wed, 14 Apr 2021 19:03:31 +0000 (15:03 -0400)]
update version upgrade script for 3.7.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoupdate release notes for 3.7-rc
Galen Charlton [Mon, 12 Apr 2021 15:47:42 +0000 (11:47 -0400)]
update release notes for 3.7-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoupdate version-upgrade script for 3.7-rc
Galen Charlton [Mon, 12 Apr 2021 15:45:28 +0000 (11:45 -0400)]
update version-upgrade script for 3.7-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agodocs: update target branches for Antora
Galen Charlton [Mon, 12 Apr 2021 15:41:01 +0000 (11:41 -0400)]
docs: update target branches for Antora

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agodocs: fix a few asciidoc syntax errors
Galen Charlton [Mon, 12 Apr 2021 15:39:40 +0000 (11:39 -0400)]
docs: fix a few asciidoc syntax errors

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoDocs: Sort by Geographic Proximity
Andrea Buntz Neiman [Fri, 9 Apr 2021 14:50:10 +0000 (10:50 -0400)]
Docs: Sort by Geographic Proximity

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoDocs: Single Sign On
Andrea Buntz Neiman [Fri, 9 Apr 2021 14:46:18 +0000 (10:46 -0400)]
Docs: Single Sign On

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoDocs: Did You Mean SWSC
Andrea Buntz Neiman [Fri, 9 Apr 2021 14:42:37 +0000 (10:42 -0400)]
Docs: Did You Mean SWSC

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoDocs: Hold Groups
Felicia Beaudry [Fri, 9 Apr 2021 14:24:37 +0000 (10:24 -0400)]
Docs: Hold Groups

Signed-off-by: Felicia Beaudry <felicia.beaudry@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoDocs: Report Sources
Andrea Buntz Neiman [Fri, 9 Apr 2021 14:02:34 +0000 (10:02 -0400)]
Docs: Report Sources

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoDocs: Library Groups
Andrea Buntz Neiman [Fri, 9 Apr 2021 13:50:09 +0000 (09:50 -0400)]
Docs: Library Groups

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1905091: stamp DB update
Galen Charlton [Fri, 2 Apr 2021 21:55:09 +0000 (17:55 -0400)]
LP#1905091: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP1905091 Supply environment for added print/email triggers
Michele Morgan [Mon, 30 Nov 2020 21:19:49 +0000 (16:19 -0500)]
LP1905091 Supply environment for added print/email triggers

Ensures that OPAC print and email triggers added by upgrade script 1231
(lp 1749475) have appropriate environment.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP1879769 Cannot Edit Carousels from Action Menu
Terran McCanna [Tue, 27 Oct 2020 22:39:09 +0000 (18:39 -0400)]
LP1879769 Cannot Edit Carousels from Action Menu

The Edit Carousels action was appearing in the action menu and
right-click menu, but wasn't wired up. This adds in the missing
piece.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1917495 Angular Catalog: Hold status in View Holds is not saved
Dan Briem [Wed, 3 Mar 2021 18:21:22 +0000 (13:21 -0500)]
LP#1917495 Angular Catalog: Hold status in View Holds is not saved

To test:
1. Go to a record in the Angular catalog
2. Click the View Holds tab
3. If status col is visible, remove status col, and save grid
4. Add status col and save grid.
5. Refresh page and note status field didn't stay visible
6. Apply patch, repeat steps 1-5, note Status stays visible

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1920815 Item edit link displayed for all users
Dan Briem [Thu, 1 Apr 2021 13:38:41 +0000 (09:38 -0400)]
LP#1920815 Item edit link displayed for all users

The Angular catalog item table doesn't check UPDATE_COPY perm
before displaying an edit link. The back-end checks, so this is
a display issue only. This commit grabs a list of org Ids where
the user has UPDATE_COPY perm and checks the copy circ lib or
cn owning lib is in the list before displaying the edit link.

To test:
1. Search for a record with items you don't have perm to edit
2. Note the edit link shows on every item
3. Apply patch
4. Repeat steps 1-2
5. Note edit link displays if you have perm to edit

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoDocs: added script info to Carousels docs
Andrea Buntz Neiman [Fri, 2 Apr 2021 15:37:21 +0000 (11:37 -0400)]
Docs: added script info to Carousels docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
6 weeks agoDocs: correction to 3.7 release notes
Andrea Buntz Neiman [Fri, 2 Apr 2021 14:25:00 +0000 (10:25 -0400)]
Docs: correction to 3.7 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
6 weeks agoDocs: a few typos in 3.7 release notes
Jane Sandberg [Thu, 1 Apr 2021 19:50:50 +0000 (12:50 -0700)]
Docs: a few typos in 3.7 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoTranslation updates - po files (3.7 beta)
Galen Charlton [Wed, 31 Mar 2021 19:51:52 +0000 (15:51 -0400)]
Translation updates - po files (3.7 beta)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agodocs: add upgrade instructions to release notes
Galen Charlton [Wed, 31 Mar 2021 19:47:20 +0000 (15:47 -0400)]
docs: add upgrade instructions to release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agodocs: more tweaks to 3.7 release notes
Galen Charlton [Wed, 31 Mar 2021 19:25:44 +0000 (15:25 -0400)]
docs: more tweaks to 3.7 release notes

- add an acknowledgment
- fix heading levels in the upgrade section

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agodocs: additional edits to the 3.7 release notes
Terran McCanna [Wed, 31 Mar 2021 19:14:40 +0000 (15:14 -0400)]
docs: additional edits to the 3.7 release notes

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoDocs: 3.6.3 release notes
Jane Sandberg [Wed, 31 Mar 2021 19:09:38 +0000 (12:09 -0700)]
Docs: 3.6.3 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoDocs: 3.5.4 release notes
Jane Sandberg [Wed, 31 Mar 2021 18:56:56 +0000 (11:56 -0700)]
Docs: 3.5.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoupdate Czech translations for Angular staff client
Galen Charlton [Wed, 31 Mar 2021 19:13:36 +0000 (15:13 -0400)]
update Czech translations for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoTranslation updates - newpot
Galen Charlton [Wed, 31 Mar 2021 18:42:22 +0000 (14:42 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1902965: removing nesting of accordion() calls
Galen Charlton [Wed, 31 Mar 2021 15:48:17 +0000 (11:48 -0400)]
LP#1902965: removing nesting of accordion() calls

This was resulting in double-encoding of content notes, making the public
catalog display things like

<div class="content_field">...</div>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLP#1902965: HTML filter on OPAC search results and record display, with accordion
Jeff Davis [Mon, 9 Nov 2020 21:59:59 +0000 (13:59 -0800)]
LP#1902965: HTML filter on OPAC search results and record display, with accordion

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/contents.tt2
Open-ILS/src/templates/opac/parts/record/summary.tt2
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLP#1902965: Fix search in Bootstrap OPAC
Jason Boyer [Tue, 12 Jan 2021 13:46:43 +0000 (08:46 -0500)]
LP#1902965: Fix search in Bootstrap OPAC

Filters and localization functions don't mix. Assign the html filtered
title to a temp var first.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLP#1902965: change format type in XML transform to avoid XSS in SuperCat
Jeff Davis [Mon, 9 Nov 2020 23:17:07 +0000 (15:17 -0800)]
LP#1902965: change format type in XML transform to avoid XSS in SuperCat

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLP#1902965: HTML filter on Bootstrap OPAC search results and record display
Jeff Davis [Mon, 9 Nov 2020 23:45:24 +0000 (15:45 -0800)]
LP#1902965: HTML filter on Bootstrap OPAC search results and record display

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks ago3.6.2 to 3.7-beta DB update script
Galen Charlton [Wed, 31 Mar 2021 18:36:42 +0000 (14:36 -0400)]
3.6.2 to 3.7-beta DB update script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1896840: (follow-up) update script to include the DB rev
Galen Charlton [Wed, 31 Mar 2021 18:34:32 +0000 (14:34 -0400)]
LP#1896840: (follow-up) update script to include the DB rev

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agodocs: add new perms/settings/etc. to 3.7 release notes
Galen Charlton [Wed, 31 Mar 2021 17:56:11 +0000 (13:56 -0400)]
docs: add new perms/settings/etc. to 3.7 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agodocs: add more acknowledgments to 3.7 release notes
Galen Charlton [Wed, 31 Mar 2021 16:36:26 +0000 (12:36 -0400)]
docs: add more acknowledgments to 3.7 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agodocs: some edits to the 3.7 release notes
Andrea Buntz Neiman [Wed, 31 Mar 2021 16:19:57 +0000 (12:19 -0400)]
docs: some edits to the 3.7 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoclear out old release notes stubs
Galen Charlton [Tue, 30 Mar 2021 15:58:54 +0000 (11:58 -0400)]
clear out old release notes stubs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agostart 3.7 release notes
Galen Charlton [Tue, 30 Mar 2021 15:57:53 +0000 (11:57 -0400)]
start 3.7 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1853006: add release notes entry
Galen Charlton [Tue, 30 Mar 2021 15:43:55 +0000 (11:43 -0400)]
LP#1853006: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP1853006 - Allow new strings to be translated
Michele Morgan [Wed, 17 Mar 2021 16:05:31 +0000 (16:05 +0000)]
LP1853006 - Allow new strings to be translated

Allow newly added strings 'Show All Copies' and 'Show Only Available Copies' to be
translated.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP1853006 TPAC: add limit to available option to item table
Zavier Banks [Wed, 13 May 2020 11:08:38 +0000 (11:08 +0000)]
LP1853006 TPAC: add limit to available option to item table

This patch adds a new control to the item table in
the TPAC public catalog only to specify that only items
that are available should be displayed.

Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoRevert "LP1174498: Add a Payments by Billing Type Reporting View"
Galen Charlton [Tue, 30 Mar 2021 15:29:02 +0000 (11:29 -0400)]
Revert "LP1174498: Add a Payments by Billing Type Reporting View"

This reverts commit df4c2fa5d8645d7833b37683064cf69234f2dad4.

6 weeks agoRevert "LP1174498: IDL changes for Payments by Billing Type"
Galen Charlton [Tue, 30 Mar 2021 15:28:55 +0000 (11:28 -0400)]
Revert "LP1174498: IDL changes for Payments by Billing Type"

This reverts commit c24fa37f34b03818689e0835e8c01c629b00fd99.

6 weeks agoRevert "LP1174498: Add Release Note"
Galen Charlton [Tue, 30 Mar 2021 15:28:48 +0000 (11:28 -0400)]
Revert "LP1174498: Add Release Note"

This reverts commit 6a01e002cf0440d8015a2c580d04280b179e1743.

6 weeks agoRevert "LP#1174498: (follow-up) reformat release notes"
Galen Charlton [Tue, 30 Mar 2021 15:28:40 +0000 (11:28 -0400)]
Revert "LP#1174498: (follow-up) reformat release notes"

This reverts commit 56da49b19efff64a60b5833d4c67cf5ee7c85fef.

6 weeks agoRevert "LP#1174498: stamp schema update"
Galen Charlton [Tue, 30 Mar 2021 15:28:33 +0000 (11:28 -0400)]
Revert "LP#1174498: stamp schema update"

This reverts commit 1e60ff5c23cd496e7f3069c71cb407959f9d9e1a.

8 weeks agoLP1873322: Angular Admin Pages default to workstation OU
Jane Sandberg [Wed, 10 Feb 2021 19:51:55 +0000 (11:51 -0800)]
LP1873322: Angular Admin Pages default to workstation OU

To test:

1) Apply this patch.
2) Log in using a workstation at a particular org unit.
3) Open some of the following admin pages:

Local Admin > Address Alerts
Local Admin > Carousels
Local Admin > Group Penalty Thresholds
Local Admin > Course Reserves List > Terms Tab
Server Admin > Billing Types
Server Admin > Call Number/Volume Suffixes
Server Admin > Copy Tags
Server Admin > Hard Due Date Configuration
Acquisitions Admin > Cancel Reason Configuration
Acquisitions Admin > Claim Policies
Booking Admin > Resource Types
Booking Admin > Resource Attribute Values

4) Verify that these pages automatically open to your
workstation's org unit.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
8 weeks agoLP#1915323 Angular Staff Client Hamburger Menu Clipped Off Screen
Dan Briem [Wed, 3 Mar 2021 22:11:44 +0000 (17:11 -0500)]
LP#1915323 Angular Staff Client Hamburger Menu Clipped Off Screen

Aligns navbar corner dropdown menu to the right to prevent it
from clipping off-screen.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
8 weeks agoLP#1917804: only show MARC 500 data in the General Note field
Jeff Davis [Tue, 16 Mar 2021 22:29:36 +0000 (15:29 -0700)]
LP#1917804: only show MARC 500 data in the General Note field

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
8 weeks agoStamping upgrade script
Jane Sandberg [Tue, 16 Mar 2021 20:19:09 +0000 (13:19 -0700)]
Stamping upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoLP1896840 Publisher display includes 264 tag
Bill Erickson [Thu, 24 Sep 2020 15:46:58 +0000 (11:46 -0400)]
LP1896840 Publisher display includes 264 tag

The stock Publisher display field now extracts data from 260 OR 264
tags, whichever has a value first.

Release notes included with upgrade instructions.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 weeks agoLP1859513: In-house use link to item summary
Garry Collum [Wed, 17 Feb 2021 19:56:38 +0000 (14:56 -0500)]
LP1859513: In-house use link to item summary

Adds a link from the item's barcode in the in-house checkin screen to the item summary screen.

To test:
Type an item barcode into the In-House Use screen. Click on the barcode that displays in the item list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 months agoLP#1424815: adjust release notes
Galen Charlton [Mon, 15 Mar 2021 21:37:19 +0000 (17:37 -0400)]
LP#1424815: adjust release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1424815: 'Read more' accordion in record view
Kyle Huckins [Thu, 17 Jan 2019 19:32:45 +0000 (19:32 +0000)]
LP#1424815: 'Read more' accordion in record view

- Introduce custom accordion.JS to handle expand/truncation of
node information.
- Expansion/Truncation of individual nodes based on configurable
length.
- Refactor content.tt2 to properly display multiple notes with both
Read More and Highlighting features.
- Create accordion() macro in summary.tt2 to handle accordion-izing
a string when also supplied with a length, display field string,
and an optional highlighting boolean.
- Implementation of config.tt2 variables to handle enabling and length
requirements for truncation.
- Apply Read More to record Title as well as item details and graphics
text on record and search results.
- Teach Accordion functionality to understand blocks of HTML
- Add release notes for Read More functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Ruth Fraser <rfrasur@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoRevert "LP#1424815: 'Read more' accordion in record view"
Galen Charlton [Mon, 15 Mar 2021 16:27:06 +0000 (12:27 -0400)]
Revert "LP#1424815: 'Read more' accordion in record view"

This reverts commit 9561b5736eadfa9325015676bc64e628d9f72be4.

Pushed by accident.

2 months agoRevert "Revert "LP#705693: add release notes entry""
Galen Charlton [Mon, 15 Mar 2021 16:24:30 +0000 (12:24 -0400)]
Revert "Revert "LP#705693: add release notes entry""

This reverts commit b3695a6fb79eca1c450bcc932734da71813f493e.

Pushed by accident.

2 months agoRevert "LP#705693: add release notes entry"
Galen Charlton [Mon, 15 Mar 2021 16:23:54 +0000 (12:23 -0400)]
Revert "LP#705693: add release notes entry"

This reverts commit dd61efc0e4b96627d5cc4ac96d472273e9da253f.

2 months agoLP#1424815: 'Read more' accordion in record view
Kyle Huckins [Thu, 17 Jan 2019 19:32:45 +0000 (19:32 +0000)]
LP#1424815: 'Read more' accordion in record view

- Introduce custom accordion.JS to handle expand/truncation of
node information.
- Expansion/Truncation of individual nodes based on configurable
length.
- Refactor content.tt2 to properly display multiple notes with both
Read More and Highlighting features.
- Create accordion() macro in summary.tt2 to handle accordion-izing
a string when also supplied with a length, display field string,
and an optional highlighting boolean.
- Implementation of config.tt2 variables to handle enabling and length
requirements for truncation.
- Apply Read More to record Title as well as item details and graphics
text on record and search results.
- Teach Accordion functionality to understand blocks of HTML
- Add release notes for Read More functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
modified:   Open-ILS/src/templates/opac/css/style.css.tt2
modified:   Open-ILS/src/templates/opac/i18n_strings.tt2
modified:   Open-ILS/src/templates/opac/parts/config.tt2
modified:   Open-ILS/src/templates/opac/parts/js.tt2
modified:   Open-ILS/src/templates/opac/parts/misc_util.tt2
modified:   Open-ILS/src/templates/opac/parts/record/authors.tt2
modified:   Open-ILS/src/templates/opac/parts/record/contents.tt2
modified:   Open-ILS/src/templates/opac/parts/record/summary.tt2
modified:   Open-ILS/src/templates/opac/parts/result/table.tt2
new file:   Open-ILS/web/js/ui/default/opac/accordion.js
new file:   docs/RELEASE_NOTES_NEXT/OPAC/read-more-feature.adoc

Signed-off-by: Ruth Fraser <rfrasur@gmail.com>
Signed-off-by: Michele <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#705693: add release notes entry
Galen Charlton [Mon, 15 Mar 2021 16:14:27 +0000 (12:14 -0400)]
LP#705693: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#705693 Check Number in Bill History
Dan Briem [Tue, 8 Dec 2020 20:42:48 +0000 (15:42 -0500)]
LP#705693 Check Number in Bill History

Adds the check number field to the Bill History payment grids
(hidden by default).

To test:
1. Bill patron and apply a check payment with a check number
2. Go to Bills->History->Payments and note check number is not
   an option (drop-down on top-right of grid shows the list)
3. Right-click the payment line->Full Details->Details and note
   check number is not an option on the bottom payments grid
4. Apply patch (may need to clear cache especially on Firefox)
5. Repeat steps 2-3 and note check number is an available option

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1174498: stamp schema update
Galen Charlton [Mon, 15 Mar 2021 16:01:37 +0000 (12:01 -0400)]
LP#1174498: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1174498: (follow-up) reformat release notes
Galen Charlton [Mon, 15 Mar 2021 15:57:48 +0000 (11:57 -0400)]
LP#1174498: (follow-up) reformat release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1174498: Add Release Note
Jason Boyer [Thu, 3 Sep 2020 17:15:51 +0000 (13:15 -0400)]
LP1174498: Add Release Note

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Elizabeth Davis <edavis@albright.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1174498: IDL changes for Payments by Billing Type
blake [Thu, 3 Sep 2020 14:54:37 +0000 (10:54 -0400)]
LP1174498: IDL changes for Payments by Billing Type

Add the mmpbbt class to make use of the new view.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Elizabeth Davis <edavis@albright.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1174498: Add a Payments by Billing Type Reporting View
blake [Thu, 3 Sep 2020 14:46:15 +0000 (10:46 -0400)]
LP1174498: Add a Payments by Billing Type Reporting View

This is an updated version of the initial concept by Mike
Rylander with input from Jeff Godin. This view connects
payments to specific billings and allows reports to be
written to determine how accepted payments were distributed
by billing type.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Elizabeth Davis <edavis@albright.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>