Evergreen.git
2 hours agolp 1848579 filtering interval columns master
Mike Risher [Wed, 19 Feb 2020 23:49:01 +0000 (23:49 +0000)]
lp 1848579 filtering interval columns

This is a shot term change intended to prevent the "I don't know how
to filter" default message from showing up when the datatype 'interval'
is filtered.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 hours agoLP#1915219: stamp schema update
Galen Charlton [Thu, 4 Mar 2021 16:09:11 +0000 (11:09 -0500)]
LP#1915219: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 hours agoLP#1915219: remove nonexistent setting group from user setting for overdue notices
Jeff Davis [Fri, 12 Feb 2021 23:01:22 +0000 (15:01 -0800)]
LP#1915219: remove nonexistent setting group from user setting for overdue notices

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 hours agoLP#1915219: opt-in setting for overdue and predue emails
Jeff Davis [Wed, 10 Feb 2021 00:31:52 +0000 (16:31 -0800)]
LP#1915219: opt-in setting for overdue and predue emails

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 hours agoLP1895679: Simplify and genericize the refund policy
Jason Boyer [Tue, 9 Feb 2021 18:06:32 +0000 (13:06 -0500)]
LP1895679: Simplify and genericize the refund policy

Don't refrence the "email above" since that's not always
the case and simplify the languge slightly, though most
users will still likely want to customize it.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 hours agoLP1895679: Add Stripe v3 support to Bootstrap OPAC
Jason Boyer [Tue, 8 Dec 2020 20:52:13 +0000 (15:52 -0500)]
LP1895679: Add Stripe v3 support to Bootstrap OPAC

Update the Bootstrap OPAC to use Stripe v3, added to the TPAC
in LP 1774892.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 hours agoLP#169625: add a release notes entry
Galen Charlton [Thu, 4 Mar 2021 15:29:52 +0000 (10:29 -0500)]
LP#169625: add a release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 hours agoLP#169625: Support script for working with OverDrive API
Jeff Davis [Thu, 8 Jun 2017 18:09:04 +0000 (11:09 -0700)]
LP#169625: Support script for working with OverDrive API

Adds a script, overdrive-api-checker.pl, for testing the
OverDrive API from the command line.

USAGE:
    Open-ILS/src/support-scripts/overdrive-api-checker.pl --get-token --key <client-key> --secret <client-secret>
    Open-ILS/src/support-scripts/overdrive-api-checker.pl --account <account_id> --token <basic_token> [ --endpoint https://api.overdrive.com/v1/libraries/1234 [ --content <content> ] ]
    Open-ILS/src/support-scripts/overdrive-api-checker.pl --account <account_id> --token <basic_token> --oauth-only
    Open-ILS/src/support-scripts/overdrive-api-checker.pl --account <account_id> --token <basic_token> --patron-auth [ --endpoint https://oauth-patron.overdrive.com/patrontoken ] --barcode <barcode> [ --password <password> ] --websiteid <websiteid> --authorizationname <authorizationname>

OPTIONS:
    --get-token
        Generate OverDrive API basic token.
    --key
        Client key supplied by OverDrive.  Required with --get-token.
    --secret
        Client secret supplied by OverDrive.  Required with --get-token.
    --token
        Your OverDrive API basic token (clientKey:clientSecret, Base64-encoded).
        Required unless using --get-token.
    --account
        Your OverDrive API account ID (e.g. 1234).  Not required for generating
        a basic token; required for everything else.
    --oauth-endpoint
        OverDrive API endpoint for OAuth token requests.
        Default: https://oauth.overdrive.com/token.
    --endpoint
        OverDrive API endpoint that you wish to test.
        Default: https://api.overdrive.com/v1/libraries/<account>
    --content
        JSON content of main API request.  Required only if you have specified
        an endpoint that expects JSON message content.
    --oauth-only
        Only request an OAuth token; do not attempt further API requests.
    --patron-auth
        Submit a patron authentication request.
    --barcode
        Patron barcode.  Required with --patron-auth.
    --password
        Patron password.  Required with --patron-auth if your library requires
        password for patron authentication.
    --websiteid
        Website ID supplied by OverDrive.  Required with --patron-auth.
    --authorizationname
        ILS name supplied by OverDrive.  Required with --patron-auth.
    --verbose
        Print full HTTP requests and responses.
    --help
        Print this help message.

EXAMPLES:

    To generate your basic token, given a client key and client secret supplied
    by OverDrive:

    Open-ILS/src/support-scripts/overdrive-api-checker.pl --get-token --key <client-key> --secret <client-secret>

    To send a basic API request (this is useful for validating your client
    credentials and determining whether the OverDrive API is currently
    available):

    Open-ILS/src/support-scripts/overdrive-api-checker.pl --account <account_id> --token <basic_token>

    To send a request to a specific API endpoint:

    Open-ILS/src/support-scripts/overdrive-api-checker.pl --account <account_id> --token <basic_token>
    --endpoint <endpoint> --content <content>

    To test OverDrive API authentication for a specific patron:

    Open-ILS/src/support-scripts/overdrive-api-checker.pl --account <account_id> --token <basic_token>
    --patron-auth --barcode <barcode> --password <password>
    --websiteid <websiteid> --authorizationname <authorizationname>

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
22 hours agoupdate the note to include the institution
Galen Charlton [Wed, 3 Mar 2021 20:30:44 +0000 (15:30 -0500)]
update the note to include the institution

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
22 hours agoadd an acknowledgment destined for the 3.7 release notes
Galen Charlton [Wed, 3 Mar 2021 20:29:16 +0000 (15:29 -0500)]
add an acknowledgment destined for the 3.7 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
27 hours agoLP#1076582: Remove Custom Dojo Build Profile and Add Release Note
Jason Stephenson [Wed, 3 Mar 2021 14:56:17 +0000 (09:56 -0500)]
LP#1076582: Remove Custom Dojo Build Profile and Add Release Note

Signed-off-by: Jason Stephenson <jason@sigio.com>
27 hours agoLP#1076582: remove reference to openils_dojo.js from Bootstrap OPAC
Jeff Davis [Tue, 2 Mar 2021 17:36:23 +0000 (09:36 -0800)]
LP#1076582: remove reference to openils_dojo.js from Bootstrap OPAC

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
27 hours agoLP#1617556 - Remove openils_dojo.js references
Chris Sharp [Sat, 27 Aug 2016 12:02:11 +0000 (08:02 -0400)]
LP#1617556 - Remove openils_dojo.js references

Somewhere along the way, openils_dojo.js was removed,
but references remained.  This removes them, hopefully
helping to speed up page loads.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 days agoLp 1703658: Stamp DB Upgrade
Jason Stephenson [Tue, 2 Mar 2021 14:22:55 +0000 (09:22 -0500)]
Lp 1703658: Stamp DB Upgrade

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 days agoLp 1703658: Repair DB Upgrade
Jason Stephenson [Thu, 25 Feb 2021 20:00:02 +0000 (15:00 -0500)]
Lp 1703658: Repair DB Upgrade

Remove an errant semicolon in the db upgrade script.

Add release notes.

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 days agoLP1703658: Convert GIST Indexes to GIN
Jason Boyer [Thu, 25 Feb 2021 15:06:38 +0000 (10:06 -0500)]
LP1703658: Convert GIST Indexes to GIN

Rather than suggest that sites experiencing search speed issues
do this conversion on demand just knock it out from the start.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 days agoLp 1901899: Remove Ubuntu 16.04 Xenial Xerus
Jason Stephenson [Wed, 28 Oct 2020 17:11:10 +0000 (13:11 -0400)]
Lp 1901899: Remove Ubuntu 16.04 Xenial Xerus

Remove prerequisites, installation, and upgrade references for Ubuntu
16.04 Xenial Xerus.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
4 days agoLp 1875544: Add Installation Support for Ubuntu 20.04 Focal Fossa
Jason Stephenson [Tue, 27 Oct 2020 17:18:13 +0000 (13:18 -0400)]
Lp 1875544: Add Installation Support for Ubuntu 20.04 Focal Fossa

README and prerequisite updates.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
5 days agoLp 1700818: brief release notes for Czech records
Jane Sandberg [Sat, 27 Feb 2021 17:05:03 +0000 (09:05 -0800)]
Lp 1700818: brief release notes for Czech records

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 days agoLP1912380 Bottom Pagination for Catalog Search
Garry Collum [Wed, 3 Feb 2021 21:11:09 +0000 (16:11 -0500)]
LP1912380 Bottom Pagination for Catalog Search

Adds pagination to the bottom of a catalog search in the staff catalog.

To Test:
Search for a general topic in the staff catalog.  Pagination is at the top
of the search results but not the bottom.

Apply the patch.  Pagination now appears at the top and bottom of the search results.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 days agoLp 1700818: Add Czech Records
Jason Stephenson [Tue, 27 Oct 2020 15:37:07 +0000 (11:37 -0400)]
Lp 1700818: Add Czech Records

Add Czech bibliographic records to sample data.  The records were
provided courstesy of SPOK.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 days agoLP1843969 Composite Attribute Entry Defs
Mike Risher [Thu, 22 Oct 2020 20:19:51 +0000 (20:19 +0000)]
LP1843969 Composite Attribute Entry Defs

Create a port of the Coded Value Maps UI from Angular JS to
Angular. Allow creation and edits of the Composite Attribute
Entry Definitions.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jason Boyer <boyer.jason@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 days agoLP#1871211: Shibboleth release notes
Jane Sandberg [Fri, 26 Feb 2021 19:11:35 +0000 (11:11 -0800)]
LP#1871211: Shibboleth release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 days agoLP#1871211: Stamp shibboleth upgrade script
Jane Sandberg [Fri, 26 Feb 2021 17:55:20 +0000 (09:55 -0800)]
LP#1871211: Stamp shibboleth upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 days agoLP#1871211: Shibboleth integration support
Mike Rylander [Fri, 28 Aug 2020 19:38:57 +0000 (15:38 -0400)]
LP#1871211: Shibboleth integration support

This commit adds Shibboleth integration to Evergreen for use in the
OPAC.  Using Shibboleth, libraries can authenticate patrons against a
wide variety of 3rd party services, using many different protocols and
standards.

Several settings control if, when and how to make use of the Shibboleth
integration:
 * Enable Shibboleth SSO for the OPAC
  - The main on/off switch.
 * Allow both Shibboleth and native OPAC authentication
  - By default only one or the other will be allowed.  This enables both
    native and Shibboleth login.
 * Log out of the Shibboleth IdP
  - If supported by the IdP configured for use on the other side of
    Shibboleth, this tells Evergreen to tell Shibboleth to log out of
    the IdP on Evergreen logout.
 * Shibboleth SSO Entity ID
  - If multiple IdPs are configured for Shibboleth, and available to a
    particular hostname, this setting defines the one to use for a
    given context org unit.
 * Evergreen SSO matchpoint
  - The Evergreen-side user field to use when looking up the patron
    after successful SSO login.
 * Shibboleth SSO matchpoint
  - The Shibboleth-side field, defined in the attribute map, that
    contains the IdP user identifier value used to look up the Evergreen
    patron.

Two apache sesttings control how Evergreen interacts with Shibboeth:
 * SetEnv sso_loc XXX, which acts in a way analogous to the physical_loc
   environment variable to define the context OU for SSO settings.
 * ShibRequestSetting applicationId XXX, which helps Shibboleth identify
   the correct set of entity ID and attribute mapping configuration.

Additional Shibboleth-focused documentation and examples will be
provided for system administrators.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 days agoLP#1916904 Bootstrap OPAC: Call number on Search Results Page
Terran McCanna [Thu, 25 Feb 2021 14:58:23 +0000 (09:58 -0500)]
LP#1916904 Bootstrap OPAC: Call number on Search Results Page

This adds the call number to the search results page when
"Show More Details" is not selected. (This brings back the same
behavior as the pre-bootstrap OPAC.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 days agoLP1913458 Bucket Add/Delete Item Operations Batched
Bill Erickson [Wed, 27 Jan 2021 16:55:56 +0000 (11:55 -0500)]
LP1913458 Bucket Add/Delete Item Operations Batched

In the record bucket administration UI, the act of adding or removing
items from a bucket are now done in batch to avoid too many parallel
requests.

These changes include new batch create/delete API calls that can operate
on any bucket type, so other UI's can be similarly batched as needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 days agoLP1916085 Bootstrap OPAC - Pagination on copy table
Terran McCanna [Fri, 19 Feb 2021 00:37:35 +0000 (19:37 -0500)]
LP1916085 Bootstrap OPAC - Pagination on copy table

This adjusts some of the display logic in the Bootstrap OPAC
copy table pagination that had been causing the Next / Prev and
Show Fewer Copies links to be hidden when they shouldn't be.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
13 days agoLP1871510 Update Interface Titles
Mike Risher [Thu, 7 Jan 2021 19:55:45 +0000 (19:55 +0000)]
LP1871510 Update Interface Titles

Update titles on several local admin interfaces so that they match the page listing all Local Admin interfaces.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 weeks agoForward port 3.6.1 to 3.6.2 db upgrade script
Jason Stephenson [Thu, 18 Feb 2021 14:33:45 +0000 (09:33 -0500)]
Forward port 3.6.1 to 3.6.2 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 weeks agoForward Port 3.5.2 to 3.5.3 db upgrade
Jason Stephenson [Wed, 17 Feb 2021 22:01:29 +0000 (17:01 -0500)]
Forward Port 3.5.2 to 3.5.3 db upgrade

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 weeks agoForward port 3.4.5-3.4.6 db upgrade script
Jason Stephenson [Wed, 17 Feb 2021 19:13:33 +0000 (14:13 -0500)]
Forward port 3.4.5-3.4.6 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 weeks agoEvergreen 3.6.2 release notes
Galen Charlton [Wed, 17 Feb 2021 20:19:46 +0000 (15:19 -0500)]
Evergreen 3.6.2 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 weeks agoEvergreen 3.5.3 release notes
Galen Charlton [Wed, 17 Feb 2021 16:47:51 +0000 (11:47 -0500)]
Evergreen 3.5.3 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 weeks agoEvergreen 3.4.6 release notes
Galen Charlton [Wed, 17 Feb 2021 15:55:56 +0000 (10:55 -0500)]
Evergreen 3.4.6 release notes

Signed-off-by: galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 weeks agoLP#1836254: Handle null authtoken in PCRUD
Mike Rylander [Sat, 13 Jul 2019 18:18:09 +0000 (14:18 -0400)]
LP#1836254: Handle null authtoken in PCRUD

When the authtoken received from the client is the unquoted literal
string "null" in a pcrud request, the drone processing the request
will crash with a segmentation fault as the session verification code
passes a NULL pointer to strcmp.

To reproduce this bug, make the following request via srfsh:

    request open-ils.pcrud open-ils.pcrud.search.pgt null
    {"parent":null},{"flesh":-1,"flesh_fields":{"pgt":["children"]}}

Note that srfsh hangs util it times out.

Next, grep /var/log/syslog for the string segfault.  You should find
something resembling the following:

    Jul 12 15:29:43 buster kernel: [   94.794920] opensrf-c[1357]:
    segfault at 0 ip 00007fe3bbb8b219 sp 00007fff2877a020 error 4 in
    liboils_pcrud.so.2.0.0[7fe3bbb82000+10000]

After patching Evergreen with this commit, repeat the srfsh request
again.  This time, the call should return almost immediately with an
osrfMethodException: "permacrud received a bad auth token: (null)."
When you grep syslog for segfault this time, you should find no new
occurrences.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 weeks agoLP1908743 Hold pickup lib does not require have-users; repairs
Bill Erickson [Tue, 9 Feb 2021 16:10:41 +0000 (11:10 -0500)]
LP1908743 Hold pickup lib does not require have-users; repairs

To match the TPAC, only disable org units where can_have_vols is false
in the hold pickup library selector (plus those explicitly disabled via
setting).

Also fixes a thinko in the settings retrieval code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 weeks agoLP1908743 Staff catalog honors org-not-pickup-lib
Bill Erickson [Mon, 11 Jan 2021 19:15:33 +0000 (14:15 -0500)]
LP1908743 Staff catalog honors org-not-pickup-lib

In the Angular staff catalog, disable org units in the pickup library
selector that have the 'opac.holds.org_unit_not_pickup_lib' org unit
setting applied, plus those that have false values for can-have-users or
can-have-vols.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 weeks agoLP1908743 Org select now supports disabled org unit
Bill Erickson [Fri, 5 Feb 2021 16:16:59 +0000 (11:16 -0500)]
LP1908743 Org select now supports disabled org unit

Org units specified as disabled in <eg-org-select /> are now visible,
but disabled when the typeahead displays.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 weeks agoLP#1858114: Fix thinko in template-parameter collection
Mike Rylander [Fri, 14 Aug 2020 19:35:10 +0000 (15:35 -0400)]
LP#1858114: Fix thinko in template-parameter collection

Minor thinko in the use of Array.prototype.concat() when gathering the
"where" and "having" template parameters -- concat() does not alter the
array it is called on, so we need to assign the result back to the
array.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP#1858114: Record template filter values for aggregate columns
Mike Rylander [Fri, 14 Aug 2020 14:35:06 +0000 (10:35 -0400)]
LP#1858114: Record template filter values for aggregate columns

Currently the "having" clause does not record template-level filter
values in the template, but forces use of a report-level parameter.
This commit allows "having" to receive a value in the same way that
"where" does.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP#1858114: Present proper input widget for aggregate parameters
Mike Rylander [Thu, 13 Aug 2020 17:05:19 +0000 (13:05 -0400)]
LP#1858114: Present proper input widget for aggregate parameters

There's currently logic to override the filter widget for all columns
that have a selector defined, such as the ID column of many tables. When
we transform the column with an aggregate transform, though, we don't want
to pick a particular selector-labeled value.

While I can imagine using a min or max aggregate to get a representative
value for a group, when other dependent filters would make the value
stable or where the value in particular doesn't matter but isn't needed
in a count (say), all the other aggregate transforms that are currently
supported are specifically numeric (sum, average, count, and
count_distinct). Because of that, and the most likely use case of
matching a count to "0" or "1", we should only present the "remote
object widget" for non-aggregates, and just use the baseline text string
input here.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP#1866406 Followup: Add Release Note
Jason Boyer [Mon, 15 Feb 2021 21:42:42 +0000 (16:42 -0500)]
LP#1866406 Followup: Add Release Note

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP#1866406: Use carousel item order
Mike Rylander [Fri, 23 Oct 2020 18:26:10 +0000 (14:26 -0400)]
LP#1866406: Use carousel item order

Previous to this commit, the item display order for carousels was
undefined.  Now, ordering is stable and predictable.

For Newly Cataloged Item and Newest Items by Shelving Location
carousels, the order is from most recently cataloged to least
recently cataloged.

For Recently Returned Item carousels, the order is from most recently
returned to least recently returned.

For Top Circulated Items carousels, the order is from most circulated
to least circulated.

For Manual carousels (as of now, without the ability to adjust the
Position of items) it is the order they are added to the backing bucket.
Thus emptying and refilling the bucket allows reordering.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP#1772955: Stamp Upgrade Script
Jason Boyer [Mon, 15 Feb 2021 21:17:06 +0000 (16:17 -0500)]
LP#1772955: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP#1772955: Only include xacts with balance in summary
Mike Rylander [Thu, 30 Jul 2020 15:48:46 +0000 (11:48 -0400)]
LP#1772955: Only include xacts with balance in summary

This commit adds a new view and IDL definition that shows the total
owed/paid/balance for transactions that have a balance other than 0.
This new view is used in the patron summary bar, and access is provided
wherever the all-open-transactions version is available in case we want
to move to the new one elsewhere.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP1670457 Action Menu Grid Selection Change
Zavier Banks [Thu, 5 Mar 2020 16:19:49 +0000 (16:19 +0000)]
LP1670457 Action Menu Grid Selection Change

I reworked the grid to disable certain actions, if
an item was needed. However, if there were actions, were
there was no item needed, they would still be available.

Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP1468132 MARC search honors search scope
Bill Erickson [Mon, 14 Sep 2020 14:52:05 +0000 (10:52 -0400)]
LP1468132 MARC search honors search scope

Adds a 'Results from All Libraries' checkbox to the MARC search form in
the Angular staff catalog.  When unchecked, the MARC search will limit
to results with holdings in the search scope.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP1468132 Staff MARC Search API supports copy filtering
Bill Erickson [Mon, 14 Sep 2020 15:33:45 +0000 (11:33 -0400)]
LP1468132 Staff MARC Search API supports copy filtering

Teaches the MARC search code to filter results on records with items
attached (though not necessarily opac-visible) for scoped staff
searches.  Prior to this patch, the scope of staff searches was
effectively ignored.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
2 weeks agoLP1914116: Apply html filter to mkurl() output
Jason Boyer [Mon, 8 Feb 2021 19:20:32 +0000 (14:20 -0500)]
LP1914116: Apply html filter to mkurl() output

Because of the way that mkurl() generates its query parameters they're
generally escaped correctly, but nowhere do we run the output of mkurl()
through the html filter to correctly handle ampersands. Rather than adding
"|html" to every invocation of mkurl, it's just added to the macro directly.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
3 weeks agoLP1474029 Stamping DB upgrade: expired staff no-login
Bill Erickson [Wed, 10 Feb 2021 20:46:56 +0000 (15:46 -0500)]
LP1474029 Stamping DB upgrade: expired staff no-login

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP#1474029: teach Evergreen how to prevent expired staff from logging in
Galen Charlton [Thu, 10 Dec 2020 22:23:47 +0000 (17:23 -0500)]
LP#1474029: teach Evergreen how to prevent expired staff from logging in

This patch adds the ability to prevent staff users whose
accounts have expired from logging in. This is controlled
by the new global flag "auth.block_expired_staff_login", which
is not enabled by default. If that flag is turned on, accounts
that have the `STAFF_LOGIN` permission and whose expiration date
is in the past are prevented from logging into any Evergreen
interface, including the staff client, the public catalog, and SIP2.

It should be noted that ordinary patrons are allowed to log into
the public catalog if their circulation privileges have expired. This
feature prevents expired staff users from logging into the public catalog
(and all other Evergreen interfaces and APIs) outright in order to
prevent them from getting into the staff interface anyway by
creative use of Evergreen's authentication APIs.

Evergreen admins are advised to check the expiration status of staff
accounts before turning on the global flag, as otherwise it is
possible to lock staff users out unexpectedly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP1907115 MARC editor avoid ID collisions
Bill Erickson [Wed, 9 Dec 2020 19:04:52 +0000 (14:04 -0500)]
LP1907115 MARC editor avoid ID collisions

Generate DOM IDs for editable content components via incrementing int
instead of a random int.  This addresses cases where records with higher
numbers of MARC fields could result id DOM ID collisions, leading to
empty subfield values.

Also remove use of Renderer2, which is considered harmful and overkill
for simple document.getElementById()-equivalent calls.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 weeks agoLP1907115 MARC editor correctly absorbs breaker changes
Bill Erickson [Mon, 7 Dec 2020 18:28:56 +0000 (10:28 -0800)]
LP1907115 MARC editor correctly absorbs breaker changes

MARC editor now correctly extracts MARC field data from the new
underlying MARC record when it is changed as a result of a breaker text
change and re-absorb.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 weeks agoLp 1913219: Use window.open for staff catalog edit link; angular version
Jane Sandberg [Tue, 2 Feb 2021 19:58:16 +0000 (11:58 -0800)]
Lp 1913219: Use window.open for staff catalog edit link; angular version

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
3 weeks agoLp 1913219: Use window.open for staff catalog edit link
Jason Stephenson [Tue, 2 Feb 2021 17:46:49 +0000 (12:46 -0500)]
Lp 1913219: Use window.open for staff catalog edit link

To avoid the "Scripts may close only the windows that were opened by
them" console message in Chrome 88, and a similar message in Firefox
84, when clicking "Save & Exit" in the Volume/Copy editor of the
AngularJS staff client after opening it via the "edit" link in the
copy table of the TT OPAC record summary, we use an onclick handler
with window.open instead of a standard href in the edit anchor.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 weeks agoLP 1827051: Remove Java Code
Jason Stephenson [Fri, 15 May 2020 12:24:01 +0000 (08:24 -0400)]
LP 1827051: Remove Java Code

Since the OpenSRF Java libraries no longer build and are out of date
with the latest OpenSRF changes, this commit removes the remaining
Java code and build steps from Evergreen as it is now useless.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 weeks agoLP1910409 MARC Batch Edit Allows CSV Column 0
Bill Erickson [Wed, 6 Jan 2021 15:23:22 +0000 (10:23 -0500)]
LP1910409 MARC Batch Edit Allows CSV Column 0

Fixes an issue where the "Go!" button was disabled in the MARC Batch
Edit interface when chosing column "0" for a CSV file updload.

Form now prevents values below 0 from being applied (via the number
spinner) and treats all column values >= 0 as valid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 weeks agoLP#1881650: add release notes entry
Galen Charlton [Tue, 9 Feb 2021 18:51:16 +0000 (13:51 -0500)]
LP#1881650: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1881650 Staff catalog TCN includes delete records
Bill Erickson [Mon, 1 Jun 2020 19:20:13 +0000 (15:20 -0400)]
LP1881650 Staff catalog TCN includes delete records

For consistency with the menu action Cataloging => Retrieve Record by
TCN Value, the staff catalog Numeric Search => TCN search now includes
deleted bib records.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1827055 Remove Python libs, install bits, and docs
Bill Erickson [Mon, 26 Oct 2020 15:34:28 +0000 (11:34 -0400)]
LP1827055 Remove Python libs, install bits, and docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 weeks agoLP1908763 Survey column sorting broken
Garry Collum [Tue, 12 Jan 2021 21:21:58 +0000 (16:21 -0500)]
LP1908763 Survey column sorting broken

Fixes the sorting on the Administration > Local Administration > Surveys
table.

To test.
1. Create a 3 or more surveys and note that none of the columns sort.
2. Apply the patch.
3. Sorting should now work.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP#1901900: Update EDI Webrick installer for Ubuntu 18.04
Chris Sharp [Wed, 28 Oct 2020 14:16:51 +0000 (10:16 -0400)]
LP#1901900: Update EDI Webrick installer for Ubuntu 18.04

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agolp1847519 Port of Circulation Limit Set UI
Mike Risher [Fri, 18 Oct 2019 20:19:54 +0000 (20:19 +0000)]
lp1847519 Port of Circulation Limit Set UI

Port Circulation Limit Set UI from DOJO to Angular. In addition to
editing circulation limit sets, you can add and remove linked circulation
modifiers, copy locations, and limit groups.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 weeks agoLP1907286 Staff catalog sets last retrieved record
Bill Erickson [Tue, 8 Dec 2020 20:33:13 +0000 (12:33 -0800)]
LP1907286 Staff catalog sets last retrieved record

Navigating to the detail page for a bib record in the Angular Staff
Catalog now correctly sets the value for the
'eg.cat.last_record_retrieved' local storage item, allowing Retrieve
Last Bib Record to work as expected.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1908724 Staff Catalog Sort by PubDate Wording
Terran McCanna [Thu, 31 Dec 2020 14:43:31 +0000 (09:43 -0500)]
LP1908724 Staff Catalog Sort by PubDate Wording

Changes wording of dropdown on search results page and matches
sort order to wording.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1906858 Carousels Ignore Deleted Flag
Garry Collum [Mon, 14 Dec 2020 17:48:13 +0000 (12:48 -0500)]
LP1906858 Carousels Ignore Deleted Flag

Adds logic to look for the copy deleted flag in the carousel queries.

To test in concerto, it is easiest to create one item on three or four bibs
and assign the same org unit and location code to these items.

Check the items in. Check the items out, and then check them back in at their home OU.

Create 4 carousels.  Newly Catalogued Items, Recently Returned Items, Top Circulated Items, and Newest Items by Shelving Location.
Make sure the carousels pull from the item library for which the items belong,
and set the owner to CONS. Select and add the correct shelving location.

Refresh the carousels. In the edit dialog box of each carousel, you can click the Link to bucket link to see the titles in the bucket.

Delete one of the items.  Refresh the carousels once more and notice that the deleted title still appears.

Apply the patch.

Refresh the carousels, and the delete item should now be gone.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 weeks agoLP1907923: Move course materials button to more suitable location
Jane Sandberg [Tue, 29 Dec 2020 21:03:18 +0000 (13:03 -0800)]
LP1907923: Move course materials button to more suitable location

To test:

1) Apply this patch
2) In the staff client, go to Admin > Local Admin > Course Reserves List
3) Double click on a course
4) Go to the course materials tab
5) Note that the "Add Material" button is now beneath the temporary call
   number, circ mod, item status, and shelving location fields.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP#1786100: stamp schema update
Galen Charlton [Tue, 9 Feb 2021 16:45:46 +0000 (11:45 -0500)]
LP#1786100: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP#1786100: fix upgrade issue that can prevent unmapping item tags
Galen Charlton [Wed, 23 Sep 2020 15:48:58 +0000 (11:48 -0400)]
LP#1786100: fix upgrade issue that can prevent unmapping item tags

Depending on the history of an Evergreen database, it might have an
incorrect trigger on asset.copy_tag_copy_map that prevents removing
item tags fom items. This patch ensures that the table has the
correct trigger.

To test (cannot remove item tags)
---------------------------------
[1] If you have a database from which item tags cannot be removed
    on items, check the asset.copy_tag_copy_map table to see if
    it has a trigger named inherit_copy_tag_copy_map_copy_fkey that
    fires on insert, update, or delete. If so, this part of the
    test plan applies to you.
[2] Make a copy of the database.
[3] Note that item tags cannot be unassigned from items in the
    holdings editor: saving a change will appear to stick, but
    opening the item back in the editor shows that the item tag
    is still there.
[4] Apply the patch and run the schema update. Note that there be
    just one inh_fkey trigger named inherit_asset_copy_tag_copy_map_copy_fkey
    that fires only on insert or update.
[5] Repeate step 3; this time, items tags can be removed
    from items.

To test (can remove item tags)
------------------------------
[1] If your test system _can_ remove item tags, as would be
    the case with ones created from scratch, apply the patch
    and verify that item tags can be added or removed from
    items.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1900159 Staff Catalog Typo - No Results
Terran McCanna [Thu, 31 Dec 2020 14:58:25 +0000 (09:58 -0500)]
LP1900159 Staff Catalog Typo - No Results

Corrects 'maching' to 'matching' on 3 results pages.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP#1907921: add release notes entry
Galen Charlton [Tue, 9 Feb 2021 16:38:40 +0000 (11:38 -0500)]
LP#1907921: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP 1907921: Add a patron search button to course admin screen
Jane Sandberg [Mon, 14 Dec 2020 16:07:16 +0000 (08:07 -0800)]
LP 1907921: Add a patron search button to course admin screen

To test:

1) Apply this patch
2) Go to Admin > Local Admin > Course Reserves List
3) Select a course and Edit it
4) Go to the Course users tab
5) Note that there is now a Search for Patrons button
6) Use this button to search for a patron.
7) Click the select button.
8) Note that the patron's barcode appears in the
Patron Barcode field
9) Select a Role
10) Click the Add User button
11) Note that the patron appears on the Course Users grid

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP#1816655: add brief release notes entry
Galen Charlton [Tue, 9 Feb 2021 16:35:20 +0000 (11:35 -0500)]
LP#1816655: add brief release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP 1816655: Add a patron search button to create booking screen
Jane Sandberg [Mon, 14 Dec 2020 16:45:04 +0000 (08:45 -0800)]
LP 1816655: Add a patron search button to create booking screen

1) Apply this patch
2) Go to Booking > Create Reservation
3) Choose a resource type
4) Choose a time and double click (or press the Create Reservation
   button)
5) Note that there is now a Search for Patrons button
6) Use this button to search for a patron.
7) Click the select button.
8) Note that the patron's barcode appears in the
Patron Barcode field
9) Click Confirm Reservation
10) Note that the reservation was made.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1914630 Create MARC record goes to AngstCat
Bill Erickson [Thu, 4 Feb 2021 16:34:40 +0000 (11:34 -0500)]
LP1914630 Create MARC record goes to AngstCat

Once a new record is created, the user is directed to the record detail
page for the new record in the Angular staff catalog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoUpdates the lineitem catalog link to point to the new Angular catalog.
Tiffany Little [Wed, 16 Dec 2020 18:40:20 +0000 (13:40 -0500)]
Updates the lineitem catalog link to point to the new Angular catalog.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1908113: link carousel titles in Bootstrap OPAC
Garry Collum [Mon, 4 Jan 2021 18:59:36 +0000 (13:59 -0500)]
LP1908113: link carousel titles in Bootstrap OPAC

Uncomments the code for the carousel title links in the Bootstrap OPAC.

To test:

After applying the patch the titles displayed in a carousel should
then provide links to the title's bibliographic record.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1908766 Bootstrap OPAC: Lost ability to have notes in lists.
Garry Collum [Sun, 20 Dec 2020 01:39:01 +0000 (20:39 -0500)]
LP1908766 Bootstrap OPAC: Lost ability to have notes in lists.

Fixes the note functionality in the Bootstrap Opac lists.
The button definition needed both the name 'save_notes' and an arbitrary value.

To test:
1. Create a list in the bootstrap opac and add a couple of titles to the list.
2. View the list and try to add a note to one of the items in the list.
3. This should fail with an error.
4. Apply the patch.
5. Try to add a note. It should now be successful.
6. Try to edit the note.  This should also succeed.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1895678: Bring course materials into the bootstrap OPAC
Jane Sandberg [Sun, 20 Dec 2020 03:20:43 +0000 (19:20 -0800)]
LP1895678: Bring course materials into the bootstrap OPAC

Also adds course_ou and use_courses to ctx, so that we
can avoid having so many duplicate and slightly inconsistent
checks to see if we are using the course materials module.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1907866 Bootstrap Opac: fix adding basket to existing List
Garry Collum [Mon, 14 Dec 2020 20:18:15 +0000 (15:18 -0500)]
LP1907866 Bootstrap Opac: fix adding basket to existing List

Fixes the issue with the screen not showing lists after adding items
to an existing list from a basket.

To test:

Create a list in the Bootstrap Opac.

Add some items to a basket. Select Add Basket to Saved List, and send
the items to the list that was just created.  Notice on the list page
after the items have been added that you can no longer see any existing
list names.  The screen displays '...From Basket'

Apply the patch.
Add some more items from a basket into the list.  The existing list
names are displayed after the items are sent to the existing list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1895676: Record Print and Email Enhancements for Bootstrap OPAC
Jason Boyer [Fri, 4 Dec 2020 19:13:48 +0000 (14:13 -0500)]
LP1895676: Record Print and Email Enhancements for Bootstrap OPAC

Bring the improvements from LP1749475 to the Bootstrap OPAC.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 weeks agoLP1903594 Bootstrap opac: suspend hold not working
Garry Collum [Wed, 11 Nov 2020 16:03:00 +0000 (11:03 -0500)]
LP1903594 Bootstrap opac: suspend hold not working

Fixes hold suspension at the time of the hold placement in the Bootstrap opac.
And fixes the date picker validation for the activation date.

To test.
As a patron, place a hold in the Bootstrap Opac.
At the time of placement select "Suspend this hold?" and set an activation date.
In the staff client, notice that neither the suspension or activation date has been saved.

Apply the patch.
Repeat the above steps and check for the suspension and activation date.
Place another hold with a activation date in the past.  This should fail.
Place a hold without "Suspend this hold" checked.
Place a hold with "Suspend this hold" checked, but without an activation date.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1902265: implement per-hold notification updates in Bootstrap OPAC
Garry Collum [Tue, 10 Nov 2020 17:54:52 +0000 (12:54 -0500)]
LP1902265: implement per-hold notification updates in Bootstrap OPAC

In the Bootstrap Opac:

* Adds a Notify Method column to the patron's hold list.
* Adds email, phone, and sms notifiction editing to the hold's
  edit screen.
* Also, adds <label> tags to the existing form fields in the edit
  page for accessibility and some bootstrappy form elements to
  format the appearance of the form.

The SMS fields do not appear unless the Library Setting for
"Enable features that send SMS text messages" is set to true.

To test work with the above OU setting off, and then on.

* Place holds for a patron with and without an email address.
* If a patron has a defualt SMS carrier, this carrier should pop up
  in the list by default.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1908298 Bootstrap OPAC: Type filter missing from advanced search
Garry Collum [Wed, 16 Dec 2020 19:22:54 +0000 (14:22 -0500)]
LP1908298 Bootstrap OPAC: Type filter missing from advanced search

The Item Type filter and the Bib Level filter were both commented out in the opac's config.tt2 file.
This patch removes the comment hashmarks.

To test.
Go to the Advanced Search in the Bootstrap Opac.
Notice that the Item Type filter and Bib Level Filters are missing.
Apply the patch.
The two filters should now be displayed.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP#1910138: (follow-up) remove unneeded sr-only span in table cell
Galen Charlton [Mon, 8 Feb 2021 15:22:04 +0000 (10:22 -0500)]
LP#1910138: (follow-up) remove unneeded sr-only span in table cell

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1910138 Display Precat Info in Circ History
Terran McCanna [Mon, 4 Jan 2021 19:32:40 +0000 (14:32 -0500)]
LP1910138 Display Precat Info in Circ History

This adds the precat title and author to the circ
history table in My Account in the Bootstrap OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 weeks agoLP1913811 progress dialog on Items Out grid
Jeff Davis [Mon, 1 Feb 2021 22:17:05 +0000 (14:17 -0800)]
LP1913811 progress dialog on Items Out grid

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 weeks agoLP1913811 Items out notice summary API batching
Bill Erickson [Mon, 1 Feb 2021 15:54:18 +0000 (10:54 -0500)]
LP1913811 Items out notice summary API batching

Tweak the open-ils.actor.user.itemsout.notices API to accept an array of
circulation IDs so the call can be batched from the client.  Similarly
modify the AngJS client to request the notice summaries in batch.

Further improves the notices API by removing an unneeded join and a
minor security fix to verify perms based on the in-database user ID
instead of the ID provided by the caller (w/ the note that the API only
returns numbers, not user data).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 weeks agoLP1868147-Titles in carousel run together in mobile display.
Garry Collum [Thu, 17 Dec 2020 18:47:41 +0000 (13:47 -0500)]
LP1868147-Titles in carousel run together in mobile display.

This patch uses the breakpoint option available in glide.js to limit the number of images in the carousel that display.

Files for both the tpac and the bootstrap opac have been updated.

There are two new variables based on bootstrap sizing, sm_width which defaults to 3, and xs_width which defaults to 2.
If a screen's width is set between 768-992 pixels, 3 images display in the carousel,
if the width is below 768 pixels, only 2 images display in the carousel.
The reduction of images helps with titles overlapping each other.

To test:
Apply the patch to an instance of Evergreen that displays carousels.
Reduce the screen size of the browser.  Eventually the carousel will display 3 and then 2 images.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 weeks agoLP1857351 (follow-up): Fix typo that led to failing test
Jane Sandberg [Fri, 29 Jan 2021 00:19:31 +0000 (16:19 -0800)]
LP1857351 (follow-up): Fix typo that led to failing test

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 weeks agoLP1855761 Fix additional occurrences of 'Succeessfully'
Michele Morgan [Mon, 30 Nov 2020 19:32:31 +0000 (14:32 -0500)]
LP1855761 Fix additional occurrences of 'Succeessfully'

Credit also to Christine Morgan and Martha Driscoll for working to
hammer out the process of editing and testing Angular files.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 weeks agoLP1855761 Another typo fix
Terran McCanna [Tue, 27 Oct 2020 23:55:06 +0000 (19:55 -0400)]
LP1855761 Another typo fix

Fix one more typo in the action dropdown.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 weeks agoLP1855761 Typo when creating new carousel mapping
Terran McCanna [Tue, 27 Oct 2020 22:54:17 +0000 (18:54 -0400)]
LP1855761 Typo when creating new carousel mapping

Fixes two typos in the carousel messages.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 weeks agoLP1901760 Shared Worker minor lint repair
Bill Erickson [Thu, 28 Jan 2021 19:17:54 +0000 (14:17 -0500)]
LP1901760 Shared Worker minor lint repair

Repair a missing semicolon to keep lint happy.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 weeks agoLP1894131 DB Stamp: Sticky Holdings Org
Bill Erickson [Thu, 28 Jan 2021 19:10:29 +0000 (14:10 -0500)]
LP1894131 DB Stamp: Sticky Holdings Org

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 weeks agoLP1894131 Sticky catalog holdings org select
Bill Erickson [Fri, 16 Oct 2020 14:41:46 +0000 (10:41 -0400)]
LP1894131 Sticky catalog holdings org select

Adds a workstation setting to make the org selector in the catalog
holdings tab sticky.

Also repairs some logic errors in the org select persistKey loading.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
5 weeks agoLP 1857351: fix field order for Course Terms
Jane Sandberg [Wed, 16 Sep 2020 21:24:33 +0000 (14:24 -0700)]
LP 1857351: fix field order for Course Terms

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
5 weeks agoLP 1857351: fix field order for Recurring Fine Rules admin interface
Jane Sandberg [Tue, 18 Aug 2020 15:14:47 +0000 (08:14 -0700)]
LP 1857351: fix field order for Recurring Fine Rules admin interface

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
5 weeks agoLP 1857351: admin-page grid column order respects specified fieldOrder
Jane Sandberg [Fri, 26 Jun 2020 07:33:08 +0000 (07:33 +0000)]
LP 1857351: admin-page grid column order respects specified fieldOrder

Grid columns that aren't auto-generated and grids without a
specified autoGeneratedColumnOrder are not affected.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>