working/Evergreen.git
2 years agoAdding acknowledgements to release notes for 3.0.3
Jane Sandberg [Wed, 17 Jan 2018 21:28:24 +0000 (13:28 -0800)]
Adding acknowledgements to release notes for 3.0.3

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Adding upgrade note to 3.03 release notes
Kathy Lussier [Wed, 17 Jan 2018 21:13:11 +0000 (16:13 -0500)]
Docs: Adding upgrade note to 3.03 release notes

Adding an upgrade note regarding the post-transaction
command in the 3.03 upgrade.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoRelease notes for 3.0.3
Jane Sandberg [Wed, 17 Jan 2018 20:36:17 +0000 (12:36 -0800)]
Release notes for 3.0.3

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoRelease notes for 2.12.9
Jane Sandberg [Wed, 17 Jan 2018 19:40:04 +0000 (11:40 -0800)]
Release notes for 2.12.9

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1743650: Stamping upgrade script for special bib visibility handling
Kathy Lussier [Wed, 17 Jan 2018 18:25:11 +0000 (13:25 -0500)]
LP#1743650: Stamping upgrade script for special bib visibility handling

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1743650: Bib vis testing needs different handling
Mike Rylander [Tue, 16 Jan 2018 23:54:47 +0000 (18:54 -0500)]
LP#1743650: Bib vis testing needs different handling

For bib-level visibility testing, we can only use the source helper for
positive inclusion, and have to deal with LURIs on a case-by-case basis.
This is because, unlike the copy visibility cache, the LURI cache is pre-
composed in a single value for all LURIs on a record, not separate ones
for each.  This is fine, as we just need to find the effectively visible
org units and test for that subset of the relevant orgs. This commit provides
a sub to test for that, and handles LURI test composition at the perl
level rather than in the database.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1743639: Stamping upgrade script for copy location group visibility
Kathy Lussier [Wed, 17 Jan 2018 18:17:02 +0000 (13:17 -0500)]
LP#1743639: Stamping upgrade script for copy location group visibility

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1743639: Test location as proxy for location group
Mike Rylander [Tue, 16 Jan 2018 21:26:31 +0000 (16:26 -0500)]
LP#1743639: Test location as proxy for location group

Location groups are a table remove from copies, and can cause very large
updates to the copy vis cache.  So, we will expand location groups to
locations, in situ, to avoid this problem and the need to supply a trigger
to update th copy vis cache for groups.  This will allow us to reclaim
the location group bit in the visibility cache namespace if necessary, at
a later date.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1743639: opac_visible on acplg is not what it seems
Mike Rylander [Tue, 16 Jan 2018 19:39:08 +0000 (14:39 -0500)]
LP#1743639: opac_visible on acplg is not what it seems

The asset.copy_location_group table has a column called opac_visible.
However, unlike other tables with a column of that name, it controls the
visibility of the location group itself, not the visibility of the copies
within the group.  This is regretable because the 3.0+ search code thinks
that it should hide copies.

This commit adjusts the default location group filter applied to patron
searches so that they act as expected.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agolp1742194 - Print Current Bills only printing circ bills
Kyle Huckins [Thu, 11 Jan 2018 18:10:51 +0000 (18:10 +0000)]
lp1742194 - Print Current Bills only printing circ bills

- Check xact for Circulation before assigning circulation data to
xact for printing.

To test
-------
[1] Set up a patron with at least one "grocery" bill.
[2] In the web staff client, go to
    Patron Account > Bills > Actions > Print Bills
[3] Note that the current bills summary is not printed
    and that there an error in the browser console.
[4] Apply the patch and repeat step #2. This time, the
    bills summary should be printed.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Terra McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1730470 Restore XUL serial receive compatibility
Dan Wells [Wed, 27 Dec 2017 13:36:23 +0000 (08:36 -0500)]
LP#1730470 Restore XUL serial receive compatibility

The older XUL interface does not have quite the same fleshing as the
new web-staff, so adding the 'move previous' code into the unitize
function breaks the old interface.

Since we already are looking up the distribution to get the setting,
let's just tack it on when it is missing.

To test
-------
[1] Set up a serial subscription with predicted issuances, then from
    the XUL serials control view attempt to receive an issue. Note
    that there will be a crash.
[2] Apply the patch and repeat step #1; this time, the issuance
    receive should work.
[3] Verify that receiving issues via the web staff interface continues
    to work.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP1719943: fixing typo in credential testing interface
Jane Sandberg [Tue, 28 Nov 2017 16:09:16 +0000 (08:09 -0800)]
LP1719943: fixing typo in credential testing interface

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP1737052: Fix Typo in Permission Name
Jason Boyer [Tue, 2 Jan 2018 19:41:31 +0000 (14:41 -0500)]
LP1737052: Fix Typo in Permission Name

fm_IDL.xml had an 'S' appended to the
ADMIN_COPY_TAG making it impossible
to grant permissions to apply or edit
copy tags on an item.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1739786 - Webstaff MarcEditor BibSource Drop Down Order
Cesar Velez [Fri, 22 Dec 2017 17:04:24 +0000 (12:04 -0500)]
LP#1739786 - Webstaff MarcEditor BibSource Drop Down Order

Sort the list of bib sources in MARC editor alphabetically;
some libraries may have a long list.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1741072 Volcopy editor deposit amount format repairs
Bill Erickson [Mon, 8 Jan 2018 15:37:17 +0000 (10:37 -0500)]
LP#1741072 Volcopy editor deposit amount format repairs

Use the new str-to-float formatter for deposit amount, consistent with
the other currency fields.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP1741072: Fix JS test for template conversion
Jason Boyer [Fri, 5 Jan 2018 21:55:15 +0000 (16:55 -0500)]
LP1741072: Fix JS test for template conversion

Changing 2 fields from "strings" to numbers does
cause such a test to fail, as one might expect.
Now the test is updated to meet the current
expectations of the template conversion.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1736763: Wait until the org tree is there before using it
Mike Rylander [Mon, 11 Dec 2017 21:21:39 +0000 (16:21 -0500)]
LP#1736763: Wait until the org tree is there before using it

In offline mode, we need to wait for the org tree to be fetched or recreated
before we set the working location dropdown.  This commit adds a function
to loop and wait for that to happen.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
2 years agoLP#1730758: Stamping upgrade script for luri_vis_cache
Kathy Lussier [Wed, 10 Jan 2018 19:42:46 +0000 (14:42 -0500)]
LP#1730758: Stamping upgrade script for luri_vis_cache

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1730758: Track record visibility on all Located URI DML
Mike Rylander [Wed, 6 Dec 2017 23:18:29 +0000 (18:18 -0500)]
LP#1730758: Track record visibility on all Located URI DML

This commit simplifies the handling of Located URI call numbers by separating
them from normal call numbers.  This will allow proper updating of bib-level
visibility attributes for all actions that may happen to a Located URI.

We also insure that we don't return a NULL INT[] as an attribute set for
either copies or bibs.  This was always impossible for copies, but was
possible for bibs.  Now both are future-proof.

The upgrade script contains a post-transaction command to forcibly update the
visibility attributes of all bibs that make use of Located URIs or bib sources.
It may take a while to run on large datasets.  If it it running too long, it
can be canceled and the following psql commands will create and run a script
that will perform the same action serially over time without blocking writes to
bibs:

\t
\o /tmp/luri_visibility_update.sql
SELECT 'UPDATE biblio.record_entry SET ' ||
  'vis_attr_vector = biblio.calculate_bib_visibility_attribute_set(id) ' ||
  'WHERE id = ' || id || '; SELECT ' || id || ';'
FROM biblio.record_entry
  WHERE id IN (
            SELECT  DISTINCT cn.record
              FROM  asset.call_number cn
              WHERE NOT cn.deleted
                    AND cn.label = '##URI##'
                    AND EXISTS (
                        SELECT  1
                          FROM  asset.uri_call_number_map m
                          WHERE m.call_number = cn.id
                    )
                UNION
            SELECT id FROM biblio.record_entry WHERE source IS NOT NULL

        );
\o
\t
\i /tmp/luri_visibility_update.sql

It will output the id of each updated bib so that the script can be killed
and then edited to remove completed bibs.  The remainder can be run at a
later time.

NOTE: When the internal flag 'ingest.reingest.force_on_same_marc' is enabled,
we do NOT update the bib's visibility attributes, as doing so causes a loop
and an eventual trigger stack violation.  This flag should ONLY be used when
forcing reingest of record attributes (NOT visibility attributes), search,
facet, and display fields, so if using this flag under normal operation,
proceed at your own risk and know that Located URI and bib source changes
will not be reflected in the visibility attributes of the record.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1736419: Bib visibility tests get OR'd
Mike Rylander [Mon, 8 Jan 2018 21:43:26 +0000 (16:43 -0500)]
LP#1736419: Bib visibility tests get OR'd

Either the source or the existance of a Located URI will trigger record
visibility, so we will OR them together.

NOTE: This branch is dependant on the branch supplied on LP#1730758. Without
that fix, the bib-level visibility attributes are not updated properly when
Located URIs are added or changed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1736419: Located URIs vs QueryParser, round 2, part deux
Mike Rylander [Fri, 5 Jan 2018 22:04:53 +0000 (17:04 -0500)]
LP#1736419: Located URIs vs QueryParser, round 2, part deux

Now we will be less strict about the 'act_as_copy' flag, and only check for
enabledness, rather than the truth of its value column.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1736419: Located URIs vs QueryParser, round 2
Mike Rylander [Thu, 4 Jan 2018 23:12:17 +0000 (18:12 -0500)]
LP#1736419: Located URIs vs QueryParser, round 2

The site() filter and #staff modifier are used to decide when and how to
include certain query filters, such as circ_lib or luri_org. Unfortunately,
site() is sometimes excluded (whole-tree search) and the test for staff-
iness was not specific enough, leading to incorrect queries in those cases
where information was lacking.  Now, we treat site() specially, forcing a
default of "top-of-tree", and we check for the #staff modifier directly
where necessary.

Note: this commit also addresses LP#1736992 which is about staff searches
using the limit-to-available modifier.  As a side effect of the special
site() treatment, that issue is resolved.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1710405 - remove Modify + Use Edits buttons in z3950 overlay
Cesar Velez [Thu, 30 Nov 2017 20:36:35 +0000 (15:36 -0500)]
LP#1710405 - remove Modify + Use Edits buttons in z3950 overlay

The workflow for using a z3950 record to overlay a marked bib
was confusing since it requires first saving the z3950 marc edits
via the Modify button at the top, and only then hitting Use Edits,
at the bottom of the modals. User often miss the click Modify part,
 thus this simplifies that, having just a "Save" button and a Cancel.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP#1739676 - Web client check in LOST_AND_PAID status
Michele Morgan [Wed, 27 Dec 2017 17:16:25 +0000 (12:16 -0500)]
LP#1739676 - Web client check in LOST_AND_PAID status

Adds COPY_STATUS_LOST_AND_PAID as a recognized checkin event in the web
client.  This gives staff the option to override or cancel the checkin.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP1712646: Require a Billing Type to Bill User
Jason Boyer [Thu, 4 Jan 2018 18:38:00 +0000 (13:38 -0500)]
LP1712646: Require a Billing Type to Bill User

Previously billing a user without choosing a billing type
would either fail silently or default to misc. This patch
requires staff to choose a billing type before the new
bill window can be dismissed.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP1741072: Global String<->Num Directives for ngModel
Jason Boyer [Thu, 4 Jan 2018 17:55:16 +0000 (12:55 -0500)]
LP1741072: Global String<->Num Directives for ngModel

To increase flexibility the stringToNumber directive
has been separated into int and float versions and
aditional directives are added to convert in the other
direction. The existing use of stringToNumber in the
volume/copy editor are also converted to strToFloat.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1691861 - make Item Status edit items in batch in volcopy
Cesar Velez [Tue, 24 Oct 2017 18:16:33 +0000 (14:16 -0400)]
LP#1691861 - make Item Status edit items in batch in volcopy

This makes the Item Status grid action of "Edit Items" work
like the Copy Buckets grid "Edit Selected Items", in that the
copies open in the volcopy editor in batch, with no record summary.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: updated note: to NOTE: to fix asciidoc syntax issue
Jeanette Lundgren [Fri, 15 Sep 2017 19:06:07 +0000 (15:06 -0400)]
Docs: updated note: to NOTE: to fix asciidoc syntax issue

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoDocs: LP1736571 fix typo done to down
Jeanette Lundgren [Tue, 26 Dec 2017 17:58:19 +0000 (12:58 -0500)]
Docs: LP1736571 fix typo done to down

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1735807 Webstaff holdings owning lib shortname
Bill Erickson [Fri, 1 Dec 2017 19:20:57 +0000 (14:20 -0500)]
LP#1735807 Webstaff holdings owning lib shortname

Display org unit shortnames in the web staff bib record Holdings View
-> Owning Library column, since displaying the full names requires
significant horizontal space.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP#1729922: correctly display most recent transit in item status
Galen Charlton [Fri, 8 Dec 2017 15:29:40 +0000 (10:29 -0500)]
LP#1729922: correctly display most recent transit in item status

This patch ensures that the 'Most Recent Transit' display in
the web staff client's item status page shows the latest transit,
not the oldest one. This also fixes a bug where the transit
receive time never got displayed.  As a side effect, this patch
also ensures that only the transit in question is fetched from
the database, not all transits on the item.

To test
-------
[1] Set up an item with some closed transits and display in in
    detail view in the Item Status page. Note that the
    /oldest/ transit is displayed and that the transit
    receive time field is blank.
[2] Apply the patch and repeat step 1.
[3] This time, the most recent transit should be displayed, and
    if that transit was received, the receive time should be
    displayed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agolp#1724321 Web Client -- existence of record with duplicate TCN does not prevent...
blake [Thu, 9 Nov 2017 15:35:07 +0000 (15:35 +0000)]
lp#1724321 Web Client -- existence of record with duplicate TCN does not prevent import

This routes the MARC import execution back to the z39.50 code instead of using the generic
MARC editor. This will make use of open-ils.cat.biblio.record.xml.import instead of pcrud.

Test
1. Edit global flag variable "Cat: Use Internal ID for TCN Value" = false
2. Perform a z39.50 search, click a result and click "import"
3. Step two should be successful, now import it again and you should get an error
4. Click the same result but use "Edit then import"
5. From the MARC editor, make no changes and click "Import"
6. It won't complain about duplicate TCNs
7. Apply the patch
8. Perform steps 4 and 5
9. Notice that the editor does not allow you to import the record

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP#1378383-WebStaff Fix Item circ history to obey max setting
Cesar Velez [Thu, 21 Sep 2017 14:45:23 +0000 (15:45 +0100)]
LP#1378383-WebStaff Fix Item circ history to obey max setting

The circ.item_checkout_history.max lib setting should be respected
in both Circ History tabs, and also check for the permission to
VIEW_COPY_CHECKOUT_HISTORY for the current user.

Also, There was ambiguity for the user to tell the difference
(from the displayed message) if an item truly has no circulations,
or if they see no circs due to the relevant permission setting
being set to 0 (Maximum previous checkouts.) This changes the templates
a bit to make that clearer.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoDocs: Use new images for in-house use
Remington Steed [Thu, 7 Dec 2017 15:55:41 +0000 (10:55 -0500)]
Docs: Use new images for in-house use

The In-House Use docs previously had new web client screenshots, but a
recent commit accidentally reverted them to the old XUL client images.
This commit changes the references back to the new images.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoForward-port 2.12.8 upgrade script
Dan Wells [Fri, 1 Dec 2017 21:05:02 +0000 (16:05 -0500)]
Forward-port 2.12.8 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoForward-port 3.0.2 upgrade script
Dan Wells [Fri, 1 Dec 2017 21:01:20 +0000 (16:01 -0500)]
Forward-port 3.0.2 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agorelease notes for Evergreen 2.12.8
Galen Charlton [Thu, 30 Nov 2017 16:24:25 +0000 (11:24 -0500)]
release notes for Evergreen 2.12.8

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years ago3.0.2 release notes
Galen Charlton [Thu, 30 Nov 2017 16:16:39 +0000 (11:16 -0500)]
3.0.2 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1178802: force ceiling dates to be end of day
Galen Charlton [Fri, 15 Sep 2017 18:38:18 +0000 (14:38 -0400)]
LP#1178802: force ceiling dates to be end of day

This patch ensures that when a hard due date (or hard due date value)
is created or edited, the ceiling date is set to the end of that day.

This fixes a problem where a ceiling date would not be applied for
loans checked out earlier on the ceiling date itself.

This patch intentionally does not touch existing hard due date
values.  It also does not use the database or middle layer to coerce
the ceiling dates to end of day to leave upon the possiblity that
an Angular version of the hard due date editor will allow operators
to set both date and time. (Note that Dojo does not readily have a
combined date/time picker.)

To test
-------
[1] Apply the patch, then in the hard due date editor, verify that
    when creating a hard due date _value_, the date gets saved as
    ending at 23:59:59 in the local time zone.
[2] Similarly, verify that when editing an existing hard due date value,
    the date gets saved as ending at 23:59:59.
[3] Repeat steps 1 and 2, but this time for hard due dates.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1734737: Display originating template UI
Mike Rylander [Mon, 27 Nov 2017 18:06:56 +0000 (13:06 -0500)]
LP#1734737: Display originating template UI

Until the (planned for 3.1) ability to clone XUL-created reports in the web
staff client is completed, it would be useful to at least display to the user
the origin UI in which a template was created. This will allow staff to, for
the immediate term, decide which UI they should use to deal with a particular
template, re cloning etc.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: fix list item index in basic_holds.adoc
Ben Shum [Wed, 29 Nov 2017 21:36:05 +0000 (16:36 -0500)]
Docs: fix list item index in basic_holds.adoc

Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agolp1705133 view holds patron info redaction
Alex Cautley [Thu, 16 Nov 2017 23:03:11 +0000 (23:03 +0000)]
lp1705133 view holds patron info redaction

Removed extra or sensitive patron information from patron and record
hold grid

Signed-off-by: Alex Cautley <acautley@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/catalog/t_holds.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_holds_list.tt2

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years ago2nd level of bullets requires '**'
Dan Scott [Wed, 29 Nov 2017 20:31:26 +0000 (15:31 -0500)]
2nd level of bullets requires '**'

The Asciidoc for this file had two levels of indentations for the
intended bulleted list, but bullet indentation levels are set by
the number of asterisks:

* = 1st level
** = 2nd level

Signed-off-by: Dan Scott <dscott@laurentian.ca>
2 years agoLP1714390:Remove acp Editor Formatting Frustration
Jason Boyer [Fri, 1 Sep 2017 02:06:31 +0000 (22:06 -0400)]
LP1714390:Remove acp Editor Formatting Frustration

In bug 1713064 I added a directive to make it possible to use
a String as a Model in an Input tag with type Number. Unfortunately
there was also a formatting function in that branch that works well
sometimes but is far more frustrating than it is helpful for enough
workflows that it should be removed.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1734963: Teach copy template converter about older templates.
Chris Sharp [Tue, 28 Nov 2017 18:42:26 +0000 (13:42 -0500)]
LP#1734963: Teach copy template converter about older templates.

The XUL-to-web-client copy template converter created to fix
bug 1691269 needs a little help when the value stored is a
number rather than a string.

Thanks to Jeff Godin for troubleshooting help and Mike
Rylander for the suggested solution.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jeff Godin <jgodin@tadl.org>
2 years agoStamping upgrade script for xul-to-web copy template translation
Mike Rylander [Mon, 27 Nov 2017 18:53:40 +0000 (13:53 -0500)]
Stamping upgrade script for xul-to-web copy template translation

Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1691269: (follow-up) fix whitespace to match local style
Galen Charlton [Mon, 27 Nov 2017 18:24:39 +0000 (13:24 -0500)]
LP#1691269: (follow-up) fix whitespace to match local style

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1691269: add unit test for convert_xul_templates
Galen Charlton [Mon, 27 Nov 2017 18:17:29 +0000 (13:17 -0500)]
LP#1691269: add unit test for convert_xul_templates

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1691269: include volume fields in converted copy templates
Galen Charlton [Mon, 27 Nov 2017 17:46:33 +0000 (12:46 -0500)]
LP#1691269: include volume fields in converted copy templates

This patch insures that call number prefix, suffix, and classification
scheme from copy templates created in the XUL unified copy editor are
brought over to web staff copy templates.

Note that in order to successfully test the call number portion of
converted copy templates in the web staff client, the volume/copy editor
default "Allow Call Number attributes in Copy Templates" should be
turned on.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1691269: (follow-up) include new cust in seed data
Galen Charlton [Mon, 27 Nov 2017 16:08:23 +0000 (11:08 -0500)]
LP#1691269: (follow-up) include new cust in seed data

Also s/Copier/Copy/.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP1691269: Webstaff Copy Editor Templates
Jason Boyer [Sun, 22 Oct 2017 19:42:02 +0000 (15:42 -0400)]
LP1691269: Webstaff Copy Editor Templates

This branch will translate and transfer your XUL client templates
the first time you load the web client copy editor. From that point
on the two diverge with no further connection to each other.

This branch also allows your copy templates to travel with you
between browsers, machines, and so on, while still allowing users
that share a browser but not usernames to have their own templates.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP 1698176: Return undef with die event in Actor.pm _add_patron function.
Jason Stephenson [Thu, 15 Jun 2017 18:11:41 +0000 (14:11 -0400)]
LP 1698176: Return undef with die event in Actor.pm _add_patron function.

If the CStoreEditor create_actor_user call fails in the _add_patron
helper function in OpenILS/Application/Actor.pm, the CStorEditor's
die_event is returned as a scalar value.  The caller expects a list
return with two values: the user object in index 0 and the event, if
any, in index 1.

Returning just the event causes the caller to use the event as if it
were the user object.  This leads to a different error message later
in the code: Can't call method "billing_address" on unblessed
reference at /path/to/perlib/OpenILS/Application/Actor.pm line 743.

This commit changes the return value in the event of a database insert
failure to be the two member list as expected by the caller with undef
in index 0 and the die_event in index 1.  This returns the proper
error message to the client.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
2 years agoLP#1671150 Document unaccented name index fix
Jeff Godin [Tue, 7 Nov 2017 21:29:03 +0000 (16:29 -0500)]
LP#1671150 Document unaccented name index fix

Release notes for evergreen.unaccent_and_squash function (and
dependent indexes) fix.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1671150 Stamp database upgrade script.
Jason Stephenson [Fri, 17 Nov 2017 20:15:15 +0000 (15:15 -0500)]
LP#1671150 Stamp database upgrade script.

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1671150 fix unqualified unaccent call
Jeff Godin [Fri, 23 Jun 2017 00:03:29 +0000 (20:03 -0400)]
LP#1671150 fix unqualified unaccent call

Fix index creation failures when using pg_restore by qualifying the
unaccent() function call in evergreen.unaccent_and_squash()

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP#1708489: Adjust sample holds status
Kathy Lussier [Fri, 17 Nov 2017 17:40:43 +0000 (12:40 -0500)]
LP#1708489: Adjust sample holds status

Changed the sample holds status to a status that would show up on a real-world holds
shelf.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1708489 Hold Shelf Print Template Additions
Kyle Huckins [Tue, 24 Oct 2017 18:12:31 +0000 (18:12 +0000)]
LP#1708489 Hold Shelf Print Template Additions

- Add Hold Status and Shelf Expiry Date to Hold Shelf Print
Template

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_hold_shelf_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/admin/workstation/app.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1708487: Update helper text in print template
Kathy Lussier [Fri, 17 Nov 2017 17:11:12 +0000 (12:11 -0500)]
LP#1708487: Update helper text in print template

Update the helper text for title and barcode for bills printer templates to
include xact.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1708487 Add Title and Barcode to Bill Print Templates
Kyle Huckins [Mon, 30 Oct 2017 15:55:24 +0000 (15:55 +0000)]
LP#1708487 Add Title and Barcode to Bill Print Templates

- Add additional documentation to Bills, Current; Bills, Payment; and Bills,
Historical print templates.
- Convert xacts to objects containing all required information for print
templates

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_bill_payment.tt2
modified:   Open-ILS/src/templates/staff/share/print_templates/t_bills_current.tt2
modified:   Open-ILS/src/templates/staff/share/print_templates/t_bills_historical.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/bills.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: fix broken image reference
Jeff Godin [Fri, 17 Nov 2017 17:07:42 +0000 (12:07 -0500)]
Docs: fix broken image reference

Fix broken image reference in copy tags documentation: file on disk
has lowercase png extension, reference in document was uppercase PNG
extension.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
2 years agolp1646210 Call Number Affixes Waiting for Copy bugfix
Kyle Huckins [Thu, 16 Nov 2017 23:54:48 +0000 (23:54 +0000)]
lp1646210 Call Number Affixes Waiting for Copy bugfix

-Checks for a volume in hold data, preventing broken grids in cases
where a hold is waiting for copy

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: updating SIP docs
Jane Sandberg [Fri, 17 Nov 2017 14:04:21 +0000 (06:04 -0800)]
Docs: updating SIP docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Set Per-OU Limits on Allowed Payment Amounts
Jane Sandberg [Fri, 17 Nov 2017 05:25:21 +0000 (21:25 -0800)]
Docs: Set Per-OU Limits on Allowed Payment Amounts

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Jane Sandberg [Fri, 17 Nov 2017 04:31:08 +0000 (20:31 -0800)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

2 years agoDocs: search scope info
Jane Sandberg [Fri, 17 Nov 2017 04:29:11 +0000 (20:29 -0800)]
Docs: search scope info

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: making tt2 docs more modular
Jane Sandberg [Fri, 17 Nov 2017 04:11:20 +0000 (20:11 -0800)]
Docs: making tt2 docs more modular

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Asciidoc fixes
Angela Kilsdonk [Thu, 16 Nov 2017 15:35:34 +0000 (07:35 -0800)]
Docs: Asciidoc fixes

Fixed capitalization for image file formats.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
2 years agoDocs: small fixes to closed dates editor
Jane Sandberg [Sun, 12 Nov 2017 18:28:01 +0000 (10:28 -0800)]
Docs: small fixes to closed dates editor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1723498: fix display of count of duplicate patrons
Galen Charlton [Fri, 10 Nov 2017 21:43:29 +0000 (16:43 -0500)]
LP#1723498: fix display of count of duplicate patrons

This patch fixes an issue where the patron registration
form's alert for duplicate phone numbers did not display
the count of matching records. (This was caused by code
that was expecting a string to be passed by reference
when it's passed by value in JavaScript).

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1723498 Patron reg/edit dupe search repairs
Bill Erickson [Thu, 9 Nov 2017 15:46:50 +0000 (10:46 -0500)]
LP#1723498 Patron reg/edit dupe search repairs

Avoid clobbering duplicate patron search links by managing search URLs
individually by search type and displaying a search link per search
type.

This change includes an improvement over the XUL version in that a link
will be displayed per matching phone number so each can be searched,
instead of only searching the most recently entered phone number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terra McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1731496 Avoid PhantomJS BroadcastChannel failure
Bill Erickson [Thu, 9 Nov 2017 16:39:12 +0000 (11:39 -0500)]
LP#1731496 Avoid PhantomJS BroadcastChannel failure

Avoid attempts to create BroadcastChannel objects in contexts where the
object does not exist.  Specifically, allow PhantomJS to run unit tesst
without dying on:

ReferenceError: Can't find variable: BroadcastChannel

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoDocs: User Buckets
Angela Kilsdonk [Thu, 9 Nov 2017 23:30:45 +0000 (15:30 -0800)]
Docs: User Buckets

Documentation for user buckets.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
2 years agoDocs: Copy Tags/Digital Bookplates
Angela Kilsdonk [Thu, 9 Nov 2017 22:27:13 +0000 (14:27 -0800)]
Docs: Copy Tags/Digital Bookplates

Documentation for the copy tags feature.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
2 years agoDocs: Patron Search to Place Hold
Angela Kilsdonk [Thu, 9 Nov 2017 22:00:05 +0000 (14:00 -0800)]
Docs: Patron Search to Place Hold

Patron search functionality while placing a hold in the staff client.  Docs written by Mary Jinglewski.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
2 years agoDocs: Serials Module 3.0
Angela Kilsdonk [Thu, 9 Nov 2017 21:31:21 +0000 (13:31 -0800)]
Docs: Serials Module 3.0

Documentation for the Serials module in Evergreen 3.0

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
2 years agoDocs: Re-adding the library settings for patron self-registration
Jane Sandberg [Thu, 9 Nov 2017 16:54:19 +0000 (10:54 -0600)]
Docs: Re-adding the library settings for patron self-registration

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: incorporating offline circ docs
Jane Sandberg [Thu, 9 Nov 2017 16:24:59 +0000 (10:24 -0600)]
Docs: incorporating offline circ docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1708488: adjust how patron financial summary is exposed to checkout receipts
Galen Charlton [Tue, 7 Nov 2017 18:41:55 +0000 (13:41 -0500)]
LP#1708488: adjust how patron financial summary is exposed to checkout receipts

This patch builds on the previous patch by grabbing the patron's
financial summary from the patron stats values. The "patron_money"
template value is no longer associated with a particular loan, meaning
that you can do things like this:

<span ng-if="patron_money.balance_owed">You owe the library ${{patron_money.balance_owed}}</span>

The additional values include

* patron_money.balance_owed - current balance
* patron_money.total_paid - payments made on outstanding fines/fees
* patron_money.total_owed - total of outstanding fines/fees

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terra McCanna <tmccanna@georgialibraries.org>
2 years agoLP#1708488 Checkout Print Template Balance Owed
Kyle Huckins [Fri, 27 Oct 2017 16:24:04 +0000 (16:24 +0000)]
LP#1708488 Checkout Print Template Balance Owed

Add Patron's money summary to Circulations in Checkout print template.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Terra McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: adding introduction section to webclient offline docs
Jane Sandberg [Thu, 9 Nov 2017 16:20:24 +0000 (10:20 -0600)]
Docs: adding introduction section to webclient offline docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1731281: stamp database update
Galen Charlton [Thu, 9 Nov 2017 16:17:44 +0000 (11:17 -0500)]
LP#1731281: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: adding offline circ webclient docs to circ manual
Jane Sandberg [Thu, 9 Nov 2017 16:16:09 +0000 (10:16 -0600)]
Docs: adding offline circ webclient docs to circ manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP1731281: Remove Deleted Items From acvac Table
Jason Boyer [Thu, 9 Nov 2017 14:55:42 +0000 (09:55 -0500)]
LP1731281: Remove Deleted Items From acvac Table

The script that created the acvac table accidentally
included entries for deleted items which leads to confusion
when titles the library no longer owns are displayed as
available again, even though no copies appear on the record
detail page. This upgrade script removes any that are left
there.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1724223: stamp schema update
Galen Charlton [Thu, 9 Nov 2017 15:44:17 +0000 (10:44 -0500)]
LP#1724223: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1724223: tweak upgrade script
Galen Charlton [Thu, 9 Nov 2017 15:37:52 +0000 (10:37 -0500)]
LP#1724223: tweak upgrade script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP1724223: Fix inherited FKEY triggers
Jason Boyer [Wed, 18 Oct 2017 03:10:46 +0000 (22:10 -0500)]
LP1724223: Fix inherited FKEY triggers

When running these triggers on TG_OP=DELETE they
always fail and prevent the delete. Skipping the
triggers on DELETE allows things to continue as
usual.

To test
-------
Verify that after applying the patch that you can remove
notes and copy tags from copies and copies from buckets
and Vandely import queues.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1724915 Webstaff auth timeout works w/ multiple tabs
Bill Erickson [Thu, 19 Oct 2017 18:46:01 +0000 (14:46 -0400)]
LP#1724915 Webstaff auth timeout works w/ multiple tabs

Adds a new API parameter to open-ils.session.retrieve which allows the
session to be fetched without extending the auth session timeout.

Teach the browser client to use the new API.

Teach the browser client to notify all webstaff tabs when a logout event
has occurred, so every tab can immediately log out.

To test
-------
[0] Apply the patch.
[1] Log in the web staff client, then open a new window/tab
    and navigate to the web staff client.
[2] Log out of the web staff client in one window. Verify that
    the second window automatically refreshes and goes to the
    login page.
[3] Set a low staff idle timeout (optional).
[4] Repeat step 1, then wait for the timeout. Verify that the
    staff client is logged out in both windows.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1728677: add release notes entry
Galen Charlton [Thu, 9 Nov 2017 14:46:35 +0000 (09:46 -0500)]
LP#1728677: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1728677 - Add survey data to concerto test dataset.
Chris Sharp [Mon, 30 Oct 2017 16:29:20 +0000 (12:29 -0400)]
LP#1728677 - Add survey data to concerto test dataset.

To more closely approximate a realistic test environment,
this branch adds data to the concerto test dataset.  Most users
are given a randomized response to a simple 3-question survey.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1717351: tweak release notes
Galen Charlton [Wed, 8 Nov 2017 22:21:08 +0000 (17:21 -0500)]
LP#1717351: tweak release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoAdded Release Notes
Sam Link [Tue, 7 Nov 2017 13:27:18 +0000 (08:27 -0500)]
Added Release Notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoWeb Client: Make Patron Email Clickable
Sam Link [Fri, 6 Oct 2017 15:40:47 +0000 (11:40 -0400)]
Web Client: Make Patron Email Clickable

The patch is twofold. First, "mailto" has been added to
$compileProvider.aHrefSanitizationWhitelist() throughout the project.
Second, the patron email in the patron summary has been wrapped in an
anchor with ng-href="mailto:{{patron().emaio()}}" to enable the desired
functionality.

Signed-off-by: Sam Link <slink@columbiacountyga.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Improve warning format in ebook api section
Remington Steed [Wed, 8 Nov 2017 21:39:27 +0000 (16:39 -0500)]
Docs: Improve warning format in ebook api section

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoLP#1527731: Allow specified join order
Mike Rylander [Wed, 18 Oct 2017 20:52:31 +0000 (16:52 -0400)]
LP#1527731: Allow specified join order

With this commit we now support user-defined join order in cstore and friends.
Previously, because the join structure of oils_sql beyond the specification of
a single table was only allowed to be represented as a JSON object, it was
subject to potential hash key reordering -- thanks, Perl.  By supporting an
intervening array layer, one can now specify the exact join order of the
tables in a join tree.

For example, given the following JSON object passing through a modern Perl 5
interpreter as a nested hash:

{select :   {acp:['id'],
             acn:['record'],
             acpl:['name']
            },
  from  :   {acp:
                {acn:{filter:{record:12345}},
                 acpl:null
                }
            }
}

the FROM clause of the query may end up as:

  FROM  acp
        JOIN acn ON (acp.call_number = acn.id AND acn.record = 12345)
        JOIN acpl ON (acp.location = acpl.id)

Or as:

  FROM  acp
        JOIN acpl ON (acp.location = acpl.id)
        JOIN acn ON (acp.call_number = acn.id AND acn.record = 12345)

In some situations, the join order will matter either to the semantics of the
query plan, or to its performance.  The following example of the newly
supported syntax illustrates how to specify join order:

{select :   {acp:['id'],
             acn:['record'],
             acpl:['name']
            },
  from  :   {acp:[
                {acn:{filter:{record:12345}}},
                 'acpl'
            ]}
}

And the only FROM clause the can be generated is:

  FROM  acp
        JOIN acn ON (acp.call_number = acn.id AND acn.record = 12345)
        JOIN acpl ON (acp.location = acpl.id)

Why is this important
---------------------
While Postgres' planner is very smart, a join tree with many tables may create
a plan search space that is simply too large to be tested effeciently.  In such
cases, Postgres will do its best to find a good plan for the query using its
GEQO algorithm.  Often, a DBA or developer has enough understanding of the
expected relative data sizes involved to give Postgres a leg up by specifying
a join order that improves the planner's chances of generating an optimal plan.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1646210 Add CN Affixes to Grids WIP
Kyle Huckins [Tue, 17 Oct 2017 20:11:25 +0000 (20:11 +0000)]
LP#1646210 Add CN Affixes to Grids WIP

Adds Call Number Suffixes and Prefixes to the following grids:
- Copy Buckets
- Pending Copy Buckets
- Checkin/Capture Holds
- Patron Holds
- Patron Checkout
- Patron Items Out
- Patron Bill History
- Holds Shelf
- Renew Items
- In-House Uses
- Bib Record View Holds
- Patron Bill History
- Transit List
- Copy Editor

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/bucket/copy/t_pending.tt2
modified:   Open-ILS/src/templates/staff/cat/bucket/copy/t_view.tt2
modified:   Open-ILS/src/templates/staff/cat/catalog/t_holds.tt2
modified:   Open-ILS/src/templates/staff/cat/volcopy/t_edit.tt2
modified:   Open-ILS/src/templates/staff/circ/checkin/t_checkin_table.tt2
modified:   Open-ILS/src/templates/staff/circ/holds/t_shelf_list.tt2
modified:   Open-ILS/src/templates/staff/circ/in_house_use/index.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_bill_history_xacts.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_checkout.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_holds_list.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_items_out.tt2
modified:   Open-ILS/src/templates/staff/circ/renew/t_renew.tt2
modified:   Open-ILS/src/templates/staff/circ/transits/t_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/in_house_use/app.js
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js
modified:   Open-ILS/web/js/ui/default/staff/circ/services/circ.js
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js
modified:   Open-ILS/web/js/ui/default/staff/circ/transits/list.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1672435: Make BR4's sample theses copy location holdable
Kathy Lussier [Mon, 25 Sep 2017 14:29:56 +0000 (10:29 -0400)]
LP#1672435: Make BR4's sample theses copy location holdable

All of the part copies in the sample dataset live in a non-holdable
copy location, usually BR4's Theses location. This commit makes
that copy location holdable so that we can better test part holds
out of the box.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1704396: reset the facet alarm timer
Mike Rylander [Wed, 1 Nov 2017 22:22:21 +0000 (18:22 -0400)]
LP#1704396: reset the facet alarm timer

When using alarm() one must reset the timer via alarm(0) or incur the wrath
of the spurious signal.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoDocs: Improve adoc list syntax in badges section
Remington Steed [Wed, 8 Nov 2017 16:57:16 +0000 (11:57 -0500)]
Docs: Improve adoc list syntax in badges section

This commit fixes some minor formatting issues with the numbered list,
and improves readability of the AsciiDoc file.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: Fix two AsciiDoc syntax warnings
Remington Steed [Wed, 8 Nov 2017 16:56:42 +0000 (11:56 -0500)]
Docs: Fix two AsciiDoc syntax warnings

A recent commit removed a docs file and integrated the content into the
3.0 release notes and the ebook_api.adoc file.  This commit cleans up
two small problems left over from that commit:

  - Remove the reference to the deleted file
  - Fix the warning block syntax in ebook_api.adoc

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoLP#1724885: (follow-up) fix whitespace
Galen Charlton [Wed, 8 Nov 2017 16:09:21 +0000 (11:09 -0500)]
LP#1724885: (follow-up) fix whitespace

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>