]> git.evergreen-ils.org Git - working/Evergreen.git/commit
Tweaks to 'my lists' paging code
authorDan Wells <dbw2@calvin.edu>
Fri, 13 Sep 2013 16:59:59 +0000 (12:59 -0400)
committerMike Rylander <mrylander@gmail.com>
Mon, 16 Sep 2013 16:37:54 +0000 (12:37 -0400)
commitfc831adcb200d4b6a20c0b2b71ea7fd3c6ce1dca
treec5d385f10051f3e16f379e3e6eca218417d57e82
parent4b472cb269ddd85fc395a3e0d62583a9c1da9401
Tweaks to 'my lists' paging code

1) Don't set and refetch the 'my lists' settings if nothing changed.
(minor nit)

2) Get the count through the same code where we get the bookbag data.

For #2, I am concerned with the current duplication of logic. At best
we are doing things twice, and at worst we end up counting a set which
is slightly different than our actual bookbag search results.

In the updated code, I think the count accuracy is subject to
search/superpage limit settings, so lists are effectively limited by
the search settings. If that is a valid concern, we can beef up the
settings for this query.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm