]> git.evergreen-ils.org Git - working/Evergreen.git/log
working/Evergreen.git
18 months agoLP1952931 release notes
Jane Sandberg [Thu, 27 Oct 2022 22:35:17 +0000 (15:35 -0700)]
LP1952931 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1952931 stamp upgrade script
Jane Sandberg [Thu, 27 Oct 2022 22:27:46 +0000 (15:27 -0700)]
LP1952931 stamp upgrade script

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1952931 Support ACQ Advanced Shipment Notices (DESADV -- Dispatch Advice Messages)
Bill Erickson [Wed, 1 Dec 2021 16:49:23 +0000 (11:49 -0500)]
LP1952931 Support ACQ Advanced Shipment Notices (DESADV -- Dispatch Advice Messages)

* Parsing DESADV EDI Messages
* ASN shipment notification SQL
* ASN shipment notifiation Perl
* ASN shipment notifiation Perl Test
* ASN receiving UI
* ASN shipment notifiation IDL
* ASN Perl Test
* Handle barcode not found
* Add process date and processed by fields
* Stamping process date and processed
* Copy upgrade SQL to base schema
* LI# link goes to LI items; show title in summary
* LI# link goes to LI items fix
* ASN EDI can contain multiple containers
* Blocking receiving before container fully loads
* More data loading indictor support
* ASN disable Dry-Run by default
* Receive Shipment AngJS menu entry
* Disable try run by default; focus input on load
* ASN dry run fixes / Notifed Count repair
* ASN support Ingram message format (PCI field)

Includes change to allow skipping line items that have no container
code, which happens with Ingram messages sometimes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1964629 release note
Jane Sandberg [Thu, 27 Oct 2022 22:12:00 +0000 (15:12 -0700)]
LP#1964629 release note

18 months agoLP#1964629 - Item Status - add column for Total Circs
Michele Morgan [Tue, 16 Aug 2022 14:36:54 +0000 (10:36 -0400)]
LP#1964629 - Item Status - add column for Total Circs

Adds Total Circulations to the column picker.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1864507 follow-up, stamp upgrade script, and release notes
Jane Sandberg [Thu, 27 Oct 2022 22:03:23 +0000 (15:03 -0700)]
LP#1864507 follow-up, stamp upgrade script, and release notes

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1864507: Improve browse by removing more ISBD
Mike Rylander [Mon, 24 Feb 2020 16:15:22 +0000 (11:15 -0500)]
LP#1864507: Improve browse by removing more ISBD

The fix for bug 1308090 introduced an improvement targetted at Facets
that removed some extraneous punctuation from author-ish fields.  Here
we expand that to cover more field types (primarily title), and protect
some author data from unhelpful changes.  The need for this is primarily
driven by the browse interface for patrons.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1396764 - Stamping upgrade script
Michele Morgan [Thu, 27 Oct 2022 14:39:33 +0000 (10:39 -0400)]
LP1396764 - Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1396764 - Add Release Notes
Michele Morgan [Thu, 27 Oct 2022 14:10:19 +0000 (10:10 -0400)]
LP1396764 - Add Release Notes

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1396764 - Apply Hours of Operation Note Field to tpac
Michele Morgan [Thu, 27 Oct 2022 14:09:50 +0000 (10:09 -0400)]
LP1396764 - Apply Hours of Operation Note Field to tpac

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agolp1396764 - Hourse of Operation Note Field
Kyle Huckins [Mon, 4 Apr 2022 09:13:57 +0000 (09:13 +0000)]
lp1396764 - Hourse of Operation Note Field

- Add a note field to each day of the week for the Hours of Operation object
- Display any existing notes note in the OPAC after their specified day

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoAdd release notes for OS versions
Jane Sandberg [Thu, 27 Oct 2022 00:50:23 +0000 (17:50 -0700)]
Add release notes for OS versions

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1990969: Remove Ubuntu Bionic Beaver Installation Prerequisites
Jason Stephenson [Tue, 27 Sep 2022 13:38:58 +0000 (09:38 -0400)]
LP1990969: Remove Ubuntu Bionic Beaver Installation Prerequisites

Since Ubuntu Bionic Beaver (18.04) is soon EOL, remove it as a viable
installation target.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1947728: Remove Debian Stretch Prerequisites
Jason Stephenson [Mon, 22 Nov 2021 16:00:04 +0000 (11:00 -0500)]
LP1947728: Remove Debian Stretch Prerequisites

Since Debian Stretch is soon EOL, remove it as a viable installation
target.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1948946 release notes
Jane Sandberg [Thu, 27 Oct 2022 00:27:29 +0000 (17:27 -0700)]
LP1948946 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1948946 Block transfers on inactive funds
Tiffany Little [Thu, 14 Jul 2022 21:29:59 +0000 (17:29 -0400)]
LP1948946 Block transfers on inactive funds

If a fund is inactive, the Create Allocation and Transfer Money buttons will be disabled.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agolp1895706 release notes
Jane Sandberg [Thu, 27 Oct 2022 00:14:19 +0000 (17:14 -0700)]
lp1895706 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agolp1895706 - Unarchive Course Button handles correctly
Kyle Huckins [Sun, 20 Mar 2022 21:26:43 +0000 (21:26 +0000)]
lp1895706 - Unarchive Course Button handles correctly

- Ensure changes made in 1939994 are reflected properly
- Hide Archive Course button if Course is archived
- Hide Unarchive Course button if Course is active

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agolp1895706 Unarchive Old Courses
Kyle Huckins [Tue, 22 Feb 2022 17:26:59 +0000 (17:26 +0000)]
lp1895706 Unarchive Old Courses

- Add option to unarchive old courses
- Remove non-public Course Users when unarchiving course

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts

Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1953692: release notes
Jane Sandberg [Wed, 26 Oct 2022 04:33:02 +0000 (21:33 -0700)]
LP1953692: release notes

18 months agoLP1953692 follow-up: missing character
Jane Sandberg [Wed, 26 Oct 2022 04:31:16 +0000 (21:31 -0700)]
LP1953692 follow-up: missing character

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1953692 Angular Catalog Record Summary links should open in new tab
Michele Morgan [Fri, 29 Jul 2022 19:08:14 +0000 (15:08 -0400)]
LP1953692 Angular Catalog Record Summary links should open in new tab

Changes the link behavior in the Angular Catalog Record summary.

The following links now open in new tabs:

Title
Created By
Last Edited By
Jacket image
Course

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1411819 stamp upgrade script and add release notes
Jane Sandberg [Wed, 26 Oct 2022 04:08:04 +0000 (21:08 -0700)]
LP1411819 stamp upgrade script and add release notes

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1411819 follow-up: add a pgtap test
Jane Sandberg [Wed, 26 Oct 2022 03:59:04 +0000 (20:59 -0700)]
LP1411819 follow-up: add a pgtap test

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1411819: org setting to override PATRON_EXCEEDS_FINES penalty on renewals
blake [Fri, 11 Mar 2022 17:18:46 +0000 (11:18 -0600)]
LP#1411819: org setting to override PATRON_EXCEEDS_FINES penalty on renewals

Original commit ca3a554b71c0bbcd013baab0e4246ddae212d6fb

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1931737: Stamping upgrade scripts
Mike Rylander [Tue, 25 Oct 2022 15:51:04 +0000 (11:51 -0400)]
LP#1931737: Stamping upgrade scripts

Signed-off-by: Mike Rylander <mrylander@gmail.com>
18 months agoLP#1931737: Allow the delay of symspell updates
Mike Rylander [Fri, 13 May 2022 16:35:24 +0000 (12:35 -0400)]
LP#1931737: Allow the delay of symspell updates

This commit adds a new internal flag, auto-created at the time of need,
to control whether record ingest will cause immediate updates to the
symspell dictionary, or if those updates will simply be recorded for
later incorporation.  Inline symspell dictionary updates can cause
record updates to be logically serialized, impacting the preformance of
other tools used for batch reingest.

pingest.pl is changed to allow an administrator to make use of this
feature via the --delay-symspell command line flag.

NOTE: includes a minor fixup from blake@mobiusconsortium.org for a
syntax error.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: blake <blake@mobiusconsortium.org>
18 months agoLP#1931737: DYM can cause deadlocks w/ parallel ingest
Mike Rylander [Fri, 4 Mar 2022 15:38:12 +0000 (10:38 -0500)]
LP#1931737: DYM can cause deadlocks w/ parallel ingest

This patch causes all symspell dictionary updates to occur at then end
of metabib search field updates in one go, which allows Postgres' INSERT
... ON CONFLICT mechanism to properly lock and serialize changes when
necessary.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: blake <blake@mobiusconsortium.org>
18 months agoLP1993922 - Fix terminology Archival->Archiving
Michele Morgan [Mon, 24 Oct 2022 20:49:27 +0000 (16:49 -0400)]
LP1993922 - Fix terminology Archival->Archiving

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1993922: Course material delete should not delete other courses' materials
Jane Sandberg [Sat, 22 Oct 2022 22:43:10 +0000 (15:43 -0700)]
LP1993922: Course material delete should not delete other courses' materials

To test:
* Apply this patch
* Login to BR1 workstation
* Go to Admin - Local Admin - Course Reserves List
* Create two courses, Course 1 and Course 2
* Associate materials to both courses
* Archive Course 1
* Go to Course materials on Course 2 and note that
it still has all of its materials attached.

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP 1993534: Followup to replace deprecated command
Jason Boyer [Thu, 20 Oct 2022 21:32:09 +0000 (17:32 -0400)]
LP 1993534: Followup to replace deprecated command

Running ng xi18n manually complained that it's deprecated and extract-i18n
is the new hotness.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1993534: Command line flag usage for ng xi18n
Jane Sandberg [Wed, 19 Oct 2022 13:28:40 +0000 (06:28 -0700)]
LP1993534: Command line flag usage for ng xi18n

To test:

1) cd [Evergreen repo]/Open-ILS/src/eg2
2) npm install
3) npm run export-strings # should fail
4) Apply this patch
5) npm run export-strings # should successfully create a file in the locales directory

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
18 months agoLP1981746 follow-up: docs and makefile updates
Jane Sandberg [Thu, 20 Oct 2022 00:50:10 +0000 (17:50 -0700)]
LP1981746 follow-up: docs and makefile updates

The jammy target was merged after this PR was posted, so this commit adds the new dependency.
Also adds release notes and a small update to the docs

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1981746: add Geo::Coder::Bing to geosort application module
Llewellyn Marshall [Thu, 14 Jul 2022 19:15:58 +0000 (15:15 -0400)]
LP1981746: add Geo::Coder::Bing to geosort application module

Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1913604 - Stamping upgrade script
Michele Morgan [Tue, 18 Oct 2022 21:05:29 +0000 (17:05 -0400)]
LP1913604 - Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1913604: Course materials module should remember original circ_lib
Jane Sandberg [Wed, 14 Sep 2022 03:21:12 +0000 (20:21 -0700)]
LP1913604: Course materials module should remember original circ_lib

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1913604: course materials module shouldn't move items to different owning libs
Jane Sandberg [Thu, 19 May 2022 21:04:05 +0000 (15:04 -0600)]
LP1913604: course materials module shouldn't move items to different owning libs

To test:
1) Create a course that can have volumes (e.g. a branch or bookmobile, not a consortium)
2) Associate an item with that course that is from a different branch
3) Note that the item's owning and circ libraries have not changed.

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1913604: Alert staff when associating item with course at a different library
Jane Sandberg [Thu, 28 Jan 2021 22:26:19 +0000 (14:26 -0800)]
LP1913604: Alert staff when associating item with course at a different library

1) Create a new course at a branch that can have items (BR3, for
   example).
2) Add an item with the circ_lib of BR3. Note that the item is
   added to the grid.
3) Add an item with a different circ_lib. Note that you get an
   alert showing that the item is not at the course's owning library.
4) Push the Cancel button.  Notice that the item is not added to the
   course.
5) Repeat step 3 and push the Confirm button.  Notice that the item is
   added to the course this time.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1940105: Perl detach material correctly resets item location
Jane Sandberg [Sat, 3 Sep 2022 00:49:55 +0000 (17:49 -0700)]
LP1940105: Perl detach material correctly resets item location

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agolp1940105 Archive Course Should Use detach_material
Kyle Huckins [Sun, 27 Feb 2022 01:33:29 +0000 (01:33 +0000)]
lp1940105 Archive Course Should Use detach_material

- Replaced resetItemFields with detachMaterials in Course Service
- Refactored disassociateMaterials to utilize detach_materials
- Refacotred deleteSelectedMaterials to utilize Course Service detachMaterials function

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1898775: Add basket to bucket in bootstrap
Jane Sandberg [Wed, 12 Oct 2022 23:38:20 +0000 (16:38 -0700)]
LP1898775: Add basket to bucket in bootstrap

The bootstrap OPAC uses links, rather than <select> for the basket dropdown, so the
existing event listener couldn't get attached to the correct element.

To test:
1. Confirm that you are using the bootstrap OPAC.
2. In the staff client, select the traditional staff catalog.
3. Add several items to your basket.
4. Click the basket icon, and select 'Add Basket to Bucket'
5. Note that you get a 404 error.
6. Apply this patch.
7. Repeat steps 1-3.
8. Note that you can now select a bucket, and that the process completes successfully.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
18 months agoLP1980297 Booking:reservations page not formatted in bootstrap opac
Garry Collum [Thu, 7 Jul 2022 18:17:05 +0000 (18:17 +0000)]
LP1980297 Booking:reservations page not formatted in bootstrap opac

Formats the page's title and table in a consistent manner with other
pages in the bootstrap opac's myopac pages.  Also adds CSS so that
the correct labels are displayed on smallish screens.

To test.

1. Set ctx.show_reservations_tab in config.tt2 to true.
2. Create a couple of bookings for a patron and login to the opac as that
patron.
3. In the opac go to the reservations screen and notice the formatting.
Resize the screen to view the display on a small scale.
4. Apply the patch
5. Repeat 3 and now notice the page title and the table formatting. View
the table in a small screen.
6. Also view the reservations page as a patron with no bookings.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1501870: stamping upgrade script
Jane Sandberg [Fri, 14 Oct 2022 22:02:06 +0000 (15:02 -0700)]
LP1501870: stamping upgrade script

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP#1501870 - Remove invalid Z39.50 search attribute from LOC
Michele Morgan [Wed, 25 May 2022 14:02:13 +0000 (10:02 -0400)]
LP#1501870 - Remove invalid Z39.50 search attribute from LOC

Removes the 1001 Item Type attribute from seed date for LOC.

Also includes an upgrade script to remove the 1001 attribute from
config.z3950_attr.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1956619 Holdings editor sanity check for VIEW_USER perm
Bill Erickson [Mon, 11 Jul 2022 14:58:40 +0000 (10:58 -0400)]
LP1956619 Holdings editor sanity check for VIEW_USER perm

When the staff accessing holdings in the holdings editor do not have the
VIEW_USER permission at a level sufficient to display the creator/editor
of a set of items, display the ID of the user instead of attempting and
failing to display the username, which causes a page rendering error.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP#1956619: use Angular holdings editor when accessing from item status and item...
Jeff Davis [Fri, 21 Jan 2022 22:17:25 +0000 (14:17 -0800)]
LP#1956619: use Angular holdings editor when accessing from item status and item buckets

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1891375 Perm Group Editor Indicates Overridden Perms
Bill Erickson [Thu, 7 Jul 2022 16:29:22 +0000 (12:29 -0400)]
LP1891375 Perm Group Editor Indicates Overridden Perms

When a permission for the selected group overrides the same permission
applied to a parent group, indicate it in the permission list with an
icon.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1735221 Item Alert Prevents Hold Capture Delay Verification
Dan Briem [Thu, 4 Aug 2022 02:46:06 +0000 (22:46 -0400)]
LP1735221 Item Alert Prevents Hold Capture Delay Verification

Clicking OK on an item alert triggers a checkin override. If the
response contains an override event, an error is thrown. Since
a hold capture delay event is handled as an override, an error
throws before the hold capture delay dialog opens.

This handles the capture delay event separately from the override
events so the dialog will open after an override attempt.

To test:
1. set Hold Capture Requires Verification on a shelving location
2. add an item alert to an item in that shelving location
3. place an item hold on that item
4. checkin that item
5. click OK on the alert dialog and Capture on the delay dialog
6. note the hold is captured`

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1907495 release notes
Jane Sandberg [Fri, 14 Oct 2022 14:12:05 +0000 (07:12 -0700)]
LP1907495 release notes

18 months agoLP1907495 Adds PO ID as a column in Acq LI search
Tiffany Little [Wed, 20 Jul 2022 14:28:17 +0000 (10:28 -0400)]
LP1907495 Adds PO ID as a column in Acq LI search

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agolp1930896 - Course Reserves Carriage Return Shouldn't Add
Kyle Huckins [Wed, 9 Feb 2022 23:20:50 +0000 (23:20 +0000)]
lp1930896 - Course Reserves Carriage Return Shouldn't Add

- Removed Enter KeyUp property from the Patron Barcode field on Associate User
- Removed Enter KeyUp property from the Item Barcode field on Associate Item

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1821950, LP198049 - Stamping upgrade script
Michele Morgan [Thu, 13 Oct 2022 18:00:09 +0000 (14:00 -0400)]
LP1821950, LP198049 - Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1980409 require barcode in order to save
Terran McCanna [Tue, 20 Sep 2022 20:02:47 +0000 (16:02 -0400)]
LP1980409 require barcode in order to save

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1821950 & LP1980409 Option to require call number label
Terran McCanna [Fri, 19 Aug 2022 17:38:56 +0000 (13:38 -0400)]
LP1821950 & LP1980409 Option to require call number label

This uses a new Library Setting for "Require call number labels
in Copy Editor" for the benefit of libraries that with to use a
predefined Prefix (such as FIC or EZ) instead of individual call
number labels for each volume.

When the setting is True, the call number label field is marked
required and the Save buttons disabled until a value is present.

When the setting is False, the call number label is not required.
In addition, the Angular interface adds an additional check for
Prefix, so if the call number label is empty then the Prefix is
required.

Acknowledgements:
Org Unit Setting created by Kyle Huckins
Angular and AngularJS changes done by New Developers Working Group

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agolp1821950 Require Call Number Label YAOUS
Kyle Huckins [Thu, 16 May 2019 22:05:55 +0000 (22:05 +0000)]
lp1821950 Require Call Number Label YAOUS

- Add YAOUS to Require Call Number Labels in Copy Editor
- Set new YAOUS to true
- Don't display empty call number field warning if call numbers
aren't required on the copy editor.
- Properly enable/disable saving an item in the volcopy editor when
CN label is empty, based on Require Call Number Label setting.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.lp1821950-call-number-label-required-yaous.sql
modified:   Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1839341: stamp upgrade script
Jane Sandberg [Thu, 13 Oct 2022 16:10:43 +0000 (09:10 -0700)]
LP1839341: stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1839341 follow-up: no console error when reverting to unset value
Jane Sandberg [Thu, 13 Oct 2022 15:18:37 +0000 (08:18 -0700)]
LP1839341 follow-up: no console error when reverting to unset value

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1839341: Fix boolean save (and other issues)
Mike Rylander [Fri, 19 Aug 2022 17:28:52 +0000 (13:28 -0400)]
LP#1839341: Fix boolean save (and other issues)

This commit makes sure that YAOUSen of type 'bool' are saved as JSON
booleans rather than one of the strings "true" or "false".  A database
cleanup script may be useful to make sure that erroneously set values
from earlier iterations of this interface don't stick around and cause
problems.  A simple version of this would be:

UPDATE  actor.org_unit_setting
  SET   value = BTRIM(value,'"')
  WHERE value IS NOT NULL
        AND name IN (
                SELECT  name
                  FROM  config.org_unit_setting_type
                  WHERE datatype ='bool'
        );

Also addressed in this commit are linked field label display (see the
Acquisitions "Default copy location" setting) and a minor low-level call
that requests too-deep object fleshing.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1839341: Allow staff to fetch view_perm on settings
Mike Rylander [Fri, 19 Aug 2022 17:28:17 +0000 (13:28 -0400)]
LP#1839341: Allow staff to fetch view_perm on settings

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoHide the selection grid elements when selection is not allowed
Mike Rylander [Tue, 29 Mar 2022 19:11:09 +0000 (15:11 -0400)]
Hide the selection grid elements when selection is not allowed

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1839341: Really stop duplicates, and provide an initial sort order
Mike Rylander [Tue, 29 Mar 2022 19:11:55 +0000 (15:11 -0400)]
LP#1839341: Really stop duplicates, and provide an initial sort order

Duplicates snuck back in due to something firing the getRows function
multiple times, concurrently.  We avoid this problem by returning an
empty observable if we're already mid-fetch.

This commit also sorts the settings by group and label at load time.
Finally, we bring back the "change not visible" warning when editing
for a location other than the context org as a toast.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1839341 YAOUS editor batch operation improvements
Bill Erickson [Mon, 28 Mar 2022 20:31:01 +0000 (16:31 -0400)]
LP1839341 YAOUS editor batch operation improvements

* Apply batch updates serially to avoid large parallel batches.
* Replace manual JSON string compilation with JSON.stringify()
* Show progress dialog during batch updates / hide toasts since they
  occur too fast to read.
* Batch update avoids applying the value "0" for numerics when the value
  is null or undefined.
* Minor linting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1839341: Address sort, revert, and layout
Mike Rylander [Fri, 25 Mar 2022 17:00:23 +0000 (13:00 -0400)]
LP#1839341: Address sort, revert, and layout

Based on testing feedback, this commit:
 * improves the layout and styling of the Edit dialog buttons
 * adds the Description as a (hidden) column
 * enables sort/multisort on the main grid
 * corrects the logic of the Revert function
 * corrects the logic used when saving booleans

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1839341: Improve grid layouts
Mike Rylander [Wed, 2 Feb 2022 21:55:30 +0000 (16:55 -0500)]
LP#1839341: Improve grid layouts

Correctly hide the ID column on the history grid, and disable tooltips
on action columns in both grids.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP#1839341: Fix row duplication and linked field lookup
Mike Rylander [Wed, 2 Feb 2022 20:13:24 +0000 (15:13 -0500)]
LP#1839341: Fix row duplication and linked field lookup

The grid needed to be refreshed after a filter change to address
duplicated rows noticed in testing.  In addition, for settings with
typed linked objects, we need to look up the labeling column via the
selector attribute, or use the pkey, rather than assuming a "name"
column will exist.

There is an additional issue with setting typed linked objects in the
Edit dialog, but this is addressed in an enhancement to the core widgets
provided as part of the Simple Reporter work in LP#1945836.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoSeed Values Missing Parens and Consistency
Kyle Huckins [Wed, 10 Feb 2021 16:46:31 +0000 (16:46 +0000)]
Seed Values Missing Parens and Consistency

- Fix missing Parens in Seed Values
- Ensure added Seed Value is consistent with upgrade script

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoUpdate Workstation Setting to proper name
Kyle Huckins [Tue, 9 Feb 2021 22:13:32 +0000 (22:13 +0000)]
Update Workstation Setting to proper name

- Change update sql file to add admin.actor.org_unit_settings

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoSwitching Org Units properly removes wrong-OU data
Kyle Huckins [Tue, 9 Feb 2021 21:50:24 +0000 (21:50 +0000)]
Switching Org Units properly removes wrong-OU data

- When switching context locations, the grid reloads the data fully, ensuring no data from previously selected Org Unit displays where it shouldn't.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoAngular Library Settings Editor Touch-up
Kyle Huckins [Mon, 16 Nov 2020 20:50:37 +0000 (20:50 +0000)]
Angular Library Settings Editor Touch-up

- Remove case-sensitivity from Filter
- Ensure filter returns you to the beginning of the grid results when
  applying or clearing the filter.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1839341: Small tweaks to org unit settings UI
Jane Sandberg [Fri, 11 Sep 2020 00:24:22 +0000 (17:24 -0700)]
LP1839341: Small tweaks to org unit settings UI

* Changes Edit link into a button so that the modal opens
* Adds [flex] widths to grid columns
* Removes some unnecessary @Import statements
* Fixes lint errors

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1839341: Updating Angular Org Unit Settings for Ang10
Jane Sandberg [Thu, 10 Sep 2020 22:25:31 +0000 (15:25 -0700)]
LP1839341: Updating Angular Org Unit Settings for Ang10

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1838341: Double-Click Setting to open Edit Dialog
Kyle Huckins [Wed, 11 Dec 2019 22:44:33 +0000 (22:44 +0000)]
LP1838341: Double-Click Setting to open Edit Dialog

- Add an OnRowActivate to allow the Edit Dialog to open
when double-clicking a row on the Org Unit Settings Grid.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.component.ts

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agolp1839341 Minor Tweaks
Kyle Huckins [Mon, 25 Nov 2019 18:05:48 +0000 (18:05 +0000)]
lp1839341 Minor Tweaks

- Add aria-label to Filter Input
- Add Name column to settings grid
- Correctly Parse HTML links in setting descriptions
- Correctly clear Value column when deleting settings

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/amin/local/org-unit-settings/org-unit-settings.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.component.ts

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agolp1839341 - Item Location Integration
Kyle Huckins [Thu, 21 Nov 2019 19:52:43 +0000 (19:52 +0000)]
lp1839341 - Item Location Integration

- Integrate Item Location Selector for acpl-linked org
unit setting value editing in the Org Unit Setting Editor.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.module.ts

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agolp1839341 Port Org Setting Editor UI
Kyle Huckins [Tue, 13 Aug 2019 15:07:07 +0000 (15:07 +0000)]
lp1839341 Port Org Setting Editor UI

- Speedy Retrieval for display all Org Unit Settings (~6 seconds
instead of DOJO's 20)
- Implement org_unit.settings.history.retrieve API Call utilizing
CSTORE operations
- View and revert OU settings to specific changes
- Update Org Unit Setting context orgs and values
- Filtering of Org Unit Settings by string found in name, description,
label, and/or group fields of Org Unit settings
- Get history in properly descending order based on date_applied
field
- Strip surrounding quotes from new values in history log
- Add columns for Edit and History actions.
- Add sql changes to support workstation setting for org unit settings grid
- Port Import/Export Dialog for batch-modifying settings using a JSON string.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-setting-history-dialog.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-setting-history-dialog.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-setting-json-dialog.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-setting-json-dialog.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings-routing.module.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.module.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.ouSettings-grid-ws-settings.sql

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
18 months agoLP1991344 rxjs empty() function deprecated
Shula Link [Fri, 30 Sep 2022 13:22:54 +0000 (09:22 -0400)]
LP1991344 rxjs empty() function deprecated

Futureproofing for rxjs 8 and the deprecation of the empty() function.
All the references to empty() have been replaced with the EMPTY constant.
Places where empty() was imported without being used have been removed.

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agolp1992657 - fix broken NPM test
Chris Sharp [Wed, 12 Oct 2022 14:16:43 +0000 (10:16 -0400)]
lp1992657 - fix broken NPM test

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1838553 User Display Name
Michele Morgan [Wed, 12 Oct 2022 20:40:21 +0000 (16:40 -0400)]
LP1838553 User Display Name

Add preferred names to 'User Alias or Display Name'

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1838553 User Display Name
Terran McCanna [Mon, 4 Apr 2022 17:03:02 +0000 (13:03 -0400)]
LP1838553 User Display Name

This modifies the User Display Name to incorporate the Preferred
Name if present.

(Note: Ryan Eby did this work, I just put it into a git branch. I
have not tested it. - TMcCanna)

Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
18 months agoLP1981628 Third follow-up
Terran McCanna [Fri, 29 Jul 2022 16:36:33 +0000 (12:36 -0400)]
LP1981628 Third follow-up

The last follow-up had the inadvertent side-effect of hiding the
message directing the patron to contact their library if they had a
negative balance. My thought is that if there are negative bills then
the patron should see the alert to contact their library about them
regardless of whether or not online payments are allowed. So, this
additional followup separates that alert from the myopac_cc_allowed logic.

This also makes some minor display tweaks to the BooPAC:
- Applies the Bootstrap 'alert-warning' to the negative bills message
in the BooPAC.
- Adds a page header.
- Changes the styling and wording of the grocery charges heading to match
the circulation charges heading.
- Changes the styling of the grocery and circulation tables to be
consistent with each other.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
18 months agoLP1981628 follow-up to the follow-up
Jason Etheridge [Mon, 18 Jul 2022 19:02:54 +0000 (15:02 -0400)]
LP1981628 follow-up to the follow-up

Consolidate some of the logic to make it more clear what is happening,
leverage the existing myopac_cc_allowed boolean, and catch the
Pay All Charges button in the TPAC.  This also clears up some display
oddities and makes sure the non-payment labeling is being used.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
18 months agoLP1981628 Follow up to Stripe payment intents bug
Terran McCanna [Wed, 13 Jul 2022 20:12:36 +0000 (16:12 -0400)]
LP1981628 Follow up to Stripe payment intents bug

The bug fix for 1965579 only resolved the negative bills problem
for grocery bills. This follow up resolves the problem for
circulation bills as well.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
18 months agoLP#1989209: SSO Shibboleth logout/re-login
Mike Rylander [Fri, 9 Sep 2022 16:40:47 +0000 (12:40 -0400)]
LP#1989209: SSO Shibboleth logout/re-login

When using Shibboleth for SSO, and global logout is disabled, logging in
after logout on the same computer can fail with a 404-Not Found. The
problem is that we need to ignore our local "don't trust Shibboleth
login" cookie in this situation.

This change also means we need to delegate SP logout, in addition to
possible IdP and/or global logout, to the Shibboleth configuration.
Therefore we always redirect to the Shibboleth logout service on
Evergreen logout (when Shibboleth SSO is enabled), and SP, IdP, and
global logout is configured and mediated by the Shibboleth and IdP
configuration.

This commit modifies the meaning of the opac.login.shib_sso.logout YAOUS
such that it is only used to decide if Evergreen timeout-forced logouts
will cause a Shibboleth logout as well.  All user-initiated logouts will
now inform Shibboleth, and the Shibboleth configuration will determine
the SSO logout degree (SP, IdP, global).

See details at
https://shibboleth.atlassian.net/wiki/spaces/SHIB2/pages/2577072384/NativeSPLogoutInitiator
and the simpler configuration option of
https://shibboleth.atlassian.net/wiki/spaces/SHIB2/pages/2577072434/NativeSPServiceLogout
for information on the Shibboleth configuration required for your local
needs.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
18 months agoLP#1986479: (follow-up) do some refactoring
Galen Charlton [Fri, 9 Sep 2022 21:12:36 +0000 (17:12 -0400)]
LP#1986479: (follow-up) do some refactoring

- don't bother checking the reactor; instead, assume that
  if the event definition includes a context user path that
  evaluates to a discernable user record, there is reason
  to check for the user's preferred locale and for alternative
  templates
- make this section of code more idiomatic

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
18 months agoLP#1986479: fix lookup of user locale during A/T event processing
Galen Charlton [Fri, 9 Sep 2022 20:42:05 +0000 (16:42 -0400)]
LP#1986479: fix lookup of user locale during A/T event processing

This patch fixes an issue with the new user-locale-sensitive
alternate Action Trigger template selection that supports letting
patrons receive notifications in their preferred language. In
particular, it corrects an assumption that the event target is
the user itself. With the patch, the the event definition's
context user path is consulted to identify the relevant user.

To test
-------
[1] Set up a patron with an email address and check out an item.
[2] Use the Quick Receipt drop-down to attempt an email checkout
    receipt.
[3] No email will be generated an the event will fail. The logs
    should contain something like

    Can't use an undefined value as a HASH reference at
    /usr/local/share/perl/5.28.1/OpenILS/Application/Trigger/Event.pm
    line 518.
[4] Apply the patch and repeat steps 1 and 2. This time, the email
    should be sent (or, at least, the A/T event will be successfully
    processed).

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
18 months agoLP1934164 Grid context/duration date minor refactoring
Bill Erickson [Wed, 30 Jun 2021 17:46:45 +0000 (13:46 -0400)]
LP1934164 Grid context/duration date minor refactoring

Move some repeated code into a shared method.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1934164 egDueDate and egOrgDateInContext Angular pipes
Bill Erickson [Tue, 29 Jun 2021 17:50:56 +0000 (13:50 -0400)]
LP1934164 egDueDate and egOrgDateInContext Angular pipes

These support displaying dates in the timezone of a specified org unit.

Example:

{{circ.xact_start() | egOrgDateInContext:circ.circ_lib():circ.duration()}}

The format service also gets a dateOnlyIntervalField parameter to
display dates as dates or dates + time depending on whether the provided
duration is day-granular.

Also adds a handy pipe (egDueDate) which takes a circulation as its
value and collects the correct parameters to display the due date in the
correct time zone and with the correct dateOnlyIntervalField value.

Example:

{{circ | egDueDate}}

Includes Sandbox examples.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1904036 Angular date utility class
Bill Erickson [Wed, 30 Jun 2021 15:33:41 +0000 (11:33 -0400)]
LP1904036 Angular date utility class

Including functions for intervalToSeconds, localDateFromYmd, and
localYmdFromDate.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1942220: stamp upgrade scripts
Jane Sandberg [Sun, 2 Oct 2022 15:18:01 +0000 (08:18 -0700)]
LP1942220: stamp upgrade scripts

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1942220: follow-up: ng lint fixes
Jane Sandberg [Sun, 2 Oct 2022 13:52:29 +0000 (06:52 -0700)]
LP1942220: follow-up: ng lint fixes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1942220: follow-up: upgrade Node to 16.17.1
Jane Sandberg [Sun, 2 Oct 2022 13:46:23 +0000 (06:46 -0700)]
LP1942220: follow-up: upgrade Node to 16.17.1

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1942220 Catalog View/Place Orders uses new UI
Bill Erickson [Thu, 29 Sep 2022 15:27:28 +0000 (11:27 -0400)]
LP1942220 Catalog View/Place Orders uses new UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP1942220 Rebase fix and recover package lock file
Bill Erickson [Thu, 29 Sep 2022 15:03:38 +0000 (11:03 -0400)]
LP1942220 Rebase fix and recover package lock file

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP#1942220: (follow-up) fix issue with seed data
Galen Charlton [Tue, 30 Aug 2022 16:06:55 +0000 (12:06 -0400)]
LP#1942220: (follow-up) fix issue with seed data

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP#1942220: (follow-up) update package-lock.json
Galen Charlton [Tue, 30 Aug 2022 16:02:52 +0000 (12:02 -0400)]
LP#1942220: (follow-up) update package-lock.json

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP#1942220: fix a merging issue with eg-item-location-select
Galen Charlton [Tue, 30 Aug 2022 16:02:28 +0000 (12:02 -0400)]
LP#1942220: fix a merging issue with eg-item-location-select

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP#1570623: Exclude deleted copies from line item existing
Galen Charlton [Mon, 29 Aug 2022 22:35:15 +0000 (22:35 +0000)]
LP#1570623: Exclude deleted copies from line item existing

This is a rebase of a patch originally written by
Tiffany Little <tlittle@georgialibraries.org>

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP#1942220: release notes for Angular Acquisitions
Galen Charlton [Mon, 29 Aug 2022 22:30:32 +0000 (22:30 +0000)]
LP#1942220: release notes for Angular Acquisitions

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP#1981714: fix Dojo AutoFieldWidget initialization bug
Galen Charlton [Thu, 14 Jul 2022 16:12:59 +0000 (16:12 +0000)]
LP#1981714: fix Dojo AutoFieldWidget initialization bug

This patch fixes a bug where AutoFieldWidget wouldn't
invoke the callback when building an org unit selector. Fixing this
allows library settings (including acq.default_owning_lib_for_auto_lids
added in the previous patch) whose datatype is link and whose fm_class
is aou to work in the Dojo Library Settings editor.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
18 months agoLP#1981714: add settings to control owning library of auto-added LIDs
Galen Charlton [Thu, 14 Jul 2022 16:14:36 +0000 (16:14 +0000)]
LP#1981714: add settings to control owning library of auto-added LIDs

Previously, when line item copies/details/items where automatically created
because the provider's default copy count is non-zero, the owning library
of those line item copies was set to the workstation library. This patch
adds two new settings to tweak this behavior:

* How to set default owning library for auto-created line item items

Stategy to use to set default owning library to set when line item items
are auto-created because the provider's default copy count has been set.
Valid values are "workstation" to use the workstation library, "blank"
to leave it blank, and "use_setting" to use the "Default owning library
for auto-created line item items" setting. If not set, the workstation
library will be used.

* Default owning library for auto-created line item items

The default owning library to set when line item items are auto-created
because the provider's default copy count has been set. This applies if
the "How to set default owning library for auto-created line item
items" setting is set to "use_setting".

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>