working/Evergreen.git
10 years agoIn Dojo i18n script: create output directories if they don't exist
dbs [Mon, 7 Jun 2010 05:15:52 +0000 (05:15 +0000)]
In Dojo i18n script: create output directories if they don't exist

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16605 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFix up acq Dojo NLS file to be strictly JSON compliant
dbs [Mon, 7 Jun 2010 05:00:16 +0000 (05:00 +0000)]
Fix up acq Dojo NLS file to be strictly JSON compliant

simplejson chokes on non-compliant JSON:
  * Strings must be delimited in double-quotes
  * Joining strings with + is not allowed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16604 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCommit updates from Launchpad translation
dbs [Mon, 7 Jun 2010 03:48:07 +0000 (03:48 +0000)]
Commit updates from Launchpad translation

Bringing all of the translated files up to date with what is in Launchpad.
Next steps: generate all of the updates from trunk and add all the new files

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16603 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoNew function oilsUtilsIntervalToSeconds() to translate a string into a
scottmk [Sun, 6 Jun 2010 01:54:31 +0000 (01:54 +0000)]
New function oilsUtilsIntervalToSeconds() to translate a string into a
number representing the number of seconds in an interval of time.

Simple integers are converted directly.  Anything else is passed to
PostgreSQL to be translated as an interval string.

M    Open-ILS/include/openils/oils_utils.h
M    Open-ILS/src/c-apps/oils_utils.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16602 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoEmail/print methods for printing A/T templated bib information
phasefx [Fri, 4 Jun 2010 21:36:03 +0000 (21:36 +0000)]
Email/print methods for printing A/T templated bib information

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16601 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBugfixes: undef handling and legacy script support setting.
erickson [Fri, 4 Jun 2010 20:53:27 +0000 (20:53 +0000)]
Bugfixes: undef handling and legacy script support setting.

The legacy setting was a major bug.  It was not possible to disable legacy scripts
except by *removing* the setting.  That is, if you set it to 'false',
we failed to interpret that here in SIP to mean FALSE.  Instead we
looked at it as a non-zero-length string and therefore TRUE!

This patch also prevents warnings from unitialized values (undef concatenation), like:
Use of uninitialized value in concatenation (.) or string at /openils/lib/perl5/OpenILS/SIP/Patron.pm line 110.

Added a little formatting and whitespace cleanup to address display along w/ undef handling.

Corrected an error screen message also.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16600 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCheckin overhual for extensions, including item, patron and checkin underpinnings.
erickson [Fri, 4 Jun 2010 20:53:25 +0000 (20:53 +0000)]
Checkin overhual for extensions, including item, patron and checkin underpinnings.

Extensions fields added to AUTOLOADable content.

Also fix checkin logic to check for NO_CHANGE and SUCCESS at necessary moments.

Update new code to match berick's #16544.

Add AUTOLOAD to Item and provide a slot to store the raw EG hold object.
Store the hold data down on the item (not the Checkin transaction level).

Allow SIP Patron lookup by usr ID (not barcode).
This is important because we need supplemental data when we find holds info at checkin.
The change is backwards compatible (w/ just 1 arg  it will still be treated as a barcode).

Propagate $inst_id down into checkout core, needed for hold routing logic.

Remove old accessor methods, also make some of the settings checks more flexible w/ regex.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16599 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoExperimental implementation: renewal, block, enable.
erickson [Fri, 4 Jun 2010 20:53:24 +0000 (20:53 +0000)]
Experimental implementation: renewal, block, enable.

Add sip_renewal (not implemented), correct log message w/ join

Patron block message and patron enable

This adds code for enable, still experimental.  It also adds the
client's block message to the patron alert, bracketed by <sip> tags.
The tags are necessary because enable has to be able to regexp out
the block alert message (including user-specified variable text).

Remove unused vars.
Whitespace cleanup and extra feedback data.

Return object on failure, not just 0

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16598 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoLots of cleanup, logging improvements, and comments.
erickson [Fri, 4 Jun 2010 20:53:23 +0000 (20:53 +0000)]
Lots of cleanup, logging improvements, and comments.

One arrayref accessor updated to recommended style

Removed unused dependency.

Removed never-possible return statement.

Trying to use an arrayref in the log message results in a string like "ARRAY(0x2541870)".
I added a prebuilt string representation of the array for use in those messages.

More whitespace cleanup.
More flexible to_bool, extra comments;
Also added institution_id method.

Note: OpenILS::Event->new returns a hash, not a true object.

script_x_check.sh is executable.
Irony: this script could have been used to detect itself.

Typo in Cronscript POD.

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16597 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBasic check for missing DB upgrades
erickson [Fri, 4 Jun 2010 20:53:22 +0000 (20:53 +0000)]
Basic check for missing DB upgrades

Run this after a update_db.sh failure to see what failed.
Or run in before update_db.sh to make sure you are ready to apply
new updates.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16596 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd two little utility functions to convert from intervals to seconds.
scottmk [Fri, 4 Jun 2010 19:00:55 +0000 (19:00 +0000)]
Add two little utility functions to convert from intervals to seconds.

M    Open-ILS/src/sql/Pg/999.functions.global.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0293.function.interval-to-seconds.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16594 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothinko (unquoted string literal); be more explicity about circ lib comparisons
miker [Fri, 4 Jun 2010 15:07:13 +0000 (15:07 +0000)]
thinko (unquoted string literal); be more explicity about circ lib comparisons

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16593 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded granularity and user_data options to create_events_for_hook wrapper
erickson [Fri, 4 Jun 2010 13:28:37 +0000 (13:28 +0000)]
added granularity and user_data options to create_events_for_hook wrapper

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16590 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoImprove circ transaction performance by indexing NULL circs (Launchpad 587031)
dbs [Fri, 4 Jun 2010 03:54:14 +0000 (03:54 +0000)]
Improve circ transaction performance by indexing NULL circs (Launchpad 587031)

Creating a unique index on target_copy in the action.circulation table where
the checkin_time is NULL will increase the speed of circ transactions,
particularly on systems with a lot of traffic. The uniqueness also
ensures that a given item will not be able to be checked out multiple times
concurrently.

Thanks to James Fournie from BC Sitka for suggesting the index in Launchpad
bug 587031!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16589 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoImprove database performance for partial indexes on boolean columns (bug 587028 in...
dbs [Fri, 4 Jun 2010 03:29:03 +0000 (03:29 +0000)]
Improve database performance for partial indexes on boolean columns (bug 587028 in Launchpad)

PostgreSQL 8.3/8.4 treats "IS FALSE" and "= FALSE" expressions differently,
which can have a significant impact on database performance if an index is
created with one and a query uses the other. This patch addresses all existing
partial indexes on boolean columns to enable the query planner to use an index
scan whether the query uses either expression.

Thanks to James Fournie of BC Sitka for noticing the problem with the index
on asset.copy and opening bug 587028 in Launchpad with the suggested fix!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16588 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoVarious tweaks:
scottmk [Thu, 3 Jun 2010 20:02:39 +0000 (20:02 +0000)]
Various tweaks:

1. When resetting the timeout for a session: if the session object
carries an endtime, and the expiration time is within a designated
interval, extend the expiration time a bit instead of reapplying the
entire original timeout from the current time.

This feature is unreachable at the moment because it is designed for
persistent sessions, which aren't otherwise implemented yet.  The
purpose is to avoid rudely terminating an active session, but without
extending it too much.

2. Whenever possible, use integral types instead of doubles.

3. Instead of calling osrfCacheSetExpire(), call osrfCachePutObject()
directly, which does the same thing with less overhead.

4. Tinkered with white space and comments here and there.

M    Open-ILS/src/c-apps/oils_auth.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16586 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoimplemented a simple mechanism to allow for linking to record detail pages by ISBN...
erickson [Thu, 3 Jun 2010 19:56:53 +0000 (19:56 +0000)]
implemented a simple mechanism to allow for linking to record detail pages by ISBN.  If no record ID is present in the URL and the URL has a search type of isbn and an isbn value, do an ISBN lookup and display the first record we get back from the search.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16585 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoorg unit setting for requiring a matching email for password reset requests (no UI...
phasefx [Thu, 3 Jun 2010 19:33:11 +0000 (19:33 +0000)]
org unit setting for requiring a matching email for password reset requests (no UI support yet)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16584 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodisplay first name instead of usrname in self-check display as a security/obscurity...
erickson [Thu, 3 Jun 2010 17:30:48 +0000 (17:30 +0000)]
display first name instead of usrname in self-check display as a security/obscurity compromise

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16583 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoprevent warnings that occur when the event type is not defined
erickson [Thu, 3 Jun 2010 17:30:47 +0000 (17:30 +0000)]
prevent warnings that occur when the event type is not defined

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16582 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodocumentation cut-n-pasto ... authority records are not org-scoped
miker [Thu, 3 Jun 2010 14:56:08 +0000 (14:56 +0000)]
documentation cut-n-pasto ... authority records are not org-scoped

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16580 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd authority browsing framework to backend supercat app
miker [Thu, 3 Jun 2010 14:35:03 +0000 (14:35 +0000)]
add authority browsing framework to backend supercat app

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16579 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agotemplates and methods for generating payment receipts
phasefx [Thu, 3 Jun 2010 10:31:18 +0000 (10:31 +0000)]
templates and methods for generating payment receipts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16578 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix some id collisions and make use of properties instead of attributes for textboxes
phasefx [Thu, 3 Jun 2010 10:31:17 +0000 (10:31 +0000)]
fix some id collisions and make use of properties instead of attributes for textboxes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16577 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofaster Library Settings UI and progress dialog
phasefx [Thu, 3 Jun 2010 10:31:16 +0000 (10:31 +0000)]
faster Library Settings UI and progress dialog

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16576 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomore due date convenience options for offline mode, courtesy of Michael Peters, India...
phasefx [Thu, 3 Jun 2010 05:28:25 +0000 (05:28 +0000)]
more due date convenience options for offline mode, courtesy of Michael Peters, Indiana State Library

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16574 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoutil.list gets used in offline mode, so don't assume that we have fetched org unit...
phasefx [Thu, 3 Jun 2010 05:28:24 +0000 (05:28 +0000)]
util.list gets used in offline mode, so don't assume that we have fetched org unit settings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16573 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoDon't hardcode our password forms to en-US
dbs [Thu, 3 Jun 2010 04:25:51 +0000 (04:25 +0000)]
Don't hardcode our password forms to en-US

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16572 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoApache2::Const::DECLINED leads to ugly error dialogues. I'm OK, you're OK.
dbs [Thu, 3 Jun 2010 04:05:39 +0000 (04:05 +0000)]
Apache2::Const::DECLINED leads to ugly error dialogues. I'm OK, you're OK.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16571 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago< is not >; get our time-to-live threshold comparison correct
dbs [Thu, 3 Jun 2010 03:39:16 +0000 (03:39 +0000)]
< is not >; get our time-to-live threshold comparison correct

Also add a useful log entry to differentiate this not-active-request reason from the others

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16570 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSetting apache->status() caused 500 server errors for password reset requests
dbs [Thu, 3 Jun 2010 03:15:38 +0000 (03:15 +0000)]
Setting apache->status() caused 500 server errors for password reset requests

Don't do that.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16569 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agopassword reset URI needs a trailing slash, and this enables the aupr entry to be...
dbs [Thu, 3 Jun 2010 02:52:10 +0000 (02:52 +0000)]
password reset URI needs a trailing slash, and this enables the aupr entry to be created, but:

  * Server is now returning a 500 instead of 200, which causes an error dialogue
    to be displayed instead of "success!" and JavaScript errors to cascade
  * We don't want to hard-code the en-US locale; need to pull that from current locale

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16568 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agos/perl/javascript/
phasefx [Wed, 2 Jun 2010 22:46:02 +0000 (22:46 +0000)]
s/perl/javascript/

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16567 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix logic error that could result in partial list of available libs for workstation...
phasefx [Wed, 2 Jun 2010 22:39:16 +0000 (22:39 +0000)]
fix logic error that could result in partial list of available libs for workstation registration

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16566 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoUndouble these elements of password-reset that somehow doubled up during the forward...
dbs [Wed, 2 Jun 2010 21:36:34 +0000 (21:36 +0000)]
Undouble these elements of password-reset that somehow doubled up during the forward-porting from rel_1_6

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16565 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosome defensive programming
phasefx [Wed, 2 Jun 2010 21:34:55 +0000 (21:34 +0000)]
some defensive programming

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16564 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoReplace most of the serial schema with a different set of tables. Only
scottmk [Wed, 2 Jun 2010 19:24:14 +0000 (19:24 +0000)]
Replace most of the serial schema with a different set of tables.  Only
the serial.record_entry table remains unscathed.

In addition: a new table asset.copy_template.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/040.schema.asset.sql
A    Open-ILS/src/sql/Pg/upgrade/0288.schema.serial-overhaul.sql
M    Open-ILS/src/sql/Pg/210.schema.serials.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16563 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosome more API documentation for these password reset request methods
phasefx [Wed, 2 Jun 2010 18:46:24 +0000 (18:46 +0000)]
some more API documentation for these password reset request methods

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16562 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadding more non-auto Identifier specifiers
miker [Wed, 2 Jun 2010 18:02:06 +0000 (18:02 +0000)]
adding more non-auto Identifier specifiers

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16560 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agouse dojo.query instead of getElementsByTagName ... IE--
miker [Wed, 2 Jun 2010 17:42:40 +0000 (17:42 +0000)]
use dojo.query instead of getElementsByTagName ... IE--

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16559 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd class/instance methods for checking required-ness and validity of an object field...
miker [Wed, 2 Jun 2010 15:11:52 +0000 (15:11 +0000)]
add class/instance methods for checking required-ness and validity of an object field in JS FM implementation

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16557 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd class/instance methods for checking required-ness and validity of an object field...
miker [Wed, 2 Jun 2010 14:55:23 +0000 (14:55 +0000)]
add class/instance methods for checking required-ness and validity of an object field in perl FM implementation; also fixing typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16556 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoget rid of search.staged_fts() and supporting functions -- entirely replaced by searc...
miker [Wed, 2 Jun 2010 14:38:58 +0000 (14:38 +0000)]
get rid of search.staged_fts() and supporting functions -- entirely replaced by search.query_parser_fts(); deprecating only, no upgrade script required

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16555 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomade overly restrictive example validation regexp more generic -- just require at...
miker [Wed, 2 Jun 2010 12:48:40 +0000 (12:48 +0000)]
made overly restrictive example validation regexp more generic -- just require at least one character, instead of all upper-case ASCII

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16554 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd required IDL flag and validation regexp support
miker [Wed, 2 Jun 2010 02:43:32 +0000 (02:43 +0000)]
add required IDL flag and validation regexp support

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16553 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMake in-db hold checking consistent with circulation when it comes to
senator [Tue, 1 Jun 2010 21:04:39 +0000 (21:04 +0000)]
Make in-db hold checking consistent with circulation when it comes to
returning events with fail_part set.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16552 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMove credit card processing ML code into the circ module, removing API method
senator [Tue, 1 Jun 2010 20:35:21 +0000 (20:35 +0000)]
Move credit card processing ML code into the circ module, removing API method
for direct payment processing.  (Using open-ils.circ.money.payment with auth
can invoke CC processing).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16550 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoForward port r16547 from rel_1_6_0: fix regression in date formatting for non-due...
dbs [Tue, 1 Jun 2010 19:19:08 +0000 (19:19 +0000)]
Forward port r16547 from rel_1_6_0: fix regression in date formatting for non-due dates

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16549 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorid ourself of some namespace prefixes because IE is too braindead to understand...
miker [Tue, 1 Jun 2010 19:02:19 +0000 (19:02 +0000)]
rid ourself of some namespace prefixes because IE is too braindead to understand them

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16546 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRemove accidentally committed OPAC CC payment test code.
senator [Tue, 1 Jun 2010 17:38:21 +0000 (17:38 +0000)]
Remove accidentally committed OPAC CC payment test code.

Only the changes in payment.js and selfcheck.js were supposed to be commited
in 16542.  The opac changes themselves were only a rough test and aren't
seaworthy.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16545 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoin the SIP server plugin, don't connect and start a transaction by default with every...
erickson [Tue, 1 Jun 2010 17:21:31 +0000 (17:21 +0000)]
in the SIP server plugin, don't connect and start a transaction by default with every cstore handle.  only connect/begin when necessary.  also, making use of new CStoreEditor::init() call for setting up the editor environment when initial load was done before the IDL was available.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16544 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoIn OPAC CC payment, fall back on alert()ing events if onPaymentSubmit undef
senator [Tue, 1 Jun 2010 16:10:36 +0000 (16:10 +0000)]
In OPAC CC payment, fall back on alert()ing events if onPaymentSubmit undef

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16543 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoIncorporate CC payment interface into OPAC fines page (rough)
senator [Tue, 1 Jun 2010 15:59:25 +0000 (15:59 +0000)]
Incorporate CC payment interface into OPAC fines page (rough)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16542 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd support for GROUP BY.
scottmk [Tue, 1 Jun 2010 15:06:20 +0000 (15:06 +0000)]
Add support for GROUP BY.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16541 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd usr_setting_type of history.hold.retention_start for setting "opt-in" date of...
miker [Tue, 1 Jun 2010 14:48:11 +0000 (14:48 +0000)]
add usr_setting_type of history.hold.retention_start for setting "opt-in" date of holds retention

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16540 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosubstream for better performance with large datasets
phasefx [Tue, 1 Jun 2010 06:14:27 +0000 (06:14 +0000)]
substream for better performance with large datasets

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16539 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd support for BETWEEN conditions.
scottmk [Mon, 31 May 2010 19:45:26 +0000 (19:45 +0000)]
Add support for BETWEEN conditions.

M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16538 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago1. Add support for function calls. Note that certain functions have
scottmk [Mon, 31 May 2010 03:03:03 +0000 (03:03 +0000)]
1. Add support for function calls.  Note that certain functions have
peculiar calling syntax.  They will require special handling as exceptions,
and are not yet supported.

2. Add a bit of sanity checking for numeric and string literal expressions.

3. Eliminate the function_id member of Expression.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16537 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFor various updatable views based on query.expression:
scottmk [Sun, 30 May 2010 03:50:47 +0000 (03:50 +0000)]
For various updatable views based on query.expression:
add COALESCE to the insert rule so that we don't always
have to specify a value for the "negate" column.

Also: eliminate a harmless but annoying duplication of
the create statements for the query.expr_xbind view.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0286.schema.query-coalesce-negate.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16536 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoutilities for testing circ and ahr events
phasefx [Fri, 28 May 2010 21:35:04 +0000 (21:35 +0000)]
utilities for testing circ and ahr events

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16535 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago.print and .email event-firing variants of open-ils.actor.history.hold.visible and...
phasefx [Fri, 28 May 2010 21:35:04 +0000 (21:35 +0000)]
.print and .email event-firing variants of open-ils.actor.history.hold.visible and open-ils.actor.history.circ.visible

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16534 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agotemplates and methods for print/email of historical hold/circ lists
phasefx [Fri, 28 May 2010 21:35:03 +0000 (21:35 +0000)]
templates and methods for print/email of historical hold/circ lists

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16533 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded a wait flag to create_events_for_hook() to allow for processing large sets...
erickson [Fri, 28 May 2010 19:37:32 +0000 (19:37 +0000)]
added a wait flag to create_events_for_hook() to allow for processing large sets of objects without dropping all the calls on the network at once

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16532 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdded org_unit_setting_type auth.persistent_login_interval
scottmk [Fri, 28 May 2010 16:40:39 +0000 (16:40 +0000)]
Added org_unit_setting_type auth.persistent_login_interval

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0284.data.persistent-login-interval.sql
M    Open-ILS/src/sql/Pg/950.data.seed-values.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16531 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded duplicate username checking/warning
erickson [Fri, 28 May 2010 15:50:23 +0000 (15:50 +0000)]
added duplicate username checking/warning

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16530 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAPI calls to expose the circ/hold history stored procedures
erickson [Fri, 28 May 2010 14:19:21 +0000 (14:19 +0000)]
API calls to expose the circ/hold history stored procedures
moved circ chain summary creator code to apputils for sharing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16529 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorepaired misnamed function oils_json_to_string -> oils_json_to_text; updated funcs...
erickson [Fri, 28 May 2010 13:25:47 +0000 (13:25 +0000)]
repaired misnamed function oils_json_to_string -> oils_json_to_text; updated funcs to use the setting name provided by the seed data retention_start_date -> retention_start

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16528 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSupport IN lists.
scottmk [Fri, 28 May 2010 03:35:32 +0000 (03:35 +0000)]
Support IN lists.

M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16527 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSupport series expressions, i.e. a series of expressions
scottmk [Fri, 28 May 2010 01:46:29 +0000 (01:46 +0000)]
Support series expressions, i.e. a series of expressions
separated by operators or commas.  This construct will
be especially useful for chains of ANDs or ORs.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16526 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadding function to return holds visible to the user, based on their horizon settings...
miker [Thu, 27 May 2010 20:16:33 +0000 (20:16 +0000)]
adding function to return holds visible to the user, based on their horizon settings; fixing logic reversal in circ version of same

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16525 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoedi_message fetching for POs is just for counting, use id_list instead of full object...
erickson [Thu, 27 May 2010 18:47:48 +0000 (18:47 +0000)]
edi_message fetching for POs is just for counting, use id_list instead of full object fetching

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16524 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofunctions and settings for purging circs and user-settable circ memory horizon
miker [Thu, 27 May 2010 18:44:22 +0000 (18:44 +0000)]
functions and settings for purging circs and user-settable circ memory horizon

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16523 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofor some added privacy, display the user's username instead of their real name in...
erickson [Thu, 27 May 2010 18:42:08 +0000 (18:42 +0000)]
for some added privacy, display the user's username instead of their real name in the self-check welcome banner.  i18n-ified

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16522 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd new expression type 'xser' to represent series expressions,
scottmk [Thu, 27 May 2010 16:10:50 +0000 (16:10 +0000)]
Add new expression type 'xser' to represent series expressions,
i.e. a series of expressions separated by operators, such as a
chain of ANDed conditions.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0280.schema.query-xser.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16521 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded global_flag editing UI and staff client menu entry
erickson [Thu, 27 May 2010 16:04:46 +0000 (16:04 +0000)]
added global_flag editing UI and staff client menu entry

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16519 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorepaired bug in dojo.mixin usage for applying overrides. support for stying fields...
erickson [Thu, 27 May 2010 16:04:44 +0000 (16:04 +0000)]
repaired bug in dojo.mixin usage for applying overrides.  support for stying fields marked readOnly via override

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16518 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded note about new direction of opt-in circ history maintenance; minor cleanup
erickson [Thu, 27 May 2010 13:18:46 +0000 (13:18 +0000)]
added note about new direction of opt-in circ history maintenance; minor cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16517 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded Replace Barcode option into new patron reg. interface. Also added a basic...
erickson [Thu, 27 May 2010 13:18:45 +0000 (13:18 +0000)]
added Replace Barcode option into new patron reg. interface.  Also added a basic See All operation that shows all attached barcodes for a user, provides no editing capabilities

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16516 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBug fix in verifyObjectPCRUD().
scottmk [Thu, 27 May 2010 12:38:48 +0000 (12:38 +0000)]
Bug fix in verifyObjectPCRUD().

When traversing a chain of rows according to the "jump" attribute:
if you encounter a null foreign key, just stop looking, without
issuing an exception.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16515 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMinor whitespace/syntax changes, sifted out of the previous telephony commit.
senator [Wed, 26 May 2010 21:29:54 +0000 (21:29 +0000)]
Minor whitespace/syntax changes, sifted out of the previous telephony commit.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16514 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFoundations of Action/Triger-based telephony,
senator [Wed, 26 May 2010 21:26:55 +0000 (21:26 +0000)]
Foundations of Action/Triger-based telephony,
by Joe Atzberger and Lebbeous Fogle-Weekley

Just as described to the open-ils-dev mailing list on May 21, 2010, with a
whitespace/non-semantic-changes patch to follow.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16513 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agohave new patron editor honor global.password_regex
phasefx [Wed, 26 May 2010 20:32:51 +0000 (20:32 +0000)]
have new patron editor honor global.password_regex

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16512 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothese entities are no longer used
phasefx [Wed, 26 May 2010 20:32:50 +0000 (20:32 +0000)]
these entities are no longer used

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16511 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCorrecting some diverging drift in the usr_merge function
scottmk [Wed, 26 May 2010 19:03:25 +0000 (19:03 +0000)]
Correcting some diverging drift in the usr_merge function

M    Open-ILS/src/sql/Pg/999.functions.global.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0278.function.usr-merge-drift.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16510 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdding a qualifying schema name to keep PG happy
scottmk [Wed, 26 May 2010 18:57:06 +0000 (18:57 +0000)]
Adding a qualifying schema name to keep PG happy

M    upgrade/0277.schema.address_schema_drift.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16509 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoand, of course, the same typo /in/ the file. fixed
miker [Wed, 26 May 2010 18:07:46 +0000 (18:07 +0000)]
and, of course, the same typo /in/ the file. fixed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16507 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoarg ... typo in filename. moved
miker [Wed, 26 May 2010 18:07:04 +0000 (18:07 +0000)]
arg ... typo in filename. moved

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16506 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoafter nearly 280 schema updates, we had a little drift. this addresses upgrade vs...
miker [Wed, 26 May 2010 15:08:33 +0000 (15:08 +0000)]
after nearly 280 schema updates, we had a little drift. this addresses upgrade vs stock substantive differences

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16505 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBug fixes in verifyObjectPCRUD():
scottmk [Wed, 26 May 2010 13:27:29 +0000 (13:27 +0000)]
Bug fixes in verifyObjectPCRUD():

1. Don't throw an exception just because a foreign key is null.

2. When looking for local or foreign contexts, always do a lookup of
the current row, even if you already have an image of that row in
hand.  The image you have may not include the foreign key(s) you need.

The latter fix is simple but inefficient.  It should be possible to
avoid the extra lookup most of the time, and maybe all of the time,
for the search, retrieve, and id_list methods.  However that will
involve additional complications, not yet implemented.  Let's make
it correct first, and worry about efficiency later.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16504 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd actor.usr_password_reset table required for password reset functionality - missed...
dbs [Wed, 26 May 2010 01:35:37 +0000 (01:35 +0000)]
Add actor.usr_password_reset table required for password reset functionality - missed it in 0237.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16503 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothis doesn't work. I think my environment wasn't pristine when I pushed it
phasefx [Tue, 25 May 2010 21:27:52 +0000 (21:27 +0000)]
this doesn't work.  I think my environment wasn't pristine when I pushed it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16501 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremove duplicate line
phasefx [Tue, 25 May 2010 21:21:35 +0000 (21:21 +0000)]
remove duplicate line

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16500 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Bill Ott to add missing apostrophe in rdetail.js
erickson [Tue, 25 May 2010 20:51:47 +0000 (20:51 +0000)]
Patch from Bill Ott to add missing apostrophe in rdetail.js

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16497 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCorrecting an upgrade script.
scottmk [Tue, 25 May 2010 17:53:43 +0000 (17:53 +0000)]
Correcting an upgrade script.

The value column in actor.org_unit_setting should be valid JSON.  In this
revised version the new value is jiggered to make it a string instead of a
number.  This conversion is a bit simplistic and can be defeated by various
kinds of improbable input.

M    Open-ILS/src/sql/Pg/upgrade/0274.data.org-setting-type-est-wait.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16496 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoThe Great For-In Refactoring of ought-nine broke dojo trees built from opensrf object...
miker [Tue, 25 May 2010 16:51:16 +0000 (16:51 +0000)]
The Great For-In Refactoring of ought-nine broke dojo trees built from opensrf objects. this un-refactors that

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16495 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPlug some memory leaks, and eliminate some unnecessary
scottmk [Tue, 25 May 2010 16:21:56 +0000 (16:21 +0000)]
Plug some memory leaks, and eliminate some unnecessary
memory allocations.

In oils_utils.[ch]:

-- Create a new function, oilsFMGetStringConst(), similar to
oilsFMGetString() except that it doesn't allocate memory; it returns
a const pointer to a string internal to the specified object.

-- Add some comments, tidy up white space.

In oils_sql.c:

-- Replace oilsFMGetString() with oilsFMGetStringConst in a number
of places; partly to reduce memory churn, and partly to plug some
memory leaks where the function call was nested within a
parameter list.

-- Change org_tree_root() so as to return a const pointer to a
static buffer (which was already in use as a cache) instead of
allocating a copy of the string.  This change reduces memory
churn.  In addition the allocated string was leaking anyway, and
now that leak is plugged.

M    Open-ILS/include/openils/oils_utils.h
M    Open-ILS/src/c-apps/oils_sql.c
M    Open-ILS/src/c-apps/oils_utils.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16494 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosupport for calculating estimated hold wait time based on new circ estimated wait...
erickson [Tue, 25 May 2010 13:51:26 +0000 (13:51 +0000)]
support for calculating estimated hold wait time based on new circ estimated wait field

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16493 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded support for propagating searchOrg, searchSort, searchSortDir, searchLang, start...
erickson [Tue, 25 May 2010 13:51:25 +0000 (13:51 +0000)]
added support for propagating searchOrg, searchSort, searchSortDir, searchLang, startIndex, and count in openurl mapper

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16492 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoVarious changes to verifyObjectPCRUD():
scottmk [Tue, 25 May 2010 03:24:07 +0000 (03:24 +0000)]
Various changes to verifyObjectPCRUD():

1. Add numerous comments.

2. Check for nullity of local_context before dereferencing it.

3. If the lookup of a foreign row results in an empty result set, set
_param to NULL instead of pointing it to a JSON_NULL.  (Existing code
seems to assume such a policy.  This assumption was false, because
jsonObjectClone() never returns NULL.)

4. Instead of using jsonObjectClone() and then immediately destroying
the original, use jsonObjectExtractIndex() to pull an existing subobject
out of its surroundings.

5. In the loop implementing the "jump" attribute: plug a memory leak by
freeing _fparam before assigning it a new value.

6. In the loop that adds org unit contexts from a foreign row: take the
call to osrfHashGet() out of the loop condition, since its return value
is a loop invariant.

-----------

NOTE: This patch does *not* fix a known bug whereby we try to trace
foreign keys that are not present in the available row image.  The result
of the bug is that all id_list calls deny access in pcrud.  The same bug
can affect retrieve and search calls, if the call specifies a SELECT list
that doesn't include all the necessary foreign keys.

A fix for this bug will come later; fixing it now would make it harder to
test the current changes.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16491 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd settings group table, shared between org and usr settings, for labeling groups...
miker [Mon, 24 May 2010 20:08:20 +0000 (20:08 +0000)]
add settings group table, shared between org and usr settings, for labeling groups of settings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16490 dcc99617-32d9-48b4-a31d-7c20da2025e4