Garry Collum [Fri, 30 Oct 2020 19:55:35 +0000 (15:55 -0400)]
lp1902302 Opac. SMS and Carriers appear in Edit Holds Regardless of OU Setting.
The SMS Number field and Default Carrier field display when editing an
individual hold in the opac, regardless of the 'Enable features that send SMS text messages' setting.
This patch rectifies that behavior.
To test.
Set the 'Enable features that send SMS text messages' to False.
Place a hold for a patron.
Login to the opac as that patron and view the holds.
Edit the hold, and notice that the SMS and Carrier fields are displayed.
Apply the patch.
Refresh the edit form. The fields no longer display.
Set the 'Enable features that send SMS text messages' to True.
Refresh the edit form. The fields now display.
Jason Boyer [Fri, 30 Oct 2020 20:06:17 +0000 (16:06 -0400)]
LP1901710: Properly nest HTML tags and TT2 directives
This is a first pass at cleaning these up and the W3C's
HTML validator is a lot happier about some of the pages,
but the advanced search page at least needs some TLC.
I'm having trouble getting the shelving location selector
to appear at all and the aria complaints will require more
fixing.
Garry Collum [Thu, 25 Feb 2021 21:02:50 +0000 (16:02 -0500)]
LP1916936-Bootstrap opac: item tags display as separate copies on small screen.
This fixes the display of item tags and item notes in the bootstrap opac.
It also cleans up some <a> tags that had class defined twice.
To test.
1. Add an item tag and an item note to an item.
2. In the bootstrap opac make the screen as small as possible.
Notice that the display shows the tags and items as copies.
3. Apply the patch and repeat. The tags and notes should be displayed with the item that they are associated with.
Garry Collum [Tue, 5 Jan 2021 21:26:55 +0000 (16:26 -0500)]
LP1910288 Bootstrap opac: E-items lines always display in account summary.
The E-item summary of ckos and holds always display in the My Account Summary of the Bootstrap Opac
regardless of the ebook_api.enabled flag in config.tt2. This fixes that issue.
It also sets both the ebook_api.enabled and ebok_api.ebook_test.enabled flags to default to false.
To test:
1. Set ebook_api.enabled in config.tt2 to false.
2. Look at a patron's account summary and notice that it displays the e-item lines.
3. Apply the patch.
4. The E-item lines are now suppressed.
Garry Collum [Thu, 18 Mar 2021 17:49:32 +0000 (13:49 -0400)]
LP1920042 Bootstrap Opac: Simple Selector in Advanced Search
Fixes the simple selector in advanced search.
To Test:
1. Go to Administration - Server Administration - MARC Coded Value Maps
2. Assign the 'Is Simple Selector' option to some record attributes.
In concerto:
Lang - French, German
Type - Musical Sound Recording
Are good choices to test searching.
3. Notice in advanced search that these options no longer appear in the
Language or Item Type search filters.
4. Apply the patch.
5. The simple selector options should now appear at the top of each search
filter category.
6. Perform some searches using the simple selector options.
Jeff Davis [Mon, 26 Apr 2021 21:33:51 +0000 (14:33 -0700)]
LP#1923225: clean up some double-escaping of HTML in record display
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#1923225: have search highlighting stored procedure do HTML-escaping
This patch builds on the previous work to have the stored procedures
that produced highlighted and unhighlighted versions of display
attributes HTML-escape the source values, then adjusts the TPAC
and Bootstrap templates to avoid double-escaping.
Jeff Davis [Tue, 13 Apr 2021 23:05:41 +0000 (16:05 -0700)]
LP#1923225: fix handling of untruncated display fields in accordion
A previous commit used the TT2 "html" filter to escape strings to which the
accordion macro is applied, but which don't get truncated. But that's
incompatible with display fields, which contain embedded HTML and
therefore shouldn't be escaped in that way. This commit uses
HTML::Defang on untruncated accordion input instead (which is consistent
with how truncated strings are handled by the same macro).
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Briem [Thu, 20 May 2021 17:05:21 +0000 (13:05 -0400)]
LP#1928684 Catalog view holds tab sort by patron barcode error
This changes the Patron Barcode column name to ucard_barcode to
match the field name in the database.
Note: due to the name change, users who saved the column on the
grid will have to add it again.
To test:
1. Go to the View Holds tab on a record that has hold requests
2. Add the Patron Barcode column to the grid
3. Sort by the barcode column and note that it works
4. It's a good idea to test that the grid settings save properly
katiegmartin [Mon, 24 May 2021 19:52:32 +0000 (15:52 -0400)]
DOCS LP 1857917 Update glossary.adoc to include IDL
LP bug https://bugs.launchpad.net/evergreen/+bug/1857917
Add IDL definition to glossary, with synonym link to Fieldmapper IDL & change anchor point for F heading
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Tiffany Little [Sun, 17 Jan 2021 19:49:13 +0000 (14:49 -0500)]
LP1912097 Add timestamps
Adds timestamps to the date columns in Acquisitions Search.
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Mike Risher <mrisher@catalyte.io> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Dan Briem [Fri, 9 Apr 2021 22:19:02 +0000 (18:19 -0400)]
LP#1918362 Unchanged workstation settings applied on every checkin
* Stop attempting to save the Update Inventory setting on every
checkin - incorrect prefix & redundant (it's a modifier now)
* Stop saving the Strict Barcode setting on every checkin,
renewal, and checkout
* Save Strict Barcode on user interaction with its checkbox
To test:
1. confirm Strict Barcode and Do Inventory Update settings still
apply and are "sticky" on the Circulation->Checkin interface
2. confirm Strict Barcode still applies and is "sticky" on the
Circulation->Renew Items and Circulation->Checkout interfaces
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jeff Davis [Tue, 27 Apr 2021 18:25:50 +0000 (11:25 -0700)]
LP#1924185: use preferred name before legal name in My Account
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
When available, the preferred name is used as the main name in the
patron summary (rather than as a less-prominent field beneath the main
name). The legal name is displayed further down in the summary, just
after the ID fields.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Wed, 23 Sep 2020 15:15:22 +0000 (11:15 -0400)]
LP1881607 Angular catalog located URIs
Display in-range located URIs in the staff catalog record summary pane.
Also applies a fix to the staff catalog to clear cached record detail
summaries on new searches to ensure the correct org-scoped version of
the record summary is retrieved on each new navigation to the detail
page.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Display electronic resource links (MARC 856's) in the Angular staff
catalog. The extraction logic, which matches the TPAC, has been put
into its own API.
To test in concerto, navigate to:
/eg2/staff/catalog/record/208
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Garry Collum [Fri, 15 Jan 2021 22:38:35 +0000 (17:38 -0500)]
LP1873539 Active column in SMS carrier configuration
This fixes the lack of values displaying in the Active column of the
SMS Carrier configuration screen. (Administration->Server Administration->SMS Carriers)
To test apply the patch.
Go to the Carrier Configuration screen and note that the 'Yes' and 'No'
boolean values now display for the Active column.
Mike Risher [Mon, 20 Jul 2020 22:10:55 +0000 (22:10 +0000)]
lp1615800 Accessibility on Patron Pages
Modify patron search, patron search results, and patron edit pages so
that they are compatible with screen readers. aria-labelledby can be
used to associate input fields with their labels.
(Rebased to master)
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified: Open-ILS/src/templates/staff/share/t_patron_search_form.tt2
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Risher <mrisher@catalyte.io> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jason Boyer [Tue, 15 Sep 2020 13:41:30 +0000 (09:41 -0400)]
LP1895660: EGCatLoader/Search.pm
CGI::param called in list context from ...
this can lead to vulnerabilities
For any call to $cgi->param that happens in a list context we need
to verify 2 things: 1, that it is intentional (otherwise use scalar())
and 2, that we don't use the results in an unsafe manner.
For those situations where it's safe and a list is expected (join,
foreach, etc.) there is a $cgi->multi_param() that behaves the same way
but does not issue a warning on use in a list context.
An assumption was made that there will only be a single 'query'
parameter (see _prepare_biblio_search_basics) but if that should
instead be run through a join() that function will need to be updated.
For more details about the potential issues read
https://metacpan.org/pod/distribution/CGI/lib/CGI.pod#Fetching-the-value-or-values-of-a-single-named-parameter
Note that this change will likely require additional testing to
be sure there are no surprises.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Boyer [Tue, 15 Sep 2020 12:50:26 +0000 (08:50 -0400)]
LP1895660: Silence Perl Warnings
There are many perl warnings in make check and the day-to-day
logs when using Evergreen. This branch aims to address the
warnings and to make reviewing easier each file will be
individually committed with a small rationale for the changes
though it is assumed that this branch will be largely squashed
away if / when committed.
Booking.pm: Possible precedence issue with control flow operator
The precedence of 'or' is significantly lower than '||', so much so
that it can be less than the precedence for assignments.
Replace 'or' with '||' since they're equivalent in this case anyway,
and also add parens for flavor.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Garry Collum [Thu, 18 Mar 2021 19:56:04 +0000 (15:56 -0400)]
LP1917944-Hold Pickup Library sometimes Empty
Checks to make sure that the opac.default_pickup_location in usr_setting
has a value.
To test.
1. The patron must have a opac.default_pickup_location set to ""
2. Place a hold for this patron.
3. Notice that the pickup location is blank.
4. Apply the patch.
5. The hold pickup location should now be filled with the patron's home library.
To re-create this in concerto you may have to tweak the usr_setting table.
1. Assign a default pickup location to a patron.
2. Find the id field for the above in the usr_setting table.
select * from actor.usr_setting;
3. Update the setting.
update actor.usr_setting set value = '""' where id = <the id number>;
Dan Briem [Tue, 11 May 2021 00:08:42 +0000 (20:08 -0400)]
LP#1927527 Catalog: Root OU shelving locations do not display
When the top level org unit is selected in the staff catalog you
only have the option to search all shelving locations.
This allows you to filter on the root org unit's shelving
locations, which is the same behavior as the OPAC.
To test:
1. Make sure the top level org unit has shelving locations
(Local Administration->Shelving Locations Editor)
2. In the staff catalog, select the top level org unit
3. Click the three dot icon next to the query text input
4. The root org unit's shelving location options display
Dan Briem [Mon, 10 May 2021 02:27:38 +0000 (22:27 -0400)]
LP#1892435 Splash page catalog searches don't work with spaces
On older versions of Apache's mod_rewrite, splash page catalog
searches are escaped in JavaScript and escaped again during the
redirect to the Angular locale path, so searches with special
characters result in a search that's still encoded.
Test on Ubuntu 16.04.7, Apache 2.4.18, EG 3.6+. A splash page
catalog search for Harry Potter results in a search for
Harry%20Potter.
Add the NE (noescape) flag to the Angular locale path redirect
in /etc/apache2/eg_vhost.conf as indicated in this example file.
A splash page search for Harry Potter then works as expected.
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Dan Briem [Wed, 3 Mar 2021 18:21:22 +0000 (13:21 -0500)]
LP#1917495 Angular Catalog: Hold status in View Holds is not saved
To test:
1. Go to a record in the Angular catalog
2. Click the View Holds tab
3. If status col is visible, remove status col, and save grid
4. Add status col and save grid.
5. Refresh page and note status field didn't stay visible
6. Apply patch, repeat steps 1-5, note Status stays visible
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
The Angular catalog item table doesn't check UPDATE_COPY perm
before displaying an edit link. The back-end checks, so this is
a display issue only. This commit grabs a list of org Ids where
the user has UPDATE_COPY perm and checks the copy circ lib or
cn owning lib is in the list before displaying the edit link.
To test:
1. Search for a record with items you don't have perm to edit
2. Note the edit link shows on every item
3. Apply patch
4. Repeat steps 1-2
5. Note edit link displays if you have perm to edit
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Mon, 9 Nov 2020 21:59:59 +0000 (13:59 -0800)]
LP#1902965: HTML filter on OPAC search results and record display, with accordion
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/contents.tt2
Open-ILS/src/templates/opac/parts/record/summary.tt2 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jeff Davis [Mon, 9 Nov 2020 23:17:07 +0000 (15:17 -0800)]
LP#1902965: change format type in XML transform to avoid XSS in SuperCat
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jeff Davis [Mon, 9 Nov 2020 23:45:24 +0000 (15:45 -0800)]
LP#1902965: HTML filter on Bootstrap OPAC search results and record display
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Wed, 10 Feb 2021 19:51:55 +0000 (11:51 -0800)]
LP1873322: Angular Admin Pages default to workstation OU
To test:
1) Apply this patch.
2) Log in using a workstation at a particular org unit.
3) Open some of the following admin pages:
Local Admin > Address Alerts
Local Admin > Carousels
Local Admin > Group Penalty Thresholds
Local Admin > Course Reserves List > Terms Tab
Server Admin > Billing Types
Server Admin > Call Number/Volume Suffixes
Server Admin > Copy Tags
Server Admin > Hard Due Date Configuration
Acquisitions Admin > Cancel Reason Configuration
Acquisitions Admin > Claim Policies
Booking Admin > Resource Types
Booking Admin > Resource Attribute Values
4) Verify that these pages automatically open to your
workstation's org unit.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
projects / working / Evergreen.git / log