]> git.evergreen-ils.org Git - working/Evergreen.git/commit
LP1890822: incorporate feedback from review
authorJane Sandberg <sandbergja@gmail.com>
Tue, 13 Feb 2024 21:44:37 +0000 (13:44 -0800)
committerGalen Charlton <gmc@equinoxOLI.org>
Wed, 14 Feb 2024 14:30:23 +0000 (09:30 -0500)
commitd03f64f9abfb37714b029cce821cfd15f8fa56ec
treed6614195f3892a1ccd4f05d941ade036570c8a65
parentc7f7d82fca9215dcfa84e4ef5bbfac9bef03624c
LP1890822: incorporate feedback from review

* Put the penalty calculation in its own transaction, so
  applicable penalties remain on the patron account, even
  if the circulation is canceled.
* Don't hard-code a list of threshold-based penalties in
  the penalty calculation call.  calculate_penalties only
  concerns itself with threshold-based penalties anyway,
  so there was no need to enumerate them (and I missed
  two anyway).
* Update a comment to better match the new state of affairs.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
Open-ILS/src/perlmods/live_t/38-patron-exceeds-overdue-count.t