]> git.evergreen-ils.org Git - working/Evergreen.git/commit
LP1823041 Angular dialogs resolve on dismiss/cancel
authorBill Erickson <berickxx@gmail.com>
Wed, 3 Apr 2019 16:14:52 +0000 (12:14 -0400)
committerBill Erickson <berickxx@gmail.com>
Wed, 3 Apr 2019 16:19:11 +0000 (12:19 -0400)
commit120626a26b49e8965c60caec4b59600f7a33b96b
treea69ff104f8e5cbff04d89ea50d6bc598ec620636
parent12f53dda91af8cda5f19f2cec00716768c6413c6
LP1823041 Angular dialogs resolve on dismiss/cancel

Angular dialogs now only result in a promise rejection when an
unexpected error occurs.  Dismissing a dialog via Esc, Cancel button,
cross-click, body-click, etc. no longer result in a rejection.  In these
situations, the response value will be set to 'null' and a new boolean
field 'dismissed' on the dialog object will be set to true.

For the current code, this primarily affects confirm dialogs, which
previously rejected the dialog promise when the user selected the "do
not confirm" option.

Additionally, this commits add typescript support for "es2018.promise"
which allows us to start using Promise.finally() handlers.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Open-ILS/src/eg2/src/app/share/dialog/dialog.component.ts
Open-ILS/src/eg2/src/app/staff/admin/workstation/workstations/workstations.component.ts
Open-ILS/src/eg2/src/app/staff/cat/vandelay/match-set-list.component.ts
Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
Open-ILS/src/eg2/src/app/staff/catalog/record/parts.component.ts
Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.ts
Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.ts
Open-ILS/src/eg2/tsconfig.json