]> git.evergreen-ils.org Git - working/Evergreen.git/commit
LP1823367 Move away from "volume" moniker internally user/dbwells/lp1823367-ang-catalog-post-3.3-omnibus-rename
authorDan Wells <dbw2@calvin.edu>
Thu, 18 Jul 2019 19:20:39 +0000 (15:20 -0400)
committerDan Wells <dbw2@calvin.edu>
Thu, 18 Jul 2019 19:39:29 +0000 (15:39 -0400)
commit0aaa26930e628f4995bedcdf1eed3f31071d6f69
tree5937b4bcaecd511dfa485770c7c181dc0ed6aadd
parent8aacda800c027e36fdbd93c8c57fe4d034863608
LP1823367 Move away from "volume" moniker internally

It isn't really correct to use "volume" and "call number"
interchangeably.  This code substitutes various forms of the second
for various forms of the first within the internal variable and
function names.  To help contain the change, it tries to only do so
for values which are native to eg2, and not leaking from or into other
interfaces.

Understanding that this change is somewhat disruptive, I still think it
is in our overall best interest, as it will help us from falling into
old habits, and it will help future coders better understand the
relationship between the code and the interface.

Note, this code does not change any filenames.  This is for review
purposes to allow the changes to be more easily observed.  If accepted,
we should change couple of affected filenames as well.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html
Open-ILS/src/eg2/src/app/staff/catalog/record/actions.component.html
Open-ILS/src/eg2/src/app/staff/catalog/record/actions.component.ts
Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.css
Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.html
Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.ts
Open-ILS/src/eg2/src/app/staff/share/holdings/delete-volcopy-dialog.component.html
Open-ILS/src/eg2/src/app/staff/share/holdings/delete-volcopy-dialog.component.ts
Open-ILS/src/eg2/src/app/staff/share/holdings/holdings.module.ts
Open-ILS/src/eg2/src/app/staff/share/holdings/holdings.service.ts
Open-ILS/src/eg2/src/app/staff/share/holds/holds.service.ts