Mike Rylander [Fri, 5 Apr 2013 05:52:16 +0000 (01:52 -0400)]
Address SQL injection vulnerability in SQL ORM layer
If the user-supplied value and the db column are both numbers
(jsonObject->type == JSON_NUMBER, get_primitive(field) == "number") then
don't quote. Otherwise, quote.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Tue, 9 Apr 2013 17:45:24 +0000 (13:45 -0400)]
TPAC bucket item retrieval operates in streaming mode
TPAC bucket item retreive fleshes bib records with large blobs of MARC
data. When a bucket contains a few thousand items, the size of the
data passed around in atomic retreival mode will exceed the typical jabber
max stanza size and result in a failure. Retrieve the records in
streaming mode instead.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Steven Callender [Fri, 15 Jun 2012 17:27:33 +0000 (13:27 -0400)]
Avoid problems when auth recs are missing the 901c
Fixed the authority.normalize_heading function to better handle
INT's when there is no 901 present. Now we look for the best-fit
control set instead of throwing a db-level error.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Fri, 29 Mar 2013 17:36:17 +0000 (13:36 -0400)]
LP 1126545 repair staff 'return to results' tpac link
Strip the extra "/" from the URL created by the "return to results"
button in the staff client TPAC view. Havin the extra "/" in place
prevents the next/previous links from functioning.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Fri, 15 Mar 2013 18:47:53 +0000 (14:47 -0400)]
Allow access to public hold notes via hold "blob"
If a hold note is marked as "public", it seems reasonable that it
should be visible to anyone who can see that hold, regardless of
who created the note.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Dan Wells [Fri, 15 Mar 2013 18:42:24 +0000 (14:42 -0400)]
Fix reversed logic for hold "blob" notes
Hold notes (at least at the data level) allow for both staff and
"private" notes to be attached. This code intended to show "private"
notes to the hold owner and staff notes to staff, but had the logic
reversed.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Bill Erickson [Mon, 25 Mar 2013 19:19:14 +0000 (15:19 -0400)]
tpac : honor page locale in record detail copy grid
The query used to load the record detail copy grid now uses the same
locale value set as the default for all cstore-editor calls. This
solves the issue where copy location names, statuses, etc. are not
properly translated.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Fri, 22 Mar 2013 14:40:59 +0000 (10:40 -0400)]
More authority fixed-field cleanup
Even with the efforts by many to add and harmonize the authority fixed-field
setup, and maintain functionality, there were some missing bits. This commit
should take care of those by realigning the remaining field names and allwowing
those fields to be saved properly.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Changed the way authority tags were being pulled to specifically use an aggregate array.
There appears to have been a change in postgres at some point between 9.0 and 9.1
to the aggregate method. Because of this, postgres was not returning the proper
results when pulling tags for authorities. This change will force postgres to do
a proper aggregate array call and return the correct results.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 3 Aug 2012 19:08:51 +0000 (15:08 -0400)]
SIP re-login fetches correct auth session
After a login session expires and the SIP server logs in again to
acquire a new authtoken, be sure to use the new authtoken when fetching
the new session object. Otherwise, the login_session is left undef and
you may see errors like this when checking in items:
Can't call method "ws_ou" on an undefined value at
/usr/local/share/perl/5.10.1/OpenILS/SIP/Transaction/Checkin.pm line 77.
Incidentally, the checkin code is the only code that references
$sip_handler->{login_session}. And the problem listed above only occurs
when the login session expires just prior to a checkin call. In any
other scenario, the login_session would ultimately get repaired.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Jeff Godin [Thu, 14 Mar 2013 18:15:28 +0000 (14:15 -0400)]
Fix detection of empty Syndetics AC data elements
Due to a change in how the vendor responds to requests for data
elements which are not present for a requested title, we need to
change how we detect "empty" data elements in the "data_exists"
function.
First, we check for the new "No Data Available" title element, then
we check for the previously-used value of "error".
This change resolves the symptom where the catalog would display
tabs for "Author Notes", "Excerpt", "Table of Contents", on every
record in the catalog, even when clicking each tab would show that
the content was not present / available.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Fri, 22 Feb 2013 05:46:17 +0000 (00:46 -0500)]
LP1054322 - libparent-perl not needed for Ubuntu Precise
The newer version of Perl 5.14 which comes with Ubuntu Precise already
contains the contents of libparent-perl, which is now an obsolete package.
Remove this dependency from the extra debs installed for Debian and Ubuntu
but then add to the extras for Debian Squeeze and create a new extras just
for Ubuntu Lucid so that it continues to be installed on those systems and
not on Ubuntu Precise.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Ben Shum [Thu, 14 Mar 2013 21:40:04 +0000 (17:40 -0400)]
LP1103068 - Show titles and authors for pre-cat items
As noted in LP1103068, TPAC does not currently show anything when viewing a
pre-cataloged item in the my account summary of items checked out.
If the call number is -1 (pre-cat), then show the dummy title and dummy author
values, which fields are hopefully relevant as long as staff were good to put
something meaningful in those during creation of the pre-cat.
Also, wrap the title in a check for attrs.title.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Restore previous behavior to the maintain_901() trigger
function so that bib records that are loaded without
explicitly setting the TCN have it set to the bib ID
when the cat.bib.use_id_for_tcn global flag is set, rather
than 'AUTOGENERATED-xxx'.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Serials: printing routing slips fails with Javascript error
The symptom (an error in the Javascript console about dijit.form.Button
and an empty page for routing slips that you try to print at batch
recieve) may or may not be affected by whether you're in a production
environment with the pre-built dojo 1.3.3 package installed or a
development environment without it.
This simple fix makes the problem go away in any case.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Thu, 28 Feb 2013 20:32:07 +0000 (15:32 -0500)]
Fix holding lib for certain distribution svrs
On a serial virtual record (svr), the holding lib is expected to be
just an ID. In one logic branch, Search/Serial.pm was attaching the
entire aou object, and we should instead attach just the ID of this
object.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Michael Peters [Tue, 12 Mar 2013 20:14:23 +0000 (16:14 -0400)]
LP#1154235 Allow inactive patron barcode to be loaded
This addresses LP#1154235 by modifying the evergreen.get_barcodes
function to allow users to retrieve patrons in barcode retrieve
who have inactive barcodes.
This returns to functionality in versions prior to around 2.2.x
series.
End result is staff receiving an alert that the patron was
accessed with an invalid barcode.
Signed-off-by: Michael Peters <mpeters@emeralddata.net> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Sat, 9 Mar 2013 03:41:08 +0000 (22:41 -0500)]
Show OPAC-invisible copies in TPAC in staff context
We were not calling the staff variation of the copy count method; thus,
the record details template was skipping the copy table in the event
that all copies for a given record were marked as OPAC-invisible via
either copy visibility or shelving location visibility.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Thu, 28 Feb 2013 19:49:16 +0000 (14:49 -0500)]
Don't populate the MFHD menu with distributions
If a distribution has no legacy record, it shouldn't get a menu
entry in the MFHD menus. A magic id of '-1' is used to indicate
this case, so we need to check for that when populating
mfhdDetails via the TPAC.
Also, entryNum must be an int, not a string, because it is
incremented prior to display. Removing the quotes solves this
display issue.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Wed, 21 Nov 2012 15:12:39 +0000 (10:12 -0500)]
extract PO name from picklist upload
If a PO name is encoded in a lineitem (via provider attribute
definition), extract that PO name when creating a new purchase order
from lineitems that were previously only linked to a selection list.
This allows staff to create selection lists first, then orders second,
while retaining the encoded purchase order name.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Fix divergence of stock serials schema and upgraded schema
And additionally make a function used in a constraint on
serial.issuance.holding_code a little bit smarter.
These issues were reported to me by Galen Charlton.
The upgrade script included here will set serial.issuance.holding_code
to NULL in cases where the value doesn't validate, but in those cases
there is no part of Evergreen that could have made use of the data
anyway, and the data is just plain bad.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Exclude copies that have been deleted from showing up on the browse holds shelf list.
If an item had been deleted while it had a status of On Holds Shelf, it would permanently show up on
the browse holds list. This will exclude deleted copies from the results.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Tue, 5 Feb 2013 18:12:02 +0000 (13:12 -0500)]
LP#1116509: prevent null SVF attribute value from breaking record import
Fix problem where a record could fail to be staged for import
with the following error:
ERROR: query string argument of EXECUTE is null
CONTEXT: PL/pgSQL function "extract_rec_attrs" line 72 at EXECUTE statement
SQL function "extract_rec_attrs" statement 1
This error would be triggered if at least one SVF attribute has a normalization
function defined that is applied to a null value during record import.
Patch is based on a suggestion by Bob Wicksall.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Mon, 11 Mar 2013 17:40:46 +0000 (13:40 -0400)]
Reify required authority fixed field names
Adam (and Art, by way of Adam's patch) added a goodly pile of fixed
field definitions that were lacking previously. The change in this
commit simply changes the label of two (008/11 and 008/15) to those
in use by other parts of the code. In particular, internally, we call
the field holding a thesaurus code value "Subj" and use that name during
ingest of authority records. Therefore, that should not change. This
required a subsequent change to the label of another, to SubjUse.
I've included a duplication in the backend-only (probably deprecated)
version of this mapping to allow the front-end labels to work.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
This is consistent with commit's e675b854 change to the
OCLC labels, and also fixes a problem where changing the
008/11 and 008/15 was not reflected in the fixed field boxes.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Adam Bowling [Fri, 26 Oct 2012 14:59:54 +0000 (10:59 -0400)]
Add fixed fields missing from previous configuration, namely for MAP and SER record types. Incoporate previous changes for AUT record types from 1040381.
Signed-off-by: Adam Bowling <adbowling@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
This patch updates the seed data from the target list at
http://www.loc.gov/z3950/lcserver.html#addr. It also changes the
structure attribute for the 'lccn' search attribute to wordlist,
which means that LCCNs can be searched without having to enter
the leading spaces.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Galen Charlton [Sat, 19 Jan 2013 05:46:32 +0000 (00:46 -0500)]
LP#1086458: clean up after event listeners in circ/patron interface
Upon window unload, now removes event listeners, both ones explicitly
created by the page JavsScript as well as ones created by
util.list, util.controller, and persist_helper().
The same approach of defining cleanup fnctions used by unload
events can be applied to the rest of the staff client, but
this patch focuses on circulation first.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
EventListenerList allows one to maintain a list
of event listeners, then remove them all when it's
time to clean up a window.
Usage is:
var list = new EventListenerList();
// attach an event listener
list.add(node, 'command', function(ev) { alert('BOO!'); }, false);
...
// get rid of them
list.removeAll();
Based on an idea by Jason Etheridge.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Wed, 16 Jan 2013 20:05:17 +0000 (15:05 -0500)]
TPAC: Don't display serial headers without content
Currently, the TPAC serial display code will print a section
header, then see if there is any content to show. This causes
headers to show up when they are unnecessary or unwanted.
Now, we only show the header if we have content needing heading.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
The asset.merge_record_assets function was not checking for deleted call numbers
and merging items onto deleted call numbers that of course causes issues.
Signed-off-by: Steve Callender <stevecallender@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Tue, 26 Feb 2013 19:33:58 +0000 (14:33 -0500)]
Repair clear holds shelf transaction timeout
Initiate our cstore transaction after making the initial, potentially
long-running call to collect the clear-shelf holds to process.
Otherwise, the cstore transaction may time out while waiting on the
holds retrieval to complete.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Mike Rylander [Fri, 8 Feb 2013 15:15:39 +0000 (10:15 -0500)]
Speed up sorted-related-holds query
In several interfaces, we use a server side method which gathers statistics
about a hold: related holds, it's position in the (approximate) queue, the
estimated wait time, etc. Within this method is a relatively complicated
json_query that returns the list of related, (FIFO-ish) sorted holds -- ones
that could be filled by a copy which could fill the hold in question. This
commit restructures that query so as to make it faster when the list of
related holds is large, by removing duplicate (cartesian product, actually)
hold ids that were being fed into an INNER JOIN clause.
Testing shows a speed increase of 4x for related-hold queue of around 675
holds [~2s -> ~0.5s] on a relatively large Evergreen installation,
appropriately tuned. The speed improvement gets larger with longer queues.
There is no observed decrease in speed for smaller queue sizes.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Ben Shum <bshum@biblio.org>
In XML-RPC Gateway, substitute __ for - in method names
Dashes have never actually been valid in XML-RPC method names, and some
clients (like newer versions of Perl's RPC::XML) enforce this rule on
their clients. This way we give XML-RPC clients a way they can still reach
our methods.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Scott <dan@coffeecode.net>
Conflicts:
Open-ILS/src/extras/Makefile.install
Serials: change more carp() to croak() to avoid infinite loops
This addresses a problem very similar to that in LP #1075167, where
certain loops never end because problems with the data elicited calls to
carp(), which fills up log, but never gives our loops notice to end.
Visible symptoms include 1) a greate volume of log spew and 2) an
open-ils.serial drone that ties up a CPU.
The fault lies maybe in our loops rather than in the MFHD
package, but this fixes the problem fastest, and should not have
undesirable side-effects.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Ben Shum [Wed, 16 Jan 2013 21:33:22 +0000 (16:33 -0500)]
LP 1092284 - Fix add to my list dropdown with ContentCafe links
As noted in the bug ticket, the dropdown menu for Add to my list disappears
whenever hovering over the Reviews & More link for ContentCafe-enabled TPACs.
Removing position:relative from .results_review seems to keep the two areas
from having any strange interactions.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
EDIReader bugfix - Process misc charges better
MOA+304 seems to be an encoding peculiar to Ingram for processing fees.
Bubble up errors better from invoice processing
Errors were getting logged, but weren't linked on the related
acq.edi_message row in the database like they could have been to make
debugging easier.
This incidentally elevates one possible message from warning level to
error, but even as a warning it was stopping the processing of the
invoice in question there. So there's no meaningful difference.
Try harder to associate incoming EDI messages with exact right account
Sites use many very nearly identical EDI accounts (same host and
credentials) with different values only for the label and the vendcode.
This allows mapping of an order to a profile on the vendor side.
The problem with this is that the edi_fetcher and the processes it
kicks off did not know how to map incoming messages to the right
account based on vendcode. That code simply iterated through
accounts, using host information and login credentials, and grabbing
what it can find, as if
there will be no other Evergreen-side EDI "accounts" with the same
hostname and loging credentials.
This should help with that.
Style and whitespace cleanups in O::A::Acq::EDI.pm
All I could stand before I just couldn't take it anymore.
New PO template created malformed JSON in the INC_COPIES=0 case
And now it no longer should.
Allow order responses and invoices to omit PO repetition in lineitem refs
Usually vendor documents have bits of EDI that look like:
RFF+LI:100/123
where 100 is a PO number and 123 is a lineitem number.
Sometimes, for some documents, B&T at least will omit the '100/' part.
This is fine because we don't really need that number repeated for
every lineitem. We do need this change so that our EDI reader code
can deal with the omission, though.
Be more liberal reading EDIFACT message reference number
Spec, if I read it correctly, says that this is alphanumeric, not just
numeric, and ULS is one vendor I've seen taking advantage of letters
and numbers in that space.
This commit makes the relevant regex in our EDIReader appropriately
more tolerant.
Fixes to new vencode parsing for incoming EDI messages
Prevent problem in preventing EDI re-retrieves
The query we were using before would needlessly transfer large objects,
potentially hitting Jabber message size limits.
We're just testing for the existence of such objects, so we need no
more than a single ID in the result.
Fix EDI invoices for ULS, improve troubleshootability
1) Taxes appear in different, but still valid way in ULS invoices than
in invoices from other vendors observed to date.
2) Invoices from ULS use MOA 203 to indicate unit price instead of the
usual meaning of whole-lineitem price.
3) Now abuse acq.invoice.note to leave better troubleshooting
breadcrumbs.
Invoices from EDI had unsavable invoice_items attached
Deal with this by letting us create fund_debits a little later than in
the previous workflow. We have to, because the EDI-level stuff creating
the invoice doesn't know what fund we want to target for taxes and misc
charges.
The problem we're fixing manifested by showing an alert() dialog about
ACQ_FUND_DEBIT_NOT_FOUND.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Mike Rylander [Thu, 14 Feb 2013 15:51:37 +0000 (10:51 -0500)]
Sort search filter group entries by 'pos'
We use a fleshed cstore call to grab search filter groups and their entries,
but we don't currently sort them by their 'pos' field, which is it's purpose.
cstore will apply order_by expressions to the applicable tables in a fleshed
search/retrieve. This does that.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 21 Jan 2013 22:02:42 +0000 (17:02 -0500)]
TPAC: Make locale picker match default locale
As noted by Pasi Kallinen, the language picker would not reflect the
chosen locale unless your cookie had been set or there was an explicit
CGI parameter with the locale name.
Accordingly, get the default locale from the context vars and use that
to set the selected value for the language picker in the absence of
anything else, to prevent the picker from possibly confusingly showing
the first language alphabetically rather than the currently displayed
language in the rest of the UI.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Ben Shum <bshum@biblio.org>
LP #1092921: Display of/sorting by CN affixes in Simplified Hold Pull List
In the Simplified Hold Pull List interface, the "Call Number Label" column
displays the call number of the copy targeted by the hold in each row,
and it does so by combining affixes with the actual label field.
Sorting of this column actually uses the call number sortkey generated
in-database for this purpose.
Sometimes this means that sorting order doesn't match what you'd
expect to see with this column. Opinions differ on desired behavior, so
now you can explicity add columns to the table for call number prefix
and suffix, and sort on either of those (potentially in combination with
other columns).
Amended from an earlier version of this commit that still didn't sort
CN prefix and suffix columns quite right.
Mark Cooper [Tue, 16 Oct 2012 18:02:23 +0000 (11:02 -0700)]
LP#1067361: vandelay: batch queue deletion no longer works
Because window.location.reload can trigger before the deletions
have occurred. Simple fix (band aid?) is to make the delete
calls in sync.
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Tue, 29 Jan 2013 05:27:55 +0000 (00:27 -0500)]
LP1054053 - Remove white padding around login inputs
Forget efforts to make the boxes bigger and smoother as it was in the past.
Instead, opting for a cleaner look by removing the extra white background
that was part of the padding surrounding the actual login input area. This
removes the feeling that the box area should have been bigger than it really
is.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Every item in KPAC that doesn't have a jacket cover uses
the cover for "Mirror Mirror". This is inappropriate, so
lets replace it with a small blank image.
Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Etheridge [Thu, 20 Sep 2012 17:10:15 +0000 (13:10 -0400)]
LP1053526 - Don't inadvertently modify the in-memory org tree when printing
To see an example of this causing a problem, load Holdings Maintenance for
an arbitrary bib record with items. Make sure the Hide Empty Libs checkbox
is checked. Hit the Print button at the bottom of the UI (it's okay to then
Cancel the print). Then hit Refresh. It should result in an org.children()
is null error.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Kathy Lussier [Thu, 31 Jan 2013 15:51:40 +0000 (10:51 -0500)]
Copy_offset and copy_limit shouldn't persist in URL
Added copy_offset and copy_limit to stop_parms definition so that they
don't persist in URL when returning to search results or launching
subject/series searches.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Ben Shum <bshum@biblio.org>
Serials: Caption/pattern wizard use enum fields for chronology when no enum
MFHD spec says that when there are no ‡a - ‡f enumeration captions, any
chronology captions should move back from their usual ‡i - ‡m places
back into enumeration space.
The predictions engine we already have deals with this better than with
the wrong patterns we were creating before, e.g.:
853 20 ‡81 ‡i(year) ‡j(month) ‡wm
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
projects / Evergreen.git / log