miker [Fri, 10 Dec 2010 17:21:09 +0000 (17:21 +0000)]
Patch from James Fournie to address https://bugs.launchpad.net/evergreen/+bug/622908 wherein we learn that related item physical description might be used as the main PD of the main item, if the main item lacks such a field in the MARC
dbs [Thu, 9 Dec 2010 04:45:29 +0000 (04:45 +0000)]
Enable Ingest to ingest multiple located URIs for a single org-unit at once
Previous logic incorrectly restricted a given bib record to have one located
URI per org-unit - unless you reingested it multiple times, each time adding
one more URI per org-unit.
We also add the strict pragma and adjust some syntax accordingly.
senator [Fri, 3 Dec 2010 15:29:38 +0000 (15:29 +0000)]
Be consistent with a misspelled field. Credit to Robert Soulliere for pointing
out my mistaken understanding of where this was already fixed and where it
wasn't.
senator [Thu, 2 Dec 2010 21:16:39 +0000 (21:16 +0000)]
Belated backport of r18688 from trunk
Booking: fix bug reported by Robert Soulliere wherein the items associated
with picked-up reservations didn't actually get their status set to 'checked
out' like they should have.
Robert reported this bug on Launchpad (#672748) and provided a patch, but
there were some neighboring bugs in the circulation logic anyway, so they've
all been fixed together.
Update: Robert and I aren't yet actually certain whether this fixed the problem
when using legacy circ scripts. Investigation continues on Launchpad.
senator [Tue, 30 Nov 2010 15:53:18 +0000 (15:53 +0000)]
Backport some booking related commits from trunk.
r17563: Booking: stop the "new resource type" dialog from executing a naughty
query
The dialog will no longer offer a field for selecting a bibliographic record,
but then again you wouldn't need it. Bibliographically-based resource types
can be set up through a context menu option in the staff OPAC browser, whereas
this interface is only suited to non-bib-based resource types, like meeting
rooms, laptops, etc.
--
r17980: more transaction cleanups
--
r18502: Booking: make the circ module avoid booking code if the booking service
isn't up
Previously, it was not possible to turn the booking service off and have
working circ. Now you should be able to turn it off if you don't need it.
--
r18514: If we already know we're not using booking, skip a redundant and
expensive test for the possibility of capturing a hold. We're just going to
try actually doing it a little farther down.
--
r18580: Patch from Steve Callender to address a booking-related collection
agency reporting problem
dbs [Mon, 15 Nov 2010 22:32:04 +0000 (22:32 +0000)]
asset.uri needs a seed entry for queries of its ID values
To fix a problem with ingesting URIs, Ingest.pm was changed to reflect
the maximum asset.uri.id value rather than the asset.call_number.id
value. However, with no entries in asset.uri, the query returned a
NULL object which broke ingest entirely. Adding a seed entry avoids
this problem.
gmc [Wed, 10 Nov 2010 13:30:39 +0000 (13:30 +0000)]
do not use TRUNCATE when refreshing reporter.materialized_simple_record
Previous behavior would break Slony replication after doing a
bib load. Since a deletion is slower than a truncate, if you're
not using Slony replication, you may prefer to truncate rmsr
prior to calling reporter.enable_materialized_simple_record_trigger.
gmc [Fri, 5 Nov 2010 17:02:59 +0000 (17:02 +0000)]
fix user password reset request time column def
Needs to be a timestamp with time zone; fixes a bug
where it was interpreted as a UTC time, throwing off
the calculation of the expiration of the password reset
request.
gmc [Thu, 28 Oct 2010 16:15:35 +0000 (16:15 +0000)]
adjust user tests that get done when retargeting holds
Fixes bug where a user having the maximum number of
active hold requests allowed to them by policy would
prevent items from being targeted to fill their requests.
dbs [Thu, 28 Oct 2010 15:22:48 +0000 (15:22 +0000)]
Backport r18516: Ensure call numbers are returned to the holdings editor in ascending sorted order
James Fournie in https://bugs.launchpad.net/evergreen/+bug/635121 reported
that call numbers were being displayed in the order that they had been
added to the database, rather than in sorted call number label order.
Although I have been unable to reproduce this problem on two different
test systems, the patch he provided for 1.6.1 (which fixes the problem on their
test system) shouldn't hurt other systems.
dbs [Wed, 27 Oct 2010 02:25:48 +0000 (02:25 +0000)]
Prevent ingest errors when asset.uri ID value outstrips asset.call_number
We were basing IDs in asset.uri on the max ID of asset.call_number,
which occasionally led to major ingest problems as attempts to insert
the next ID into asset.uri failed because that ID already existed. Using
the max ID from asset.uri for asset.uri inserts seems to make more sense
and does resolve that problem.
The bigger problem of not using the sequences that are already on these
tables to generate the IDs will not be an issue in 2.0, when we move to
in-database ingest and can use the normal lastval() approach to populate
asset.uri_call_number_map with the new values.
gmc [Thu, 21 Oct 2010 14:54:44 +0000 (14:54 +0000)]
improve call number sorting
oils_text_as_bytea now does uppercasing in addition
to converting strings to bytea, working around
the limitation that json_query can't stack transforms
dbs [Fri, 8 Oct 2010 03:26:59 +0000 (03:26 +0000)]
Avoid scary SSL / HTTPS errors in Apache configuration
When port 443 is the last listener port, Apache generates lots
of "unknown protocol speaking not SSL to HTTPS port!?" errors in
the logs - which are scary, but harmless. Putting port 80 last
avoids those errors entirely, per http://wiki.apache.org/httpd/InternalDummyConnection
phasefx [Mon, 4 Oct 2010 17:32:09 +0000 (17:32 +0000)]
prevent repeat renderings of opac sidebar (relevant subjects, authors, etc.) in Firefox. What's happening is that the rresultHandleMods is not firing immediately with each record retrieve, and so we get a flurry at the end where resultPageIsDone() returns true for all of them, triggering the allRecordsReceived event more than once. So now at the end of the first allRecordsReceived event chain, we set a global variable, and have these render functions check to see if it has been set.
* all potential capturable copies are now checked (up to the first
one that is permitted for the request), instead of a small random
subset of them
* don't do redundant permission checks
Forward-port of a patch from Steve Callendar, via James Fournie, via launchpad:
When the patron.password.use_phone is set, new patrons are created with their password set to the last 4 digits of their phone number, HOWEVER, when a patron's password is reset, it does not work properly. Although the little underlined summary shows the proper 4 digits, the password box displays 9-ish digits, and is not the last 4 digits of the password.
The attached patch was created by Steve Callender and is confirmed working on 1.6.0
This patch will not work on 2.0 as that has a new user editor, but it would presumably be worthwhile to verify this functionality works in that editor as well.
Update version stamp for Evergreen service, adopting branch convention from trunk
http://hostname/gateway?service=open-ils.actor&method=opensrf.open-ils.system.ils_version
was returning "1-5" for a number of systems we checked; in trunk, we have adopted the
"x-y" convention for branches, so in the 1.6 branches we will follow the "x-y-z"
approach for a little more clarity.
Backport just the bib-source setting portion of r17403
When importing a set of records from Vandelay, the bib source selection widget
on the Vandelay screen should actually affect the biblio.record_entry.source
value of the imported records.
dbs [Fri, 13 Aug 2010 19:11:38 +0000 (19:11 +0000)]
Grant permissions related to booking/reservations to circulators and admins
This should make for a better out-of-the-box experience for Evergreen adopters.
The permissions in the upgrade script are outside of the transaction to avoid
rolling back the entire upgrade if a site has already assigned these
permissions.
TODO: Document the new permissions as part of the 1.6.1 release notes so
that sites can alter the upgrade script according to their desires if they
don't like the defaults.
dbs [Thu, 12 Aug 2010 18:21:55 +0000 (18:21 +0000)]
Show the "Active?" checkbox as part of the required (minimal) set of fields
As we're registering users, it's probably a good idea to ensure that staff
can set the user to active at the same time that they enter the minimal
patron information.
dbs [Thu, 12 Aug 2010 17:50:32 +0000 (17:50 +0000)]
Enable "Delete address" button to work in rel_1_6
In some ways the inverse of r17023, the else clause that enabled
the delete button to be enabled was never being reached because
the preceding clauses caught all cases.
Moving it outside of the foreach() loop entirely seems to resolve the problem.
dbs [Thu, 12 Aug 2010 07:45:11 +0000 (07:45 +0000)]
Remove broken old JavaScript in Google Book preview code
I /think/ this was supposed to change the title of the "Preview" link to
"Read this online" or the like in the case that the full text is available,
but it was relying on a function that didn't exist (setText) and trying
to reference an ID that didn't exists. So it broke in those rare cases
where Google Books did provide the full text.
gmc [Tue, 10 Aug 2010 21:22:22 +0000 (21:22 +0000)]
bug 592777: allow authoritative version of open-ils.circ.retrieve
Part of a fix to avoid race condition that can occur
when patron renews an item in the OPAC in a database
that uses pgpool and replication, which sometimes
results in an erroneous 'action_circulation_not_found' error.
dbs [Mon, 9 Aug 2010 13:15:26 +0000 (13:15 +0000)]
Patch from Ben Ostrowsky <ben@esilibrary.com> to specify "staff account" in proxied pages
This change will make it a bit more clear that we're not looking for a
patron barcode/PIN in the Selfcheck Login screen (and make the wording
consistent across similar login pages).
gmc [Fri, 6 Aug 2010 20:38:07 +0000 (20:38 +0000)]
bug 532217: work around caching issue resulting doubled title display
Quick hack shamelessly borrowed from Dan Scott to fix problem
of title being displayed twice on bib details page when back
button is used in OPAC or staff client.
This is a temporary fix in lieu of rewriting the bib details
display to use BibTemplate exclusively.
gmc [Fri, 6 Aug 2010 01:22:39 +0000 (01:22 +0000)]
bug 614150: bail out on ACTOR_USER_NOT_FOUND
This fixes a bug where uploading an offline checkout
that refers to a missing patron returns an INTERNAL_SERVER_ERROR
instead of ACTOR_USER_NOT_FOUND. More generally, this avoids
an exception in case case where a circ operation is made
without checking the existence of the patron record beforehand.
Get the 1.6.0.4-1.6.0.5 updates into the rel_1_6/rel_1_6_0 stream
This may end up in someone who has followed the entire 1.6.0.x
upgrade train applying these two updates twice, but it shouldn't
hurt - and ensures that someone who jumped to 1.6.1.0 or 1.6.1.1
gets these important updates.
r15562 contained a fix for this to rel_1_6_0, but apparently I never
forward-ported that "fix". Unfortunately, this leads to broken interfaces in
the i18n build (bug re-found by Robert Souilliere in the 1.6.1.1 release).
senator [Mon, 28 Jun 2010 21:35:59 +0000 (21:35 +0000)]
Patch from Don McMorris. Good catch, Don.
He writes:
In the branch rel_1_6 version of 950.data.seed-values.sql [1], lines
138-142 create the OU setting
'circ.booking_reservation.default_elbow_room' via the query:
INSERT INTO actor.org_unit_setting (org_unit, name, value) VALUES (
(SELECT id FROM actor.org_unit WHERE parent_ou IS NULL),
'circ.booking_reservation.default_elbow_room',
'"1 day"'
);
However, it appears that actor.org_unit does not start to get
populated until line 853. As such, the "SELECT id FROM actor.org_unit
WHERE parent_ou IS NULL" portion of the insert will return NULL, and
actor.org_unit_setting.org_unit has a 'NOT NULL' contraint - as such,
the insert fails.
erickson [Mon, 14 Jun 2010 16:14:23 +0000 (16:14 +0000)]
removed unused method retrieved from method_lookup. apart from being unused, the call was attempting to fetch a nonexistent method ('auth' vs. 'authority') and hilarity ensued
erickson [Fri, 11 Jun 2010 13:50:24 +0000 (13:50 +0000)]
added a number of info messages to the action/trigger runner and server code. the messages provide summary data about what event defs / hooks are being processed and when/if they complete or timeout.
projects / Evergreen.git / log