Jason Boyer [Tue, 15 Sep 2020 12:50:26 +0000 (08:50 -0400)]
LP1895660: Silence Perl Warnings
There are many perl warnings in make check and the day-to-day
logs when using Evergreen. This branch aims to address the
warnings and to make reviewing easier each file will be
individually committed with a small rationale for the changes
though it is assumed that this branch will be largely squashed
away if / when committed.
Booking.pm: Possible precedence issue with control flow operator
The precedence of 'or' is significantly lower than '||', so much so
that it can be less than the precedence for assignments.
Replace 'or' with '||' since they're equivalent in this case anyway,
and also add parens for flavor.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Garry Collum [Thu, 18 Mar 2021 19:56:04 +0000 (15:56 -0400)]
LP1917944-Hold Pickup Library sometimes Empty
Checks to make sure that the opac.default_pickup_location in usr_setting
has a value.
To test.
1. The patron must have a opac.default_pickup_location set to ""
2. Place a hold for this patron.
3. Notice that the pickup location is blank.
4. Apply the patch.
5. The hold pickup location should now be filled with the patron's home library.
To re-create this in concerto you may have to tweak the usr_setting table.
1. Assign a default pickup location to a patron.
2. Find the id field for the above in the usr_setting table.
select * from actor.usr_setting;
3. Update the setting.
update actor.usr_setting set value = '""' where id = <the id number>;
Dan Briem [Tue, 11 May 2021 00:08:42 +0000 (20:08 -0400)]
LP#1927527 Catalog: Root OU shelving locations do not display
When the top level org unit is selected in the staff catalog you
only have the option to search all shelving locations.
This allows you to filter on the root org unit's shelving
locations, which is the same behavior as the OPAC.
To test:
1. Make sure the top level org unit has shelving locations
(Local Administration->Shelving Locations Editor)
2. In the staff catalog, select the top level org unit
3. Click the three dot icon next to the query text input
4. The root org unit's shelving location options display
Dan Briem [Mon, 10 May 2021 02:27:38 +0000 (22:27 -0400)]
LP#1892435 Splash page catalog searches don't work with spaces
On older versions of Apache's mod_rewrite, splash page catalog
searches are escaped in JavaScript and escaped again during the
redirect to the Angular locale path, so searches with special
characters result in a search that's still encoded.
Test on Ubuntu 16.04.7, Apache 2.4.18, EG 3.6+. A splash page
catalog search for Harry Potter results in a search for
Harry%20Potter.
Add the NE (noescape) flag to the Angular locale path redirect
in /etc/apache2/eg_vhost.conf as indicated in this example file.
A splash page search for Harry Potter then works as expected.
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Dan Briem [Wed, 3 Mar 2021 18:21:22 +0000 (13:21 -0500)]
LP#1917495 Angular Catalog: Hold status in View Holds is not saved
To test:
1. Go to a record in the Angular catalog
2. Click the View Holds tab
3. If status col is visible, remove status col, and save grid
4. Add status col and save grid.
5. Refresh page and note status field didn't stay visible
6. Apply patch, repeat steps 1-5, note Status stays visible
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
The Angular catalog item table doesn't check UPDATE_COPY perm
before displaying an edit link. The back-end checks, so this is
a display issue only. This commit grabs a list of org Ids where
the user has UPDATE_COPY perm and checks the copy circ lib or
cn owning lib is in the list before displaying the edit link.
To test:
1. Search for a record with items you don't have perm to edit
2. Note the edit link shows on every item
3. Apply patch
4. Repeat steps 1-2
5. Note edit link displays if you have perm to edit
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Filters and localization functions don't mix. Assign the html filtered
title to a temp var first.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jeff Davis [Mon, 9 Nov 2020 23:17:07 +0000 (15:17 -0800)]
LP#1902965: change format type in XML transform to avoid XSS in SuperCat
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jeff Davis [Mon, 9 Nov 2020 23:45:24 +0000 (15:45 -0800)]
LP#1902965: HTML filter on Bootstrap OPAC search results and record display
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jeff Davis [Mon, 9 Nov 2020 21:59:59 +0000 (13:59 -0800)]
LP#1902965: HTML filter on OPAC search results and record display
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Wed, 10 Feb 2021 19:51:55 +0000 (11:51 -0800)]
LP1873322: Angular Admin Pages default to workstation OU
To test:
1) Apply this patch.
2) Log in using a workstation at a particular org unit.
3) Open some of the following admin pages:
Local Admin > Address Alerts
Local Admin > Carousels
Local Admin > Group Penalty Thresholds
Local Admin > Course Reserves List > Terms Tab
Server Admin > Billing Types
Server Admin > Call Number/Volume Suffixes
Server Admin > Copy Tags
Server Admin > Hard Due Date Configuration
Acquisitions Admin > Cancel Reason Configuration
Acquisitions Admin > Claim Policies
Booking Admin > Resource Types
Booking Admin > Resource Attribute Values
4) Verify that these pages automatically open to your
workstation's org unit.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jane Sandberg [Fri, 18 Dec 2020 16:57:04 +0000 (08:57 -0800)]
LP1907979: Fix Search by Instructor setting lookup in OPAC
Previously, the Search Courses screen in the OPAC relied on a locg
param in the URL to determine whether or not to display the "Search
by Instructor option", defaulting to location id 1 if no such param
exists. However, we can also consult physical_loc and other settings
to get a more accurate idea of which library's setting we need here.
To test:
1) In the Library settings editor, set Course Materials Module Opt In
to true for BR1.
2) In the Library settings editor, set Search by Instructor to true
for BR1.
3) In eg.conf, add the line:
SetEnv physical_loc 4
4) Restart httpd
5) Go to your OPAC. Note that the OPAC is at the BR1 level, and that
course search and browse options are available.
6) Click Search courses.
7) Note that only two values are available in the qtype dropdown: Course
Name and Course Number.
8) Apply this patch.
9) Repeat steps 5-6.
10) Note that the screen now appropriately consults the value for the
"Search by Instructor" setting at the BR1 level, with an "Instructor"
value now available in the qtype dropdown.
Jason Boyer [Fri, 12 Mar 2021 19:28:12 +0000 (14:28 -0500)]
Revert the effects of both LP1687545 and LP1914116
Revert "LP1687545: Force TT CGI plugin to use ampersands in query strings"
and "LP1914116: Apply html filter to mkurl() output"
until a fix for LP1918470 is available.
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Jane Sandberg [Sat, 23 Jan 2021 00:33:15 +0000 (16:33 -0800)]
LP1907977: Display course name and number in course material editor
To test:
1) Go to Administration > Local > Course List
2) Make sure you have a variety of courses added.
3) Double click on a course that already has materials
attached to it.
4) Go to the materials tab.
5) Select a material and choose Edit
6) Note that the Course combobox shows both the course
number (HST243) and course name (History of Indonesia).
7) Note that you can blank out that field and type to
complete to get other courses in the same format.
This is a shot term change intended to prevent the "I don't know how
to filter" default message from showing up when the datatype 'interval'
is filtered.
Jason Boyer [Tue, 9 Feb 2021 18:06:32 +0000 (13:06 -0500)]
LP1895679: Simplify and genericize the refund policy
Don't refrence the "email above" since that's not always
the case and simplify the languge slightly, though most
users will still likely want to customize it.
Mike Risher [Thu, 22 Oct 2020 20:19:51 +0000 (20:19 +0000)]
LP1843969 Composite Attribute Entry Defs
Create a port of the Coded Value Maps UI from Angular JS to
Angular. Allow creation and edits of the Composite Attribute
Entry Definitions.
Signed-off-by: Mike Risher <mrisher@catalyte.io> Signed-off-by: Jason Boyer <boyer.jason@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Terran McCanna [Thu, 25 Feb 2021 14:58:23 +0000 (09:58 -0500)]
LP#1916904 Bootstrap OPAC: Call number on Search Results Page
This adds the call number to the search results page when
"Show More Details" is not selected. (This brings back the same
behavior as the pre-bootstrap OPAC.)
In the record bucket administration UI, the act of adding or removing
items from a bucket are now done in batch to avoid too many parallel
requests.
These changes include new batch create/delete API calls that can operate
on any bucket type, so other UI's can be similarly batched as needed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Mike Risher [Thu, 7 Jan 2021 19:55:45 +0000 (19:55 +0000)]
LP1871510 Update Interface Titles
Update titles on several local admin interfaces so that they match the page listing all Local Admin interfaces.
Signed-off-by: Mike Risher <mrisher@catalyte.io> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Tue, 9 Feb 2021 16:10:41 +0000 (11:10 -0500)]
LP1908743 Hold pickup lib does not require have-users; repairs
To match the TPAC, only disable org units where can_have_vols is false
in the hold pickup library selector (plus those explicitly disabled via
setting).
Also fixes a thinko in the settings retrieval code.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Mon, 11 Jan 2021 19:15:33 +0000 (14:15 -0500)]
LP1908743 Staff catalog honors org-not-pickup-lib
In the Angular staff catalog, disable org units in the pickup library
selector that have the 'opac.holds.org_unit_not_pickup_lib' org unit
setting applied, plus those that have false values for can-have-users or
can-have-vols.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Mike Rylander [Fri, 14 Aug 2020 19:35:10 +0000 (15:35 -0400)]
LP#1858114: Fix thinko in template-parameter collection
Minor thinko in the use of Array.prototype.concat() when gathering the
"where" and "having" template parameters -- concat() does not alter the
array it is called on, so we need to assign the result back to the
array.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Mike Rylander [Fri, 14 Aug 2020 14:35:06 +0000 (10:35 -0400)]
LP#1858114: Record template filter values for aggregate columns
Currently the "having" clause does not record template-level filter
values in the template, but forces use of a report-level parameter.
This commit allows "having" to receive a value in the same way that
"where" does.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Mike Rylander [Thu, 13 Aug 2020 17:05:19 +0000 (13:05 -0400)]
LP#1858114: Present proper input widget for aggregate parameters
There's currently logic to override the filter widget for all columns
that have a selector defined, such as the ID column of many tables. When
we transform the column with an aggregate transform, though, we don't want
to pick a particular selector-labeled value.
While I can imagine using a min or max aggregate to get a representative
value for a group, when other dependent filters would make the value
stable or where the value in particular doesn't matter but isn't needed
in a count (say), all the other aggregate transforms that are currently
supported are specifically numeric (sum, average, count, and
count_distinct). Because of that, and the most likely use case of
matching a count to "0" or "1", we should only present the "remote
object widget" for non-aggregates, and just use the baseline text string
input here.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Previous to this commit, the item display order for carousels was
undefined. Now, ordering is stable and predictable.
For Newly Cataloged Item and Newest Items by Shelving Location
carousels, the order is from most recently cataloged to least
recently cataloged.
For Recently Returned Item carousels, the order is from most recently
returned to least recently returned.
For Top Circulated Items carousels, the order is from most circulated
to least circulated.
For Manual carousels (as of now, without the ability to adjust the
Position of items) it is the order they are added to the backing bucket.
Thus emptying and refilling the bucket allows reordering.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Mike Rylander [Thu, 30 Jul 2020 15:48:46 +0000 (11:48 -0400)]
LP#1772955: Only include xacts with balance in summary
This commit adds a new view and IDL definition that shows the total
owed/paid/balance for transactions that have a balance other than 0.
This new view is used in the patron summary bar, and access is provided
wherever the all-open-transactions version is available in case we want
to move to the new one elsewhere.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Zavier Banks [Thu, 5 Mar 2020 16:19:49 +0000 (16:19 +0000)]
LP1670457 Action Menu Grid Selection Change
I reworked the grid to disable certain actions, if
an item was needed. However, if there were actions, were
there was no item needed, they would still be available.
Bill Erickson [Mon, 14 Sep 2020 14:52:05 +0000 (10:52 -0400)]
LP1468132 MARC search honors search scope
Adds a 'Results from All Libraries' checkbox to the MARC search form in
the Angular staff catalog. When unchecked, the MARC search will limit
to results with holdings in the search scope.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Bill Erickson [Mon, 14 Sep 2020 15:33:45 +0000 (11:33 -0400)]
LP1468132 Staff MARC Search API supports copy filtering
Teaches the MARC search code to filter results on records with items
attached (though not necessarily opac-visible) for scoped staff
searches. Prior to this patch, the scope of staff searches was
effectively ignored.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Jason Boyer [Mon, 8 Feb 2021 19:20:32 +0000 (14:20 -0500)]
LP1914116: Apply html filter to mkurl() output
Because of the way that mkurl() generates its query parameters they're
generally escaped correctly, but nowhere do we run the output of mkurl()
through the html filter to correctly handle ampersands. Rather than adding
"|html" to every invocation of mkurl, it's just added to the macro directly.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Garry Collum <gcollum@gmail.com>
Galen Charlton [Thu, 10 Dec 2020 22:23:47 +0000 (17:23 -0500)]
LP#1474029: teach Evergreen how to prevent expired staff from logging in
This patch adds the ability to prevent staff users whose
accounts have expired from logging in. This is controlled
by the new global flag "auth.block_expired_staff_login", which
is not enabled by default. If that flag is turned on, accounts
that have the `STAFF_LOGIN` permission and whose expiration date
is in the past are prevented from logging into any Evergreen
interface, including the staff client, the public catalog, and SIP2.
It should be noted that ordinary patrons are allowed to log into
the public catalog if their circulation privileges have expired. This
feature prevents expired staff users from logging into the public catalog
(and all other Evergreen interfaces and APIs) outright in order to
prevent them from getting into the staff interface anyway by
creative use of Evergreen's authentication APIs.
Evergreen admins are advised to check the expiration status of staff
accounts before turning on the global flag, as otherwise it is
possible to lock staff users out unexpectedly.
Bill Erickson [Wed, 9 Dec 2020 19:04:52 +0000 (14:04 -0500)]
LP1907115 MARC editor avoid ID collisions
Generate DOM IDs for editable content components via incrementing int
instead of a random int. This addresses cases where records with higher
numbers of MARC fields could result id DOM ID collisions, leading to
empty subfield values.
Also remove use of Renderer2, which is considered harmful and overkill
for simple document.getElementById()-equivalent calls.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Mon, 7 Dec 2020 18:28:56 +0000 (10:28 -0800)]
LP1907115 MARC editor correctly absorbs breaker changes
MARC editor now correctly extracts MARC field data from the new
underlying MARC record when it is changed as a result of a breaker text
change and re-absorb.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Lp 1913219: Use window.open for staff catalog edit link
To avoid the "Scripts may close only the windows that were opened by
them" console message in Chrome 88, and a similar message in Firefox
84, when clicking "Save & Exit" in the Volume/Copy editor of the
AngularJS staff client after opening it via the "edit" link in the
copy table of the TT OPAC record summary, we use an onclick handler
with window.open instead of a standard href in the edit anchor.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Tue, 8 Dec 2020 20:33:13 +0000 (12:33 -0800)]
LP1907286 Staff catalog sets last retrieved record
Navigating to the detail page for a bib record in the Angular Staff
Catalog now correctly sets the value for the
'eg.cat.last_record_retrieved' local storage item, allowing Retrieve
Last Bib Record to work as expected.
Garry Collum [Mon, 14 Dec 2020 17:48:13 +0000 (12:48 -0500)]
LP1906858 Carousels Ignore Deleted Flag
Adds logic to look for the copy deleted flag in the carousel queries.
To test in concerto, it is easiest to create one item on three or four bibs
and assign the same org unit and location code to these items.
Check the items in. Check the items out, and then check them back in at their home OU.
Create 4 carousels. Newly Catalogued Items, Recently Returned Items, Top Circulated Items, and Newest Items by Shelving Location.
Make sure the carousels pull from the item library for which the items belong,
and set the owner to CONS. Select and add the correct shelving location.
Refresh the carousels. In the edit dialog box of each carousel, you can click the Link to bucket link to see the titles in the bucket.
Delete one of the items. Refresh the carousels once more and notice that the deleted title still appears.
Apply the patch.
Refresh the carousels, and the delete item should now be gone.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jane Sandberg [Tue, 29 Dec 2020 21:03:18 +0000 (13:03 -0800)]
LP1907923: Move course materials button to more suitable location
To test:
1) Apply this patch
2) In the staff client, go to Admin > Local Admin > Course Reserves List
3) Double click on a course
4) Go to the course materials tab
5) Note that the "Add Material" button is now beneath the temporary call
number, circ mod, item status, and shelving location fields.
LP#1786100: fix upgrade issue that can prevent unmapping item tags
Depending on the history of an Evergreen database, it might have an
incorrect trigger on asset.copy_tag_copy_map that prevents removing
item tags fom items. This patch ensures that the table has the
correct trigger.
To test (cannot remove item tags)
---------------------------------
[1] If you have a database from which item tags cannot be removed
on items, check the asset.copy_tag_copy_map table to see if
it has a trigger named inherit_copy_tag_copy_map_copy_fkey that
fires on insert, update, or delete. If so, this part of the
test plan applies to you.
[2] Make a copy of the database.
[3] Note that item tags cannot be unassigned from items in the
holdings editor: saving a change will appear to stick, but
opening the item back in the editor shows that the item tag
is still there.
[4] Apply the patch and run the schema update. Note that there be
just one inh_fkey trigger named inherit_asset_copy_tag_copy_map_copy_fkey
that fires only on insert or update.
[5] Repeate step 3; this time, items tags can be removed
from items.
To test (can remove item tags)
------------------------------
[1] If your test system _can_ remove item tags, as would be
the case with ones created from scratch, apply the patch
and verify that item tags can be added or removed from
items.
Garry Collum [Sun, 20 Dec 2020 01:39:01 +0000 (20:39 -0500)]
LP1908766 Bootstrap OPAC: Lost ability to have notes in lists.
Fixes the note functionality in the Bootstrap Opac lists.
The button definition needed both the name 'save_notes' and an arbitrary value.
To test:
1. Create a list in the bootstrap opac and add a couple of titles to the list.
2. View the list and try to add a note to one of the items in the list.
3. This should fail with an error.
4. Apply the patch.
5. Try to add a note. It should now be successful.
6. Try to edit the note. This should also succeed.
Jane Sandberg [Sun, 20 Dec 2020 03:20:43 +0000 (19:20 -0800)]
LP1895678: Bring course materials into the bootstrap OPAC
Also adds course_ou and use_courses to ctx, so that we
can avoid having so many duplicate and slightly inconsistent
checks to see if we are using the course materials module.
Garry Collum [Mon, 14 Dec 2020 20:18:15 +0000 (15:18 -0500)]
LP1907866 Bootstrap Opac: fix adding basket to existing List
Fixes the issue with the screen not showing lists after adding items
to an existing list from a basket.
To test:
Create a list in the Bootstrap Opac.
Add some items to a basket. Select Add Basket to Saved List, and send
the items to the list that was just created. Notice on the list page
after the items have been added that you can no longer see any existing
list names. The screen displays '...From Basket'
Apply the patch.
Add some more items from a basket into the list. The existing list
names are displayed after the items are sent to the existing list.
Garry Collum [Wed, 11 Nov 2020 16:03:00 +0000 (11:03 -0500)]
LP1903594 Bootstrap opac: suspend hold not working
Fixes hold suspension at the time of the hold placement in the Bootstrap opac.
And fixes the date picker validation for the activation date.
To test.
As a patron, place a hold in the Bootstrap Opac.
At the time of placement select "Suspend this hold?" and set an activation date.
In the staff client, notice that neither the suspension or activation date has been saved.
Apply the patch.
Repeat the above steps and check for the suspension and activation date.
Place another hold with a activation date in the past. This should fail.
Place a hold without "Suspend this hold" checked.
Place a hold with "Suspend this hold" checked, but without an activation date.
Garry Collum [Tue, 10 Nov 2020 17:54:52 +0000 (12:54 -0500)]
LP1902265: implement per-hold notification updates in Bootstrap OPAC
In the Bootstrap Opac:
* Adds a Notify Method column to the patron's hold list.
* Adds email, phone, and sms notifiction editing to the hold's
edit screen.
* Also, adds <label> tags to the existing form fields in the edit
page for accessibility and some bootstrappy form elements to
format the appearance of the form.
The SMS fields do not appear unless the Library Setting for
"Enable features that send SMS text messages" is set to true.
To test work with the above OU setting off, and then on.
* Place holds for a patron with and without an email address.
* If a patron has a defualt SMS carrier, this carrier should pop up
in the list by default.
Garry Collum [Wed, 16 Dec 2020 19:22:54 +0000 (14:22 -0500)]
LP1908298 Bootstrap OPAC: Type filter missing from advanced search
The Item Type filter and the Bib Level filter were both commented out in the opac's config.tt2 file.
This patch removes the comment hashmarks.
To test.
Go to the Advanced Search in the Bootstrap Opac.
Notice that the Item Type filter and Bib Level Filters are missing.
Apply the patch.
The two filters should now be displayed.
Bill Erickson [Mon, 1 Feb 2021 15:54:18 +0000 (10:54 -0500)]
LP1913811 Items out notice summary API batching
Tweak the open-ils.actor.user.itemsout.notices API to accept an array of
circulation IDs so the call can be batched from the client. Similarly
modify the AngJS client to request the notice summaries in batch.
Further improves the notices API by removing an unneeded join and a
minor security fix to verify perms based on the in-database user ID
instead of the ID provided by the caller (w/ the note that the API only
returns numbers, not user data).
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Garry Collum [Thu, 17 Dec 2020 18:47:41 +0000 (13:47 -0500)]
LP1868147-Titles in carousel run together in mobile display.
This patch uses the breakpoint option available in glide.js to limit the number of images in the carousel that display.
Files for both the tpac and the bootstrap opac have been updated.
There are two new variables based on bootstrap sizing, sm_width which defaults to 3, and xs_width which defaults to 2.
If a screen's width is set between 768-992 pixels, 3 images display in the carousel,
if the width is below 768 pixels, only 2 images display in the carousel.
The reduction of images helps with titles overlapping each other.
To test:
Apply the patch to an instance of Evergreen that displays carousels.
Reduce the screen size of the browser. Eventually the carousel will display 3 and then 2 images.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
projects / Evergreen.git / log