]> git.evergreen-ils.org Git - Evergreen.git/commit
LP1895660: Silence Perl Warnings
authorJason Boyer <JBoyer@equinoxinitiative.org>
Tue, 15 Sep 2020 12:50:26 +0000 (08:50 -0400)
committerGalen Charlton <gmc@equinoxOLI.org>
Fri, 14 May 2021 21:40:18 +0000 (17:40 -0400)
commitbeeca95266f4ee435f8d45abe2fdfe99f624fbc7
tree8949d011fa3c511cdc713a8e254416a65a906491
parent6fb442acb392ca0c11cd69c5a5589a24ef5d3060
LP1895660: Silence Perl Warnings

There are many perl warnings in make check and the day-to-day
logs when using Evergreen. This branch aims to address the
warnings and to make reviewing easier each file will be
individually committed with a small rationale for the changes
though it is assumed that this branch will be largely squashed
away if / when committed.

Booking.pm: Possible precedence issue with control flow operator
The precedence of 'or' is significantly lower than '||', so much so
that it can be less than the precedence for assignments.
Replace 'or' with '||' since they're equivalent in this case anyway,
and also add parens for flavor.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Booking.pm