]> git.evergreen-ils.org Git - working/Evergreen.git/commit - Open-ILS/src/perlmods/OpenILS/SIP.pm
Lots of cleanup, logging improvements, and comments.
authorerickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Fri, 4 Jun 2010 20:53:23 +0000 (20:53 +0000)
committererickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Fri, 4 Jun 2010 20:53:23 +0000 (20:53 +0000)
commit5162a5a73455c09cde5639f48c6a472aca871770
treefd050a3d32814d10e49bd0278fc6f606bb9570b7
parent8f2d2f825811b36ad510c4233b0771710bf9a842
Lots of cleanup, logging improvements, and comments.

One arrayref accessor updated to recommended style

Removed unused dependency.

Removed never-possible return statement.

Trying to use an arrayref in the log message results in a string like "ARRAY(0x2541870)".
I added a prebuilt string representation of the array for use in those messages.

More whitespace cleanup.
More flexible to_bool, extra comments;
Also added institution_id method.

Note: OpenILS::Event->new returns a hash, not a true object.

script_x_check.sh is executable.
Irony: this script could have been used to detect itself.

Typo in Cronscript POD.

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16597 dcc99617-32d9-48b4-a31d-7c20da2025e4
Open-ILS/src/perlmods/OpenILS/Event.pm
Open-ILS/src/perlmods/OpenILS/SIP.pm
Open-ILS/src/perlmods/OpenILS/SIP/Item.pm
Open-ILS/src/perlmods/OpenILS/SIP/Patron.pm
Open-ILS/src/perlmods/OpenILS/SIP/Transaction.pm
Open-ILS/src/perlmods/OpenILS/Utils/Cronscript.pm
Open-ILS/src/sql/Pg/upgrade/0264.schema.acq-edi-message-type.sql
Open-ILS/src/support-scripts/settings-tester.pl
build/tools/script_x_check.sh [changed mode: 0644->0755]