Jason Boyer [Mon, 28 Jan 2019 14:45:35 +0000 (09:45 -0500)]
LP1796945: More Accurate Joins in AngularJS IDL
Currently all joins of all classes are hard-coded to
inner, which is clearly sub-optimal. This branch
tries to correct this by looking at the reltype param
on links.
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
LP1779467: Fix bug with charging fees when marking item damaged.
Revert the changes made to the mark_damaged function in the web staff
client code (Open-ILS/web/js/ui/default/staff/circ/services/circ.js)
earlier in this branch. The new code does not handle the mark damaged
process correctly, but the original code does.
blake [Mon, 2 Oct 2017 19:42:06 +0000 (14:42 -0500)]
lp1642036 Web Staff Client - Group Members Don't Display
Altered app.js so that the call to grid.setQuery happens after the initTab
execution. Using .then().
Test:
1. Login to webby. Search patrons. Find a patron.
2. Click a search result and click the "Other" Menu.
3. Choose "Group Member Details"
4. Notice that there are no grid items.
5. Apply the patch. Repeat 1-3.
6. Notice that there is at least one grid item.
Cesar Velez [Thu, 26 Jul 2018 21:39:36 +0000 (17:39 -0400)]
LP#1642036 - Prevent race condition in Group Member Grid
A timing condition was causing the setQuery() fnc to not
exist when called resulting in a blank group members grid.
A simple $timeout seems to address it.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Cesar Velez [Thu, 26 Jul 2018 21:39:36 +0000 (17:39 -0400)]
LP#1642036 - Prevent race condition in Group Member Grid
A timing condition was causing the setQuery() fnc to not
exist when called resulting in a blank group members grid.
A simple $timeout seems to address it.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
James Fournie [Thu, 17 Jan 2019 21:23:12 +0000 (13:23 -0800)]
LP1783421 - Make Copy Alerts permission not global
For some reason copy alerts require global permissions. Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.
Tiffany Little [Thu, 10 Jan 2019 17:13:13 +0000 (12:13 -0500)]
Adds documentation links to acqadmin menus
Adds links to appropriate PINES wiki pages for remaining Dojo Acquisition administration menus. Additionally also marks required fields on Load MARC Order Records page.
Galen Charlton [Thu, 15 Nov 2018 14:59:44 +0000 (09:59 -0500)]
LP#1726568: expose circ lib and owning lib fields to spine/pocket labels
This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID. As a consequence, the
following fields are now available for label templates:
If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.
To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
or more of the new fields listed above; verify that the current
value is displayed on the label preview.
Cesar Velez [Fri, 7 Dec 2018 23:50:43 +0000 (18:50 -0500)]
LP1765179 - fix issue with pending/staged user reg
After completing a staged user registration, the controller
in regctl.js was refreshing to the same route, and
trying to fetch the same staged user, but never finding it
as it was no longer staged/pending. This addresses that bug
and adds a bChannel refresh to the pending grid, so once
the user is registered in the child tab, it closes the tab and
the pending user grid is updated.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Adds a new dedicated patron parent/guardian field. This field is
editable in the patron edit interface, displays in the patron summary
side bar on the browser client, and is search-able from the patron
search interface in the browser client.
Adds patron editor "show" and "suggest" library settings.
Also adds a new library setting
'ui.patron.edit.guardian_required_for_juv' ("GUI: Juvenile account
requires parent/guardian"). When this setting is applied, a value
will be required in the patron editor when the juvenile flag is active.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Previously, the selfcheck ignored this setting if it was
set to "False", since the setting value is stored as text
and the truth test always succeeded. Instead, explicitly
check that the setting is "True".
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Terran McCanna [Wed, 12 Dec 2018 22:57:19 +0000 (17:57 -0500)]
LP#1743783 Web Client Bill Full Detail Display Issues
Fleshes out retrieved data to be able to display the billing
location for both circulation and grocery bills on the full
details page as well as the owning library for circulation bills.
- Call Number
- Owning Library
- Shelving Location
- Last Billing Note
- Last Billing Timestamp
- Last Payment Timestamp
- Last payment Note
- Last Payment Type
2) Corrected path for Type
3) Changed column name for Location to 'Billing Location'
and the former Billing Location to 'Grocery Billing Location' for clarity
A new option to "Mark Item as Discard/Weed" is added to many actions
menus in the staff client. This command is connected to the back end
function open-ils.circ.mark_item_discard.
The back end functionality for the open-ils.circ.mark_item_* family of
functions is altered to provide more consistent behavior and to avoid
some strange situations that have come up in the past, such as items
with the Missing status having active transits or open circulations.
The code for "Mark Item as Damaged" and "Mark Item as Missing" are
altered to take advantage of the back end changes. NB: These changes
do not affect the "Mark Item as Missing Pieces" function, as that is
handled by different back end code.
Perl live tests are added for the backend functionality changes to
test that certain conditions works. Like most of our tests these
could be expanded to cover more potential situations.
See the release notes for more detail on changes in functionality.
Bill Erickson [Fri, 21 Sep 2018 18:53:33 +0000 (14:53 -0400)]
LP#793802 Aged billings and payments
Creates tables money.aged_billing and money.aged_payment. When a
circulation is aged, billings/payments linked to the circ are migrated
to the aged_* table.
Upgrade script includes a migration script for migrating existing
billings and payments.
Includes IDL entries for reporting and pcrud access just in case it's
needed. Note the 'xact' column on these new tables links directly to
the aged circulation instead of the non-existent money.billable_xact.
Certain third-party products such as collection development
management providers require copy statistics that are not
readily available in a single report. This view adds those,
which will also benefit library staff reports generally.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Chris Sharp [Tue, 21 Aug 2018 18:22:05 +0000 (14:22 -0400)]
LP#1788260 - Break out in-house-use non-cat circulations.
Previously, all non-cataloged circulations were grouped
together, causing problems for libraries who need to
exclude in-house circulations from circ counts.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Apply the edi_message.account value when sending EDI order messages via
edi_order_pusher.pl. This solves a problem where EDI ORDERS message
were not visible in the interface, because there was no way to complete
the permission check.
Mike Rylander [Tue, 16 Jan 2018 23:54:47 +0000 (18:54 -0500)]
LP#1743650: Bib vis testing needs different handling
For bib-level visibility testing, we can only use the source helper for
positive inclusion, and have to deal with LURIs on a case-by-case basis.
This is because, unlike the copy visibility cache, the LURI cache is pre-
composed in a single value for all LURIs on a record, not separate ones
for each. This is fine, as we just need to find the effectively visible
org units and test for that subset of the relevant orgs. This commit provides
a sub to test for that, and handles LURI test composition at the perl
level rather than in the database.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
This commit attempts to achieve the goals of both simplification and
feature completeness/flexibility. In brief, limit the number of
marking and transfer options, then have the code decide the right
action to take given the circumstances.
There are now just two "marking" actions, one at the record level,
one at the holdings level. The holdings level mark will automatically
mark the destination as specifically as possible from the selected row,
which means either to the library or call number (vol) level.
We are also now down to two transfer options: transfer the selected
item, or transfer the selected call number. Either option will use
as much given context as possible, then fill in any blanks with
reasonable defaults and actions.
As part of the change, a number of functions and variables are also
renamed. This is all done for clarification, and in most cases is
due to the variable or function now being used more generally (i.e.
it is used in both the item and vol context, so it is confusing to
be named 'volume_transfer_target', etc.).
Finally, clear up a fair bit of now redundant and unused code.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
This attempt leaves the Syndetics perl code in place to retrieve images,
but ignores it in favor of hardcoding in the Added Content button and
modal code on the item details page.
projects / evergreen / pines.git / log