Chris Sharp [Fri, 22 Nov 2013 15:18:58 +0000 (10:18 -0500)]
Allowing unfillable hold placement in the staff client, not the OPAC
In PINES, we do not allow patrons to override hold policies, but staff
may in certain circumstances. This change makes the option visible in
the staff client, but not the OPAC.
The alternate view in the Item Status screen shows a "Total Circs"
field that was under-counting circulations because UNION filtered
out duplicates. This commit replaces UNION with UNION ALL, which
allows duplicate rows.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Ben Shum [Wed, 10 Oct 2012 21:00:54 +0000 (17:00 -0400)]
LP1071505 - Add 264 RDA tag to TPAC pubinfo display
Prior to this, TPAC only retrieved the 260 tag for publication info. Allow for
the possibility that the 264 tag might exist and contain relevant information.
Special note: the 264 tag must have a second indicator value of 1 to be meant
for publication statement.
Also, this only picks out the first 260 or 264 tags in any given bib record.
Approach inspired by Dan Scott's approach taken for finding edition statements.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Ben Shum [Sat, 2 Mar 2013 07:21:58 +0000 (02:21 -0500)]
TPAC - set autofocus to user input when placing holds in staff client
When placing holds in TPAC via the staff client, the focus had been on the
basic search field above. Change this to have autofocus on the input field
for the hold user by default.
This can potentially save staff from having to perform an extra click to
select the input field. Now they can immediately begin entering the barcode
of the user they plan to create a hold on behalf of.
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/templates/opac/parts/place_hold.tt2
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Chris Sharp [Sat, 4 May 2013 14:33:34 +0000 (10:33 -0400)]
PINES Survey Link - TPAC Edition
PINES does an online survey that runs for a week every Spring. These
changes create a red link to the survey above the search bar on the
OPAC home page.
This includes removing the toggle option for TPac usage.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Chris Sharp [Wed, 1 Feb 2012 20:16:08 +0000 (15:16 -0500)]
Revert "Use my_asv here.. surveys pertinent to the workstation library.. in case survey usage ever takes off. Should probably move some of this to the middle layer"
Michael Peters [Wed, 13 Mar 2013 12:31:43 +0000 (08:31 -0400)]
Password Length Helpers
This branch provides length helpers when patrons are setting or resetting
passwords.
This assumes the default 7 characters, 1 number requirement that comes stock.
You would need to change the hard coded strings if you use a different password
requirement regex in Library Settings Editor.
Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Mike Rylander [Fri, 5 Apr 2013 05:52:16 +0000 (01:52 -0400)]
Address SQL injection vulnerability in SQL ORM layer
If the user-supplied value and the db column are both numbers
(jsonObject->type == JSON_NUMBER, get_primitive(field) == "number") then
don't quote. Otherwise, quote.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Tue, 9 Apr 2013 17:45:24 +0000 (13:45 -0400)]
TPAC bucket item retrieval operates in streaming mode
TPAC bucket item retreive fleshes bib records with large blobs of MARC
data. When a bucket contains a few thousand items, the size of the
data passed around in atomic retreival mode will exceed the typical jabber
max stanza size and result in a failure. Retrieve the records in
streaming mode instead.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Steven Callender [Fri, 15 Jun 2012 17:27:33 +0000 (13:27 -0400)]
Avoid problems when auth recs are missing the 901c
Fixed the authority.normalize_heading function to better handle
INT's when there is no 901 present. Now we look for the best-fit
control set instead of throwing a db-level error.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Fri, 29 Mar 2013 17:36:17 +0000 (13:36 -0400)]
LP 1126545 repair staff 'return to results' tpac link
Strip the extra "/" from the URL created by the "return to results"
button in the staff client TPAC view. Havin the extra "/" in place
prevents the next/previous links from functioning.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Fri, 15 Mar 2013 18:47:53 +0000 (14:47 -0400)]
Allow access to public hold notes via hold "blob"
If a hold note is marked as "public", it seems reasonable that it
should be visible to anyone who can see that hold, regardless of
who created the note.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Dan Wells [Fri, 15 Mar 2013 18:42:24 +0000 (14:42 -0400)]
Fix reversed logic for hold "blob" notes
Hold notes (at least at the data level) allow for both staff and
"private" notes to be attached. This code intended to show "private"
notes to the hold owner and staff notes to staff, but had the logic
reversed.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Bill Erickson [Mon, 25 Mar 2013 19:19:14 +0000 (15:19 -0400)]
tpac : honor page locale in record detail copy grid
The query used to load the record detail copy grid now uses the same
locale value set as the default for all cstore-editor calls. This
solves the issue where copy location names, statuses, etc. are not
properly translated.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Fri, 22 Mar 2013 14:40:59 +0000 (10:40 -0400)]
More authority fixed-field cleanup
Even with the efforts by many to add and harmonize the authority fixed-field
setup, and maintain functionality, there were some missing bits. This commit
should take care of those by realigning the remaining field names and allwowing
those fields to be saved properly.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Changed the way authority tags were being pulled to specifically use an aggregate array.
There appears to have been a change in postgres at some point between 9.0 and 9.1
to the aggregate method. Because of this, postgres was not returning the proper
results when pulling tags for authorities. This change will force postgres to do
a proper aggregate array call and return the correct results.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 3 Aug 2012 19:08:51 +0000 (15:08 -0400)]
SIP re-login fetches correct auth session
After a login session expires and the SIP server logs in again to
acquire a new authtoken, be sure to use the new authtoken when fetching
the new session object. Otherwise, the login_session is left undef and
you may see errors like this when checking in items:
Can't call method "ws_ou" on an undefined value at
/usr/local/share/perl/5.10.1/OpenILS/SIP/Transaction/Checkin.pm line 77.
Incidentally, the checkin code is the only code that references
$sip_handler->{login_session}. And the problem listed above only occurs
when the login session expires just prior to a checkin call. In any
other scenario, the login_session would ultimately get repaired.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Jeff Godin [Thu, 14 Mar 2013 18:15:28 +0000 (14:15 -0400)]
Fix detection of empty Syndetics AC data elements
Due to a change in how the vendor responds to requests for data
elements which are not present for a requested title, we need to
change how we detect "empty" data elements in the "data_exists"
function.
First, we check for the new "No Data Available" title element, then
we check for the previously-used value of "error".
This change resolves the symptom where the catalog would display
tabs for "Author Notes", "Excerpt", "Table of Contents", on every
record in the catalog, even when clicking each tab would show that
the content was not present / available.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Fri, 22 Feb 2013 05:46:17 +0000 (00:46 -0500)]
LP1054322 - libparent-perl not needed for Ubuntu Precise
The newer version of Perl 5.14 which comes with Ubuntu Precise already
contains the contents of libparent-perl, which is now an obsolete package.
Remove this dependency from the extra debs installed for Debian and Ubuntu
but then add to the extras for Debian Squeeze and create a new extras just
for Ubuntu Lucid so that it continues to be installed on those systems and
not on Ubuntu Precise.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Ben Shum [Thu, 14 Mar 2013 21:40:04 +0000 (17:40 -0400)]
LP1103068 - Show titles and authors for pre-cat items
As noted in LP1103068, TPAC does not currently show anything when viewing a
pre-cataloged item in the my account summary of items checked out.
If the call number is -1 (pre-cat), then show the dummy title and dummy author
values, which fields are hopefully relevant as long as staff were good to put
something meaningful in those during creation of the pre-cat.
Also, wrap the title in a check for attrs.title.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Restore previous behavior to the maintain_901() trigger
function so that bib records that are loaded without
explicitly setting the TCN have it set to the bib ID
when the cat.bib.use_id_for_tcn global flag is set, rather
than 'AUTOGENERATED-xxx'.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Serials: printing routing slips fails with Javascript error
The symptom (an error in the Javascript console about dijit.form.Button
and an empty page for routing slips that you try to print at batch
recieve) may or may not be affected by whether you're in a production
environment with the pre-built dojo 1.3.3 package installed or a
development environment without it.
This simple fix makes the problem go away in any case.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Thu, 28 Feb 2013 20:32:07 +0000 (15:32 -0500)]
Fix holding lib for certain distribution svrs
On a serial virtual record (svr), the holding lib is expected to be
just an ID. In one logic branch, Search/Serial.pm was attaching the
entire aou object, and we should instead attach just the ID of this
object.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Michael Peters [Tue, 12 Mar 2013 20:14:23 +0000 (16:14 -0400)]
LP#1154235 Allow inactive patron barcode to be loaded
This addresses LP#1154235 by modifying the evergreen.get_barcodes
function to allow users to retrieve patrons in barcode retrieve
who have inactive barcodes.
This returns to functionality in versions prior to around 2.2.x
series.
End result is staff receiving an alert that the patron was
accessed with an invalid barcode.
Signed-off-by: Michael Peters <mpeters@emeralddata.net> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Sat, 9 Mar 2013 03:41:08 +0000 (22:41 -0500)]
Show OPAC-invisible copies in TPAC in staff context
We were not calling the staff variation of the copy count method; thus,
the record details template was skipping the copy table in the event
that all copies for a given record were marked as OPAC-invisible via
either copy visibility or shelving location visibility.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Thu, 28 Feb 2013 19:49:16 +0000 (14:49 -0500)]
Don't populate the MFHD menu with distributions
If a distribution has no legacy record, it shouldn't get a menu
entry in the MFHD menus. A magic id of '-1' is used to indicate
this case, so we need to check for that when populating
mfhdDetails via the TPAC.
Also, entryNum must be an int, not a string, because it is
incremented prior to display. Removing the quotes solves this
display issue.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Wed, 21 Nov 2012 15:12:39 +0000 (10:12 -0500)]
extract PO name from picklist upload
If a PO name is encoded in a lineitem (via provider attribute
definition), extract that PO name when creating a new purchase order
from lineitems that were previously only linked to a selection list.
This allows staff to create selection lists first, then orders second,
while retaining the encoded purchase order name.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Fix divergence of stock serials schema and upgraded schema
And additionally make a function used in a constraint on
serial.issuance.holding_code a little bit smarter.
These issues were reported to me by Galen Charlton.
The upgrade script included here will set serial.issuance.holding_code
to NULL in cases where the value doesn't validate, but in those cases
there is no part of Evergreen that could have made use of the data
anyway, and the data is just plain bad.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Exclude copies that have been deleted from showing up on the browse holds shelf list.
If an item had been deleted while it had a status of On Holds Shelf, it would permanently show up on
the browse holds list. This will exclude deleted copies from the results.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Tue, 5 Feb 2013 18:12:02 +0000 (13:12 -0500)]
LP#1116509: prevent null SVF attribute value from breaking record import
Fix problem where a record could fail to be staged for import
with the following error:
ERROR: query string argument of EXECUTE is null
CONTEXT: PL/pgSQL function "extract_rec_attrs" line 72 at EXECUTE statement
SQL function "extract_rec_attrs" statement 1
This error would be triggered if at least one SVF attribute has a normalization
function defined that is applied to a null value during record import.
Patch is based on a suggestion by Bob Wicksall.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Mon, 11 Mar 2013 17:40:46 +0000 (13:40 -0400)]
Reify required authority fixed field names
Adam (and Art, by way of Adam's patch) added a goodly pile of fixed
field definitions that were lacking previously. The change in this
commit simply changes the label of two (008/11 and 008/15) to those
in use by other parts of the code. In particular, internally, we call
the field holding a thesaurus code value "Subj" and use that name during
ingest of authority records. Therefore, that should not change. This
required a subsequent change to the label of another, to SubjUse.
I've included a duplication in the backend-only (probably deprecated)
version of this mapping to allow the front-end labels to work.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
This is consistent with commit's e675b854 change to the
OCLC labels, and also fixes a problem where changing the
008/11 and 008/15 was not reflected in the fixed field boxes.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
projects / evergreen / pines.git / log