Galen Charlton [Wed, 23 Jan 2019 01:50:01 +0000 (20:50 -0500)]
LP#1772680: add admin interfaces for the RBDigital integration tables
The database tables used by the RBDigital interface now have
standard Angular administration interfaces. These can be reached
from a new item on the web staff Adminstration menu, "Extras Administration"
LP#1772680: add global flag to control display of digital search tab
This patch introduces a new global flag, extras.enable_digital_resource_search_tab,
that controls whether the public catalog search tab for digital
resources is displayed. If that flag is not turned on, the tab
is not displayed and unnecessary RBDigital initialization code
is bypassed.
This includes tables used by the RBdigital integration, putting
them in a new schema called 'extra' that's meant to collect
Evergreen extensions and integrations that are optional but ship
with Evergreen.
This feature allows searching of RBdigital resources from the Evergreen
catalog without needing to import and maintain bibliographic records for
the RBdigital resources.
The RBdigital search results will appear in the OPAC on a different tab -
a search in basic or advanced Evergreen search will carry over to the
RBdigital tab (along with filters when mapping is feasible) so that the
user can type in a search once and see both sets of results. The design
of the RBdigital tab will make use of the OPAC styling for consistency.
This feature is sponsored by Recorded Books (RBDigital) and
GPLS and was primary written by Jaswinder Singh with code contributions
and testing from the Equinox Open Library Initiative.
LP 1827250: Fix Last Captured Hold Check for Holds Shelf
When the current copy on an on shelf hold is the same as that on some
uncaptured holds, the hold fails to appear on the hold shelf when it
should. This comes down to some SQL in the storage function to
retrieve wide holds: open-ils.storage.action.live_holds.wide_hash.
The intent of the new code is to check that the current hold matches
the most recently captured hold for the copy. However, the order by
in the query fails to take into account holds with a NULL capture time
on the same copy will sort before the captured holds. This patch
rectifies this situation by adding "NULLS LAST" to the order by.
PINES Customization: Alter wording for COPY_CIRC_NOT_ALLOWED
Change wording of COPY_CIRC_NOT_ALLOWED message because the default
wording indicates that it is a problem with the copy, but it can
also be triggered when there is a problem with the user (such as when
a Digital Only user attempts to check out a physical item).
Support extracting buyer code (AKE edi_account.vendcode) values directly
from the EDI RFF+API field. This provides better matching to
edi_accounts based on vendcode values for inbound EDI messages.
The code will still fall back to extracting vendcodes appended to the SAN,
when no RFF+API is present.
Modifies our previously customized code for the new books dropdown
list so that it limits what is retrieved in the new books supercat
feeds by available statuses only.
Adam Bowling [Thu, 7 Mar 2019 04:06:09 +0000 (23:06 -0500)]
LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Wed, 24 Apr 2019 13:19:40 +0000 (09:19 -0400)]
LP1642036 Group member detail grid query repair
Teach the grid to automatically use the current version of the grid
query in group member details lookup, since the query changes as
patron's change and is sometimes applied after the grid has already
absorbed the setQuery function.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Daniel Pearl [Wed, 12 Dec 2018 17:51:07 +0000 (12:51 -0500)]
LP#1029601: Prevent double-clicking when submitting hold requests.
Double clicking on hold submit buttons causes multiple holds to be generated. This adds some code to
disable the Submit button(s) after the first click, so subsequent clicks don't "work" in unintended ways.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
The purchase order reporting source contains several fields that are
available in the reporter but are non-functional (because they are
generated on-the-fly within user interfaces). This view allows a
similar calculation and provides access back to the PO object as well.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Kyle Huckins [Mon, 14 Jan 2019 22:22:40 +0000 (22:22 +0000)]
lp1777677 Security tweaks
- Refactor test notification API to check if requestor
is user,and if not, then check if requestor has
permissions to view users at target user's home ou.
- Change event_def_type references to "hook"
- Separate out sendTestEmail and sendTestSMS functions
in frontend to prevent potential misuse of functionality.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified: Open-ILS/src/templates/opac/myopac/prefs.tt2
modified: Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
modified: Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified: Open-ILS/web/js/ui/default/opac/test_notification.js
modified: Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Kyle Huckins [Wed, 12 Dec 2018 21:26:23 +0000 (21:26 +0000)]
lp1777677 Test Notification Release Notes
- Add release notes for Test Notification functionality.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
new file: docs/RELEASE_NOTES_NEXT/Circulation/test_notification_method.adoc
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
- Create fire_test_notification subroutine to create, fire, and
return event
- Add Test Notification UI buttons to preferences and patron edit screen.
- Add Toast to inform of success or failure of sending test notification
- Add Strings to patron interface to handle ngToast notifications
- Add Test Notification to OPAC preferences UI for email
and default sms number.
- Abort Test Notification event if no user is found.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified: Open-ILS/src/sql/Pg/400.schema.action_trigger.sql
modified: Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file: Open-ILS/src/sql/Pg/upgrade/XXXX.data.lp1777677-action-triggers-test-notification.sql
modified: Open-ILS/src/templates/opac/myopac/prefs.tt2
modified: Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
new file: Open-ILS/src/templates/opac/myopac/test_notification.tt2
modified: Open-ILS/src/templates/opac/parts/header.tt2
modified: Open-ILS/src/templates/opac/parts/js.tt2
modified: Open-ILS/src/templates/staff/circ/patron/index.tt2
modified: Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
new file: Open-ILS/web/js/ui/default/opac/test_notification.js
modified: Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Terran McCanna [Wed, 6 Feb 2019 17:53:38 +0000 (12:53 -0500)]
PINES Custom UI Change: Date Field on Circ Screen
Forced size of custom date selector on checkout screen since
it is too small. This will probably be fixed differently in
master later, but this will help us for now.
Jason Boyer [Mon, 28 Jan 2019 14:45:35 +0000 (09:45 -0500)]
LP1796945: More Accurate Joins in AngularJS IDL
Currently all joins of all classes are hard-coded to
inner, which is clearly sub-optimal. This branch
tries to correct this by looking at the reltype param
on links.
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Cesar Velez [Thu, 26 Jul 2018 21:39:36 +0000 (17:39 -0400)]
LP#1642036 - Prevent race condition in Group Member Grid
A timing condition was causing the setQuery() fnc to not
exist when called resulting in a blank group members grid.
A simple $timeout seems to address it.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Tiffany Little [Thu, 10 Jan 2019 17:13:13 +0000 (12:13 -0500)]
Adds documentation links to acqadmin menus
Adds links to appropriate PINES wiki pages for remaining Dojo Acquisition administration menus. Additionally also marks required fields on Load MARC Order Records page.
projects / evergreen / pines.git / log