]> git.evergreen-ils.org Git - contrib/Conifer.git/commit
LP#1857710: fix Angular client whitescreen on Firefox
authorGalen Charlton <gmc@equinoxinitiative.org>
Fri, 27 Dec 2019 18:21:15 +0000 (13:21 -0500)
committerDan Scott <dan@coffeecode.net>
Fri, 3 Jan 2020 19:31:27 +0000 (14:31 -0500)
commitbc9071ba9377340213c4db86a2e8308e95167ca1
tree891f720260f2703b7fc6c2f1017c984344e19363
parentd09582c588f2882eec0c46232d6fc2cc5bb18aea
LP#1857710: fix Angular client whitescreen on Firefox

Work done for LP#1830391 added an instance of a Javascript
regexp replace using the dotAll ("/s") flag, but as of the moment
Firefox treats that flag as a fatal syntax error, breaking the
Angular staff client.

To test
-------
[1] Attempt to log in the Angular staff client with Firefox. Note
    that you get a whitescreen with the following in the browser
    console:

    SyntaxError: invalid regular expression flag s
[2] Apply the patch and repeat step 1. This time, the Angular
    staff client should work normally.
[3] Verify that the Angular unit tests pass.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Open-ILS/src/eg2/src/app/share/util/htmltotxt.service.spec.ts [new file with mode: 0644]
Open-ILS/src/eg2/src/app/share/util/htmltotxt.service.ts