]> git.evergreen-ils.org Git - contrib/Conifer.git/commit
LP#1857156: handle HHH:MM:SS durations in loans
authorGalen Charlton <gmc@equinoxinitiative.org>
Fri, 20 Dec 2019 17:55:16 +0000 (12:55 -0500)
committerDan Scott <dan@coffeecode.net>
Fri, 3 Jan 2020 19:31:28 +0000 (14:31 -0500)
commit60989f89e9376be49b76408ce1bcc6d09754658e
tree0a6985c147c4bac472f63de7e249a4a82f99ead6
parentda96f434fcfa48bf164a63553ff31550d214696a
LP#1857156: handle HHH:MM:SS durations in loans

This patch fixes a problem where loan durations of the form
HHH:MM:SS, where the hours component is longer than 2 digits, could
cause checkouts to fail. This sort of duration has been observed
in cases where a library wanted a long-term reserves loan that
doesn't have the due time bumped up to midnight.

To test
-------
[1] Set up a circulation policy that has a loan duration of 167:59:59.
[2] Attempt a checkout that uses that policy. Note that the checkout
    will fail.
[3] Apply the patch and repeat step 2. This time, the checkout should
    succeed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Open-ILS/src/perlmods/lib/OpenILS/Utils/DateTime.pm
Open-ILS/src/perlmods/t/14-OpenILS-Utils.t