1 commit 66103eb652fccf9b847d6ce295c62e1562e47964
2 Author: Galen Charlton <gmc@equinoxinitiative.org>
3 Date: Thu Jan 17 17:22:40 2019 -0500
5 update versions for 3.1.0
7 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
10 2 2 src/perl/lib/OpenSRF.pm
11 1 1 src/python/setup.py
14 commit 6045fdaa42c5581a9a32cf9dea27f1a4e80bffb8
15 Author: Galen Charlton <gmc@equinoxinitiative.org>
16 Date: Thu Jan 17 17:20:20 2019 -0500
18 update release notes to 3.1.0 and fix typos
20 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
22 7 7 doc/RELEASE_NOTES.txt
24 commit b35e8538351b8c6c1e0bddb7678435d62b996c31
25 Author: Galen Charlton <gmc@equinoxinitiative.org>
26 Date: Wed Jan 9 17:35:12 2019 -0500
28 fix formatting issue in release notes
30 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
32 1 1 doc/RELEASE_NOTES.txt
34 commit 5c8b62f209a62a0ad2bf2a05b9e8fd34fda50630
35 Author: Galen Charlton <gmc@equinoxinitiative.org>
36 Date: Wed Jan 9 17:23:01 2019 -0500
38 update ChangeLog for 3.1.0-beta
40 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
44 commit b74533255c61937b96fb4326b9f94c18aaa37d4d
45 Author: Galen Charlton <gmc@equinoxinitiative.org>
46 Date: Wed Jan 9 17:18:48 2019 -0500
48 bump up version numbers for 3.1.0-beta release
50 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
53 3 3 doc/RELEASE_NOTES.txt
54 2 2 src/perl/lib/OpenSRF.pm
55 1 1 src/python/setup.py
58 commit 0ed43a65d9f814540a9b0ec087ca29bf8090f7b2
59 Author: Galen Charlton <gmc@equinoxinitiative.org>
60 Date: Wed Jan 9 17:04:24 2019 -0500
62 draft 3.1.x release notes for 3.1-beta
64 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
66 154 0 doc/RELEASE_NOTES.txt
67 create mode 100644 doc/RELEASE_NOTES.txt
69 commit d7e9df6838f1c9a72db3fd41556d178cfe7f6700
70 Author: Galen Charlton <gmc@equinoxinitiative.org>
71 Date: Wed Dec 12 14:35:56 2018 -0500
73 LP#1729610: extend backlog queue to C apps
75 This patch extends the notion of a backlog queue to C apps and
76 offers the same functionality as the Perl side of the patch series:
78 - max_backlog_queue configuration setting
79 - ability to queue messages up to the configured limit
80 - ability to drop requests that would overflow the backlog
81 queue and send status 503 exceptions back to the client.
83 This patch also adds a new service, opensrf.cslow, that implements
84 a opensrf.cslow.wait method similar to the Perl opensrf.slooooooow
89 [1] Set a low max_backlog_queue for opensrf.cslow and a low
91 [2] Arrange for srfsh to fire off a bunch of opensrf.cslow.wait
93 [3] Verify that requests that come in after the backlog queue fills
94 up immediately get 503 exceptions.
96 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
97 Signed-off-by: Bill Erickson <berickxx@gmail.com>
98 Signed-off-by: Mike Rylander <mrylander@gmail.com>
100 19 0 examples/opensrf.xml.example
101 5 1 src/c-apps/Makefile.am
102 58 0 src/c-apps/osrf_cslow.c
103 117 40 src/libopensrf/osrf_prefork.c
104 create mode 100644 src/c-apps/osrf_cslow.c
106 commit efa9b713d5341458a3afaa26d1cf9e750fa78654
107 Author: Galen Charlton <gmc@equinoxinitiative.org>
108 Date: Wed Nov 7 12:03:17 2018 -0500
110 LP#1729610: return new OpenSRF status if backlog queue fills up
112 This patch teaches Perl services how to return a new OpenSRF status,
113 OSRF_STATUS_SERVICEUNAVAILABLE (code 503) if the backlog queue
114 for a service gets full.
118 [1] Set a low max_backlog_queue for opensrf.sloooow and a low
120 [2] Arrange for srfsh to fire off a bunch of opensrf.sloooow.wait
122 [3] Verify that requests that come in after the backlog queue fills
123 up immediately get 503 exceptions.
125 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
126 Signed-off-by: Bill Erickson <berickxx@gmail.com>
127 Signed-off-by: Mike Rylander <mrylander@gmail.com>
129 1 0 include/opensrf/osrf_message.h
130 1 0 src/javascript/opensrf.js
131 3 0 src/perl/lib/OpenSRF/DomainObject/oilsResponse.pm
132 42 2 src/perl/lib/OpenSRF/Server.pm
133 1 0 src/python/osrf/const.py
135 commit 848843b1cda6d79d3aec589746abf7a8efdc313d
136 Author: Galen Charlton <gmc@equinoxinitiative.org>
137 Date: Tue Nov 6 15:14:55 2018 -0500
139 LP#1729610: make it possible to set max_backlog_queue in opensrf.xml
141 This patch adds a new service configuration option, max_backlog_queue,
142 to allow controlling the size of the backlog queue.
144 If not otherwise specified in opensrf.xml, max_backlog_queue defaults
147 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
148 Signed-off-by: Bill Erickson <berickxx@gmail.com>
149 Signed-off-by: Mike Rylander <mrylander@gmail.com>
151 1 0 examples/opensrf.xml.example
152 1 0 src/perl/lib/OpenSRF/System.pm
154 commit 60bcf74ecc5a5c7d0740d7054e829eef19828091
155 Author: Remington Steed <rjs7@calvin.edu>
156 Date: Wed Jan 31 16:05:52 2018 -0500
158 LP#1729610: Fix incorrect param description
160 Mike confirmed that the code expects "pause" to be an integer. This
161 commit changes the description to reflect that, and to mention the
164 Signed-off-by: Remington Steed <rjs7@calvin.edu>
165 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
166 Signed-off-by: Bill Erickson <berickxx@gmail.com>
167 Signed-off-by: Mike Rylander <mrylander@gmail.com>
169 1 1 src/perl/lib/OpenSRF/Application/Slooooooow.pm
171 commit a9da9c7b25ef90276d41ba84ba8ccf0ea856da1b
172 Author: Mike Rylander <mrylander@gmail.com>
173 Date: Tue Oct 24 16:45:09 2017 -0400
175 LP#1729610: Add some debug/internal logging to backlog queue
177 Signed-off-by: Mike Rylander <mrylander@gmail.com>
178 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
179 Signed-off-by: Bill Erickson <berickxx@gmail.com>
180 Signed-off-by: Mike Rylander <mrylander@gmail.com>
182 7 0 src/perl/lib/OpenSRF/Server.pm
184 commit 1abec0da61a46fa5a4a881c29a2e95a51e9013fa
185 Author: Mike Rylander <mrylander@gmail.com>
186 Date: Wed Nov 1 11:11:08 2017 -0400
188 LP#1729610: Add a service useful for testing behavior in slow response conditions
190 This service, opensrf.slooooooow, offers a opensrf.slooooooow.wait method
191 that waits for the number of seconds specified in its sole parameter.
193 Signed-off-by: Mike Rylander <mrylander@gmail.com>
194 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
195 Signed-off-by: Bill Erickson <berickxx@gmail.com>
196 Signed-off-by: Mike Rylander <mrylander@gmail.com>
198 19 0 examples/opensrf.xml.example
199 48 0 src/perl/lib/OpenSRF/Application/Slooooooow.pm
200 create mode 100644 src/perl/lib/OpenSRF/Application/Slooooooow.pm
202 commit 0201ca954002eb241d277c3068659bb1f8100bab
203 Author: Mike Rylander <mrylander@gmail.com>
204 Date: Tue Oct 24 13:27:37 2017 -0400
206 LP#1729610: Allow queuing (for a while) during child backlog
208 This patch teaches OpenSRF listeners for Perl services how to maintain
209 a queue of requests in case no drone process is immediately available
210 to process a requeust.
212 Signed-off-by: Mike Rylander <mrylander@gmail.com>
213 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
214 Signed-off-by: Bill Erickson <berickxx@gmail.com>
215 Signed-off-by: Mike Rylander <mrylander@gmail.com>
217 35 5 src/perl/lib/OpenSRF/Server.pm
218 2 3 src/perl/lib/OpenSRF/Transport/SlimJabber/XMPPReader.pm
220 commit f3eab1715079243d541dc12fd90db005630ffec9
221 Author: Bill Erickson <berickxx@gmail.com>
222 Date: Tue Nov 13 17:21:18 2018 -0500
224 LP#1803182 Websocketd graceful shutdown support
226 Give websocketd clients a chance to complete any requests that are
227 in-process at time of shutdown.
229 Graceful shutdown is initiated by sending a SIGUSR1 signal to the
230 websocket-osrf child processes or to the parent process group.
232 This can be done directly via:
234 $ kill -s USR1 -$websocketd_parent_pid
236 Or via systemd for systemd users:
238 $ sudo systemctl kill -s USR1 websocketd-osrf
240 Note the websocketd parent process ignores SIGUSR1.
242 Once initiated, the websocketd backend goes into shutdown mode polling
243 for a graceful shutdown window, which occurs when all request up to now
244 have been completed. Once that moment arrives, the client is kicked off
245 and must connect to a new websocketd instance to issue any new requests.
247 The polling period lasts for SHUTDOWN_MAX_GRACEFUL_SECONDS seconds (in
248 osrf-websocket-stdio.c), which currently defaults to 2 minutes.
250 Signed-off-by: Bill Erickson <berickxx@gmail.com>
251 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
253 91 13 src/websocket-stdio/osrf-websocket-stdio.c
255 commit 304365165e7ba0cc08bb6c5f0ba25f0b541fd27d
256 Author: Bill Erickson <berickxx@gmail.com>
257 Date: Mon Jul 24 12:08:56 2017 -0400
259 LP#1706147 Perl Force-Recycle drone option
261 Creates an API-level option to inform the OpenSRF drone management code
262 that the running drone should be recycled upon completion of the current
263 OpenSRF session. This allows for quicker release of resources consumed
268 sub some_api_method {
269 my ($self, $client, ...) = @_;
270 $self->session->force_recycle(1);
274 Signed-off-by: Bill Erickson <berickxx@gmail.com>
275 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
277 10 0 src/perl/lib/OpenSRF/AppSession.pm
278 15 1 src/perl/lib/OpenSRF/Server.pm
280 commit 51a4651186c94686051262a9255d165eadd4f049
281 Author: Bill Erickson <berickxx@gmail.com>
282 Date: Mon Aug 27 10:12:57 2018 -0400
284 LP#1684970 Translator compatible with mod_remoteip
286 Teach the OSRF Translator to request the IP address of the user agent
287 (e.g. web browser) instead of the IP address of the up stream client,
288 which may be a proxy, using the Apache 2.4 request_rec->useragent_ip
291 http://httpd.apache.org/docs/2.4/developer/new_api_2_4.html
293 This make is possible for the translator to access the client IP with
294 Apache's mod_remoteip enabled and configured.
296 Includes sample config and install documentation.
298 Signed-off-by: Bill Erickson <berickxx@gmail.com>
299 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
302 1 1 src/gateway/osrf_http_translator.c
304 commit 1423787b6076daeb18176e907b1ed307255ffbcb
305 Author: Bill Erickson <berickxx@gmail.com>
306 Date: Thu Sep 13 13:08:37 2018 -0400
308 LP#1711145 NGINX sample websocketd configs
310 Signed-off-by: Bill Erickson <berickxx@gmail.com>
311 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
313 20 3 examples/nginx/osrf-ws-http-proxy
315 commit 3db305ba4329b4c93d16b03800755d5807de4de0
316 Author: Bill Erickson <berickxx@gmail.com>
317 Date: Wed Jul 11 12:27:05 2018 -0400
319 LP#1711145 NGINX sample config security improvements
321 * Adds security recommendations from
322 https://mozilla.github.io/server-side-tls/ssl-config-generator/
324 * Apply a 5-minute proxy read timeout to avoid too-short timeouts on
326 * Adds a (commented) section on sending nginx logs to syslog
328 Includes INSTALL notes on generating the dhparam file.
330 Signed-off-by: Bill Erickson <berickxx@gmail.com>
331 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
334 30 2 examples/nginx/osrf-ws-http-proxy
336 commit 5c803ae4550bf0e4a992c217baeaffabee30c45a
337 Author: Jason Stephenson <jason@sigio.com>
338 Date: Mon Nov 5 10:42:32 2018 -0500
340 Reorder Ejabberd configuration steps for Ubuntu 18.04.
342 Rearrange the steps for modifying /etc/ejabberd/ejabberd.yml on Ubuntu
343 18.04 so that they are in the same order that they appear in the file.
345 Signed-off-by: Jason Stephenson <jason@sigio.com>
349 commit 705599ff6aa29857e8ed1b3da11e6e8ba05e9aa9
350 Author: Bill Erickson <berickxx@gmail.com>
351 Date: Tue Jun 12 12:12:45 2018 -0400
353 LP#1776510 JS libs handle transport errors
355 Teach the websocket client code to look for the transport_error flag
356 applied to the websocket wrapper message by the websocket gateway when a
357 request for an unavilable service is made.
359 When encountered, fire the transport or generic error handler callbacks,
360 if available. Avoid any attempts to further process the message.
362 Signed-off-by: Bill Erickson <berickxx@gmail.com>
363 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
365 23 0 src/javascript/opensrf.js
367 commit 884e00c41abd33ed8785acc1bc5958fd027a0807
368 Author: Ben Shum <ben@evergreener.net>
369 Date: Thu Sep 20 11:34:45 2018 -0400
371 Update README to include Bionic steps
373 Note the use of mod_legacy_auth in ejabberd 18.x version for Ubuntu Bionic
375 Signed-off-by: Ben Shum <ben@evergreener.net>
376 Signed-off-by: Jason Stephenson <jason@sigio.com>
377 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
381 commit f234372cb5f175c79ad9fe8279ae445b78fdaeb5
382 Author: Chris Sharp <csharp@georgialibraries.org>
383 Date: Tue Aug 7 19:43:45 2018 -0400
385 Add support for Ubuntu 18.04 Bionic Beaver to Makefile.install
387 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
388 Signed-off-by: Ben Shum <ben@evergreener.net>
389 Signed-off-by: Jason Stephenson <jason@sigio.com>
390 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
392 13 0 src/extras/Makefile.install
394 commit 9682d15475485522812ac73ac10e283d11176f7e
395 Author: Bill Erickson <berickxx@gmail.com>
396 Date: Thu Sep 20 18:04:09 2018 -0400
398 LP#1703411 XMPP opensrf element make check repairs
400 Update the transport_message unit tests to check for the new <opensrf/>
401 element for relaying custom commands.
403 Signed-off-by: Bill Erickson <berickxx@gmail.com>
404 Signed-off-by: Jason Stephenson <jason@sigio.com>
405 Signed-off-by: Mike Rylander <mrylander@gmail.com>
407 3 2 tests/check_transport_message.c
409 commit 744f0d1f2775bd5c51bfbf47d4d89a29001aafcf
410 Author: Bill Erickson <berickxx@gmail.com>
411 Date: Wed Sep 19 15:34:49 2018 -0400
413 LP#1703411 XMPP opensrf sub-element repairs
415 * Message template typo repair -- missing "'"
416 * XPath repair on path to opensrf sub-element for Perl
417 * Move 'type' attribute get/set back up to the <message> for Perl.
418 * Clean up code duplication in the C message building libs.
419 * Squash a centuries-old memory leak where xmlFree(sender) was only
420 called if a router_from was not supplied.
422 Signed-off-by: Bill Erickson <berickxx@gmail.com>
423 Signed-off-by: Jason Stephenson <jason@sigio.com>
424 Signed-off-by: Mike Rylander <mrylander@gmail.com>
426 17 54 src/libopensrf/transport_message.c
427 3 3 src/perl/lib/OpenSRF/Transport/SlimJabber/XMPPMessage.pm
428 2 2 src/perl/lib/OpenSRF/Transport/SlimJabber/XMPPReader.pm
430 commit b44fb8675a3b9983d3d3c1f2586006520b6f7281
431 Author: Mike Rylander <mrylander@gmail.com>
432 Date: Tue Aug 28 14:32:02 2018 -0400
434 LP#1703411: Move OpenSRF XMPP attrs to subelement
436 Modern versions of Ejabberd strip custom XML attributes which appear
437 outside of custom elements. To support OpenSRF's custom router and
438 osrf_xid commands, move these attributes into a new custom XML element
441 Signed-off-by: Mike Rylander <mrylander@gmail.com>
442 Signed-off-by: Bill Erickson <berickxx@gmail.com>
443 Signed-off-by: Jason Stephenson <jason@sigio.com>
445 8 0 src/java/org/opensrf/net/xmpp/XMPPReader.java
446 70 8 src/libopensrf/transport_message.c
447 13 8 src/libopensrf/transport_session.c
448 9 4 src/perl/lib/OpenSRF/Transport/SlimJabber/XMPPMessage.pm
449 7 2 src/perl/lib/OpenSRF/Transport/SlimJabber/XMPPReader.pm
451 commit 265aa9f8cc12472b347e34a62a8f2655dfb1c51b
452 Author: Jason Stephenson <jason@sigio.com>
453 Date: Wed Sep 20 11:56:34 2017 -0400
455 Lp#1718459: Remove Debian 7 Wheezy installation support.
457 Remove references to Debian 7 Wheezy in the README.
459 Remove src/extras/Makefile.install targets for Wheezy.
461 Remove the examples/apache2 directory, since none of the supported
462 distros come with Apache 2.2 any longer.
464 To test: Simply install on a supported distribution other than Debian
465 7 Wheezy and do the usual tests.
467 Signed-off-by: Jason Stephenson <jason@sigio.com>
468 Signed-off-by: Ben Shum <ben@evergreener.net>
471 0 49 examples/apache2/opensrf.conf
472 0 64 examples/apache2/websockets/apache2.conf
473 1 13 src/extras/Makefile.install
474 delete mode 100644 examples/apache2/opensrf.conf
475 delete mode 100644 examples/apache2/websockets/apache2.conf
477 commit da7e927c350c3c098b081f432b53cfb3a24ab480
478 Author: Ben Shum <ben@evergreener.net>
479 Date: Wed Sep 12 13:07:18 2018 -0400
481 LP#1777180: Add zip/unzip to prerequisites
483 Need unzip for new websocketd unpackaging. Also get zip just because.
485 Signed-off-by: Ben Shum <ben@evergreener.net>
486 Signed-off-by: Jason Stephenson <jason@sigio.com>
488 2 0 src/extras/Makefile.install
490 commit d1c33b4b1e2305c4dbb9a54dec22f04f665a7a2c
491 Author: Jason Stephenson <jason@sigio.com>
492 Date: Wed Sep 12 10:58:58 2018 -0400
494 LP#1777180 Update README for websocketd
496 Add optional command to run websocketd without using a proxy.
498 Signed-off-by: Jason Stephenson <jason@sigio.com>
499 Signed-off-by: Ben Shum <ben@evergreener.net>
503 commit 21c9c76332b8a4b591e443d098a0fc78b6db0e9d
504 Author: Bill Erickson <berickxx@gmail.com>
505 Date: Sat Jun 9 19:05:25 2018 -0400
507 LP#1777180 Websocketd gateway and test scripts
509 Adds a new OpenSRF binary/program for relaying websockets messages
510 to and from a websocketd instance. The new binary
511 (osrf-websocket-stdio) performs the same tasks as the
512 osrf_websocket_translator.c Apache module, minus the Apache module glue
513 and the extra threading required to run within the Apache module.
515 Commit includes 2 test scripts (tester.pl and test-stateful.pl) for
516 generating large series of test messages to send to a websockets
517 instance. tester.pl sends echo requests only, test-stateful.pl sends
518 connect->echo-request->disconnect batches across a configurable number
521 INSTALL document updated to include websocketd setup as an alternative
522 to Apache websockets.
524 Signed-off-by: Bill Erickson <berickxx@gmail.com>
525 Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
526 Signed-off-by: Jason Stephenson <jason@sigio.com>
527 Signed-off-by: Ben Shum <ben@evergreener.net>
533 22 0 src/websocket-stdio/Makefile.am
534 609 0 src/websocket-stdio/osrf-websocket-stdio.c
535 148 0 src/websocket-stdio/test-stateful.pl
536 87 0 src/websocket-stdio/tester.pl
537 create mode 100644 src/websocket-stdio/Makefile.am
538 create mode 100644 src/websocket-stdio/osrf-websocket-stdio.c
539 create mode 100755 src/websocket-stdio/test-stateful.pl
540 create mode 100755 src/websocket-stdio/tester.pl
542 commit 6414c2527f6b6857d9f163bdba6f071b09f710a3
543 Author: Mike Rylander <mrylander@gmail.com>
544 Date: Fri Jul 7 15:22:21 2017 -0400
546 LP#1702978: memcache Get methods use key as va_list format
548 And, when a key (composed of, say, a username or barcode) has a % in it,
549 bad things happen. We will stop acting as if these are variadic functions
550 now, and also update Evergreen so that it does not do that either.
552 TODO: Make these actually non-variadic, but that breaks ABI.
554 Signed-off-by: Mike Rylander <mrylander@gmail.com>
555 Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
556 Signed-off-by: Jason Stephenson <jason@sigio.com>
558 13 17 src/libopensrf/osrf_cache.c
560 commit 71720f639e00d0e457bc8f967f8060b579bc2882
561 Author: Galen Charlton <gmc@equinoxinitiative.org>
562 Date: Mon May 7 16:03:16 2018 -0400
564 LP#1243841: quiet a misleading indentation warning
566 Adjusts a spaces-vs-tabs issue to fix the following compilation
569 osrf_prefork.c: In function ‘check_children’:
570 osrf_prefork.c:1067:5: warning: this ‘if’ clause does not
571 guard... [-Wmisleading-indentation]
572 if( select_ret <= 0 ) // we're done here
574 osrf_prefork.c:1072:2: note: ...this statement, but the latter is
575 misleadingly indented as if it is guarded by the ‘if’
576 cur_child = forker->first_child;
579 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
581 1 1 src/libopensrf/osrf_prefork.c
583 commit 0f0a2281767a47c0ab4971d2b0dba5da10c6907b
584 Author: Jason Stephenson <jason@sigio.com>
585 Date: Tue Nov 7 16:39:39 2017 -0500
587 LP#1243841 - Quiet remaining Make install warnings.
589 We silence the following warnings:
591 apachetools.c:179:15: warning: initialization discards 'const' qualifier
592 from pointer target type [enabled by default]
594 apachetools.c:181:8: warning: assignment discards 'const' qualifier from
595 pointer target type [enabled by default]
597 apachetools.c:183:8: warning: assignment discards 'const' qualifier from
598 pointer target type [enabled by default]
600 ./osrf_websocket_translator.c:541:9: warning: return makes integer from
601 pointer without a cast [enabled by default]
603 ./osrf_http_translator.c:300:25: warning: passing argument 1 of 'free'
604 discards 'const' qualifier from pointer target type [enabled by default]
606 Signed-off-by: Jason Stephenson <jason@sigio.com>
607 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
609 1 1 src/gateway/apachetools.c
610 1 1 src/gateway/osrf_http_translator.c
611 1 1 src/gateway/osrf_websocket_translator.c
613 commit f47f108e7a2af04360c872313978be6ce71c5c25
614 Author: Jason Stephenson <jason@sigio.com>
615 Date: Tue Nov 7 15:58:05 2017 -0500
617 LP#1243841 - Quiet additional Make warnings and some code cleanup.
619 We make the following warnings go away:
621 osrf_legacy_json.c:607:6: warning: variable ‘fourth_dash’ set but
622 not used [-Wunused-but-set-variable]
624 osrf_legacy_json.c:836:5: warning: passing argument 3 of ‘makeNode’
625 discards ‘const’ qualifier from pointer target type [enabled by
628 utils.c:133:2: warning: format not a string literal and no format
629 arguments [-Wformat-security]
631 We also cleanup the while block nested in a do while block around line
632 63 of osrf_cache.c to be more readable by adding braces and breaking
635 Signed-off-by: Jason Stephenson <jason@sigio.com>
636 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
638 3 1 src/libopensrf/osrf_cache.c
639 4 6 src/libopensrf/osrf_legacy_json.c
640 6 3 src/libopensrf/utils.c
642 commit 9dd65c72e5bd114eb1e1d6c2b1388e01df02bbb8
643 Author: Chris Sharp <csharp@georgialibraries.org>
644 Date: Tue Sep 19 21:25:12 2017 -0400
646 LP#1243841 - Quiet wrong format warnings during make install.
648 During make install, the compiler warns that %d expects an int when the
649 actual value is a long int. Changing %d to %ld fixes the issue.
651 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
652 Signed-off-by: Jason Stephenson <jason@sigio.com>
653 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
655 3 3 src/gateway/osrf_websocket_translator.c
657 commit f8f1813bf17f745719c9dabbdfc5c7bed05c7138
658 Author: Chris Sharp <csharp@georgialibraries.org>
659 Date: Tue Sep 19 20:46:28 2017 -0400
661 LP#1243841 - Quiet unused return value warning in srfsh.c
663 Using the technique described here: https://stackoverflow.com/a/13999461.
665 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
666 Signed-off-by: Jason Stephenson <jason@sigio.com>
667 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
669 1 1 src/srfsh/srfsh.c
671 commit 6aedae0b42434c95f22924ed4b93ba726353f034
672 Author: Chris Sharp <csharp@georgialibraries.org>
673 Date: Tue Sep 19 20:37:13 2017 -0400
675 LP#1243841 - Quiet unused return value warnings.
677 Using advice given here: https://stackoverflow.com/a/13999461, "The
678 only good (if ugly) way to suppress these is to convert the return
679 value into something that the compiler agrees that you can ignore."
681 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
682 Signed-off-by: Jason Stephenson <jason@sigio.com>
683 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
685 4 4 src/libopensrf/utils.c
687 commit 2e5c11c04c4db962aebf4b8632ce35a46434cd12
688 Author: Chris Sharp <csharp@georgialibraries.org>
689 Date: Tue Sep 19 18:10:00 2017 -0400
691 LP#1243841 - Wrap truth test using "=" in an extra set of parens.
693 Referring to https://stackoverflow.com/questions/5476759/compiler-warning-suggest-parentheses-around-assignment-used-as-truth-value,
694 it is recommended to wrap variable assignments that are used as a truth
695 test within an extra set of parentheses.
697 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
698 Signed-off-by: Jason Stephenson <jason@sigio.com>
699 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
701 1 1 src/libopensrf/osrf_cache.c
703 commit e72473d9c43a579ea64cb79fd410d37df23c3445
704 Author: Jason Stephenson <jason@sigio.com>
705 Date: Sun Feb 18 12:12:13 2018 -0500
707 LP1340982: Ignore both 'comment' and '#comment' nodes in Settings Parse.
709 Modify the XML2perl helper function in OpenSRF::Utils::SettingsParser
710 to ignore comment nodes that have names of comment and #comment.
712 To reproduce the bug:
714 1. Stop OpenSRF services.
716 2. Add a XML comment, any text betwen <!-- and -->, in the list of
717 MARC templates in the opensrf.xml file.
719 3. Restart OpenSRF services.
721 4. In the staff client, go to Cataloging->Create New MARC Record.
723 5. In the list of templates, you will #comment where you added the
724 comment. (NOTE: I only tested with 1 comment. Things may get worse
725 with more than 1 comment.)
727 6. There will be an error like the following in the
728 open-ils.cat_stderr.log if you attempt to choose the #comment entry:
730 Caught error from 'run' method: Exception: OpenSRF::EX::ERROR
731 2018-02-18T11:24:30 OpenSRF::Application
732 /usr/local/share/perl/5.22.1/OpenSRF/Application.pm:240 System
733 ERROR: Unable to open MARC template file: HASH(0x2249928) :
737 1. Leave the comments in the opensrf.xml file from before.
739 2. Apply this commit, do make and make install for OpenSRF.
741 3. Just to make sure, do make and make install for Evergreen.
743 4. Repeat steps 3 and 4 from above.
745 5. You should NOT see any templates named #comment.
747 Signed-off-by: Jason Stephenson <jason@sigio.com>
748 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
750 1 1 src/perl/lib/OpenSRF/Utils/SettingsParser.pm
752 commit f8dfa10b7613799190524ae1bf635d6c90a97b98
753 Author: Bill Erickson <berickxx@gmail.com>
754 Date: Tue Apr 10 15:06:56 2018 -0400
756 LP#1762815 Empty client TZ defaults to server TZ (Perl)
758 Fixes an issue in the Perl client time zone handling that resulted in
759 the server defaulting to UTC time instead of the server time zone when
760 no time zone value was received from the client.
762 Signed-off-by: Bill Erickson <berickxx@gmail.com>
763 Signed-off-by: Jason Stephenson <jason@sigio.com>
765 1 0 src/perl/lib/OpenSRF/DomainObject/oilsMessage.pm
767 commit 4163499191dfb511ba8646ae1c4748d88996558e
768 Author: Bill Erickson <berickxx@gmail.com>
769 Date: Wed Jan 24 15:16:14 2018 -0500
771 LP#1744158 Websocket proc exits on ejabberd disconnect
773 Any errors relaying websocket messages to OpenSRF now result in the WS
774 client being disconnected, allowing the WS process to exit. This
775 prevents the WS gateway from accepting requests it cannot process and
776 allows the client to connect to a new WS process.
778 Signed-off-by: Bill Erickson <berickxx@gmail.com>
779 Signed-off-by: Jason Stephenson <jason@sigio.com>
781 17 4 src/gateway/osrf_websocket_translator.c
783 commit 50a6bcad0b6d94e8edd15ee460b84466bc55c941
784 Author: Bill Erickson <berickxx@gmail.com>
785 Date: Wed Jan 31 13:07:41 2018 -0500
787 LP#1746577 Websocket responder exits on jabber disconnect
789 Regularly check for Jabber socket disconnects in the websocket gateway
790 "responder" thread (that relays messages from opensrf to the WS client)
791 and force a client disconnect when a broken jabber socket is detected.
793 Signed-off-by: Bill Erickson <berickxx@gmail.com>
794 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
795 Signed-off-by: Jason Stephenson <jason@sigio.com>
797 18 2 src/gateway/osrf_websocket_translator.c
799 commit a90a1d9a99e510423b9fdc43afcb128ace79a24a
800 Author: Galen Charlton <gmc@equinoxinitiative.org>
801 Date: Thu Sep 21 09:51:20 2017 -0400
803 and continue to bump up version numbers
805 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
809 commit f3775e2c750ce0119c1bb5c2bd286d356bca8467
810 Author: Galen Charlton <gmc@equinoxinitiative.org>
811 Date: Wed Sep 20 10:57:09 2017 -0400
813 bump up version numbers in master to reflect 3.0 as next major release branch
815 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
817 2 2 src/perl/lib/OpenSRF.pm
818 1 1 src/python/setup.py
820 commit cace46d9acd653234ffc298d8ea483ce3c08c54d
821 Author: Jason Stephenson <jason@sigio.com>
822 Date: Tue Sep 12 11:29:41 2017 -0400
824 LP#1708048: Fix ld problems by renaming libraries.
826 We add the lib... prefix to all C library names as expected by most
827 linkers. This necessitates changes to the opensrf.xml configuration
830 Signed-off-by: Jason Stephenson <jason@sigio.com>
831 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
833 2 2 examples/opensrf.xml.example
834 10 10 src/c-apps/Makefile.am
836 commit a85132ecc7760106a317fdd967236cef99835771
837 Author: Ben Shum <ben@evergreener.net>
838 Date: Tue Aug 1 16:07:16 2017 -0400
840 LP#1708048: Add support for Debian 9 Stretch
842 - Add new make target "debian-stretch"
843 - Add Stretch instructions to README
845 Signed-off-by: Ben Shum <ben@evergreener.net>
846 Signed-off-by: Jason Stephenson <jason@sigio.com>
847 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
850 12 0 src/extras/Makefile.install
852 commit 1f38166249e9f8fbb58ad21d1a00b935200a9278
853 Author: Galen Charlton <gmc@equinoxinitiative.org>
854 Date: Thu Sep 14 17:36:40 2017 -0400
856 LP#1717350: fix chunking messages sent from Perl services
858 The chunk size adjustments introduced by the patches for bug 1709710
859 could result in calculating non-integral chunk sizes for Perl services.
860 This in turn led to fractional offsets and lengths being passed to
861 Perl's substr() function; rounding in turn can lead to characters
862 in the response getting silently dropped, which in turn broke
863 parsing the reconstituted response.
867 The problem can be reproduced by invoking
869 open-ils.storage open-ils.storage.actor.org_unit.descendants.atomic 1, 0
871 in Evergreen databases with org unit trees large enough that the
872 response gets chunked.
874 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
875 Signed-off-by: Jason Stephenson <jason@sigio.com>
877 2 1 src/perl/lib/OpenSRF/AppSession.pm
879 commit be2b2645f7da0907366eb0c99b5d6c231c366b30
880 Author: Bill Erickson <berickxx@gmail.com>
881 Date: Fri Sep 8 17:53:52 2017 -0400
883 LP#1709710 Count Perl chunk/bundle sizes in bytes
885 For the purposes of bundling/chunking, count the number of bytes in each
886 affected string instead of the number of characters.
888 See also https://perldoc.perl.org/bytes.html and 'perldoc -f length'
890 Signed-off-by: Bill Erickson <berickxx@gmail.com>
891 Signed-off-by: Jason Stephenson <jason@sigio.com>
892 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
894 6 3 src/perl/lib/OpenSRF/AppSession.pm
896 commit 3d91aeb066c52213f2c82f04bdfc84b87ec8d1d0
897 Author: Galen Charlton <gmc@equinoxinitiative.org>
898 Date: Fri Sep 8 15:34:29 2017 -0400
900 LP#1709710: write unit tests for osrfXmlEscapingLength()
902 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
903 Signed-off-by: Bill Erickson <berickxx@gmail.com>
904 Signed-off-by: Jason Stephenson <jason@sigio.com>
905 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
907 6 2 tests/Makefile.am
908 43 0 tests/check_osrf_utils.c
909 create mode 100644 tests/check_osrf_utils.c
911 commit cb4587be75bf9294d65c7173ff41c275a14e0f04
912 Author: Mike Rylander <miker@esilibrary.com>
913 Date: Fri Aug 18 11:43:31 2017 -0400
915 LP#1709710: Make chunk sizing smart about XML quoting
917 XML inside JSON as a quoted string that's itself inside XML causes quite the
918 pile up of nested excaping of certain characters in OpenSRF PARTIAL_RESPONSE
919 messages. Here we check for the worst offenders (<, >, &, and ") and account
920 for the cost of escaping them in chunked response stanzas.
922 Signed-off-by: Mike Rylander <mrylander@gmail.com>
923 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
924 Signed-off-by: Bill Erickson <berickxx@gmail.com>
925 Signed-off-by: Jason Stephenson <jason@sigio.com>
926 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
928 6 0 include/opensrf/utils.h
929 11 4 src/libopensrf/osrf_app_session.c
930 8 3 src/libopensrf/osrf_application.c
931 23 0 src/libopensrf/utils.c
932 21 3 src/perl/lib/OpenSRF/AppSession.pm
934 commit af4ab2355707083a22a2828202a541bf0e718bc0
935 Author: Chris Sharp <csharp@georgialibraries.org>
936 Date: Thu May 11 14:47:32 2017 -0400
938 LP#1690206 - remove check of httpd.conf from OpenSRF Makefile.install
940 The original src/extras/Makefile.install included a grep of the
941 file /etc/apache2/httpd.conf, which is no longer installed by default
942 on supported Debian and Ubuntu releases. As this check results in
943 an error message, it makes sense to remove the check altogether.
945 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
946 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
948 0 6 src/extras/Makefile.install
950 commit ea72acaf798f3fc6cc0aae8d93771c6dc2a21a57
951 Author: Bill Erickson <berickxx@gmail.com>
952 Date: Fri Jun 9 13:01:46 2017 -0400
954 LP#1697029 Log and exit on write to dead child
956 Confirm that a child process is alive just before attempting to write to
957 its pipe. If the child process is dead, log the error, then drop the
958 message and move on. This allows the parent to continue servicing
961 Signed-off-by: Bill Erickson <berickxx@gmail.com>
962 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
964 13 0 src/perl/lib/OpenSRF/Server.pm
966 commit 53e7f82b534eef2b513fe31bcb2a9c719a7ee746
967 Author: Galen Charlton <gmc@equinoxinitiative.org>
968 Date: Fri Aug 18 11:11:29 2017 -0400
970 LP#1711194: avoid division by zero errors
972 Under some circumstances, osrf_control --diagnostic may not
973 be able to deduce the correct max_children setting for a service,
974 e.g., if it's run without --localhost on a system that doesn't
975 have a opensrf.xml config section specifying active apps for a
976 specific hostname. When that happens, just display the count
977 of running drones rather than displaying error messages about
978 undefined $dmax values and divisions by zero.
980 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
981 Signed-off-by: Bill Erickson <berickxx@gmail.com>
983 6 2 bin/opensrf-perl.pl.in
985 commit b198681669ed28a510fd0d18d3a89d4dd0837ebe
986 Author: Bill Erickson <berickxx@gmail.com>
987 Date: Wed Aug 16 14:10:13 2017 -0400
989 LP#1711194 osrf_config --diagnostic reports max-children
991 --diagnostic output shows the maximum number of allowed drones per
992 service along with the active drone count. Additionally, a usage
993 percentage value is displayed.
997 $ /openils/bin/osrf_control -l --diagnostic
999 * open-ils.acq [1581] uptime=00:35 cputime=00:00:00 #drones=1/15 6%
1000 * open-ils.actor [1629] uptime=00:35 cputime=00:00:00 #drones=2/15 13%
1002 Signed-off-by: Bill Erickson <berickxx@gmail.com>
1003 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
1004 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
1006 9 1 bin/opensrf-perl.pl.in
1008 commit e88891bcdd9781c2d291057a802e4f751202fee9
1009 Author: Graham Billiau <graham@geeksinthegong.net>
1010 Date: Mon Jul 31 11:00:25 2017 -0400
1012 LP#1704090: ensure make install respects DESTDIR
1014 This patch ensures that 'make install' uses DESTDIR consistently,
1015 making life easier for packagers.
1017 Signed-off-by: Graham Billiau <graham@geeksinthegong.net>
1018 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
1021 7 2 src/gateway/Makefile.am
1023 commit 716b674a5197f9ec70091c9f3dfa3eabca3bbe9d
1024 Author: Mike Rylander <mrylander@gmail.com>
1025 Date: Mon Jul 31 15:15:09 2017 -0400
1027 Revert "LP#1635737 Add optional context to interval_to_seconds"
1029 This reverts commit a481100ef9d5bd9eaad5a87ce29776cb07a8687c.
1031 17 48 src/perl/lib/OpenSRF/Utils.pm
1033 commit 0484c673577c49a552af861364caac03ef187f5e
1034 Author: Mike Rylander <mrylander@gmail.com>
1035 Date: Mon Jul 31 15:15:02 2017 -0400
1037 Revert "LP#1635737: Unit tests for DST and date math"
1039 This reverts commit 316f58375c40087bfae32234c4dd3817260831e5.
1041 2 13 src/perl/t/09-Utils-interval_to_seconds.t
1043 commit 316f58375c40087bfae32234c4dd3817260831e5
1044 Author: Mike Rylander <mrylander@gmail.com>
1045 Date: Mon Jul 31 12:53:59 2017 -0400
1047 LP#1635737: Unit tests for DST and date math
1049 Signed-off-by: Mike Rylander <mrylander@gmail.com>
1051 13 2 src/perl/t/09-Utils-interval_to_seconds.t
1053 commit a481100ef9d5bd9eaad5a87ce29776cb07a8687c
1054 Author: Dan Wells <dbw2@calvin.edu>
1055 Date: Fri Jul 21 14:17:34 2017 -0400
1057 LP#1635737 Add optional context to interval_to_seconds
1059 Any given interval (e.g. "1 month") can be a different amount of
1060 seconds depending on the context (i.e. "1 month" after February 1 is
1061 March 1, but "1 month" after March 1 is April 1, yet March is longer
1062 than February). This affects months all the time, but also can affect
1063 days, hours, and even seconds once you consider DST and "leap" times.
1065 By giving an optional context to interval_to_seconds, you can find the
1066 true number of seconds in, for example, "1 month", when starting from
1067 "February 1" (the context).
1069 Signed-off-by: Dan Wells <dbw2@calvin.edu>
1070 Signed-off-by: Mike Rylander <mrylander@gmail.com>
1072 48 17 src/perl/lib/OpenSRF/Utils.pm
1074 commit 66acf02b800b6bb9b128c591e7ce480dc111b99d
1075 Author: Jason Stephenson <jason@sigio.com>
1076 Date: Wed Jul 12 15:24:48 2017 -0400
1078 LP 1703958: Update Websockets Intructions for Debian Jessie
1080 Modify the Websockets installation instructions so that users will
1081 have a working installation on Debian Jessie. We change the "Debian"
1082 instructions to say "Debian Wheezy" and add "Debian Jessie" to the
1083 list with "Ubuntu Trusty / Xenial" where necessary.
1085 Signed-off-by: Jason Stephenson <jason@sigio.com>
1086 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
1090 commit 740e725fbb02d7d3476d39efbed0b382f13b880d
1091 Author: Graham Billiau <graham@geeksinthegong.net>
1092 Date: Thu Jul 13 11:29:43 2017 -0400
1094 LP#1704116: fix intermittant failure of parallel building
1096 Running make to do a parallel build (e.g., 'make -j 4' or
1097 the like) could fail because of an undeclared dependency; this
1098 patch fixes the issue.
1100 The issue can be reproduced by repeating "make clean; make -j 4"
1101 until the build fails.
1103 Signed-off-by: Graham Billiau <graham@geeksinthegong.net>
1104 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
1106 1 0 src/libopensrf/Makefile.am