dbs [Tue, 3 Nov 2009 04:46:26 +0000 (04:46 +0000)]
Patch from Jeff Godin to make holds placed by staff respect the patron's notification preferences.
The attached patch should fix a bug which resulted in patron notification
preferences (phone/email/both) being ignored in favor of the staff user's
notification preferences when staff place a hold on behalf of another
user.
BUG: When staff place a hold for another user, the staff member's
notification preferences (not the recipient user's) are consulted.
This patch fixes that bug, as well as a bug where notification selections
were not reset between canceled attempts to place holds for different
recipients.
There is also a minor change to grabUserPrefs() regarding which session
variable to send as an auth token (now uses G.user.session, which seems to
be an acceptable convention used elsewhere. This was needed, as the passed
user does not always have a valid session.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Jeff Godin <jeff@tcnet.org>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14735 dcc99617-32d9-48b4-a31d-7c20da2025e4
miker [Tue, 3 Nov 2009 01:57:46 +0000 (01:57 +0000)]
add support for, and use, the mint_condition flag on holds and copies; adjust the mint_condition upgrade script -- please ignore the possible failure on the post-COMMIT ALTER TABLE statement, that is generally expected
phasefx [Tue, 3 Nov 2009 00:18:45 +0000 (00:18 +0000)]
Fix minor typos for plural versus singular strings, and change a few identifiters to protect against accidental column collisions.
Meat of this changeset is to allow manipulation of the mint_condition fields on items and holds. The desired functionality is a way to let holds opt for pristine/complete/or-just-plain-better copies
or not, with the idea being that an item missing pieces or slightly damaged could be marked as mint_condition = false. I've re-cast mint condition as Quality/Copy Quality as far as labels go, with
Good and Mediocre/Any Copy instead of True or False. I'm open to better suggestions. There's some dissonance here with the Damaged copy status.
phasefx [Mon, 2 Nov 2009 07:15:50 +0000 (07:15 +0000)]
some refactoring. redistribute payment when Payment Received field changes its value and leaves focus, or when the field is in focus and the enter key is pressed. In the case of the Enter key while in that field, switch focus to the Apply Payment button, so that a subsequent enter press would apply the payment
phasefx [Mon, 2 Nov 2009 06:47:32 +0000 (06:47 +0000)]
FEATURE: bill patron dialog on mark item damage given certain org settings. allows you to override the item price for the purpose of billing and optionally specify an arbitrary billing type. TODO: see if we need to either disable the note field in the dialog or have the middle layer make use of it. See if we need to display both the billing type and the btype in the bills interface, or if the btype is meant to replace the billing type
phasefx [Mon, 2 Nov 2009 03:07:37 +0000 (03:07 +0000)]
FEATURE: Renew with Specific Due Date option for Items Out interface. DEV NOTES: Some refactoring. Would this style of commit message be useful for change logs? Some keywords like FEATURE or BUGFIX for stuff meant to be more widely read? Or alternately, we could use development branches for intermediate work/commits, and reserve trunk and the release branches for changelog worthy commits? I personally don't mind reviewing 'typo' and 'oops' changesets that fly by. :)
erickson [Mon, 2 Nov 2009 01:48:16 +0000 (01:48 +0000)]
added explicit --process-hooks flag to turn on hook event creation. This allows the script to run in --run-pending mode without trying to create hook events from default values
erickson [Thu, 29 Oct 2009 18:55:18 +0000 (18:55 +0000)]
added feauture to org unit settings interface to display friendly values and selector widgets for settings with type of 'link' where pcrud for the link type is supported
erickson [Thu, 29 Oct 2009 15:29:35 +0000 (15:29 +0000)]
combined patch from Lebbeous Fogle-Weekley to add option of overriding the default billing address and first/last when creating CC payments and converts a pile of tabs to 4-char spaces
phasefx [Thu, 29 Oct 2009 06:59:14 +0000 (06:59 +0000)]
Some refactoring and payment distribution logic. Refunds have the same limitation as before in that they only get further applied to subsequent bills in the list. We could either put refundable transactions at the top of the
list by default (maybe a good idea for making them more prominent if nothing else), and/or we could make a second pass over the list whenever money is left over.
phasefx [Thu, 29 Oct 2009 05:28:15 +0000 (05:28 +0000)]
params.on_retrieve() inside a retrieve_row handler must run at least once when that handler is invoked, otherwise the row will get stuck on "Refreshing..."
phasefx [Thu, 29 Oct 2009 02:18:36 +0000 (02:18 +0000)]
modified patch from Steve Callender; exposes the patron 'alias' field in the Receipt Template Editor as %PATRON_ALIAS%. There's also a %PATRON_ALIAS_OR_FIRSTNAME% macro that will show the alias, or the first name if alias is unset
miker [Tue, 27 Oct 2009 16:57:29 +0000 (16:57 +0000)]
move the hook configuration out to a config file (action_trigger_filters.json.example); default to the list of hooks in that file if none are specified; use try/otherwise instead of eval/$@
erickson [Tue, 27 Oct 2009 14:44:20 +0000 (14:44 +0000)]
Patch from Lebbeous Fogle-Weekley to fine-tune credit card payment support in the the staff client.
This adds support for differentiating between in-band (using credit card processor) and
out-of-band (using external CC mechamism) in the staff client and payment entries
phasefx [Tue, 27 Oct 2009 06:35:52 +0000 (06:35 +0000)]
List columns for hold cancel reason, cancel note, and cancel time. Display them by default if either of the two org unit settings that control display of cancelled holds are set.
phasefx [Tue, 27 Oct 2009 02:39:59 +0000 (02:39 +0000)]
Tweak the Record In-House Use interface so that it has sound, a larger textbox for the '# of uses' field, and org unit settings that control the warning threshold and max allowed value for '# of uses'. Exceeding the cap no longer
sets the value to the cap.
erickson [Mon, 26 Oct 2009 21:11:18 +0000 (21:11 +0000)]
since showing title/auther will be common in predue, overdue, billing, etc. notices, provide a helper routine to get the title/author for given a copy. this does the precat dance as well. Removed the get_user_fines_summary helper routine since we can now flesh the 'mus' directly on the user
erickson [Sun, 25 Oct 2009 19:01:08 +0000 (19:01 +0000)]
when testing for existing events (to prevent duplicates) don't test for the presence of events linked to the previous event def in the loop. when fetching targets, only fetch the identifier column since it is all that is needed to create the event (and there could be many objects for passive events). increase the search timeout for event targets
scottmk [Fri, 23 Oct 2009 20:45:20 +0000 (20:45 +0000)]
Create new table asset.copy_location_order, and a new permission
for administering it.
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0052.schema.asset_copy_location_order.sql
M Open-ILS/src/sql/Pg/950.data.seed-values.sql
M Open-ILS/examples/fm_IDL.xml
erickson [Fri, 23 Oct 2009 18:43:57 +0000 (18:43 +0000)]
added support for passing in key/val pairs for hold update, instead of the entire hold object. added open-ils.circ.hold.update.batch which expects either an array of holds as second param, or list of key/value hashes as 3rd param
miker [Fri, 23 Oct 2009 17:21:03 +0000 (17:21 +0000)]
Patch from Warren Layton which fixes the behavior of the new Org Unit
configuration interfaces. Moving from raw open-ils.pcrud service calls to the
handy openils.PermaCrud dojo module.
Applied with minor editorialization to remove some duplicated code.
projects / Evergreen.git / log