Evergreen.git
4 years agoLP#1413624: update doc to reflect that spaces can also delimit option lists
Galen Charlton [Thu, 19 Feb 2015 16:36:39 +0000 (16:36 +0000)]
LP#1413624: update doc to reflect that spaces can also delimit option lists

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1413624: AccessHandler Space delimination and bugfix
Thomas Berezansky [Thu, 22 Jan 2015 16:31:03 +0000 (11:31 -0500)]
LP#1413624: AccessHandler Space delimination and bugfix

In addition to commas, allow spaces to delimit option lists.

Also, I apparently left a "!=" where I wanted a "ne" in _get_org_id.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1413624: OpenILS::WWW::AccessHandler Module
Thomas Berezansky [Tue, 20 Jan 2015 17:42:53 +0000 (12:42 -0500)]
LP#1413624: OpenILS::WWW::AccessHandler Module

Perl module compatible with Apache PerlAccessHandler directives.

Includes Release Notes and basic documentation (in the form of a mildly edited
copy of the release notes)

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1418772: (follow-up) tweak undef-edness check
Galen Charlton [Thu, 19 Feb 2015 15:59:33 +0000 (15:59 +0000)]
LP#1418772: (follow-up) tweak undef-edness check

Use the Perl defined() function rather than "eq undef"
to avoid logging warnings about undefined values.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1418772: Avoid internal server error on viewing full record when copy create_date...
Steven Chan [Mon, 22 Jul 2013 19:39:48 +0000 (12:39 -0700)]
LP#1418772: Avoid internal server error on viewing full record when copy create_date is null

In the TPAC client, when it tries to show record details containing a copy
record with no create date, it shows an Internal Server Error instead.

1. The error is caused by trying to execute the parse_datetime() method
in the parse_date() function in the WWW/EGCatLoader/util.pm module with
an empty date string. The function will normally translate a datetime
string from the database to a datetime string that is formatted for TPAC
templates.  The fix is to not execute parse_datetime() and just return
an empty string.

2. In the record/copy_table.tt2 template, if an empty datetime string is
the value for copy_info.create_date, the format() method of the Date
plugin will show the current datetime by default. The fix is to show '-'
in its place, replicating the same template logic as for
copy_info.due_date.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/copy_table.tt2

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1419813 Fix default joins for config.rule_age_hold_protection.
Chris Sharp [Mon, 9 Feb 2015 14:24:11 +0000 (09:24 -0500)]
LP#1419813 Fix default joins for config.rule_age_hold_protection.

config.rule_age_hold_protection had a "has_a" relationship
to several copy and copy-like sources when age protection
is optional.  Changing those to "might_have" to allow left
joins by default.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1366026: Adding release notes entry for display active date
Kathy Lussier [Thu, 19 Feb 2015 13:02:40 +0000 (08:02 -0500)]
LP#1366026: Adding release notes entry for display active date

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP1366026: Add Active Date to Record Detail Page
Jason Boyer [Fri, 5 Sep 2014 14:16:26 +0000 (10:16 -0400)]
LP1366026: Add Active Date to Record Detail Page

Display active date in place of create date when
item circ_lib uses active date for hold age
protection calculations.

Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Conflicts:
Open-ILS/src/templates/opac/parts/record/copy_table.tt2

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agolp1422555: Shorter permalink on record summary page
Kathy Lussier [Tue, 17 Feb 2015 03:06:01 +0000 (22:06 -0500)]
lp1422555: Shorter permalink on record summary page

The record summary page will now offer a link to a shorter permalink with
most URL parameters removed. The locg and copy-depth parameters are maintained.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1350371 ACQ dupe orders release notes
Bill Erickson [Thu, 31 Jul 2014 17:03:00 +0000 (13:03 -0400)]
LP#1350371 ACQ dupe orders release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1350371 display existing copies
Bill Erickson [Wed, 30 Jul 2014 21:34:07 +0000 (17:34 -0400)]
LP#1350371 display existing copies

In the picklist / PO lineitem list view, display the number of existing
catalog copies owned at or below the PO ordering agency or Picklist org
unit whose status is not in some form of lost or missing.

Value is displayed beside the lineitem ID and is styled bold/red if the
count is greater than zero.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1350371 detect dupe PO name on edit
Bill Erickson [Wed, 30 Jul 2014 19:59:02 +0000 (15:59 -0400)]
LP#1350371 detect dupe PO name on edit

When changing the name of an existing PO, if the selected name collides
w/ another PO at or below the ordering agency, a warning is shown to
the user, including a link to the matching PO, and the name change is
aborted.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1350371 PO name on create w/ dupe detect
Bill Erickson [Wed, 30 Jul 2014 19:02:22 +0000 (15:02 -0400)]
LP#1350371 PO name on create w/ dupe detect

Adds support for entering a PO name at PO creation time, both from the
picklist page and from the PO create page.  If a name is entered which
matches the name of an existing PO at or below the ordering agency, a
link to the matching PO is shown and the user is prevented from creating
the PO until the name is changed or cleared.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoFix typo in release notes for TPAC discoverability
Dan Scott [Wed, 18 Feb 2015 22:11:30 +0000 (17:11 -0500)]
Fix typo in release notes for TPAC discoverability

Thanks to Ben Shum for catching that!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoLP#1403967: show 'subject heading thesaurus' value in Manage Authorities results
Yamil Suarez [Tue, 17 Feb 2015 19:29:46 +0000 (14:29 -0500)]
LP#1403967: show 'subject heading thesaurus' value in Manage Authorities results

The 'subject heading thesaurus' basically defines the issuing authority
that created the authority record. For example, a value of "a" means that
it came from LoC. A value of "n" means that it is a locally created
authority. Note that within the authority MARC editor the 'Subject
Heading Thesaurus' is stored/displayed in the 'Subj' fixed field.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoTPAC discoverability release notes entry
Dan Scott [Wed, 18 Feb 2015 21:17:32 +0000 (16:17 -0500)]
TPAC discoverability release notes entry

Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoLP1171984: Stamping upgrade script
Mike Rylander [Wed, 18 Feb 2015 20:24:50 +0000 (15:24 -0500)]
LP1171984: Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1171984 vandelay authority rec attr create repair
Bill Erickson [Fri, 19 Dec 2014 15:53:23 +0000 (10:53 -0500)]
LP#1171984 vandelay authority rec attr create repair

After selecting a bib attribute to view then attempting to create an
authority record attribute, the editor would get confused and think it
was trying to update an existing attribute.  This clears the "we are
editing attr X" flag so create will create instead of update.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1171984 Vandelay auth. match release notes
Bill Erickson [Fri, 28 Nov 2014 20:48:14 +0000 (15:48 -0500)]
LP#1171984 Vandelay auth. match release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1171984 Vandelay authority record matching
Bill Erickson [Fri, 14 Nov 2014 15:16:27 +0000 (10:16 -0500)]
LP#1171984 Vandelay authority record matching

Adds support for building and using authority match sets in vandelay for
import record matching.  Match sets include MARC tag/subfield matching
and normalized authority heading + thesaurus matching.

Commit also contains various small Vandelay UI repairs related to
displaying authority queues and matches.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#957466: Stamping Upgrade Script
Jason Stephenson [Wed, 18 Feb 2015 15:13:56 +0000 (10:13 -0500)]
LP#957466: Stamping Upgrade Script

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
4 years agoLP#957466 Vandelay set the 905$u on imported bib records to current user.
Jason Stephenson [Fri, 13 Feb 2015 17:22:19 +0000 (12:22 -0500)]
LP#957466 Vandelay set the 905$u on imported bib records to current user.

This will cause the code in the previous commit to trigger and update the
appropriate fields in biblio.record_entry.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
4 years agoLP#957466: Update editor/edit_date/source on overlay
Remington Steed [Mon, 13 Oct 2014 16:22:32 +0000 (12:22 -0400)]
LP#957466: Update editor/edit_date/source on overlay

This commit does three things.

1. It removes some declared variables that are never used in this
function.

2. It updates the bib record edit_date field (along with the editor) if
an editor is found in the MARC. If an editor is not found (or doesn't
match an Evergreen user), it seems best to leave the edit_date
unchanged so as not to imply that the previous editor is responsible for
the newest edit.

3. If a bib source is chosen in the vandelay importer UI, it updates the
bib record with the source. To access this field, the reference to table
"queued_record" is replaced by its child table "queued_bib_record".
Since the new table is a child of the other, all of the other needed
values are still available.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
4 years agoLP#1413592: DB upgrade script numbering
Mike Rylander [Mon, 16 Feb 2015 14:57:53 +0000 (09:57 -0500)]
LP#1413592: DB upgrade script numbering

Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agolp1413592: Release notes entry for no changes to fully-paid lost transactions
Kathy Lussier [Sat, 14 Feb 2015 21:43:02 +0000 (16:43 -0500)]
lp1413592: Release notes entry for no changes to fully-paid lost transactions

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1413592: Avoid generating fines in "consider zero balance closed" mode
Mike Rylander [Tue, 10 Feb 2015 15:46:20 +0000 (10:46 -0500)]
LP#1413592: Avoid generating fines in "consider zero balance closed" mode

We will now also disable the behavior triggered by the "Lost Checkin
Generates New Overdues" org setting when the new "Do not change fines/fees
on zero-balance LOST transaction" org setting is enabled.  This is to follow
the new rule that the new setting creates: a zero-balance LOST transaction is
considered handled, and should not be changed by the system.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1413592: Don't change lost/long-overdue fines/fees on zero-balance
Mike Rylander [Wed, 28 Jan 2015 13:40:20 +0000 (08:40 -0500)]
LP#1413592: Don't change lost/long-overdue fines/fees on zero-balance

The situation that has been reported as the worst offender for creating
negative balances for folks that do not want that to happen goes like this:

1) Item is lost or goes long-overdue
2) Fees/fines charged
3) Said fees/fines are paid in full
4) Item is found and returned
4a) "Void fines and fees on lost item return" settings are enabled
4b) "Reinstate overdue fines on lost item return" setting is enabled
4c) System dutifully voids the lost fines/fees
4d) System dutifully reinstates the overdue fines

So we add an YAOUS to ensure that when a lost item is returned and the
balance of the transaction is exactly $0, the lost fines and fees are not
voided EVEN IF "void fines and fees on lost/long-overdue return" settings are
enabled, and voided overdue fees are likewise not reinstated EVEN IF
"restore overdue on lost/long-overdue return" settings are enabled.

The reason for the second condition is that the point of this new setting is
to have Evergreen consider zero-balance lost/long-overdue transactions as
"handled", and that they should not automatically change.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1410532: Add release note for "show more details" option
Ben Shum [Mon, 16 Feb 2015 09:46:08 +0000 (04:46 -0500)]
LP#1410532: Add release note for "show more details" option

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1413769: Add release note for new link to My Lists
Ben Shum [Mon, 16 Feb 2015 09:42:48 +0000 (04:42 -0500)]
LP#1413769: Add release note for new link to My Lists

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1413769: Better access to My Lists
Christine Morgan [Thu, 5 Feb 2015 17:10:13 +0000 (12:10 -0500)]
LP#1413769: Better access to My Lists

Adds a link to My Lists from topnav for more direct access for patrons.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1411106: Add URIs to the list of bib records for sitemaps
Dan Scott [Thu, 15 Jan 2015 04:38:09 +0000 (23:38 -0500)]
LP#1411106: Add URIs to the list of bib records for sitemaps

Also make the org unit ancestor / descendant checks much more
robust by using the appropriate functions.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1410532: Follow-up to fix config option for "Show more details"
Ben Shum [Mon, 16 Feb 2015 09:24:29 +0000 (04:24 -0500)]
LP#1410532: Follow-up to fix config option for "Show more details"

Somehow we got two entries in config.tt2 for the "Show more details". Remove
one of these so that there's no confusion over how the variable is set and
applied.

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1410532: TPAC - Make "Show more details" in results optional
Art Rhyno [Mon, 13 Aug 2012 21:22:17 +0000 (17:22 -0400)]
LP#1410532: TPAC - Make "Show more details" in results optional

Academic sites typically handle a lot of electronic content and want to
bring most details about entries, such as availability, status, and
URLs, on a results screen to the front.

This adds a 'show_more_details.default' option in 'config.tt2' that can
have the values 'true', 'false' and 'hide'.  The 'true' and 'false'
values set the default for the button to more and less respectively, and
'hide' suppresses the button from showing at all.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1410532: TPAC "Show more details" config option
Dan Scott [Tue, 13 Jan 2015 21:30:35 +0000 (16:30 -0500)]
LP#1410532: TPAC "Show more details" config option

Enable sites to either enable the "Show more details in search results"
by default, or to turn on the detailed search results and hide the UI
widget entirely.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1406025: Provide graceful human output for HTTP errors
Dan Scott [Sun, 28 Dec 2014 03:35:37 +0000 (22:35 -0500)]
LP#1406025: Provide graceful human output for HTTP errors

For the expected HTTP errors of HTTP_GONE (record deleted)
and HTTP_NOT_FOUND (record never existed), return the HTML
pages that we used to return (red border warning that the
record was deleted, or just an empty template for
non-existing records) so that the user can at least try
another search. However, the HTTP status code gets set to
410 or 404 as expected so that machines can react
accordingly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1406025: Return 404 or 410 HTTP status codes for bibs
Dan Scott [Sun, 28 Dec 2014 01:25:50 +0000 (20:25 -0500)]
LP#1406025: Return 404 or 410 HTTP status codes for bibs

If a record has been deleted, return a 410 Gone status code; if it doesn't
exist at all, return a 404 Not Found code.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1414033: Add rel="nofollow" to search/browse links
Dan Scott [Fri, 6 Feb 2015 22:13:27 +0000 (17:13 -0500)]
LP#1414033: Add rel="nofollow" to search/browse links

Mark links in the TPAC that robots should not attempt to crawl (such as
search results, call number browsing, adding records to temporary lists,
placing holds, logging in) using the rel="nofollow" convention, per
https://support.google.com/webmasters/answer/96569?hl=en

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1419977: Map subject headings to schema:about
Dan Scott [Mon, 9 Feb 2015 20:26:17 +0000 (15:26 -0500)]
LP#1419977: Map subject headings to schema:about

http://schema.org/about is a more specific fit for subject headings,
which describe what a given title is about, than the more generic
http://schema.org/keywords. This is the emerging standard mapping
seen in other implementations.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1406451: Prevent some catalogue pages from being indexed
Dan Scott [Sun, 11 Jan 2015 03:09:48 +0000 (22:09 -0500)]
LP#1406451: Prevent some catalogue pages from being indexed

Tell search engines that they should not index search results
pages, call number browsing pages, and the like. We really
just want them to focus on records and the library pages.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1406451: Set rel=canonical for record and library pages
Ben Shum [Mon, 16 Feb 2015 08:59:00 +0000 (03:59 -0500)]
LP#1406451: Set rel=canonical for record and library pages

Search engines use the "<link rel=canonical>" convention to determine that, no
matter how many variations on a URL you might generate through the likes of
appending &query= parameters, etc, those URLs are all the same as the value of
the href attribute in the <link> element.

Start with a simple implementation that, first, provides a placeholder in the
TPAC base where any page-specific <meta> or <link> (or really, any other <head>
contents) should go; then denotes the current page URL (stripped of all query
params) as the canonical URL for record and library pages.

This should help prevent search engines from crawling endless variations of the
same page, lowering load on Evergreen servers and potentially improving the
ranking of the canonical URLs.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/templates/opac/parts/base.tt2

4 years agoLP#1406013: Improve schema.org expression for electronic resources
Dan Scott [Sat, 27 Dec 2014 22:06:18 +0000 (17:06 -0500)]
LP#1406013: Improve schema.org expression for electronic resources

Specify the URL from which an electronic resource is available as the
schema:url of the associated schema:Offer. Also, if we have descriptive
link text and/or a note about the electronic resource, mark it up with
schema:description.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1405812: Relate contributors to the id.loc.gov relator vocab
Dan Scott [Fri, 26 Dec 2014 16:57:37 +0000 (11:57 -0500)]
LP#1405812: Relate contributors to the id.loc.gov relator vocab

If we have relator codes (subfield 4), then we can specify the
nature of the contribution being played much more accurately
for machines than just schema:contributor by including the
relator code as a second value of the @property.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1402921: Add the ability to link to sameAs and exampleOfWork entities
Dan Scott [Tue, 16 Dec 2014 04:29:35 +0000 (23:29 -0500)]
LP#1402921: Add the ability to link to sameAs and exampleOfWork entities

Look for standard identifiers with known URIs, such as
LCCNs, OCLC numbers, and URIs identified in 024 fields,
and add http://schema.org/sameAs or
http://schema.org/exampleOfWork properties to the record.
This helps us link out to the broader linked data world,
and should help those consuming our data to better
understand what resources we have to offer.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1421673 Typo in webby: "Databse ID"
Dan Scott [Fri, 13 Feb 2015 15:17:48 +0000 (10:17 -0500)]
LP#1421673 Typo in webby: "Databse ID"

Fixes a typo in the record display in webby.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1402797 Check for a copy before trying to use it -- fixes non-cat checkout failure
Mike Rylander [Fri, 30 Jan 2015 18:04:42 +0000 (13:04 -0500)]
LP#1402797 Check for a copy before trying to use it -- fixes non-cat checkout failure

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1402797 browser client noncat circ display
Bill Erickson [Wed, 31 Dec 2014 21:05:53 +0000 (16:05 -0500)]
LP#1402797 browser client noncat circ display

Adds a new tab to the patron items out page for Non-Cataloged
Circulations.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 browser client noncat counts in patron summary
Bill Erickson [Wed, 31 Dec 2014 21:00:06 +0000 (16:00 -0500)]
LP#1402797 browser client noncat counts in patron summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 browser client interval parser
Bill Erickson [Wed, 31 Dec 2014 20:28:48 +0000 (15:28 -0500)]
LP#1402797 browser client interval parser

Adds a new service on the core module for adding date handling
utilities.  Included in this commit is a new function:

egDate.intervalToSeconds(interval);

Includes Gruntfile additions and unit tests.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 PCRUD access for noncat circs in IDL
Bill Erickson [Wed, 31 Dec 2014 20:26:03 +0000 (15:26 -0500)]
LP#1402797 PCRUD access for noncat circs in IDL

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 patron search form focus repairs cont.
Bill Erickson [Fri, 2 Jan 2015 16:21:43 +0000 (11:21 -0500)]
LP#1402797 patron search form focus repairs cont.

Building on Mike's original work, use Angular ng-mouseover and the
Angular $document built-in.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 use null as default payment amount
Galen Charlton [Fri, 26 Dec 2014 22:46:31 +0000 (22:46 +0000)]
LP#1402797 use null as default payment amount

This means that operator does not have to select the
previous default of "0" in the control to clear it out.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 webby: catalog record -> view holds org filter repair
Bill Erickson [Mon, 15 Dec 2014 18:47:51 +0000 (13:47 -0500)]
LP#1402797 webby: catalog record -> view holds org filter repair

Selecting a pickup library from the filter in the Catalog -> View Holds
UI shows holds for the selected org unit and descendant org units.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Repair browser client dropdown buttons - #2
Bill Erickson [Mon, 15 Dec 2014 18:46:14 +0000 (13:46 -0500)]
LP#1402797 Repair browser client dropdown buttons - #2

Repairs egOrgSelector.

Angular-ui-bootstrap as of version ~0.11.2 does not want bare
"dropdown-toggle" attributes within action link tags.  When present,
they prevent the dropdown button from opening.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Allow, and use, disabling of button-ish anchors
Mike Rylander [Wed, 17 Dec 2014 16:31:24 +0000 (11:31 -0500)]
LP#1402797 Allow, and use, disabling of button-ish anchors

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Only enable the Apply Payment button when a bill is selected
Mike Rylander [Wed, 17 Dec 2014 15:57:28 +0000 (10:57 -0500)]
LP#1402797 Only enable the Apply Payment button when a bill is selected

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 webby: checkin fine tally patron bills link
Bill Erickson [Fri, 12 Dec 2014 22:27:06 +0000 (17:27 -0500)]
LP#1402797 webby: checkin fine tally patron bills link

Checkin fine tally display now acts as a link which opens a new tab to
the patron bills page for the current checkin patron when fines exist.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Actually do search button, too
Mike Rylander [Fri, 12 Dec 2014 21:43:53 +0000 (16:43 -0500)]
LP#1402797 Actually do search button, too

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Focus patron search field on search, expand, clear
Mike Rylander [Fri, 12 Dec 2014 21:41:24 +0000 (16:41 -0500)]
LP#1402797 Focus patron search field on search, expand, clear

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Use .finally() instead of hash-y syntax~
Mike Rylander [Fri, 12 Dec 2014 19:02:29 +0000 (14:02 -0500)]
LP#1402797 Use .finally() instead of hash-y syntax~

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Apply focus in the .finally() in case there was a popup
Mike Rylander [Fri, 12 Dec 2014 19:01:59 +0000 (14:01 -0500)]
LP#1402797 Apply focus in the .finally() in case there was a popup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 fix checkout focus after patron load
Jason Etheridge [Fri, 5 Dec 2014 21:59:30 +0000 (16:59 -0500)]
LP#1402797 fix checkout focus after patron load

Thanks to berick and jcamins, and to eeevil for actually nailing the solution

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Repair browser client dropdown buttons
Bill Erickson [Thu, 4 Dec 2014 22:22:46 +0000 (17:22 -0500)]
LP#1402797 Repair browser client dropdown buttons

Angular-ui-bootstrap as of version ~0.11.2 does not want bare
"dropdown-toggle" attributes within action link tags.  When present,
they prevent the dropdown button from opening.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 webby: repair Hatch type=text printing
Bill Erickson [Wed, 3 Dec 2014 19:57:54 +0000 (14:57 -0500)]
LP#1402797 webby: repair Hatch type=text printing

When printing text, Hatch was receiving no print content due to some
code refactoring.  Repaired.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Avoid org tree retrieval race condition on patron app
Bill Erickson [Wed, 3 Dec 2014 17:48:12 +0000 (12:48 -0500)]
LP#1402797 Avoid org tree retrieval race condition on patron app

Avoid calling egOrg.ancestors() during startup, because the org unit
tree is not guarantee to be available until startup has completed.  This
was causing an occasional JS excpetion in the patron app pages, which
prevented the pages from loading.

The error in question:

 TypeError: Cannot read property 'map' of undefined
    at Object.service.get (https://host/js/ui/default/staff/services/org.js:21:25)
    at Object.service.ancestors (https://host/js/ui/default/staff/services/org.js:34:28)
    at Object.egCore.env.classLoaders.actsc (https://host/js/ui/default/staff/circ/patron/app.js:41:37)
    at https://host/js/ui/default/staff/services/env.js:77:55
    at Object.r [as forEach] (https://host/js/ui/default/staff/build/js/angular.min.js:7:290)
    at Object.service.load (https://host/js/ui/default/staff/services/env.js:76:17)
    at https://host/js/ui/default/staff/services/startup.js:64:23
    at J (https://host/js/ui/default/staff/build/js/angular.min.js:101:96)
    at https://host/js/ui/default/staff/build/js/angular.min.js:102:259
    at h.$eval (https://host/js/ui/default/staff/build/js/angular.min.js:113:32)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Adjust timestamp with local timezone before truncating to the date
Mike Rylander [Wed, 3 Dec 2014 21:40:50 +0000 (16:40 -0500)]
LP#1402797 Adjust timestamp with local timezone before truncating to the date

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Add usr and requestor columns to the hold pull list
Mike Rylander [Wed, 3 Dec 2014 15:54:34 +0000 (10:54 -0500)]
LP#1402797 Add usr and requestor columns to the hold pull list

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Begin teaching grid about class hierarchies for labels
Mike Rylander [Wed, 3 Dec 2014 15:54:13 +0000 (10:54 -0500)]
LP#1402797 Begin teaching grid about class hierarchies for labels

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Fetch old circ when the user is not the same (API misuse)
Mike Rylander [Wed, 3 Dec 2014 15:53:35 +0000 (10:53 -0500)]
LP#1402797 Fetch old circ when the user is not the same (API misuse)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Browser client checkout 'Done' clears current user
Bill Erickson [Tue, 2 Dec 2014 22:28:01 +0000 (17:28 -0500)]
LP#1402797 Browser client checkout 'Done' clears current user

Clicking the 'Done' button after checkout resets the patron side bar and
action tabs to completely hide the previous patron's data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Remove useless options in record bucket export
Mike Rylander [Wed, 26 Nov 2014 15:48:07 +0000 (10:48 -0500)]
LP#1402797 Remove useless options in record bucket export

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Allow the status bar to be hidden
Mike Rylander [Wed, 12 Nov 2014 20:00:07 +0000 (15:00 -0500)]
LP#1402797 Allow the status bar to be hidden

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Separate stock and custom penalty type models
Mike Rylander [Wed, 12 Nov 2014 15:46:43 +0000 (10:46 -0500)]
LP#1402797 Separate stock and custom penalty type models

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Supply top-level method for uncanceling holds
Mike Rylander [Tue, 11 Nov 2014 18:26:21 +0000 (13:26 -0500)]
LP#1402797 Supply top-level method for uncanceling holds

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Fix boolean assumption
Mike Rylander [Tue, 11 Nov 2014 18:25:55 +0000 (13:25 -0500)]
LP#1402797 Fix boolean assumption

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Sort by class, and keep columns from one class together
Mike Rylander [Tue, 11 Nov 2014 18:25:25 +0000 (13:25 -0500)]
LP#1402797 Sort by class, and keep columns from one class together

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Adjust the default for penalty type so it is selected
Mike Rylander [Tue, 11 Nov 2014 18:24:39 +0000 (13:24 -0500)]
LP#1402797 Adjust the default for penalty type so it is selected

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Add invalid-address alert
Mike Rylander [Thu, 30 Oct 2014 15:06:14 +0000 (11:06 -0400)]
LP#1402797 Add invalid-address alert

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Add Check Number input
Mike Rylander [Thu, 30 Oct 2014 14:50:03 +0000 (10:50 -0400)]
LP#1402797 Add Check Number input

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Add the ability (and action) to uncancel holds
Mike Rylander [Thu, 30 Oct 2014 14:38:15 +0000 (10:38 -0400)]
LP#1402797 Add the ability (and action) to uncancel holds

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Ignore the "current_copy" field, we already get that separately
Mike Rylander [Thu, 30 Oct 2014 14:18:07 +0000 (10:18 -0400)]
LP#1402797 Ignore the "current_copy" field, we already get that separately

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Teach autogrid how to ignore fields explicitly
Mike Rylander [Thu, 30 Oct 2014 14:17:49 +0000 (10:17 -0400)]
LP#1402797 Teach autogrid how to ignore fields explicitly

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Add patron barcode and alias to hold lists where appropriate
Mike Rylander [Thu, 30 Oct 2014 13:57:11 +0000 (09:57 -0400)]
LP#1402797 Add patron barcode and alias to hold lists where appropriate

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Fix "scan item for missing pieces" label to say Item instead of Patron
Mike Rylander [Thu, 30 Oct 2014 13:06:53 +0000 (09:06 -0400)]
LP#1402797 Fix "scan item for missing pieces" label to say Item instead of Patron

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Make "Checkout" the consistent spelling in the IDL
Mike Rylander [Thu, 30 Oct 2014 13:01:21 +0000 (09:01 -0400)]
LP#1402797 Make "Checkout" the consistent spelling in the IDL

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Comment out Hide/Show All in autogrid
Mike Rylander [Thu, 30 Oct 2014 12:59:02 +0000 (08:59 -0400)]
LP#1402797 Comment out Hide/Show All in autogrid

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Add label to custom penalty dropdown
Mike Rylander [Thu, 30 Oct 2014 12:57:45 +0000 (08:57 -0400)]
LP#1402797 Add label to custom penalty dropdown

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Push explicitly added columns to the top and keep the explicit order,...
Mike Rylander [Mon, 22 Sep 2014 16:03:48 +0000 (12:03 -0400)]
LP#1402797 Push explicitly added columns to the top and keep the explicit order, then sort the rest by their labels

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Add catalog search to the search menu in the nav bar
Mike Rylander [Mon, 22 Sep 2014 16:02:55 +0000 (12:02 -0400)]
LP#1402797 Add catalog search to the search menu in the nav bar

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1402797 Add checkout/in workstation colums to the available set
Mike Rylander [Mon, 22 Sep 2014 16:02:33 +0000 (12:02 -0400)]
LP#1402797 Add checkout/in workstation colums to the available set

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoForward-port 2.7.2-2.7.3 upgrade script
Ben Shum [Wed, 4 Feb 2015 21:08:41 +0000 (16:08 -0500)]
Forward-port 2.7.2-2.7.3 upgrade script

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1418164: Fix 0905.schema.user_currnet_normalize_heading.sql.
Jason Stephenson [Wed, 4 Feb 2015 18:38:45 +0000 (13:38 -0500)]
LP#1418164: Fix 0905.schema.user_currnet_normalize_heading.sql.

We can't alter a table, enabling triggers in this case, while a
table has trigger events pending.  We move the trigger enabling
to outside the transaction to resolve this.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1261777 repair cloned addr owner link
Bill Erickson [Tue, 17 Dec 2013 14:57:08 +0000 (09:57 -0500)]
LP#1261777 repair cloned addr owner link

Repair reference to undefined variable (offline) in spawn_editor()
function, which is responsible for opening the tab for the linked
patron.  Variable should be "offlineStrings".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1390138: Clarify 2.6-2.7 upgrade path
Ben Shum [Wed, 4 Feb 2015 18:10:50 +0000 (13:10 -0500)]
LP#1390138: Clarify 2.6-2.7 upgrade path

The file for upgrading from 2.6 to 2.7 series changed to be specifically
2.6.3-2.7.0 (not just 2.6 to 2.7.0 but 2.6.3 to 2.7.0).

Additionally, alter note on reingesting to include that it might be required
post upgrade script running.

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1390138: Remove references to Ubuntu Lucid Lynx 10.04 as this is not supported
Ben Shum [Wed, 4 Feb 2015 17:59:23 +0000 (12:59 -0500)]
LP#1390138: Remove references to Ubuntu Lucid Lynx 10.04 as this is not supported

Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1390138: Updating Upgrade and Install docs for 2.7
Josh Stompro [Tue, 27 Jan 2015 17:01:12 +0000 (11:01 -0600)]
LP#1390138: Updating Upgrade and Install docs for 2.7

 - Updated docs to use 2.7.3 as the base in case this gets included in 2.7.3

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1390138: Updating Upgrade and Install docs for 2.7
Josh Stompro [Wed, 12 Nov 2014 15:19:11 +0000 (09:19 -0600)]
LP#1390138: Updating Upgrade and Install docs for 2.7

Upgrade Docs
- Bolded all linux user names so the format matches the install docs.
- Added note about postgres 9.3 being recommended version and 9.1 being the minium version.
- Added Fedora to list of supported linux distros so it matches install docs.
- Added a note about the different apache config files for apache 2.4+ vs Apache 2.2.
- Added a link to troubleshooting section of install docs.

Install Docs
- Added notes about 9.3 being recommened version of postgres and 9.1 being the minimum.
- Changed opensrf version from 2.3.0 to 2.4.0

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1390138: Another update for install/update docs - added make install
Josh Stompro [Fri, 7 Nov 2014 16:05:45 +0000 (10:05 -0600)]
LP#1390138: Another update for install/update docs - added make install

The docs say that the make command will copy the packages into the /updates folder, but without
"make install" that doesn't happen.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1390138: Updated upgrade docs for 2.7.1
Josh Stompro [Thu, 6 Nov 2014 22:16:26 +0000 (16:16 -0600)]
LP#1390138: Updated upgrade docs for 2.7.1

Missed one instance of 2_6_1 in the /openils/var/web/xul server symlink section.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1390138: Updated upgrade docs for 2.7.1.
Josh Stompro [Thu, 6 Nov 2014 17:24:31 +0000 (11:24 -0600)]
LP#1390138: Updated upgrade docs for 2.7.1.

Added in section about checking the release notes for other upgrade steps to the end.

Added in the step to restart memcached as Galen Charlton mentioned in his 11/5 dev list email
about clearing out old login sessions for security reasons.

Added in Jessie and Trusty with a pointer to the Ruby EDI bug that users of the distributions
will run into.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1413660: Stamping upgrade script to change z3950 function
Ben Shum [Tue, 3 Feb 2015 21:12:14 +0000 (16:12 -0500)]
LP#1413660: Stamping upgrade script to change z3950 function

Signed-off-by: Ben Shum <bshum@biblio.org>