The last follow-up had the inadvertent side-effect of hiding the
message directing the patron to contact their library if they had a
negative balance. My thought is that if there are negative bills then
the patron should see the alert to contact their library about them
regardless of whether or not online payments are allowed. So, this
additional followup separates that alert from the myopac_cc_allowed logic.
This also makes some minor display tweaks to the BooPAC:
- Applies the Bootstrap 'alert-warning' to the negative bills message
in the BooPAC.
- Adds a page header.
- Changes the styling and wording of the grocery charges heading to match
the circulation charges heading.
- Changes the styling of the grocery and circulation tables to be
consistent with each other.
Jason Etheridge [Mon, 18 Jul 2022 19:02:54 +0000 (15:02 -0400)]
LP1981628 follow-up to the follow-up
Consolidate some of the logic to make it more clear what is happening,
leverage the existing myopac_cc_allowed boolean, and catch the
Pay All Charges button in the TPAC. This also clears up some display
oddities and makes sure the non-payment labeling is being used.
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
When using Shibboleth for SSO, and global logout is disabled, logging in
after logout on the same computer can fail with a 404-Not Found. The
problem is that we need to ignore our local "don't trust Shibboleth
login" cookie in this situation.
This change also means we need to delegate SP logout, in addition to
possible IdP and/or global logout, to the Shibboleth configuration.
Therefore we always redirect to the Shibboleth logout service on
Evergreen logout (when Shibboleth SSO is enabled), and SP, IdP, and
global logout is configured and mediated by the Shibboleth and IdP
configuration.
This commit modifies the meaning of the opac.login.shib_sso.logout YAOUS
such that it is only used to decide if Evergreen timeout-forced logouts
will cause a Shibboleth logout as well. All user-initiated logouts will
now inform Shibboleth, and the Shibboleth configuration will determine
the SSO logout degree (SP, IdP, global).
See details at
https://shibboleth.atlassian.net/wiki/spaces/SHIB2/pages/2577072384/NativeSPLogoutInitiator
and the simpler configuration option of
https://shibboleth.atlassian.net/wiki/spaces/SHIB2/pages/2577072434/NativeSPServiceLogout
for information on the Shibboleth configuration required for your local
needs.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
- don't bother checking the reactor; instead, assume that
if the event definition includes a context user path that
evaluates to a discernable user record, there is reason
to check for the user's preferred locale and for alternative
templates
- make this section of code more idiomatic
LP#1986479: fix lookup of user locale during A/T event processing
This patch fixes an issue with the new user-locale-sensitive
alternate Action Trigger template selection that supports letting
patrons receive notifications in their preferred language. In
particular, it corrects an assumption that the event target is
the user itself. With the patch, the the event definition's
context user path is consulted to identify the relevant user.
To test
-------
[1] Set up a patron with an email address and check out an item.
[2] Use the Quick Receipt drop-down to attempt an email checkout
receipt.
[3] No email will be generated an the event will fail. The logs
should contain something like
Can't use an undefined value as a HASH reference at
/usr/local/share/perl/5.28.1/OpenILS/Application/Trigger/Event.pm
line 518.
[4] Apply the patch and repeat steps 1 and 2. This time, the email
should be sent (or, at least, the A/T event will be successfully
processed).
The format service also gets a dateOnlyIntervalField parameter to
display dates as dates or dates + time depending on whether the provided
duration is day-granular.
Also adds a handy pipe (egDueDate) which takes a circulation as its
value and collects the correct parameters to display the due date in the
correct time zone and with the correct dateOnlyIntervalField value.
Example:
{{circ | egDueDate}}
Includes Sandbox examples.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
This patch fixes a bug where AutoFieldWidget wouldn't
invoke the callback when building an org unit selector. Fixing this
allows library settings (including acq.default_owning_lib_for_auto_lids
added in the previous patch) whose datatype is link and whose fm_class
is aou to work in the Dojo Library Settings editor.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#1981714: add settings to control owning library of auto-added LIDs
Previously, when line item copies/details/items where automatically created
because the provider's default copy count is non-zero, the owning library
of those line item copies was set to the workstation library. This patch
adds two new settings to tweak this behavior:
* How to set default owning library for auto-created line item items
Stategy to use to set default owning library to set when line item items
are auto-created because the provider's default copy count has been set.
Valid values are "workstation" to use the workstation library, "blank"
to leave it blank, and "use_setting" to use the "Default owning library
for auto-created line item items" setting. If not set, the workstation
library will be used.
* Default owning library for auto-created line item items
The default owning library to set when line item items are auto-created
because the provider's default copy count has been set. This applies if
the "How to set default owning library for auto-created line item
items" setting is set to "use_setting".
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
* set 024 ind1 correctly (i.e., to '1') when applying UPC as order
identifier
* add flesh_po_items_further option to PO retrieval
This fleshes in any fund debits and debit invoice items associated
with PO direct charges
* add open-ils.acq.po_item.disencumber method
This method disencumbers a PO item by setting its fund debit's amount
to zero. Note that this can be done only for encumbrances; if the
debit is an expenditure, it cannot be changed.
* add flesh_li_details_receiver to LI retrieval
* add two additional fleshing options to LI retrieval
Specifically, flesh_copy_location and flesh_call_number. These take
effect only when flesh_copies is also true and are used to further
flesh values of items attached to line item details.
* remove cancel reason if last LID of LI is received
Otherwise, a sequence where a line item was cancelled but one of
its items was received would have the LI end up in a received
state but with a cancel reason.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Galen Charlton [Thu, 10 Feb 2022 16:00:22 +0000 (11:00 -0500)]
LP#1960526: adjust link color on Angular and AngularJS staff interfaces
Change the default link blue on the Angular and AngularJS interfaces
to #255a88. This achieves two things:
- Improves the color contrast on the AngularJS side against a white
background from AA for normal text to AAA.
- Improves the Angular side so that it meets AAA color contrast for
normal and large text, instead of meeting only AA for large text.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Wed, 14 Jul 2021 14:52:44 +0000 (10:52 -0400)]
LPLP1929741 Optional experimental Acq; seed data
Adds and org setting and a workstation setting to 1) enable display of
experimental Angular ACQ UI's and 2) enable display of links to the
experimental UI's from search results.
Display a new menu entry "Acquisitions (Experimental)" when the org
setting is enabled. This menu contains "Create Purchase Order" only for
now.
Copy seed data from upgrade file to seed data file.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Thu, 24 Jun 2021 15:30:24 +0000 (11:30 -0400)]
LP1929741 Welcome page navigates to staff w/ href
When a route failure occurs, etc. and the user is sent back to the
Welcom to Webby page, make the link to the staff page an href instead of
a routerLink, so Angular is forced to load new route data.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Tue, 22 Jun 2021 15:43:05 +0000 (11:43 -0400)]
LP1929741 Batch of PO fixes
* Avoid clearing the owning library during batch edit copy operations
* Leverage combobox startsWith for distribution formulas
* Disable the order ident selector so it cannot be modified after a PO
is activated
* Add some icons to the PO actions for more eye-grabbiness.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Mon, 14 Jun 2021 21:43:15 +0000 (17:43 -0400)]
LP1929741 ACQ order ident indicate multiples
When multiple order identifer values (e.g. ISBN's) exist on a lineitem,
the number of options is now displayed just to the left of the
identifier selector.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Mon, 14 Jun 2021 21:35:21 +0000 (17:35 -0400)]
LP1929741 Apply default lineitem order identifers
Apply a default order identifier to lineitems instead of leaving the
selector blank. Ensure the value that will display in the selector
matches what's in the database by setting the value on load when needed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Fri, 11 Jun 2021 15:29:47 +0000 (11:29 -0400)]
LP1929741 Bundle of ACQ bug fixes
* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1991444: Cleanup Build Docs Artifacts in GitHub Actions
The Build Docs GitHub action leaves the built docs behind as
artifacts. These artifacts currently use about 58MB apiece. This can
quickly consume all of the available storage spacce (500MB) for
free-tier GitHub accounts.
This commit adds a retention-days setting of 2 so that build docs
artifacts should be removed after two days.
Jason Stephenson [Sun, 18 Sep 2022 13:38:40 +0000 (09:38 -0400)]
LP1990018: Fix libdbi build
Resolve issues with finding libdbi and libdbdpgsql on ARM64 by using better
autoconf hygiene:
* Use PKG_CHECK_MODULES to find and set the dbi library flags.
* Remove the "backup" code to find a manually installed libdbi.
(This has not been needed for some time.)
* Update Makefile.ams to use the dbi LDFLAGS properly.
* Remove -ldbdpgsql from compile commands.
(It is loaded dynamically.)
I tested it on a x86_64 VM with Ubuntu 22.04. Most tests passed. Only the
remot auth and cover uploader tests failed. The latter have not passed for
some time, and I believe the former may have been affected by a recent
change unrelated to this commit.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jeff Davis [Wed, 6 Jul 2022 19:10:41 +0000 (12:10 -0700)]
LP#1980867: optionally remove traditional catalog from staff client menu
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
LP1953381 not-allowed pointer for inactive buttons
Adds a style to change the mouse pointer to the "no" symbol for disabled
buttons.
To test:
1. Apply patch.
2. Go to an item record in the staff catalog.
3. Mouse over the "Set Default View" button (disabled by default on the
Item Table tab).
4. The pointer should change to the "no" symbol.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1909583 Bootstrap Opac: Cannot edit title and description
Fixes the editing of the title and description in the Bootstrap Opac lists.
Adds and Edit List button with a collapsible form.
To Test:
1. Create several lists in the Opac.
2. Notice you are unable to edti the title or description.
3. Apply the patch
4. Use the Edit List button to display an editable form for each individual
list.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP1903767 - Bootstrap Opac: Make other formats and editions more visible.
This patch does the following:
1. Moves "Other Formats and Editions" below # of holds and available items.
2. Changes "Other Options" to "Other Formats and Editions" and makes the
header tage and <h2> tag consistent with other header tags.
3. Resizes <h2> tags.
4. Removes bullets and changes the margins of some of the table/list displays
under the <h2> headers.
5. Fixes the alignment of the button group that contains Place Hold.
For Testing:
1. Find a record that contains other formats and editions. In concerto
record #71 contains other formats and editions.
2. Notice that you have to click the More Details button to view the Other
Formats.
3. Apply the patch.
4. Other Formats and Editions now appear under the Available Copies and
Holds heading. You no longer have to push the More Details button.
Fixing "hold Type" to "Hold Type" in hold details screen
Test plan:
1. Go to the staff interface, right click a hold to see hold details,
observe that "hold Type" is not capitalized
2. Apply the patch
3. Refresh the staff interface hold details screen and observe that
the "Hold Type" is properly capitalized
Garry Collum [Tue, 2 Aug 2022 19:35:39 +0000 (19:35 +0000)]
LP1902272-Bootstrap opac needs to prompt on notification preference update
Adds the prompting of updating holds when default notification preferences
are updated in the Bootstrap opac.
To Test:
1. Place a few holds for a patron.
2. Login to the opac and change some default notification methods.
3. The opac does not prompt to update the holds.
4. Apply the patch.
5. The patron should now be prompted to update holds when default
notification methods are changed.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jane Sandberg [Thu, 11 Feb 2021 01:37:57 +0000 (17:37 -0800)]
LP1907974: Updating call numbers in course module reflected in grid
Also:
* refactors the updateItem method for more idiomatic RxJS usage (e.g.
no nested subscribes)
* corrects some Boolean, String, and Number types to boolean, string,
and number (to use the primitive types instead of objects, as
recommended by the Typescript handbook:
https://www.typescriptlang.org/docs/handbook/basic-types.html#about-number-string-boolean-symbol-and-object)
To test:
1) Go to Local Admin > Course List
2) Double click on a course
3) Go to the materials tab
4) Add an item by barcode, making sure to supply a temporary call
number, and that the call number checkbox is checked.
5) Note that the grid on the right display's the item's old call number,
not its new one.
6) Apply this patch.
7) Repeat step 4. Note that the temporary call number is reflected in
the grid now.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
projects / Evergreen.git / log