dbs [Thu, 20 Dec 2007 19:26:51 +0000 (19:26 +0000)]
Enable translation of ils_events.xml, roundtripping from XML to POT to PO to XML.
Check in a current trunk version of the POT file.
Still need to enable <desc> elements for each xml:lang to merge into the ultimate XML file.
dbs [Sat, 15 Dec 2007 05:29:49 +0000 (05:29 +0000)]
Update to correspond with polib 0.30.1:
* occurences->occurrences
* different handling of header newline characters
Remove some inherited methods that add no new behaviour.
phasefx [Thu, 13 Dec 2007 17:40:19 +0000 (17:40 +0000)]
changed on_retrieve callback for list.full_retrieve so that it can handle an array of callbacks. dump_csv_to_clipboard function for refactoring elsewhere
phasefx [Thu, 13 Dec 2007 15:39:05 +0000 (15:39 +0000)]
refactoring the pick_file/export/import a bit, though chrome/content/main.js is a little more complicated than what I want to tackle right now. Ultimate goal down the road is to abstract things so that we can store data like this on the backend to facilitate sharing/administration
dbs [Mon, 10 Dec 2007 19:41:48 +0000 (19:41 +0000)]
Add a test for incorrect driver in /reporter/; bug found by Ben Ostrowsky.
Test for /reporter/ in xpath including delimiters, instead of just "reporter".
phasefx [Sat, 8 Dec 2007 00:44:32 +0000 (00:44 +0000)]
Hrmm, going back to the old--url param--way of passing data around windows/iframes here. Fixes a regression where Item Details weren't showing for Bill History/Alternate View/Full Details in billing interface. Remind me to never use iframes in the next major staff client overhaul; I'll use Bill & Mike's clone template node strategy first. :) Let's also trap the error I'm working around here, TypeError: this.docShell has no properties when trying to access the contentWindow for these specific iframes
dbs [Fri, 7 Dec 2007 04:09:10 +0000 (04:09 +0000)]
Split out localization base class into basel10n.py
Add a class to support localization of fm_IDL.xml
Generate a POT file for the fieldmapper IDL
Clean up db-seed-i18n.py (thanks to pylint the pedantic)
phasefx [Thu, 6 Dec 2007 23:03:06 +0000 (23:03 +0000)]
banging on the 'dos print' kludge. There was a 1.2 regression involving a file path, which still needs to be tested with an actual windows machine and receipt printer. This changeset also adds linux lpr support for 'dos print'. I may need to use this print strategy for incremental printing, as much as it pains me.
dbs [Tue, 4 Dec 2007 08:17:35 +0000 (08:17 +0000)]
Enable translation of seed values stored in database.
Moves all DML from schema files into a single file.
db-seed-i18n.py will generate POT files and SQL for new localizations.
Commit a new POT file for the database seed values.
miker [Sun, 2 Dec 2007 02:27:33 +0000 (02:27 +0000)]
This is a big commit. It started with a patch from Scott McKellar to
clean up several memory leaks in cstore and provide const-ification. I
was then inspired to add HAVING and multiple predicates per column support.
From Scott:
1. I applied the static qualifier to a number of functions, and a few
variables, that aren't referenced by other files. I left as global
those functions that are registered for dynamic calls.
2. I found a number of cases where a call to buffer_data() was being
passed as a parameter to a function, guaranteeing a memory leak. I
added code to capture the pointer returned by buffer_data() so that I
could free it later.
3. I added code to free a number of growing_buffers, jsonObjects,
and dynamically allocated buffers that were otherwise leaking. In
some cases I had to juggle some extra pointers so that I could
distinguish between things I could delete and things I couldn't. In
other cases I rearranged operations so that the freeing wouldn't get
bypassed. I don't guarantee that I have plugged all the leaks.
4. Whenever possible I replaced buffer_data() with buffer_release(),
to eliminate a round of malloc() and free(). In some cases this
change enabled me to eliminate an intermediate variable.
5. Whenever possible I replaced jsonObjectGetKey() with
jsonObjectGetKeyConst(). Sometimes I had to juggle an extra pointer
or two in order to distinguish between what was const and what wasn't.
6. I applied the const qualifier to a number of local variables and
function parameters.
7. Here and there I changed double leading underscores to single
leading underscores.
dbs [Sat, 1 Dec 2007 19:39:57 +0000 (19:39 +0000)]
Use XML::LibXML's parentNode function to avoid invalid expression warning.
Short-circuit test for driver -> language correspondence to avoid bogus warning noted by Ben Ostrowsky.
miker [Mon, 26 Nov 2007 18:25:09 +0000 (18:25 +0000)]
Big cleanup of the C auth app from Scott McKellar:
1. Apply the const qualifier where possible.
2. Plug memory leaks.
3. Make some global things static.
4. Some minor tidying-up.
Details:
1. The variables __oilsAuthOPACTimeout, __oilsAuthStaffTimeout and
and __oilsAuthOverrideTimeout are now static, since no other file
references them. Also I reduced the leading underscores to one each.
2. In several places I replaced jsonObjectGetKey() with
jsonObjectGetKeyConst().
3. In oilsAuthInit(): I plugged a memory leak by moving the freeing
of username out of an else block and into the code following.
4. In oilsAuthVerifyPassword(): I plugged a memory leak in the case
of an early return.
5. In oilsAuthVerifyWorkstation: I plugged a memory leak by freeing
workstation at the end.
6. In oilsAuthCheckCard(): I eliminated the ctx and userObj parameters.
The function didn't do anything with them except to verify that they
weren't NULL. I transferred that responsibility to the calling code
in oilsAuthComplete() (where I also plugged another memory leak).
7. Also in oilsAuthCheckCard(): I plugged a memory leak by freeing
params and card. Also I rearranged the last few lines a bit so that
we free active in only one place.
8. In oilsAuthComplete(): I plugged a number of memory leaks caused
by a failure to free userObj in various early returns.
9. Also in oilsAuthComplete(): In order to be able make uname a const
pointer, but still be able to delete it when necessary, I created an
intermdiate non-const pointer named freeable_uname -- which also takes
the place of the original freeuname variable used as a boolean.
10. In oilsAuthSessionRetrieve(): I moved the freeing of evt out of
the if-else structure and put it at the end, to make sure that none
of the branches would miss it.
11. Also in oilsAuthSessionRetrieve(): one of the branches of the
if-else had a second variable named evt, hiding the variable of the
same name declared in an enclosing scope. That's not a bug, but it's
confusing. I renamed it to evt2.