Jason Stephenson [Mon, 10 Feb 2020 16:09:37 +0000 (11:09 -0500)]
Lp 1862652: pingest.pl reingest record attributes fix
Use the rdeleted parameter when reingesting record attributes in
pingest.pl support script so that passing argument values to the
--attr option makes sense.
Prior to this patch, arguments of the --attr option would be ignored,
and all record attribute fields were reingested for all records,
deleted and not deleted alike.
With this patch, the arguments of the --attr option are respected for
not deleted records. Deleted records still have all attributes
reingested.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
teaches the Holdings view to determine the number of copies and call
numbers attached to each org unit based on the full data set (via new
API) instead of copies in hand, since we may only have copies in hand
for a subset of child org units.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mary Llewellyn <mllewell@biblio.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Galen Charlton [Thu, 11 Nov 2021 16:21:11 +0000 (11:21 -0500)]
LP#1949910: serialize deleting items from item bucket
This patch serializes the fetching and fleshing of items to delete
when the delete-from-item-bucket action is invoked, thereby
avoiding possible drone starvation from open-ils.search. It
also throws up the progress dialog for good measure while
the deletion occurs.
To test
-------
[1] Set up an item bucket with 25-50 items.
[2] From the item bucket intervace, invoke the action to delete
all of the items.
[3] Note that the open-ils.search.asset.copy.fleshed2.retrieve calls,
one for each item, are all made simultaneously. Assuming stock
max_children settings, this will cause open-ils.search to log
that some requests are hitting the backlog.
[4] Apply the patch and refresh the item bucket page, then repeat
step 2 (it doesn't matter for this purpose that the items have
already been deleted). This time, the open-ils.search API calls
are made serially and a progress bar is displayed while the
deletion takes place. Verify that no requests hit the backlog.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Bill Erickson [Tue, 30 Jul 2019 16:12:12 +0000 (12:12 -0400)]
LP1739277 Angular org selector style callback
Allow the caller of an <eg-org-select> to pass a function which is
called against each org unit in the list to determine what CSS class(es)
should be applied to the org unit label in the list.
Includes sandbox example.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Adjust the eg-basic-combo-box so that it doesn’t give console errors
when typing characters such as [. Fix the bug that causes it to
sometimes show no results when there are valid results that match.
To test
-------
[1] Apply the patch, then create a new report template, add a
display field, then open the Change Transform modal.
[2] Verify that the selection box will accept characters like '['
as input without browser console noise, that the filtering
is case-insensitive, and that filtering continues to work
after clicking on the selector.
[3] Instances of this combo box can also be found in the AngularJS
volume/copy editor.
LP1906842 PLACE_UNFILLABLE_HOLD permission not working if no titles exist
This fix will correct an issue where the screen just keeps looping to
the override screen when trying to place a hold that has no titles
available for it.
Jeff Davis [Thu, 6 Jun 2019 21:30:34 +0000 (14:30 -0700)]
LP#1830089: close transaction and update copy status on payment or adjust to zero
When you make a payment that sets the balance owed to zero, Evergreen
closes the transaction and sets the item status to Lost & Paid (if
appropriate). Adjust to Zero should do the same thing, but hitherto it
would not update the item status. This commit refactors some code to
ensure that Evergreen gives the same result whether you make a payment
or adjust to zero.
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Stephenson [Sun, 24 Oct 2021 18:38:52 +0000 (14:38 -0400)]
LP1948594: Fix pgtap live test
Fix the lp1145213_test_func_asset.merge_record_assets.pg pgtap live
test by removing the COMMIT and adding a ROLLBACK at the end. This
permits the test to run multiple times without requiring a database
reload.
To verify the bug:
1. Install the pgtap package appropriate for your PostgreSQL database
version.
2. Load a fresh database with eg_db_config using the --load-all-sample
option.
3. Create the pgtap extension in the evergreen database.
4. Run the Open-ILS/src/sql/Pg/live_t/ tests with pg_prove.
5. Repeat step 4, and if this patch has not been applied, then the
lp1145213_test_func_asset.merge_record_assets.pg tests will fail on
the second run.
To test the fix, repeat steps 2 - 5, above, after pulling this commit.
Step 5 should succeed.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
If a MARC record has effectively empty fields (all space or punctuation)
then it's possible to stumble over a NULL text array when parsing
content for the symspell dictionary. This commit checks for that
condition and returns early to avoid the problem.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
For certain data, and certain data set sizes, merging the suggestion
arrays used by the symspell algorithm is noticably expensive. This is
the case for suggestion arrays containing many thousands of entries.
These suggestion sets are not only slow, but generally not useful. We
avoid the creation of such overly long suggestion sets using several
word filters that take advantage of our knowledge of the incoming data
to optimize for what is useful in a bibliographic context. The
mechanisms employed by this patch are:
- Omit suggestions whose length is longer than the max prefix key length
when the prefix key length is less than or equal to the maximum prefix
key length minus the maximum edit distance.
- Omit words that contain a run of 5 or more digits. This will drop most
identifiers from the dictionary while still allowing suggestions to
happen for year values.
- Omit empty keys from the dictionary. This should have been the case
already but is now enforced directly.
- Add a small speedup to evergreen.text_array_merge_unique() by making
it assume that arrays passed to it do not have null values, which we
intentionally avoid, and against which we protect in other ways in the
commit.
Besides improving reingest speed, the patches will also make the
search.symspell_dictionary table significantly smaller.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Avoid requiring staff to send an Enter event (keyword / scanner) when
entering a patron barcode into the place holds form. Instead, look the
barcode up after a sufficient amount of time has passed.
Limit the authority_full_rec_value_index and
authority_full_rec_value_tpo_index indexes to the first 1024
characters of a field or subfield in order to avoid database errors
when inserting or updating authorities with long fields.
Include release note and regression test.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Lp 1942920: Show Legacy/Not Dated for Legacy Circs
When legacy circ counts are displayed in the AngularJS client, the
year shows up as -1. This patch attempts to replace -1 with a
translatable string: "Legacy/Not Dated" as was used in the XUL staff
client.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Bill Erickson [Wed, 22 Sep 2021 15:04:18 +0000 (11:04 -0400)]
LP1919465 Pull list only shows holds with current_copy
This avoids a scenario where copy-level holds would appear in the pull
list even if they are not pull-able, because they have "a copy" (i.e.
the requested copy), but no current copy (i.e. targeted copy).
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Wed, 22 Sep 2021 14:24:30 +0000 (10:24 -0400)]
LP1919465 Avoid dupe Current Item's in pull list
* Show a value for Current Item when a hold is targeted
* Show a value for a new column on Requested Item for copy-level holds.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Tue, 14 Sep 2021 15:04:10 +0000 (11:04 -0400)]
LP1919465 Pull List Mark Discard/Weed Action
Includes general purpose discard/weed dialog.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Rename various "Item Location ..." references to "Shelving Location ..."
in the Angular holds grids.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Tue, 14 Sep 2021 14:43:47 +0000 (10:43 -0400)]
LP1919465 Pull list detail show record summary
Display the bib record summary when displaying the hold detail view from
the holds pull list.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Tue, 14 Sep 2021 14:27:30 +0000 (10:27 -0400)]
LP1919465 Pull list prefix/suffix sorting; columns
* Include call number prefix and suffix in hold pull list sorting.
* Apply sane default grid columns.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Fri, 13 Aug 2021 16:02:01 +0000 (12:02 -0400)]
LP1919465 Fix default holds pull list sorting
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Fri, 12 Mar 2021 22:50:40 +0000 (17:50 -0500)]
LP1919465 Holds pull list Angular / Wide Holds API Port
Ports the holds pull list to Angular and takes advantage of the new Wide
Holds API. Includes seed data for grid preferences and a new holds pull
list (server) print template.
The UI displays the total holds count and includes a org unit selector.
It pre-fetches all holds, partly to display the full count, but also
based on the assumption that a pull list will typically be used all or
none.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
This patch enables mod_headers for Debian Stretch and Buster
and Ubuntu Bionic and Focal during installation. Without
mod_headers, the Angular staff client application can have
its index page cached for 24 hours on a stock system, meaning
that browsers will not consistently fetch the updated app
after an upgrade.
This patch does not change the Fedora Makefile as mod_headers
is enabled by default on RHEL-like distributions.
UPGRADE NOTES
-------------
Existing Evergreen systems on Debian and Ubuntu should
do the following to ensure that mod_headers is active:
To test
-------
[1] Perform a fresh installation of Evergreen on Stretch, Buster,
Bionic, or Focal.
[2] Verify that mod_headers is enabled.
[3] (Optional) Fetch the Angular staff client index page, e.g.,
/eg2/staff, and verify that the response headers call for
not caching it.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Shula Link [Tue, 13 Jul 2021 14:16:39 +0000 (10:16 -0400)]
LP1834258 Replace Javascript with Placeholder Attribute
onfocus/onblur javascript replaced with placeholder="[% seed %]" in
Open-ILS/src/templates/kpac/getit.tt2 and
Open-ILS/src/templates/kpac/parts/searchbox.tt2
Signed-off-by: Shula Link <slink@gchrl.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Mike Rylander [Mon, 26 Oct 2020 19:26:09 +0000 (15:26 -0400)]
LP#1901597: Allow multi-subfield match in vandelay.strip_field
Now, when supplying a subfield match restriction for use with
vandelay.strip_field, you can separate multiple restrictions with '&&'
(no quotes). For instance, to remove a Located URI 856 for for a
combination of a specific owner and a specific domain, you might say:
856[u~oldservice.com && 9~MYLIB]
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Stephenson [Fri, 20 Aug 2021 00:20:58 +0000 (20:20 -0400)]
LP1940146: Debian Bullseye Installation Support
Update documentation and prerequisite installation Makefiles to add
support for Debian Bullseye (11.0).
Use PKG_CHECK_MODULES instead of AC_CHECK_PROG to test for the
presence of yaz. This is done because of the following Changelog
entry:
yaz-config and its man page are no longer packaged. Please switch
to pkg-config (yaz, yaz-icu or yaz-server). This also makes the
package reproducible. Closes: #955501
This change works on all currently supported Evergreen distros. You
can test it by running autoreconf -f and then running the normal
configure command.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Stephenson [Thu, 19 Aug 2021 19:16:52 +0000 (15:16 -0400)]
Lp1940145: Remove Installation Support for Debian Jessie
Remove references to Debian Jessie (8.0) in the installation and
upgrade documentation as well as from the prerequisite installation
Makefiles. Debian 8 has been out of long term support for over a year
at this point.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Boyer [Mon, 16 Aug 2021 17:59:28 +0000 (13:59 -0400)]
LP1850156: Remove Browsers From *-developer Targets
Because the developer targets are currently necessary for a from-git
installation, both Firefox and Chrome are removed and the docs updated
to note that you should install one or both if you want to run the tests.
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Mon, 2 Aug 2021 20:30:21 +0000 (16:30 -0400)]
LP1938729 Cache "cascade" setting values
Cache values retrieved from 'open-ils.actor.settings.retrieve' lookups
in IndexedDB, similar to to org unit setting lookups, to reduce the need
for so many API calls for settings retrieval.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
This change places the cursor in the user name field and adjusts the order
of the elements so that tabbing out of the user name field comes to the
password field next.
Note that this modifies both the login modal and the embedded login form.
Bill Erickson [Mon, 11 Jan 2021 15:59:54 +0000 (10:59 -0500)]
LP1911023 Batch hold cancel refreshes before completion
Ensure all hold cancelation promises complete before reporting the
results back to the caller. Issue was result of thinko in the code
that failed to relay one of the promises in the chain, so it reported
promise completion prematurely.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
A change in Perl release 5.26.0 necessitates that the SIP_DIR variable
(default value "/opt/SIPServer") be exported to the environment in
oils_ctl.sh when attempting to start SIPServer. This change affects
Ubuntu 18.04 (Bionic Beaver) and Debian 10 (Buster) and any future
releases.
To verify the bug:
1. Install OpenSRF, Evergreen, and SIPServer on an affected O/S.
2. Start OpenSRF service.
3. Start SIPServer via oils_ctl.sh:
oils_ctl.sh -a start_sip
4. Notice the "Starting OILS SIP Server" message is printed with no
indication of failure.
5. Verify that the PID file exists: /openils/var/run/oils_sip.pid
6. Verify that no SIPServer processes are actually running:
pgrep -af SIPServer
The above should produce no output.
To test this patch:
1. Apply this patch and install oils_ctl.sh to /openils/bin/.
2. Assuming you have run the previous steps, delete the PID file:
rm /openils/var/run/oils_sip.pid
3. Start SIPServer via oils_ctl.sh:
oils_ctl.sh -a start_sip
4. Notice the "Starting OILS SIP Server" message is printed.
5. Verify that the PID file exists: /openils/var/run/oils_sip.pid
6. `pgrep -af SIPServer` should produce output.
It is safe to apply this patch on an unaffected O/S. Explicitly
adding SIP_DIR to PERL5LIB will have no detrimental effect on any O/S
currently supported by Evergreen.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Galen Charlton [Wed, 25 Aug 2021 22:21:03 +0000 (18:21 -0400)]
LP#1928275: fix the Angular "Copy Queue To Bucket"
Similar to bug 1934184, a blank routerLink on an anchor no longer
causes an ngbModal to open via a click handler.
To test
-------
[1] Create a MARC import bib queue that has at least one imported
record it.
[2] Click the "Copy Queue To Bucket" link from the queue inspection page
and observe that nothing happens.
[3] Apply the patch and repeat step 2. This time, the add-to-bucket dialog
should appear.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mary Llewellyn <mllewell@biblio.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
LP1924621 Staff catalog place hold screen preferred name
Displays the preferred first or last name on the place holds screen,
if a patron barcode is entered.
To test.
1. Set up a borrower with a preferred first name, and one with a
preferred last name, and one with both.
2. Use the catalog place hold screen to search for these borrowers
and notice that the preferred names, if available, are displayed.
* note newline added by Bill to break up wide column.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Mary Llewellyn <mllewell@biblio.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Certain third-party products such as collection development
management providers require copy statistics that are not
readily available in a single report. This view adds those,
which will also benefit library staff reports generally.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Mike Rylander [Mon, 24 Feb 2020 17:01:49 +0000 (12:01 -0500)]
LP#1864516: case-insensitive browse entry display value comparison
Following up on bug 1350831, there remains one complaint relating to
"bad data makes browse suboptimal" that can't actually be handled today
by the existing Evergreen code or a pullrequested branch: case differences,
particularly in titles.
We should allow an Evergreen admin to decide on a field-by-field basis
whether case should be considered when determining the uniqueness of a
browse entry coming from a bibliographic record, effectively allowing case
folding. Note that authority fields, being by definition the authorized
value that should be used, do not support this case folding. However, if
authority records are processed first, then bibliographic fields can fold
/into/ those authority fields, achieving the desired result and, in fact,
using the best possible case-preserving display value.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
projects / Evergreen.git / log