Jane Sandberg [Wed, 12 Oct 2022 23:38:20 +0000 (16:38 -0700)]
LP1898775: Add basket to bucket in bootstrap
The bootstrap OPAC uses links, rather than <select> for the basket dropdown, so the
existing event listener couldn't get attached to the correct element.
To test:
1. Confirm that you are using the bootstrap OPAC.
2. In the staff client, select the traditional staff catalog.
3. Add several items to your basket.
4. Click the basket icon, and select 'Add Basket to Bucket'
5. Note that you get a 404 error.
6. Apply this patch.
7. Repeat steps 1-3.
8. Note that you can now select a bucket, and that the process completes successfully.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1980297 Booking:reservations page not formatted in bootstrap opac
Formats the page's title and table in a consistent manner with other
pages in the bootstrap opac's myopac pages. Also adds CSS so that
the correct labels are displayed on smallish screens.
To test.
1. Set ctx.show_reservations_tab in config.tt2 to true.
2. Create a couple of bookings for a patron and login to the opac as that
patron.
3. In the opac go to the reservations screen and notice the formatting.
Resize the screen to view the display on a small scale.
4. Apply the patch
5. Repeat 3 and now notice the page title and the table formatting. View
the table in a small screen.
6. Also view the reservations page as a patron with no bookings.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Bill Erickson [Mon, 11 Jul 2022 14:58:40 +0000 (10:58 -0400)]
LP1956619 Holdings editor sanity check for VIEW_USER perm
When the staff accessing holdings in the holdings editor do not have the
VIEW_USER permission at a level sufficient to display the creator/editor
of a set of items, display the ID of the user instead of attempting and
failing to display the username, which causes a page rendering error.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mary Llewellyn <mllewell@biblio.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jeff Davis [Fri, 21 Jan 2022 22:17:25 +0000 (14:17 -0800)]
LP#1956619: use Angular holdings editor when accessing from item status and item buckets
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Dan Briem [Thu, 4 Aug 2022 02:46:06 +0000 (22:46 -0400)]
LP1735221 Item Alert Prevents Hold Capture Delay Verification
Clicking OK on an item alert triggers a checkin override. If the
response contains an override event, an error is thrown. Since
a hold capture delay event is handled as an override, an error
throws before the hold capture delay dialog opens.
This handles the capture delay event separately from the override
events so the dialog will open after an override attempt.
To test:
1. set Hold Capture Requires Verification on a shelving location
2. add an item alert to an item in that shelving location
3. place an item hold on that item
4. checkin that item
5. click OK on the alert dialog and Capture on the delay dialog
6. note the hold is captured`
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
- Removed Enter KeyUp property from the Patron Barcode field on Associate User
- Removed Enter KeyUp property from the Item Barcode field on Associate Item
Terran McCanna [Fri, 19 Aug 2022 17:38:56 +0000 (13:38 -0400)]
LP1821950 & LP1980409 Option to require call number label
This uses a new Library Setting for "Require call number labels
in Copy Editor" for the benefit of libraries that with to use a
predefined Prefix (such as FIC or EZ) instead of individual call
number labels for each volume.
When the setting is True, the call number label field is marked
required and the Save buttons disabled until a value is present.
When the setting is False, the call number label is not required.
In addition, the Angular interface adds an additional check for
Prefix, so if the call number label is empty then the Prefix is
required.
Acknowledgements:
Org Unit Setting created by Kyle Huckins
Angular and AngularJS changes done by New Developers Working Group
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Kyle Huckins [Thu, 16 May 2019 22:05:55 +0000 (22:05 +0000)]
lp1821950 Require Call Number Label YAOUS
- Add YAOUS to Require Call Number Labels in Copy Editor
- Set new YAOUS to true
- Don't display empty call number field warning if call numbers
aren't required on the copy editor.
- Properly enable/disable saving an item in the volcopy editor when
CN label is empty, based on Require Call Number Label setting.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file: Open-ILS/src/sql/Pg/upgrade/XXXX.lp1821950-call-number-label-required-yaous.sql
modified: Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
The last follow-up had the inadvertent side-effect of hiding the
message directing the patron to contact their library if they had a
negative balance. My thought is that if there are negative bills then
the patron should see the alert to contact their library about them
regardless of whether or not online payments are allowed. So, this
additional followup separates that alert from the myopac_cc_allowed logic.
This also makes some minor display tweaks to the BooPAC:
- Applies the Bootstrap 'alert-warning' to the negative bills message
in the BooPAC.
- Adds a page header.
- Changes the styling and wording of the grocery charges heading to match
the circulation charges heading.
- Changes the styling of the grocery and circulation tables to be
consistent with each other.
Jason Etheridge [Mon, 18 Jul 2022 19:02:54 +0000 (15:02 -0400)]
LP1981628 follow-up to the follow-up
Consolidate some of the logic to make it more clear what is happening,
leverage the existing myopac_cc_allowed boolean, and catch the
Pay All Charges button in the TPAC. This also clears up some display
oddities and makes sure the non-payment labeling is being used.
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
When using Shibboleth for SSO, and global logout is disabled, logging in
after logout on the same computer can fail with a 404-Not Found. The
problem is that we need to ignore our local "don't trust Shibboleth
login" cookie in this situation.
This change also means we need to delegate SP logout, in addition to
possible IdP and/or global logout, to the Shibboleth configuration.
Therefore we always redirect to the Shibboleth logout service on
Evergreen logout (when Shibboleth SSO is enabled), and SP, IdP, and
global logout is configured and mediated by the Shibboleth and IdP
configuration.
This commit modifies the meaning of the opac.login.shib_sso.logout YAOUS
such that it is only used to decide if Evergreen timeout-forced logouts
will cause a Shibboleth logout as well. All user-initiated logouts will
now inform Shibboleth, and the Shibboleth configuration will determine
the SSO logout degree (SP, IdP, global).
See details at
https://shibboleth.atlassian.net/wiki/spaces/SHIB2/pages/2577072384/NativeSPLogoutInitiator
and the simpler configuration option of
https://shibboleth.atlassian.net/wiki/spaces/SHIB2/pages/2577072434/NativeSPServiceLogout
for information on the Shibboleth configuration required for your local
needs.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
- don't bother checking the reactor; instead, assume that
if the event definition includes a context user path that
evaluates to a discernable user record, there is reason
to check for the user's preferred locale and for alternative
templates
- make this section of code more idiomatic
LP#1986479: fix lookup of user locale during A/T event processing
This patch fixes an issue with the new user-locale-sensitive
alternate Action Trigger template selection that supports letting
patrons receive notifications in their preferred language. In
particular, it corrects an assumption that the event target is
the user itself. With the patch, the the event definition's
context user path is consulted to identify the relevant user.
To test
-------
[1] Set up a patron with an email address and check out an item.
[2] Use the Quick Receipt drop-down to attempt an email checkout
receipt.
[3] No email will be generated an the event will fail. The logs
should contain something like
Can't use an undefined value as a HASH reference at
/usr/local/share/perl/5.28.1/OpenILS/Application/Trigger/Event.pm
line 518.
[4] Apply the patch and repeat steps 1 and 2. This time, the email
should be sent (or, at least, the A/T event will be successfully
processed).
LP1991444: Cleanup Build Docs Artifacts in GitHub Actions
The Build Docs GitHub action leaves the built docs behind as
artifacts. These artifacts currently use about 58MB apiece. This can
quickly consume all of the available storage spacce (500MB) for
free-tier GitHub accounts.
This commit adds a retention-days setting of 2 so that build docs
artifacts should be removed after two days.
LP1953381 not-allowed pointer for inactive buttons
Adds a style to change the mouse pointer to the "no" symbol for disabled
buttons.
To test:
1. Apply patch.
2. Go to an item record in the staff catalog.
3. Mouse over the "Set Default View" button (disabled by default on the
Item Table tab).
4. The pointer should change to the "no" symbol.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1909583 Bootstrap Opac: Cannot edit title and description
Fixes the editing of the title and description in the Bootstrap Opac lists.
Adds and Edit List button with a collapsible form.
To Test:
1. Create several lists in the Opac.
2. Notice you are unable to edti the title or description.
3. Apply the patch
4. Use the Edit List button to display an editable form for each individual
list.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP1903767 - Bootstrap Opac: Make other formats and editions more visible.
This patch does the following:
1. Moves "Other Formats and Editions" below # of holds and available items.
2. Changes "Other Options" to "Other Formats and Editions" and makes the
header tage and <h2> tag consistent with other header tags.
3. Resizes <h2> tags.
4. Removes bullets and changes the margins of some of the table/list displays
under the <h2> headers.
5. Fixes the alignment of the button group that contains Place Hold.
For Testing:
1. Find a record that contains other formats and editions. In concerto
record #71 contains other formats and editions.
2. Notice that you have to click the More Details button to view the Other
Formats.
3. Apply the patch.
4. Other Formats and Editions now appear under the Available Copies and
Holds heading. You no longer have to push the More Details button.
Fixing "hold Type" to "Hold Type" in hold details screen
Test plan:
1. Go to the staff interface, right click a hold to see hold details,
observe that "hold Type" is not capitalized
2. Apply the patch
3. Refresh the staff interface hold details screen and observe that
the "Hold Type" is properly capitalized
Garry Collum [Tue, 2 Aug 2022 19:35:39 +0000 (19:35 +0000)]
LP1902272-Bootstrap opac needs to prompt on notification preference update
Adds the prompting of updating holds when default notification preferences
are updated in the Bootstrap opac.
To Test:
1. Place a few holds for a patron.
2. Login to the opac and change some default notification methods.
3. The opac does not prompt to update the holds.
4. Apply the patch.
5. The patron should now be prompted to update holds when default
notification methods are changed.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jane Sandberg [Thu, 11 Feb 2021 01:37:57 +0000 (17:37 -0800)]
LP1907974: Updating call numbers in course module reflected in grid
Also:
* refactors the updateItem method for more idiomatic RxJS usage (e.g.
no nested subscribes)
* corrects some Boolean, String, and Number types to boolean, string,
and number (to use the primitive types instead of objects, as
recommended by the Typescript handbook:
https://www.typescriptlang.org/docs/handbook/basic-types.html#about-number-string-boolean-symbol-and-object)
To test:
1) Go to Local Admin > Course List
2) Double click on a course
3) Go to the materials tab
4) Add an item by barcode, making sure to supply a temporary call
number, and that the call number checkbox is checked.
5) Note that the grid on the right display's the item's old call number,
not its new one.
6) Apply this patch.
7) Repeat step 4. Note that the temporary call number is reflected in
the grid now.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Garry Collum [Wed, 3 Aug 2022 18:00:02 +0000 (18:00 +0000)]
lp1983129-Bootstrap Opac: Inconsistent wording in My Account
Removes the word "Current" and "Currently" from the holds and items checked out
menus and pages in My Account, and fixes capitalization in the summary screen.
Also removes 'Current' from the menus and screens for E-items out, and E-items
on hold.
Michele Morgan [Thu, 12 Aug 2021 18:09:41 +0000 (14:09 -0400)]
LP#1939730 - Use original call number owning_lib when reverting items
When removing items with edited call numbers from a course, find or
create the resulting call number using the original call number's
owning_lib rather than the course owner.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Galen Charlton [Thu, 26 May 2022 15:11:59 +0000 (11:11 -0400)]
LP#1957179: improve saving of templates in Angular holdings editor
This patch makes the following improvements to the handling
of holding templates in the Angular holdings editor:
- templates are now saved to the cat.copy.templates user setting,
matching the AngularJS holdings editor
- toast is displayed upon saving or deleting a template
- upon saving a completely new template, re-style it in the
combobox so that it no longer has the new-and-freetext
styling
To test
-------
[1] Apply the patch and open the Angular holdings editor.
[2] Verify that once a template is saved or deleted, that
refreshing the Angular holdings editor will show the
updated list of templates.
[3] Verify that toast is displayed upon saving or deleting
a template.
Note that because of a quirk in how user settings are cached by
the web staff client, if you are testing in more than one browser
(but with the same user account), if you save a template in one
browser, you'll need to log out and back in with the second browser
to see the changes.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP#1980887: fixes cases where shelving location selector didn't work
This patch fixes an issue where the Angular shelving location selection
component (eg-item-location-select) wouldn't work (in particular,
when its contextOrgIds wasn't set, as opposed to contextOrgId).
Coding note: TypeScript confounds the Perl programmer: an empty array
evaulates to true; .length needs to be checked instead.
To test
-------
[1] Apply the patch.
[2] Verify that the shelving location selector works in the following
interfaces:
- Acquisitions Administration -> Distribution Formuals
- Course Materials (in the material form for a course)
- Linked locations for Circulation Limit Sets
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jeff Davis [Mon, 25 Jul 2022 20:08:43 +0000 (13:08 -0700)]
LP#1920268: properly align titles in Bootstrap search results, regardless of cover art
The changes in this commit were proposed by Eva Cerninakova.
Co-authored-by: Eva Cerninakova <cerninakova@jabok.cz> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#1986725: restore portrait/landscape choice when printing from Angular
This patch works around a default setting in Bootstrap 4 that specifies
A3 as the paper size for printing. Specifying any paper size like this
causes Chrome and Firefox to stop offering the users the option to
choose the paper orientation.
My testing suggests that specifying A3 as the default paper size also
resulted in the printed text using a smaller font size when printing
on US paper sizes. Some sort of scaling down from A3 to letter,
perhaps.
To test
-------
[1] Open the Angular Holds Pull List, select a branch that has items
to pull, and click the Print Full List button. Observe that the
browser print dialog does not offer an option to choose the
orientation.
[2] As above, but for any Angular grid's Print Full Grid action.
[3] Apply the patch and repeat 1 and 2. This time, the browser print
dialog should offer the option to select the orientation.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Garry Collum [Fri, 17 Jun 2022 17:39:36 +0000 (17:39 +0000)]
LP1979080 Lengthy titles in a carousel should be truncated.
Lengthy titles in a carousel push the content that is below the carousel
down sometimes resulting in odd displays.
This patch truncates lengthy titles to 4 lines ending with an ellipsis.
To test.
1. Create a couple of manual carousels and populate them with some bibs that
have lengthy titles.
2. Notice that there is odd spacing below the carousels.
3. Apply the patch.
4. The lengthy titles are now truncated and end with an ellipsis. There
is now normal spacing below the carousels.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Mike Rylander [Fri, 27 May 2022 15:22:29 +0000 (11:22 -0400)]
LP#1976002: Include ancestors in item location filters
The item location selector should include locations from ancestor org
units regardless of the specific permission-limiting check it may be
asked to perform. Item locations at ancestor org units are valid for
use on items in descendant locations.
This commit also makes the org filter list unique.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxOLI.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Bill Erickson [Mon, 3 Jan 2022 17:54:43 +0000 (12:54 -0500)]
LP1771636 Org Select Combined Org Names Option
Adds an option to the staff client workstation settings page for
"Library Selector Shows Combined Names?". When enabled, Angular org
unit selectors display the full branch in addition to the branch short
code.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Bill Erickson [Mon, 11 Jul 2022 18:06:44 +0000 (14:06 -0400)]
LP1823225 Patron Penalty Refresh Action
New menu entry added under the 'Other' menu for patrons. It refreshes
the patron's penalties and reloads the patron to ensure all needed data
is refreshed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Bill Erickson [Tue, 19 Jul 2022 14:19:29 +0000 (10:19 -0400)]
LP1910546 Prevent Copy Location Delete With Active Copies
Raise a database exception when any attempt is made to marke a copy
location as deleted when the location contains non-deleted copies.
To Test:
1. Navigate to /eg2/staff/admin/local/asset/copy_location
2. Attempt to delete a copy location that is known to contain
non-deleted copies.
3. Confirm an error message is displayed and the location is not marked
as deleted.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jason Boyer [Thu, 28 Jul 2022 19:15:17 +0000 (15:15 -0400)]
LP1978567: Teach fieldmapper.py about field groups
Because the "group" tag in IDL field_groups was never added to
this file that helps with translations, Simple Reporter field groups
all have the same name when built for release.
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP#1956986: fix and refactor item alert handing in Angular editor
This patch changes the handling of item alerts in the Angular
Holdings View and Item Attributes editor to be more like how
item notes and item tags are handled.
In particular:
- The separate 'Add Item Alert' and 'Edit Item Alerts' context menu
items in Holdings View are consolidated to a 'Add/Manage Item Alerts'
action.
- Pending new alerts are displayed in separate area of the modal
- The 'Apply Changes' and 'Add New' buttons now work the same way as
item notes and item tags
To test
-------
[1] Apply patch.
[2] Create a new item with one or more item alerts. Verify that they are
properly saved.
[3] Edit an existing item and add, modify, and clear alerts. Verify that
the changes are saved.
[4] From Holdings View, choose 'Add/Manage Item Alerts' with a single
item selected. Verify that changes are saved.
[5] From Holdings View, choose 'Add/Manage Item Alerts' with multiple
items selected. Verify that you are only given the option to add
new alerts. Verify that new alerts are saved.
LP#1978889: display alert type for existing item alerts
This patch ensures that the type of an item alert is
displayed when managing item alerts in the Angular item
attributes editor.
To test
-------
[1] Add an alert to an item.
[2] From the Angular Holdings View, chose 'Edit Item Alerts'
for that item. Note that the combobox for the existing
alert does not display a value.
[3] Open the item in the Item Attributes editor and click
the Item Alerts button. Again, note that the alert type
combobox does not display a value.
[4] Apply the patch and repeat steps 2 and 3. This time, the alert
type should be displayed.
Bill Erickson [Wed, 13 Jul 2022 14:09:33 +0000 (10:09 -0400)]
LP1884950 Org service loads all ou types fix
Recover an unintended line deletion.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Wed, 6 Jul 2022 20:35:28 +0000 (16:35 -0400)]
LP1884950 Org service loads all ou types
Explicitly load all org unit types at page startup so that we fetch org
types that may not have an org unit attached.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Wed, 6 Jul 2022 19:32:42 +0000 (15:32 -0400)]
LP1884950 Org Unit Admin Scrolling
Admin -> Server Admin -> Organizational Units now displays the tree of
org units in a vertical-scrollable div which occupies 80% of the
vertical window space.
Tree is opened to the first level of child nodes. Deeper child nodes
are collapsed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Terran McCanna [Thu, 20 Jan 2022 19:42:33 +0000 (14:42 -0500)]
LP1958573 PMC messages created by action triggers not patron-visible
This adds a missing patron-visibility flag to messages created for
the patron message center by notification action triggers (when
using grouped events).
LP#1981095: fix deletion of item tags in Angular item attributes editor
This patch fixes several bugs that prevent item tags from
being correctly deleted by the Angular item attributes editor.
To test
-------
[1] Apply patch.
[2] Edit a single item in the Angular item attributes editor.
[3] Verify that tags can be added and deleted.
[4] In Holdings View, choose Add/Manage Item Tags for a single
selected item.
[5] Verify that tags can be added and deleted;
[6] Repeat steps 4 and 5 for a different item after successfully
deleting an item tag. Verify that tags can be added and deleted.
[7] In Holdings View, choose Add/Manage Item Tags for multiple
selected items.
[8] Verify that ntoes can be added to the selected items
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1955065: fix deletion of item notes in Angular item attributes editor
This patch fixes several bugs that prevent item notes from
being correctly deleted by the Angular item attributes editor.
To test
-------
[1] Apply patch.
[2] Edit a single item in the Angular item attributes editor.
[3] Verify that notes can be added and deleted.
[4] In Holdings View, choose Add/Manage Item Notes for a single
selected item.
[5] Verify that notes can be added and deleted;
[6] Repeat steps 4 and 5 for a different item after successfully
deleting an item note. Verify that notes can be added and deleted.
[7] In Holdings View, choose Add/Manage Item Notes for multiple
selected items.
[8] Verify that ntoes can be added to the selected items.
Bill Erickson [Thu, 7 Jul 2022 20:28:36 +0000 (16:28 -0400)]
LP1965448 Holdings edit enforce required stat cats
Required copy stat cats require a value when creating or editing
copies.
Switching between tabs in the copy editor no longer alert the user when
a change is pending, since it may be necessary to hop between tabs to
resolve issues. Pending changes alerts will still appear when leaving
the page if needed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
[1] Set the Angular holdings and item attributes editor to
unified mode.
[2] Create a new call number and item. Note that the buttons
to create item tags, item alerts, and item notes do not work.
[3] Apply the patch and repeat step 2.
[4] This time, adding tags, alerts, and notes in the course of
creating a new item should work.
Display shortnames instead of IDs for the Requesting Library
and Selection Library columns in the Pull List grid in the
staff client.
Test:
1. Circulation->Pull List for Hold Requests
2. Select OU with holds to pull or place an item hold on an
available item and select the owning OU
3. Add the Requesting Library and Selection Library columns
(note IDs are displayed)
5. Apply patch, rebuild Angular, rebuild Perl
6. Refresh and re-add columns (note shortnames are displayed)
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Garry Collum [Tue, 28 Jun 2022 11:59:21 +0000 (11:59 +0000)]
LP1951642 Self-registration DOB autopopulating date
This removes the autopopulation of the dob date in the OPAC's
self-registration page. Note that the issue applies only to
the Bootstrap OPAC, not TPAC.
To test:
1. In library settings turn on "Allow Patron Self-Registration" and "Show dob
field in patron registration". "Require dob field on patron registration"
can also be turned on to test that option.
2. Go to the "Request Library Card" page of the opac and notice that the
dob field is populated with today's date.
3. Apply the patch.
4. Check the dob field again and notice that it is no longer autopopulated.
5. Create a few registrations with dob dates and with no dob dates to confirm
that the field works.
Garry Collum [Tue, 9 Nov 2021 16:09:48 +0000 (11:09 -0500)]
LP1950166 TPac: Self-registration form won't submit with blank DOB
Adds a check for a blank value in the DOB validation script. Note
that the issue is present in TPAC, not the Bootsstrap OPAC.
To test:
1. Confirm "Require dob field on patron registration" is not set or set to False.
2. Confirm "Show dob field on patron registration" is true.
3. Confirm "Allow Patron Self-Registration" is set to true.
4. Try to register a patron in the TPAC with DOB blank.
5. Apply patch.
6. Try to register a patron in the TPAC with the DOB blank.
7. Try to register a patron with Invalid DOB input.
8. Try to register a patron with valid DOB input.
Garry Collum [Wed, 10 Nov 2021 19:44:16 +0000 (14:44 -0500)]
LP1950514: TPac hold groups table displays incorrect column names on small screens.
This fixes the incorrect display of column names in the hold groups table
in the tpac. Previously the table would display names for the hold history
table.
To test:
1. create an opac visible hold group and assign a patron to the group.
2. login to the TPac as the patron assigned to the group.
3. view hold groups and make the browser screen as small as possible.
4. notice on the smallest screen the headers for the table are incorrect.
5. apply the patch and view the headers.
LP#1851884: eg-fm-record-editor: avoid fetching all rows from linked table
This patch ensures that Angular FM record editor dialogs do
not attempt to fetch all rows from target table when constructing
a combobox for a linked field.
In particular, it makes the following changes:
* If a custom template for a field is supplied, use that by
default rather than _also_ creating a data source for
a combobox.
* Rather than creating its own data source for a linked field,
the FM record editor now uses the IDL mode of eg-combobox. By doing
this, we use eg-combobox's default data source, which limits
record retrievals to 100 rows max. Also, empty-click is now
enabled by default.
* When attempting to identify a selector for an IDL class, if
the class doesn't define a selector and doesn't have a field named
'name', but its primary key is a text field, use the primary
key as the selector.
To test
-------
[1] Create a few thousand empty bib record buckets in your test database.
[2] Edit a carousel under Local Administration; note that it can
take some time for the dialog to load.
[3] Apply the patch and repeat step 2. This time, the carousel edit modal
should open instantly.
[4] Test various Angular record editor modals to confirm that they behave
as expected. For example:
* The allocate to fund dialog in Fund Administration, in particular
to verify that only active funds show up.
* The assign user to course modal, to verify that searching is done
by course number, not name.
* Filter Dialog Set editor under /eg2/en-US/staff/admin/local/config/filter_dialog_filter_set
to verify that the drop down for the creator doesn't fetch
all patrons. (Note that this is an artificial example).
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Jeff Davis [Thu, 19 May 2022 23:32:38 +0000 (16:32 -0700)]
LP#1945385: use eg-admin-page for circ limit sets admin UI
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Jason Stephenson <jason@sigio.com>
Kyle Huckins [Tue, 15 Mar 2022 02:20:40 +0000 (02:20 +0000)]
lp1942647 Provide Warning when deleting Term linked to Courses
- Separates out Course Term Grid to its own component
- Adds retrieval service function for Course/Term Maps based on Term ID
- Displays Confirmation dialog when deleting terms on the term grid if term is mapped to a course
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-term-grid.component.html
new file: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-term-grid.component.ts
modified: Open-ILS/src/eg2/src/app/staff/share/course.service.ts
Signed-off-by: Beth Willis <willis@noblenet.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Garry Collum [Wed, 10 Nov 2021 19:01:44 +0000 (14:01 -0500)]
LP1950345-Format the Current Hold Groups table in bootstrap opac
This patch styles the Current Hold Groups table in bootstrap to be consistent
with other tables in the bootstrap catalog. It fixes overlappling text
in cells. It also fixes the column headings for small screens. Previously
the headings on small screens were pulling from the css rules for the
holds history table.
To test:
1. create a couple of hold groups and add a patron to each group. Make the
groups opac visible.
2. login to the opac as the patron to view the holds groups to which the
patron belongs. Notice the table style with not margins or padding.
3. make your browser as small as possible to see the incorrect headings.
4. apply the patch.
5. repeat 2 and 3 to view the fix.
Galen Charlton [Mon, 23 May 2022 23:06:48 +0000 (19:06 -0400)]
LP#1930617: reduce parallel requests initiated by AngularJS holdings editor
This patch decreases the number of parallel requests spawned by the
AngularJS holdings editor. This can reduce load on open-ils.pcrud when
the editor is used to handle a large number of items in one batch.
This patch takes the following approaches:
- the fetching of call number affixes now only makes one request
per relevant org unit
- item alerts are now retrieved via fleshing when the batch of items
is requested (as opposed to doing a PCRUD request for each copy)
- fetching monograph parts is now done serially
To test
-------
[1] Apply the patch.
[2] Create a bucket with a few hundred items and edit all of them
in the AngularJS holdings editor (which is what you get when
you edit items from the bucket interface).
[3] Verify that the editing loads itself without causing errors
or PCRUD drone spikes.
[4] Verify that item alerts and monograph parts are loaded
[5] Verify that the call number prefix and suffix drop-downs
are correctly populated.
[6] Verify that copy alerts can be attached to newly-created items
and saved.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Galen Charlton [Thu, 19 May 2022 14:00:48 +0000 (10:00 -0400)]
LP#1974195: fix memory leak when performing fleshed Fieldmapper search
This patch fixes a memory leak that occurs when performing
a fleshed search of an IDL class via open-ils.cstore, open-ils.pcrud,
or open-ils.rstore. It removes a debug-level log entry that didn't
free a temporary string.
To test
-------
[1] Perform a PCRUD search that includes fleshing and retrieves
a large responses. One example is a search on bre that fleshes
call numbers and copies and returns a few hundred bibs.
[2] Observe that the PCRUD drone that serviced the request has
increased its memory usage significantly.
[3] Apply the patch and repeat step 1. This time, the drone's memory
usage should not (persistently) increase as much.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
projects / Evergreen.git / log