Evergreen.git
11 years agoMerge branch 'master' of git+ssh://yeti.esilibrary.com/home/evergreen/evergreen-equin...
Bill Erickson [Thu, 20 Jan 2011 14:23:16 +0000 (09:23 -0500)]
Merge branch 'master' of git+ssh://yeti.esilibrary.com/home/evergreen/evergreen-equinox into opac-tt-poc

11 years agowhack-a-mole, was getting a null instead of an empty array here, but may be a red...
phasefx [Wed, 19 Jan 2011 22:28:13 +0000 (22:28 +0000)]
whack-a-mole, was getting a null instead of an empty array here, but may be a red herring

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19225 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoif this user does not have permission to edit an existing user, disable the save...
erickson [Wed, 19 Jan 2011 22:27:14 +0000 (22:27 +0000)]
if this user does not have permission to edit an existing user, disable the save and clone buttons

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19222 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoremove disallowed permission groups from the perm group selector in user registration...
erickson [Wed, 19 Jan 2011 22:27:14 +0000 (22:27 +0000)]
remove disallowed permission groups from the perm group selector in user registration; see bug 699914

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19221 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agolet amnesty checkin mode trump the restore overdues on lost checkin setting
phasefx [Wed, 19 Jan 2011 22:05:18 +0000 (22:05 +0000)]
let amnesty checkin mode trump the restore overdues on lost checkin setting

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19219 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoBooking: Robert Soulliere spotted and fixed a bug in processing reservation-
senator [Wed, 19 Jan 2011 21:52:28 +0000 (21:52 +0000)]
Booking: Robert Soulliere spotted and fixed a bug in processing reservation-
related overdue fines.  See https://bugs.launchpad.net/evergreen/+bug/705061

This patch tests successfully for me. Thanks Robert!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19214 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoBuild and flatten a tree, correcting a sorting issue in some OU dropdowns.
miker [Wed, 19 Jan 2011 19:50:47 +0000 (19:50 +0000)]
Build and flatten a tree, correcting a sorting issue in some OU dropdowns.

The previous code assumed that work org units would be delivered in hierarchical order, but alas, they are not.  Thus, we build the hierarchy and then flatten it, sorting at each level.  This will be non-fast with many work OUs, but the common case is a small set, which is not painful.

Further improvement is warranted when the above proves false.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19208 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agouse explicit odd/even classes since some browsers don't support css3 odd/even selector
Bill Erickson [Wed, 19 Jan 2011 18:17:48 +0000 (13:17 -0500)]
use explicit odd/even classes since some browsers don't support css3 odd/even selector

11 years agoMerge branch 'master' of git+ssh://yeti.esilibrary.com/home/evergreen/evergreen-equin...
Bill Erickson [Wed, 19 Jan 2011 17:22:33 +0000 (12:22 -0500)]
Merge branch 'master' of git+ssh://yeti.esilibrary.com/home/evergreen/evergreen-equinox into opac-tt-poc

11 years agobug #684467: more bulletproofing of naco_normalize
gmc [Wed, 19 Jan 2011 15:59:01 +0000 (15:59 +0000)]
bug #684467: more bulletproofing of naco_normalize

Also preparing for backporting to rel_2_0.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19204 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agodrop name check constraint on config.hard_due_due
gmc [Wed, 19 Jan 2011 15:34:56 +0000 (15:34 +0000)]
drop name check constraint on config.hard_due_due

See https://bugs.launchpad.net/evergreen/+bug/704951 for context
and possible future direction.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19203 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAvoid escaping issues in authority.normalize_heading() by parameterizing the query
dbs [Wed, 19 Jan 2011 14:53:48 +0000 (14:53 +0000)]
Avoid escaping issues in authority.normalize_heading() by parameterizing the query

Long story short: MARC subfield values containing backslashes caused noise
and in some cases painful errors. Using spi_prepare/spi_exec_query is the
safest way of handling escaping, rather than adding more regexes and munging
the data before it even gets to naco_normalize().

Most painful case was <subfield code="a">Foo, Bar\</subfield> - the trailing
slash ended up escaping the enclosing single quote (because PostgreSQL isn't
configured by default with strict conformance to SQL escaping rules yet) and
threw an error.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19201 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPart 2 of creating a more secure default setup
dbs [Wed, 19 Jan 2011 04:41:15 +0000 (04:41 +0000)]
Part 2 of creating a more secure default setup

With this commit, the user name and password for the administrative
user will be MD5 hashes of a random string of numbers. You can set
the user name and password to your liking using the --admin-user and
--admin-pass switches for eg_db_config.pl (this will be the
documented method in the install docs) or via straight SQL as:

UPDATE actor.usr SET usrname = 'FOO', passwd = 'BAR' WHERE id = 1;

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19200 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTowards a more secure default setup
dbs [Wed, 19 Jan 2011 04:24:49 +0000 (04:24 +0000)]
Towards a more secure default setup

Shipping with a default account user name and password is considered
an authentication anti-pattern; see
http://code.google.com/p/owasp-development-guide/wiki/WebAppSecDesignGuide_D2

By making the user select an admin user name and password at the time
they create the database, we avoid the chance that they will forget to
change the default password and leave their system open to access.

Next step is to change the seed data to insert random values for the
admin username and password, then update the documentation accordingly.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19199 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoProtect against blank and invalid scap IDs in issuance editor
dbwells [Tue, 18 Jan 2011 23:44:00 +0000 (23:44 +0000)]
Protect against blank and invalid scap IDs in issuance editor

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19197 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofix glitch that could break invoice proration
gmc [Tue, 18 Jan 2011 22:52:04 +0000 (22:52 +0000)]
fix glitch that could break invoice proration

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19195 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoMerge branch 'master' of git+ssh://yeti.esilibrary.com/home/evergreen/evergreen-equin...
Bill Erickson [Tue, 18 Jan 2011 20:01:27 +0000 (15:01 -0500)]
Merge branch 'master' of git+ssh://yeti.esilibrary.com/home/evergreen/evergreen-equinox into opac-tt-poc

11 years agouser saved searches are only accessible to the originating user; remove (incorrect...
erickson [Tue, 18 Jan 2011 19:57:55 +0000 (19:57 +0000)]
user saved searches are only accessible to the originating user; remove (incorrect) permacrud config for usr_saved_searches

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19193 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoMerge branch 'master' of git+ssh://yeti.esilibrary.com/home/evergreen/evergreen-equin...
Bill Erickson [Tue, 18 Jan 2011 19:39:36 +0000 (14:39 -0500)]
Merge branch 'master' of git+ssh://yeti.esilibrary.com/home/evergreen/evergreen-equinox into opac-tt-poc

11 years agoMake EditPane objects built of AutoFieldWidget objects (such as those used
senator [Tue, 18 Jan 2011 18:35:04 +0000 (18:35 +0000)]
Make EditPane objects built of AutoFieldWidget objects (such as those used
for create/edit dialogs with AutoGrid) enforce required fields more forcefully.

Before, if a field was marked required either in the IDL or by the
requirdFields attribute of an AutoGrid, you'd get a yellow widget with a caution
sign for that field, but you could still click save and the system would
attempt to save your object.

Sometimes this is stopped when pcrud can't save the object due to
required="true" in the IDL and/or a "not null" constraint in the schema, but
there may be cases where a given interface wants to require a value in a given
field even though that's not necessarily enforced at lower levels.

Serials: Specifically use this new feature in the distribution pane of the
Alternate Serial Control view, to prevent the creation of issues without a
"receive unit template" field, as you can't receive items in the Batch
Receive interface without one.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19192 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAuto-generation of placeholder barcodes approved for backport
dbwells [Tue, 18 Jan 2011 18:06:00 +0000 (18:06 +0000)]
Auto-generation of placeholder barcodes approved for backport

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19190 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomake better use of media_prefix; only apply ses cookie in secure context; updated...
Bill Erickson [Tue, 18 Jan 2011 16:48:11 +0000 (11:48 -0500)]
make better use of media_prefix; only apply ses cookie in secure context; updated docs

11 years agoadded sample cache-killer for tt opac for development purposes
Bill Erickson [Tue, 18 Jan 2011 15:37:07 +0000 (10:37 -0500)]
added sample cache-killer for tt opac for development purposes

11 years agoadded the default config options for running the tt opac. only the eg_vhost change...
Bill Erickson [Tue, 18 Jan 2011 15:34:12 +0000 (10:34 -0500)]
added the default config options for running the tt opac.  only the eg_vhost change is needed

11 years agoProof of concept Template-Toolkit OPAC
Bill Erickson [Tue, 18 Jan 2011 14:59:16 +0000 (09:59 -0500)]
Proof of concept Template-Toolkit OPAC

11 years agoAuto-generation of placeholder barcodes
dbwells [Mon, 17 Jan 2011 23:34:49 +0000 (23:34 +0000)]
Auto-generation of placeholder barcodes

This commit implements a very basic trigger for auto-generating placeholder barcodes, as discussed at the Dec. 14 2010 IRC developer meeting.  The 1.6.1-2.0 upgrade script has not been changed, as backporting this to 2.0 is pending review.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19189 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoIn serial control, if they defined a *_call_number, honor it as the default
dbwells [Mon, 17 Jan 2011 19:29:14 +0000 (19:29 +0000)]
In serial control, if they defined a *_call_number, honor it as the default

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19187 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agodefault ordering-agency org unit to workstation org in PO create dialog
erickson [Mon, 17 Jan 2011 15:54:08 +0000 (15:54 +0000)]
default ordering-agency org unit to workstation org in PO create dialog

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19185 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoget more aggressive with unsaved data prompts. onkeypress instead of onchange
phasefx [Mon, 17 Jan 2011 15:30:15 +0000 (15:30 +0000)]
get more aggressive with unsaved data prompts.  onkeypress instead of onchange

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19184 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPostpone advanced serial call-number handling until after 2.0
dbwells [Sat, 15 Jan 2011 04:04:23 +0000 (04:04 +0000)]
Postpone advanced serial call-number handling until after 2.0

Sharing of a single call-number for multiple volumes, while well intentioned, was not ready for primetime for various reasons.  This commit:
1) harmonizes and unifies call-number handling in Serial.pm, sticking with current practices
2) adds a very basic and now necessary prompt to the Serial Control view

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19182 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSerials: a regularity (i.e. 85X subfield $y) page for the caption/pattern wizard
senator [Sat, 15 Jan 2011 03:03:45 +0000 (03:03 +0000)]
Serials: a regularity (i.e. 85X subfield $y) page for the caption/pattern wizard

This adds a new page to the caption/pattern wizard that allows the user to
enter regularity information (specific published, omitted, and combined issues)
by chronology.  Doing the same by enumeration is possible in MFHD but not yet
supported in the wizard.

You still have to be a serials librarian who understands MFHD and the 85X tags
in order to really benefit from this, but it beats hand-entering the MARC tags.

Still to-do to perfect this:
    -   suggest (pre-enable) the regularity page when numeric $w is used
    -   use grid layout instead of hbox and vbox elements for neatness
    -   support enumeration codes
    -   days of month widget should be smarter than to always allow 31 days
    -   the whole caption/pattern wizard still needs scrollbars
    -   more limitations to prevent the user from entering patterns that
            don't make sense
    -   make sure that if a user fills out a page of the wizard, including
            this new one, but then unchecks the whole page, that whatever
            work they did is not included in the compiled result
    -   more testing, general cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19181 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoWhitespace normalization: tabs to spaces
dbs [Fri, 14 Jan 2011 02:57:46 +0000 (02:57 +0000)]
Whitespace normalization: tabs to spaces

Also, remove vestigial Data::Dumper import.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19176 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoEnable truncation attribute in Z39.50 queries to be left out entirely
dbs [Fri, 14 Jan 2011 02:49:33 +0000 (02:49 +0000)]
Enable truncation attribute in Z39.50 queries to be left out entirely

Per https://bugs.launchpad.net/evergreen/+bug/702695, some Z39.50
servers hate the truncation attribute (@attr 5=anything) and always
return 0 hits.

This gives you the ability to specify a negative value for the
truncation attribute and thereby prevent the truncation attribute
from being included in the Z39.50 query for a given server.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19175 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agotrivial typo fixes FTW!
gmc [Thu, 13 Jan 2011 01:12:30 +0000 (01:12 +0000)]
trivial typo fixes FTW!

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19174 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSerials: In the holding code mini wizard of the alt serials controls, pre-
senator [Wed, 12 Jan 2011 22:50:16 +0000 (22:50 +0000)]
Serials: In the holding code mini wizard of the alt serials controls, pre-
populate any Year, Season, Month or Day fields based on issuance.date_published
to reduce the need for redundant user input.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19173 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agogit-svn-id: svn://svn.open-ils.org/ILS/trunk@19172 dcc99617-32d9-48b4-a31d-7c20da2025e4
dbs [Wed, 12 Jan 2011 21:11:08 +0000 (21:11 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19172 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoDeprecate overdue/predue config sections in favour of action/trigger
dbs [Wed, 12 Jan 2011 20:55:54 +0000 (20:55 +0000)]
Deprecate overdue/predue config sections in favour of action/trigger

Set email notification to "false" for holds, overdues, and predues.

Fix one line of whitespace.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19169 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAutoFieldWidget no longer uses CurrencyTextBox dijit
gmc [Wed, 12 Jan 2011 20:51:27 +0000 (20:51 +0000)]
AutoFieldWidget no longer uses CurrencyTextBox dijit

NumberTextBox used instead to work around problem with
CurrencyTextBox's support for negative monetary amounts
in Dojo 1.3.  See https://bugs.launchpad.net/evergreen/+bug/702117

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19167 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoRevert r19162 for now, pending further conversation in #Evergreen
senator [Wed, 12 Jan 2011 15:52:37 +0000 (15:52 +0000)]
Revert r19162 for now, pending further conversation in #Evergreen
about the right way to address this.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19166 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoallow data entry of negative currency amounts
gmc [Wed, 12 Jan 2011 00:30:07 +0000 (00:30 +0000)]
allow data entry of negative currency amounts

Plug in fix for Dojo bug http://bugs.dojotoolkit.org/ticket/9438, which
was preventing the input of discounts and credits during invoice
creation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19163 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSerials: Fix a problem with chronology prediction when there's
senator [Wed, 12 Jan 2011 00:24:51 +0000 (00:24 +0000)]
Serials: Fix a problem with chronology prediction when there's
a subfield $y in a caption/pattern with a weekly chronology code

Illustrative 853 tag:
 $2$0$8$1$a$v.$b$no.$u$50$v$r$i$(year)$j$(month)$k$(day)$w$w$x$01$y$ow1198,1204
Holding (863) tag:
 $4$1$8$1$a$1$b$39$i$2011$j$09$k$26$x$AUTOGEN

Before this commit, you get a run of predictions that look like this:
v.1:no.40(2011:Oct.03)
v.1:no.41(2011:Oct.10)
v.1:no.42(2011:Oct.17)
v.1:no.43(2011:Oct.24)
v.1:no.44(2011:Oct.31)
v.1:no.45(2011:Nov.07)
v.1:no.46(2011:Nov.21)
v.1:no.47(2011:Nov.28)
v.1:no.48(2011:Dec.05)
v.1:no.49(2011:Dec.12)
v.1:no.50(2011:Dec.26)
v.2:no.1(2012:Jan.02)

Which I'm pretty sure is wrong.  The next-to-last week in November should have
been skipped, and the fourth week in December should have been skipped.  I think
the week number should be defined in terms of the day of the week on which this
weekly serial is published, so fourth week means fourth Monday in this case (?).

With this commit, you get a run of predictions that look like:
v.1:no.40(2011:Oct.03)
v.1:no.41(2011:Oct.10)
v.1:no.42(2011:Oct.17)
v.1:no.43(2011:Oct.24)
v.1:no.44(2011:Oct.31)
v.1:no.45(2011:Nov.07)
v.1:no.46(2011:Nov.14)
v.1:no.47(2011:Nov.28)
v.1:no.48(2011:Dec.05)
v.1:no.49(2011:Dec.12)
v.1:no.50(2011:Dec.19)
v.2:no.1(2012:Jan.02)

Which seems correct to me. I'm going to consult with others before backporting
this to rel_2_0, however.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19162 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoallow deletion of incomplete invoice LIs
gmc [Tue, 11 Jan 2011 23:18:21 +0000 (23:18 +0000)]
allow deletion of incomplete invoice LIs

Fix silent failure when attempting to delete a LI
whose type or cost was not set; dojo.string.subtitute
does not like replacement values to be null.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19160 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofix regression with org selector when specifying ?ol= and the org unit hiding setting...
phasefx [Tue, 11 Jan 2011 21:45:53 +0000 (21:45 +0000)]
fix regression with org selector when specifying ?ol= and the org unit hiding setting is unset

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19155 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoClean up opensrf.xml.example for easier consumption
dbs [Tue, 11 Jan 2011 21:29:35 +0000 (21:29 +0000)]
Clean up opensrf.xml.example for easier consumption

Make open-ils.acq, as the first service alphabetically and the Perl service
to boot, be the commented example.

Remove max_requests elements (not unix_config/max_requests elements!) from
service configurations where the language is not Perl.

Comment out open-ils.resolver in activeapps to match the commented-out state
within the configuration.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19154 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agorepaired pending-order vs order-pending thinko. Thanks to Kathy Lussier and Mike...
erickson [Tue, 11 Jan 2011 21:28:26 +0000 (21:28 +0000)]
repaired pending-order vs order-pending thinko.  Thanks to Kathy Lussier and Mike R. for the diagnosis

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19152 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoRemove leftover import of Data::Dumper
dbs [Tue, 11 Jan 2011 00:09:45 +0000 (00:09 +0000)]
Remove leftover import of Data::Dumper

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19150 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdditional code unification; add 'reset item' capability to unitize_items()
dbwells [Mon, 10 Jan 2011 22:16:16 +0000 (22:16 +0000)]
Additional code unification; add 'reset item' capability to unitize_items()

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19148 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoavoid fetching user settings for new user registration; the result of fetching setti...
erickson [Mon, 10 Jan 2011 16:27:54 +0000 (16:27 +0000)]
avoid fetching user settings for new user registration;  the result of fetching settings with a null user id is that settings of the staff/editor were fetched instead, leading to settings that appeared to selected, but were not saved during submit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19146 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoremoved deprecated, unused code
erickson [Mon, 10 Jan 2011 16:27:53 +0000 (16:27 +0000)]
removed deprecated, unused code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19145 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSimplify authority reference deduplication
dbs [Mon, 10 Jan 2011 15:27:37 +0000 (15:27 +0000)]
Simplify authority reference deduplication

Rather than multiplying the number of records to be returned in
the case of a .refs. call, stick with the original number. This
avoids corner cases where paging through the results would skip
some records, and the UI is not overly heavily affected as even
in the case where one record offers 10 matches for see also /
see from references and represents an entire page of results,
the UI will display 11 lines (1 for the 1XX field and 10 for
the 4XX / 5XX fields). The user will be able to page to the next
set of results to continue browsing.

We can also be smarter about some things:
  * Return the original list immediately if not a .refs. call
  * No need to reverse and unshift the list items when
    deduping the .refs. list; just stick with the same
    order of the incoming list

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19144 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoClean up c-apps Makefile.am and make everything load cleanly again
dbs [Mon, 10 Jan 2011 03:44:34 +0000 (03:44 +0000)]
Clean up c-apps Makefile.am and make everything load cleanly again

Executable programs don't have library versions, so don't set -version-info
for them.

Add -version-info to liboils_idl and liboils_util, and link liboils_util
explicitly against liboils_idl rather than relying on AM_LDFLAGS.

Set the linking dependencies correctly; if a library links against
liboils_util, set that as the sole link dependency; no need for liboils_idl
once (let alone twice!)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19141 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSet explicit library versioning for Evergreen 2.0 to 2:0:0
dbs [Mon, 10 Jan 2011 03:06:50 +0000 (03:06 +0000)]
Set explicit library versioning for Evergreen 2.0 to 2:0:0

This should help for anything linking to core Evergreen libraries;
as we revise the -version-info number, anything that links against
the core Evergreen libraries will quickly scream if we rev the
interface number without specifying via the age number that previous
interfaces are still supported. Let's remember to revise it
accordingly!

Also remove redundant linkage to oils_idl.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19140 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPrevent dupe record IDs from being returned by authority browse/startwith
dbs [Sun, 9 Jan 2011 21:27:01 +0000 (21:27 +0000)]
Prevent dupe record IDs from being returned by authority browse/startwith

The 4xx/5xx .ref variants on the authority browse/startwith methods
could return duplicate records if a 1xx/4xx/5xx contained similar entries,
which was highly irritating in the user interfaces.

I haven't been able to figure out a way to use just json_query to return
a set of unduped records that are still ordered appropriately, so I'm
fixing it in post-production... roughly. There is probably a better way
to do this (create an SQL function and select from that, perhaps) but
this at least appears to be an improvement over the current state of affairs.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19139 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoMake openils.PermaCrud.Store use a default order_by clause in common situations
senator [Fri, 7 Jan 2011 23:05:29 +0000 (23:05 +0000)]
Make openils.PermaCrud.Store use a default order_by clause in common situations

This avoids an issue where, using a FilteringSelect dijit, sometimes you type a
couple letters, let's says "ABC", and you get a set of matches like this:

"ABCDE"
"ABCD"
"ABC"

just because there happens to be no specific ordering.  If you click the ABC
match and tab away too quickly, the dijit will reset itself to the first match,
"ABCDE".  This is probably a Dojo/Dijit bug, as I've been able to duplicate the
problem with other stores, but that's all murky.

This avoids the issue by making sure the shortest match is at the top of the
list.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19137 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoIn 1.6.1-2.0 upgrade, update index IDs to the target_id, not the incoming arg
dbs [Fri, 7 Jan 2011 21:58:24 +0000 (21:58 +0000)]
In 1.6.1-2.0 upgrade, update index IDs to the target_id, not the incoming arg

Also, create (and later drop) indexes that /might/ help with the
otherwise ultra-painful sequential scans of metabib.*_field_entry if it turns
out that indexes do need to get moved around. Sounds good in theory, our test
box is still slogging away on this bit though...

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19136 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAcq: fix prorating bug
senator [Fri, 7 Jan 2011 20:04:34 +0000 (20:04 +0000)]
Acq: fix prorating bug

When prorating, the system decides what funds to target by looking at what
funds have already been spent against.  Previously, the system only looked at
acqie objects, but an invoice can also be composed of acqii objects.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19134 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoWhen modifying existing indexes, ensure subject|complete drops into ID 16
dbs [Fri, 7 Jan 2011 14:00:14 +0000 (14:00 +0000)]
When modifying existing indexes, ensure subject|complete drops into ID 16

Other parts of the upgrade script assumed that subject|complete would be
ID = 16, so we might as well try and make it conform. This means turning
config.bump_metabib_field() into a two-argument function so that we can
provide an explicit target ID for the modified index.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19133 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPrevent tag array from growing insanely in supercat browses
dbs [Fri, 7 Jan 2011 04:58:05 +0000 (04:58 +0000)]
Prevent tag array from growing insanely in supercat browses

Modifying the passed-in tag array reference apparently resulted
in those changes persisting to the next call, growing the tag
array at a rapid clip. So we needed to clean that up.

Also, applying the DISTINCT transform to the afr.record column, while
a valiant effort, didn't actually work. distinct() is not DISTINCT
ON () for starters; also, because DISTINCT ON needs to have the
ORDER BY clause match its arguments, and we actually want to order
by afr.value, not afr.record.

We could do it in a subquery, then reorder by value in the outer
SELECT, but it's not clear that json_query supports DISTINCT ON
anyway. Some days I wish I could just write SQL.

We could retrieve only the afr.record column - it's not clear that
any callers actually need the naco-normalized value column - but
that seems like a pretty major change at this point.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19132 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTeach supercat browse / startwith to return a distinct set of records
dbs [Thu, 6 Jan 2011 18:47:21 +0000 (18:47 +0000)]
Teach supercat browse / startwith to return a distinct set of records

The addition of the .refs variants exposed feeds that had multiple
copies of the same bib in the same results (e.g. if 1xx was "Scott, Daniel"
and 4xx in the same record was "Scott, Dan" it would be returned twice).
Filtering it in this call prevents the callers from requesting 10 records
and only getting 7 back (or whatever). If there's an actual use case for
getting the same record twice, we can revisit this.

Note that the authority context menu currently still shows duplicate
records, because the record is displayed in full for each 4xx / 5xx
entry, that will be fixed in a subsequent patch.

Also, prevent supercat browse from issuing two separate requests for
page = 0; the second would always stomp on the results of the first,
so I just made the first request go away in that case.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19131 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoUnify some summarization code in preparation for further development.
dbwells [Wed, 5 Jan 2011 23:16:44 +0000 (23:16 +0000)]
Unify some summarization code in preparation for further development.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19129 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPerhaps naive method of bumping existing custom config.metabib_field entries
dbs [Wed, 5 Jan 2011 22:16:15 +0000 (22:16 +0000)]
Perhaps naive method of bumping existing custom config.metabib_field entries

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19128 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSerials: provide a way for users to create and modify serial items
senator [Wed, 5 Jan 2011 19:31:13 +0000 (19:31 +0000)]
Serials: provide a way for users to create and modify serial items

Generally, these are created by caption and pattern-based prediction, and
modified by receiving.  However, some circumstances will warrant manually
creating items, and there need to be significant bumper rails around that
process, as it's otherwise easy to make items that don't respect certain
assumptions of the serials logic (you can still accomplish this if you're
trying, but it's harder to do than it would be if you had the anarchy of
a more straightforward AutoGrid interface).

Access the new interface by clicking any link in the Label column of the
Issuances tab of the Alternate Serials Control Subscription Details inteface.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19125 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoroll back xact in set_item_lost when copy is alrady marked lost and we exit the sub...
erickson [Wed, 5 Jan 2011 14:47:20 +0000 (14:47 +0000)]
roll back xact in set_item_lost when copy is alrady marked lost and we exit the sub;  if caller passes an event to editor->die_event, capture it as the editor's last event

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19123 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFinish adding authority.js to i18n Makefile
dbs [Wed, 5 Jan 2011 04:24:34 +0000 (04:24 +0000)]
Finish adding authority.js to i18n Makefile

Forgot to add some crucial bits in the extensive copy and paste
effort that's required to add another file to the i18n build.
Sigh. Rewrites welcome! And sorry for leaving this trap for
you to fall into, miker.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19121 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAddressing https://bugs.launchpad.net/evergreen/+bug/696078 where deleted/inactive...
miker [Tue, 4 Jan 2011 16:34:09 +0000 (16:34 +0000)]
Addressing https://bugs.launchpad.net/evergreen/+bug/696078 where deleted/inactive records are included in the freshmeat feed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19106 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomixing use of '/' and '/eg' for the auth cookie path is creating complications; ...
erickson [Tue, 4 Jan 2011 16:33:58 +0000 (16:33 +0000)]
mixing use of '/' and '/eg' for the auth cookie path is creating complications;  fall back to '/', which is the assumption from most EG code

Signed-off-by: Bill Erickson <berick@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19105 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocleaned up vestigal item import API call; repaired some faulty assumptions in vandela...
erickson [Tue, 4 Jan 2011 16:28:56 +0000 (16:28 +0000)]
cleaned up vestigal item import API call; repaired some faulty assumptions in vandelay UI regarding which types of import to attempt based on user input

Signed-off-by: Bill Erickson <berick@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19103 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agooils_xpath_table was too strict about field nullness -- we need /some/ data, not...
miker [Tue, 4 Jan 2011 16:09:17 +0000 (16:09 +0000)]
oils_xpath_table was too strict about field nullness -- we need /some/ data, not /all/ data, to be present

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19101 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPatch from Jason Stephenson to silence spurious warnings: https://bugs.launchpad...
miker [Tue, 4 Jan 2011 15:10:48 +0000 (15:10 +0000)]
Patch from Jason Stephenson to silence spurious warnings: https://bugs.launchpad.net/evergreen/+bug/695510

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19096 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAcq: Make manual lineitem claiming work better. When a claiming policy has not
senator [Tue, 4 Jan 2011 14:40:23 +0000 (14:40 +0000)]
Acq: Make manual lineitem claiming work better. When a claiming policy has not
been applied, users can now choose claim actions manually (this is what a
claiming policy would have specified).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19094 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoInternationalize the JavaScript portion of the "Manage Authorities" interface
dbs [Mon, 3 Jan 2011 03:54:04 +0000 (03:54 +0000)]
Internationalize the JavaScript portion of the "Manage Authorities" interface

We can use the dojo i18n infrastructure to support translations of the
"Manage Authorities" interface, but unfortunately we still don't have
a TT2 solution for i18n. Still, better to do what we can.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19093 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCreate and use authority browse feeds that match against see and see also references
dbs [Mon, 3 Jan 2011 03:09:33 +0000 (03:09 +0000)]
Create and use authority browse feeds that match against see and see also references

Approaching something workable for recognizing 4xx/5xx entries in
authority records by registering feeds with ".refs." axes that
search the 4xx/5xx as well as the 1xx, then using the feeds in
the MARC editor authority context menu.

Also tighten up the layout of the see / see from entries when
they appear in the authority context menu; "text-align: right" was
a bit over the top.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19092 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoImprove see from / see also handling in MARC editor authority menu
dbs [Sun, 2 Jan 2011 18:30:02 +0000 (18:30 +0000)]
Improve see from / see also handling in MARC editor authority menu

The 2.0-style authorities use a browse menu that currently consists
of matches against the 1XX entries, which makes working with see from /
see also entries rather difficult. To prepare for an authority browse
method that does surface matches against 4xx and 5xx entries, we will
now display the 4xx and 5xx entries for a given authority record
immediately below the 1xx entry in the browse menu, with the entry
text italicized, aligned to the right, and prefixed with "See also" or
"See from" appropriately. This won't provide a perfect alphabetized
solution - we won't know which field provided the alphabetical browse
match, so the best we can do is present the 1xx in the main browse
menu and the 4xx / 5xx below - but it will provide access to the other
references.

We now display the 4xx fields in the authority summary / selector menu
along with the 5xx fields. As part of making the 4xx and 5xx fields
first-class entries in the context menu, 5xx subfields are no longer
appended to their 1xx field menu entry with a "/" in the context menu.

$0 subfields are no longer added to the 4xx and 5xx fields from the
authority summary / selector menu; if a user had selected a 5xx and the
$0 that had been added by the menu, the field would have incorrectly been
linked to the 1xx authority record. To link to a 5xx entry, for now the
workaround is for the user to select the 5xx subfield(s), "Apply Selected",
then right-click on the new subfield to generate a new authority context menu.
To improve the 5xx handling, we need to make the "See also" entry fire a new
authority context menu based on the 5xx contents so that the actual 1xx
authority record can be inserted and linked against.

Consider an authority record containing the following fields:

150 $a Infants
450 $a Babies
550 $a Children

The ASCII-ized authority context menu will now display:

Infants              ->
    See from: Babies ->
  See also: Children ->

The submenu in each case will currently lead to the authority record
for "Infants". If we teach the underlying authority browse and startswith
methods to return matches based on 4xx and 5xx fields instead of just 1xx
fields, then the menu triggered by a right-click on "Childs" might look
like:

Chickens             ->
Infants              ->
    See from: Babies ->
  See also: Children ->
Choking              ->

The main entry will be out of alphabetical order, which is not ideal,
but the linkage from the 5xx should at least be evident. (Also, this
suggests that when clicking on a 5xx entry in the authority menu is
changed to launch a new authority menu, it should use the 1xx-only
browse variant to avoid showing the record from which the user was
referred...)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19091 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd an "--all" option to marc_export and silence some warnings
dbs [Sun, 2 Jan 2011 05:02:00 +0000 (05:02 +0000)]
Add an "--all" option to marc_export and silence some warnings

Rather than forcing users to generate a set of record IDs using a
separate process, the --all option enables to to export all records
of the specified type. Note that the approach is basic: grab the
record with the highest ID, then start at ID 0 and count up by 1
while trying to retrieve each record along the way. While this will
undoubtedly generate plenty of warnings for deleted records or gaps
in the ID sequences, the alternative of retrieving an ID list for
potentially millions of records in large Evergreen instances wasn't
appealing.

Also, $count{did} and $count{bib} resulted in uninitialized variable
warnings if no records were actually exported, so initialize them to 0.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19090 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoNever do money math as anything but pennies I tell you. :-) Three $0.60 transactions...
phasefx [Thu, 30 Dec 2010 18:42:30 +0000 (18:42 +0000)]
Never do money math as anything but pennies I tell you. :-)  Three $0.60 transactions run through check-in were showing a running tally of $1.79 instead of $1.80.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19086 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofix a bug with standing penalties and the stop sign page. We still have a race condi...
phasefx [Thu, 30 Dec 2010 16:29:53 +0000 (16:29 +0000)]
fix a bug with standing penalties and the stop sign page.  We still have a race condition where the stop sign page may not show, and this seems to happen when multiple patrons are retrieved at once from a patron search.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19084 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoClean up marc_export and teach it how to export authority records
dbs [Thu, 30 Dec 2010 06:40:37 +0000 (06:40 +0000)]
Clean up marc_export and teach it how to export authority records

The new "--type" parameter enables users to specify "authority"
and have the expected result.

Some other refactoring and fixes:

Two large chunks of code were factored out into subroutines to
make it a little easier to read the main flow of the code.

As we explicitly call uc() on the $format input parameter
to begin with, we don't have to call it subsequently.

If a requested ID did not exist in the database, then
the script would die; now we trap and flag that error but
continue to fulfill subsequent requests.

The --money parameter is now documented in the help, and
the help has a brief overview that describes (poorly) the
expected format for the list of IDs.

An uninitialized variable error when exporting BRE format
records was squashed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19083 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoat po activation time, apply the provider's default claim policy to each lineitem...
erickson [Wed, 29 Dec 2010 16:43:44 +0000 (16:43 +0000)]
at po activation time, apply the provider's default claim policy to each lineitem when no policy is already applied

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19081 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoVandelay import repairs
erickson [Wed, 29 Dec 2010 15:33:30 +0000 (15:33 +0000)]
Vandelay import repairs

Disable OpenSRF response chunking on calls that respond with small,
sparse status updates.

Repaired some bugs with status reporting and changed the reporting style
for queue imports to report more early in the import, then plateau.

Added some fault-tolerance to record importing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19079 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoMusty old modeline returned tabs to this source; death to tabs!
dbs [Wed, 29 Dec 2010 04:26:42 +0000 (04:26 +0000)]
Musty old modeline returned tabs to this source; death to tabs!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19077 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCreate authority records with meaningful cataloging agency values
dbs [Wed, 29 Dec 2010 03:37:38 +0000 (03:37 +0000)]
Create authority records with meaningful cataloging agency values

Hardcoded values in the 040 are problematic for sites that want
to be a source of authority records; with the addition of another
parameter to the open-ils.cat.authority.record.create_from_bib(.readonly)
API, we can solve that problem. The callers of this API (the MARC editor)
have access to the cat.marc_control_number_identifier OU setting, so as
long as that is set correctly, problem solved.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19073 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoInvoke MARC editor with the appropriate control number identifier
dbs [Wed, 29 Dec 2010 03:12:04 +0000 (03:12 +0000)]
Invoke MARC editor with the appropriate control number identifier

The control number identifier is most critical for the creation
of authority records; given that the callers have the required
context, have them pass in the control number identifier to the
MARC editor. Edit MARC record, new MARC record, import MARC record;
those have to be the big ones, right?

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19072 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoEnhance usability of authority record deletion dialogue
dbs [Tue, 28 Dec 2010 17:26:57 +0000 (17:26 +0000)]
Enhance usability of authority record deletion dialogue

Don't show the number of linked bib records unless it is
a non-zero sum.

Make "Cancel" the button with focus in the dialog, so that
an errant press of the "Enter" key doesn't do the wrong thing.

Trim space from the authority text in the display. Move the
authority text from the dialog title to the contents of the
dialog.

Do not display the MARC for the authority record by default;
add a "View MARC" button and toggle it to show/hide MARC.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19071 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoUpdate auth-cached user after payment
erickson [Tue, 28 Dec 2010 16:47:40 +0000 (16:47 +0000)]
Update auth-cached user after payment

After payment toward one's own account, reset the cached user object so
that it will contain the latest last_xact_id value.  This is necessary
for supporting patron credit card payments in the catalog.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19068 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTowards a more useful authority delete confirmation pane
dbs [Tue, 28 Dec 2010 06:16:56 +0000 (06:16 +0000)]
Towards a more useful authority delete confirmation pane

Rather than simply creating a raw confirm dialogue that only
provides the cataloguer with the ID of the authority record that
is about to be deleted (not an especially useful handle), supply
a confirmation dialogue that recaps how many bibliographic records
are linked to this authority record and also displays the MARC of
the record about to be deleted.

Most authority records appear to be short enough that the MARC
display is not a concern, but if it becomes a problem we can opt
not to show the MARC by default and give the cataloguer the ability
to click a "View MARC" button on the confirmation dialog instead.

Along the way, make some more variables local and remove some
unnecessary workarounds for object IDs.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19067 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofurther fixes to null indicator handling in flat-text MARC editor
gmc [Thu, 23 Dec 2010 15:14:10 +0000 (15:14 +0000)]
further fixes to null indicator handling in flat-text MARC editor

[1] ensure that null indicators are converted to blanks
[2] fix glitch when supplying default indicator values

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19066 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoWhen the subfield delimiter is configured as "$" (the default), use {dollar} to repre...
miker [Thu, 23 Dec 2010 02:24:17 +0000 (02:24 +0000)]
When the subfield delimiter is configured as "$" (the default), use {dollar} to represent a literal dollar sign.  This is apparently in line with other Breaker-format tools.  Fix suggested by Galen Charlton, thanks gmc!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19051 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoaddressing two Breaker-format issues: 1) supply an "empty" (space) value for indicato...
miker [Thu, 23 Dec 2010 02:12:43 +0000 (02:12 +0000)]
addressing two Breaker-format issues: 1) supply an "empty" (space) value for indicators in the internal format if they are left out and 2) add indicator placeholders to incoming Breaker datafield lines if they seem to be missing.  Addresses https://bugs.launchpad.net/evergreen/+bug/693468

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19049 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPatch from Nathanael Schilling protecting cstore/pcrud from no-search-param segfaults...
miker [Thu, 23 Dec 2010 01:43:43 +0000 (01:43 +0000)]
Patch from Nathanael Schilling protecting cstore/pcrud from no-search-param segfaults (with minor editorializing)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19047 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoallow vandelay.replace_field() to handle a complex field spec by splitting and loopin...
miker [Thu, 23 Dec 2010 01:27:30 +0000 (01:27 +0000)]
allow vandelay.replace_field() to handle a complex field spec by splitting and looping; bringing 1.6.1-2.0 upgrade script up to date

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19043 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoOPAC/Serials: small aesthetic change to render held issues more neatly
senator [Wed, 22 Dec 2010 16:59:47 +0000 (16:59 +0000)]
OPAC/Serials: small aesthetic change to render held issues more neatly

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19041 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAcq: support manual claiming as always intended, which to some users means
senator [Tue, 21 Dec 2010 23:10:42 +0000 (23:10 +0000)]
Acq: support manual claiming as always intended, which to some users means
claiming with no predefined policy

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19040 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFor making predictions, remove some debug/dead code, refresh the list.
dbwells [Tue, 21 Dec 2010 23:09:25 +0000 (23:09 +0000)]
For making predictions, remove some debug/dead code, refresh the list.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19038 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years ago'Bindery' item status rethink - this status should eventually be tracked at the unit...
dbwells [Tue, 21 Dec 2010 22:54:15 +0000 (22:54 +0000)]
'Bindery' item status rethink - this status should eventually be tracked at the unit level, not the item level.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19036 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd line feeds to the output of org_tree_proximity.pl
dbs [Tue, 21 Dec 2010 20:51:23 +0000 (20:51 +0000)]
Add line feeds to the output of org_tree_proximity.pl

When another routine was appended to autogen.sh, the output
was appended to the result string returned from org_tree_proximity.pl;
adding a linefeed cleans that up.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19034 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPropagate merged authority record change to bibliographic record
dbs [Tue, 21 Dec 2010 20:21:58 +0000 (20:21 +0000)]
Propagate merged authority record change to bibliographic record

Launchpad bug 688015 reported that the merge of authority records
resulted in the control number identifier in a controlled field
in a bibliographic record changing to the right value, but the
value of the field itself wasn't being changed.

The problem turned out to be a confusion of the "source" and
"target" values in the authority.merge_record() function. Once
that was straightened out, the merge updated the controlled
field as expected.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19032 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAcq: Fix a bug where upon PO activation, lineitems in the order-ready state
senator [Tue, 21 Dec 2010 19:37:18 +0000 (19:37 +0000)]
Acq: Fix a bug where upon PO activation, lineitems in the order-ready state
would stay there, rather than progressing to the on-order state

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19030 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoprotect against null orig-location resulting in depth=-1 searches after logout
erickson [Mon, 20 Dec 2010 18:13:44 +0000 (18:13 +0000)]
protect against null orig-location resulting in depth=-1 searches after logout

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19028 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAcq: In fund propagation and rollover, add amounts as numbers, not strings
senator [Mon, 20 Dec 2010 17:37:40 +0000 (17:37 +0000)]
Acq: In fund propagation and rollover, add amounts as numbers, not strings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19026 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agosync naco_normalize versions
gmc [Mon, 20 Dec 2010 16:30:18 +0000 (16:30 +0000)]
sync naco_normalize versions

The copy in FTS.pm now matches the stored procedure, avoiding
a potential bug validating authorized headings that contain
diacritics.

Also added FIXME for the code-duplication.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19025 dcc99617-32d9-48b4-a31d-7c20da2025e4