Evergreen.git
8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac
Bill Erickson [Wed, 20 Jul 2011 18:19:41 +0000 (14:19 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

8 years agoLP#647121 Event handling on override abort
Michael Peters [Wed, 20 Jul 2011 15:09:40 +0000 (11:09 -0400)]
LP#647121 Event handling on override abort

Discussed on IRC, phasefx discovered that several events were not being properly
handled when they were empty strings.  Tested and working on Evergreen 2.0.4.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Lebbeous Fogle-Weekley [Tue, 19 Jul 2011 21:04:38 +0000 (17:04 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

8 years agoMerge remote branch 'working/user/dbwells/lp_811255_compressed_holdings_fixes'
Lebbeous Fogle-Weekley [Tue, 19 Jul 2011 20:53:06 +0000 (16:53 -0400)]
Merge remote branch 'working/user/dbwells/lp_811255_compressed_holdings_fixes'

Dan's tests pass, and I don't see any problems or ill effects on a
working system with serials loaded.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMake inactive cards/patrons "not exist" via SIP2
Thomas Berezansky [Mon, 18 Jul 2011 00:28:14 +0000 (20:28 -0400)]
Make inactive cards/patrons "not exist" via SIP2

And make sure if we do get a deleted patron for some reason they are ignored too.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agorerun DB update 0582 to avoid upgrade problem
Galen Charlton [Tue, 19 Jul 2011 18:43:03 +0000 (14:43 -0400)]
rerun DB update 0582 to avoid upgrade problem

This implements the same update as 0582.schema.aging_circ_view.sql,
and exists purely the the sake of avoid a potential upgrade
glitch for somebody who's upgrading from 2.0.8+ that includes
a version of this fix that's not compatible with with 2.1+.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoMFHD compressed holding fixes
Dan Wells [Tue, 19 Jul 2011 16:02:17 +0000 (12:02 -0400)]
MFHD compressed holding fixes

1. Add new utility method to MFHD.pm:
    holdings_by_caption(): return all holdings attached to a
    given caption

2. Add 'passthru_open_ended' option to get_decompressed_holdings()
    Previously, attempts to decompress an open-ended holding
    would error out.  Now, in the absence of this option,
    open-ended holdings are discarded and you get a warning
    (since they cannot logically be decompressed), while if
    this option is 'true' they are passed back unaffected

3. compressed_to_last() on an open-ended holding now more
   correctly returns 'undef' rather than the unaltered holding

4. get_compressed_holdings() will now honor an open-ended holding
   by treating it as "infinite", and thus absorbing any holdings
   which would follow

5. Overloaded comparison operator now correctly detects "swap"
   cases (where only the second operand is a holding)

6. Overloaded comparison operator now consistently treats
   open-ended holdings as "greater-than" a single or closed
   holding which has the same starting point

7. Fix 2 thinkos in comparison operator for overlapping
   compressed holdings

8. Add new compressed_end() method to Holding.pm which can add
   or set a new ending to a holding, making compressed if needed

9. Correctly recognize partially compressed holdings
    If a holding is defined as:
        863 40 $81.1 $a1 $b2-10
    this actually means:
        863 40 $81.1 $a1-1 $b2-10
    so let's make sure to treat it that way.

9. Expand the MFHD test suite to better cover the improvements
   in this commit

There is also the beginnings of a _get_truncated_holdings()
method for handling odd cases where an open-ended holding is
followed by a single/closed holding, but it is currently
commented out, pending further design consideration.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agolp#812550: Removed nulls from showing for patron penalties when no note attached...
Steven Callender [Mon, 18 Jul 2011 20:26:13 +0000 (20:26 +0000)]
lp#812550: Removed nulls from showing for patron penalties when no note attached to penalty.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoFix the wrongish way we were doing staff-assisted holds
Lebbeous Fogle-Weekley [Mon, 18 Jul 2011 22:49:01 +0000 (18:49 -0400)]
Fix the wrongish way we were doing staff-assisted holds

Now the patron that a staff user wants to place a hold for is passed
around as a cookie

It's a little unclear when is best from a workflow perspective to kill
said cookie... hrmmm....

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agobump xulrunner version
Jason Etheridge [Mon, 18 Jul 2011 20:24:30 +0000 (16:24 -0400)]
bump xulrunner version

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoMerge remote branch 'working/collab/phasefx/unified_vol_copy_ui_from_item_status_ui'
Lebbeous Fogle-Weekley [Mon, 18 Jul 2011 19:48:39 +0000 (15:48 -0400)]
Merge remote branch 'working/collab/phasefx/unified_vol_copy_ui_from_item_status_ui'

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen into template-toolkit...
Lebbeous Fogle-Weekley [Mon, 18 Jul 2011 17:56:38 +0000 (13:56 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen into template-toolkit-opac

8 years agoAlert or block holds on available copy at same pickup lib
Lebbeous Fogle-Weekley [Mon, 18 Jul 2011 17:40:17 +0000 (13:40 -0400)]
Alert or block holds on available copy at same pickup lib

This improves upon the earlier commit that attempted to deal with what
to do when either of these org_unit settings are true:

     circ.holds.hold_has_copy_at.alert
     circ.holds.hold_has_copy_at.block

The correct use of these settings are that when /any/ type of hold is
attempted at a given pickup lib, if either of those settings are true in
the context of said pickup lib, and there are copies in an available
status at the pickup lib already, inform the user before placing the
hold.  In the alert case, the user can place the hold anyway with
another click.  In the block case, there's an end on't.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoRemove extraneous COMMIT message in 950 seed data
Dan Scott [Mon, 18 Jul 2011 15:43:13 +0000 (11:43 -0400)]
Remove extraneous COMMIT message in 950 seed data

The extra COMMIT message didn't hurt when creating a new schema, but did
result in a warning message that could cause confusion. So, get rid of
it to avoid that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoItem Status->Alternate View support for the dynamic Record Summary
Jason Etheridge [Wed, 6 Jul 2011 18:52:53 +0000 (14:52 -0400)]
Item Status->Alternate View support for the dynamic Record Summary

For now, you could put something like this in server/skin/custom.js to re-configure the display:

try {

    netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
    var prefs = Components.classes['@mozilla.org/preferences-service;1'].getService(Components.interfaces['nsIPrefBranch']);
    prefs.setCharPref(
        'oils.bib_brief.alternate_copy_summary.dynamic_grid_replacement.data',
        js2JSON([
            ['title',       'edition',  'editor'],
            ['author',      'pubdate',  'edit_date'],
            ['call_number', 'tcn',      'create_date']
        ])
    );

} catch(E) {
    dump('Error in custom.js trying to set oils.bib_brief.alternate_copy_summary.dynamic_grid_replacement.data: ' + E + '\n');
}

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agodynamic Record Summary layout based on preference
Jason Etheridge [Wed, 6 Jul 2011 07:19:09 +0000 (03:19 -0400)]
dynamic Record Summary layout based on preference

For now, you could add something like this to server/skin/custom.js to re-configure the display:

try {

    netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
    var prefs = Components.classes['@mozilla.org/preferences-service;1'].getService(Components.interfaces['nsIPrefBranch']);
    prefs.setCharPref(
        'oils.bib_brief.horizontal.dynamic_grid_replacement.data',
        js2JSON([
            ['title',           'edition',  'editor'],
            ['author',          'pubdate',  'edit_date'],
            ['bib_call_number', 'tcn',      'create_date']
        ])
    );

} catch(E) {
    dump('Error in custom.js trying to set oils.bib_brief.horizontal.dynamic_grid_replacement.data: ' + E + '\n');
}

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agosome refactoring in prep for dynamic Record Summary layout
Jason Etheridge [Wed, 6 Jul 2011 06:32:01 +0000 (02:32 -0400)]
some refactoring in prep for dynamic Record Summary layout

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoin staff Record Summary (bib brief) pane, stretch the column for title, author, and...
Jason Etheridge [Fri, 1 Jul 2011 16:05:46 +0000 (12:05 -0400)]
in staff Record Summary (bib brief) pane, stretch the column for title, author, and bib call #

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAddress minor code formatting consistency
Dan Scott [Mon, 18 Jul 2011 15:00:26 +0000 (11:00 -0400)]
Address minor code formatting consistency

The rest of the code has spaces around the conditional clause in an if()
statement, so do likewise here.

Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agoSpine label editor assumes LC as reported in LP #780665.
James Fournie [Mon, 6 Jun 2011 17:00:22 +0000 (10:00 -0700)]
Spine label editor assumes LC as reported in LP #780665.

This patch encapsulates the LC-assuming code in an IF block which
considers the asset.call_number.volume.label_class.  If that is equal to
3, it will use the LC formatting.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agofix bill ui display update bug where total owed and total checked were not updated...
Jason Etheridge [Thu, 14 Jul 2011 20:03:42 +0000 (16:03 -0400)]
fix bill ui display update bug where total owed and total checked were not updated if the total owed as paid off in full

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamping upgrade script for "Bad join condition all_circulation view"
Mike Rylander [Sat, 16 Jul 2011 16:56:32 +0000 (12:56 -0400)]
Stamping upgrade script for "Bad join condition all_circulation view"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoBad join condition in secondary (physical) address lookup, causing terrible performan...
Mike Rylander [Sat, 16 Jul 2011 16:53:13 +0000 (12:53 -0400)]
Bad join condition in secondary (physical) address lookup, causing terrible performance of circ aging

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP795032 Fix cursor rendering and dropdown position in holdings maintenance OU dropdown
mrpeters-isl [Wed, 13 Jul 2011 13:42:54 +0000 (09:42 -0400)]
LP795032 Fix cursor rendering and dropdown position in holdings maintenance OU dropdown
Signed-off-by: mrpeters-isl <mrpeters@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamping upgrade script for "Opac Renewal at original circ library"
Mike Rylander [Sat, 16 Jul 2011 14:25:44 +0000 (10:25 -0400)]
Stamping upgrade script for "Opac Renewal at original circ library"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDefault to existing behaviour for the new circ-behaviour global flag
Mike Rylander [Sat, 16 Jul 2011 14:22:51 +0000 (10:22 -0400)]
Default to existing behaviour for the new circ-behaviour global flag

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoCache global flag at first use
Thomas Berezansky [Tue, 5 Jul 2011 20:33:41 +0000 (16:33 -0400)]
Cache global flag at first use

This way only the first opac renewal per backend has to ask the database for the global flag.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUnwrapped upgrade script
Thomas Berezansky [Tue, 5 Jul 2011 16:15:19 +0000 (12:15 -0400)]
Unwrapped upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoOpac Renewal at original circ library
Thomas Berezansky [Sat, 2 Jul 2011 16:50:36 +0000 (12:50 -0400)]
Opac Renewal at original circ library

Fixes multiple potential issues:
1 - Bad home ou on patron breaks circ rules
    Ex. Patron edited while editor would let you pick bad home ou
2 - Item not allowed to circ at patron home ou
    Ex. Patron went to where they were allowed to pick it up
3 - Fines change to patron home ou fine rules
    Ex. Patron's home ou doesn't charge fines but circ lib does
    Ex. Circ lib doesn't charge fines but Patron's home ou does

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamping upgrade script for "Prevent OU loops at DB level"
Mike Rylander [Sat, 16 Jul 2011 14:08:03 +0000 (10:08 -0400)]
Stamping upgrade script for "Prevent OU loops at DB level"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUnwrapped upgrade script for ou loop protect
Thomas Berezansky [Thu, 16 Jun 2011 02:03:47 +0000 (22:03 -0400)]
Unwrapped upgrade script for ou loop protect

May need to be split into "create function" and "add trigger" pieces.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoPrevent OU loops at DB level
Thomas Berezansky [Thu, 16 Jun 2011 02:03:38 +0000 (22:03 -0400)]
Prevent OU loops at DB level

Database trigger to prevent actor.org_unit from being parent of self

Actually detects any loops, even those above the current point

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMake spell-checking case insensitive
Dan Wells [Thu, 7 Jul 2011 21:18:16 +0000 (17:18 -0400)]
Make spell-checking case insensitive

As it stands, if you search for a proper noun using
lower case, but manage to trigger the "did you mean"
functionality, all the words are 'corrected' even if
just the case is wrong.  However, we are stripping
out the best correction precisely because it is the
same word, different case.  It is a bit confusing to
explain, but here is an example:

daniel potatoe

gets corrected to:

Daniela potato

This happens because the current spell check is case
sensitive, so 'daniel' is spelled wrong, but then we
remove 'Daniel' from the list of corrections
(presumably to avoid possibly suggesting terms which
would yield the same exact result set).

So, we either need to make the spell-check itself case
insensitive, or stop removing the re-cased corrections.
Since the catalog search itself is already
case-insensitive, I think it makes sense that the spell
check should follow suit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamping upgrade script for "INDB Circ Matrix + Checkout Overrides Fix"
Mike Rylander [Sat, 16 Jul 2011 12:41:50 +0000 (08:41 -0400)]
Stamping upgrade script for "INDB Circ Matrix + Checkout Overrides Fix"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUnwrapped upgrade script for checkout overrides
Thomas Berezansky [Tue, 7 Jun 2011 15:08:17 +0000 (11:08 -0400)]
Unwrapped upgrade script for checkout overrides

Replace the function.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoINDB Circ Matrix + Checkout Overrides Fix
Thomas Berezansky [Mon, 6 Jun 2011 21:30:35 +0000 (17:30 -0400)]
INDB Circ Matrix + Checkout Overrides Fix

Move most failures to after matchpoint lookup.
This prevents "no duration rule" errors on overridable errors.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamping upgrade script for "Fix part holds in reporter.hold_request_record"
Mike Rylander [Sat, 16 Jul 2011 00:08:35 +0000 (20:08 -0400)]
Stamping upgrade script for "Fix part holds in reporter.hold_request_record"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUnwrapped upgrade script
Thomas Berezansky [Fri, 15 Jul 2011 19:55:18 +0000 (15:55 -0400)]
Unwrapped upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFix part holds in reporter.hold_request_record
Thomas Berezansky [Fri, 15 Jul 2011 19:54:35 +0000 (15:54 -0400)]
Fix part holds in reporter.hold_request_record

Specifically, make them show a bib id, instead of null.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAllow overriding some hold events when permissions apply
Lebbeous Fogle-Weekley [Fri, 15 Jul 2011 22:27:30 +0000 (18:27 -0400)]
Allow overriding some hold events when permissions apply

Works fine now for HOLD_EXISTS and HOLD_ITEM_CHECKOUT_OUT, at least

But this was also supposed to work with these org settings:
 circ.holds.hold_has_copy_at.alert
 circ.holds.hold_has_copy_at.block
which are supposed to define behavior when the user wants to place a
(copy- or volume-level only?) hold on an item at a branch that's not his
home_ou but his home_ou has an available copy.

Anyway, the open-ils.circ.title_hold.is_possible method is supposed to
return information about whether local copies are available to support
such a function, but it doesn't seem to do so.  I think.  Will revisit.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoVandelay item import copy location inheritance
Bill Erickson [Tue, 12 Jul 2011 21:39:37 +0000 (17:39 -0400)]
Vandelay item import copy location inheritance

When importing items that have a copy location configured and no such
location exists at the copy's owning/circ lib, Vandelay will now use
copy locations from ancestor org units as appropriate.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoCorrected the logic of format string building for metarecord holds and...
Lebbeous Fogle-Weekley [Thu, 14 Jul 2011 20:41:42 +0000 (16:41 -0400)]
Corrected the logic of format string building for metarecord holds and...

made hold possiblity checking for metarecord holds respect the format
string (so you can't place holds on formats for which there will never
be anything targetable)

Made possible by much concerted effort from Mike Rylander

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoCorrect CDBI thinko -- search_where is smart about wantarray, search is not
Mike Rylander [Thu, 14 Jul 2011 15:42:26 +0000 (11:42 -0400)]
Correct CDBI thinko -- search_where is smart about wantarray, search is not

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoPreset correct default pickup lib for staff placing holds for patrons
Lebbeous Fogle-Weekley [Wed, 13 Jul 2011 16:24:38 +0000 (12:24 -0400)]
Preset correct default pickup lib for staff placing holds for patrons

Also, for hold placement, only enable org unit selection where
can_have_vols is true.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoRemove deprecated, conflicting version of vandelay.match_bib_record from base schema...
Bill Erickson [Tue, 12 Jul 2011 21:49:10 +0000 (17:49 -0400)]
Remove deprecated, conflicting version of vandelay.match_bib_record from base schema.  Thanks, Galen

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agopin an upgrade version for fix_maintain_901_quoting
Jason Etheridge [Tue, 12 Jul 2011 21:55:54 +0000 (17:55 -0400)]
pin an upgrade version for fix_maintain_901_quoting

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoupgrade script for bugfix for lp#809540
Galen Charlton [Tue, 12 Jul 2011 20:56:10 +0000 (16:56 -0400)]
upgrade script for bugfix for lp#809540

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agolp#809540: quote replacement values properly in maintain_901()
Galen Charlton [Tue, 12 Jul 2011 20:51:31 +0000 (16:51 -0400)]
lp#809540: quote replacement values properly in maintain_901()

Prevents a failure if, for example, the tcn_value of a bib to be
added or updated contains the string '\1'.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoalert the user when the OPAC's Quick Search->Item Barcode function returns a pre...
Jason Etheridge [Tue, 12 Jul 2011 18:36:37 +0000 (14:36 -0400)]
alert the user when the OPAC's Quick Search->Item Barcode function returns a pre-cataloged item

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agocopy and volume level holds for staff
Lebbeous Fogle-Weekley [Tue, 12 Jul 2011 21:24:16 +0000 (17:24 -0400)]
copy and volume level holds for staff

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years ago"Mark Local Result as Overlay Target" action in z39.50 client
Jason Etheridge [Tue, 12 Jul 2011 14:42:08 +0000 (10:42 -0400)]
"Mark Local Result as Overlay Target" action in z39.50 client

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoRemoving errant comma spotted by Thomas Berezansky
Mike Rylander [Tue, 12 Jul 2011 13:40:54 +0000 (09:40 -0400)]
Removing errant comma spotted by Thomas Berezansky

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoWhen coming from staff client patron interface,
Lebbeous Fogle-Weekley [Mon, 11 Jul 2011 22:17:13 +0000 (18:17 -0400)]
When coming from staff client patron interface,

pre-populate the patron barcode text box by which staff places a hold
for a patron.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMerge branch 'template-toolkit-opac' of git://git.evergreen-ils.org/evergreen/equinox...
Lebbeous Fogle-Weekley [Mon, 11 Jul 2011 21:46:20 +0000 (17:46 -0400)]
Merge branch 'template-toolkit-opac' of git://git.evergreen-ils.org/evergreen/equinox into template-toolkit-opac

8 years agoStaff can now place title-type holds for patrons
Lebbeous Fogle-Weekley [Mon, 11 Jul 2011 21:43:51 +0000 (17:43 -0400)]
Staff can now place title-type holds for patrons

Still need to put in copy, volume and issuance (and parts? maybe later) -type
holds.  Still need to deal with overridable events.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMerge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into...
Mike Rylander [Mon, 11 Jul 2011 20:16:22 +0000 (16:16 -0400)]
Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac
Mike Rylander [Mon, 11 Jul 2011 20:16:21 +0000 (16:16 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

8 years agoappend line items to table in specified order
Galen Charlton [Mon, 11 Jul 2011 19:09:34 +0000 (15:09 -0400)]
append line items to table in specified order

Prior to this patch, the order that line items were displayed
in (e.g.) a purchase order view was effetively randomized based
on the amount of time it would take for async calls to fetch
additional line item details to return.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMerge branch 'authority-control-sets-squashed_for_master'
Lebbeous Fogle-Weekley [Mon, 11 Jul 2011 18:26:16 +0000 (14:26 -0400)]
Merge branch 'authority-control-sets-squashed_for_master'

Authority control sets! Largely by Mike Rylander, somewhat by me and
others.

This is the merge commit.  See individual commit messages for more
detail.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoStamping Mike's upgrade script for authority control sets
Lebbeous Fogle-Weekley [Mon, 11 Jul 2011 18:23:30 +0000 (14:23 -0400)]
Stamping Mike's upgrade script for authority control sets

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoUnstamped upgrade script for Authority Control Sets
Mike Rylander [Mon, 11 Jul 2011 15:41:35 +0000 (11:41 -0400)]
Unstamped upgrade script for Authority Control Sets

... with additional fixes from Lebbeous Fogle-Weekley

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMerge/rebase cleanup -- remove useless/incorrect versions of the MARC flattener for...
Mike Rylander [Mon, 11 Jul 2011 13:52:26 +0000 (09:52 -0400)]
Merge/rebase cleanup -- remove useless/incorrect versions of the MARC flattener for different record types

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMerge/rebase cleanup -- authority template by id is needed
Mike Rylander [Mon, 11 Jul 2011 13:51:33 +0000 (09:51 -0400)]
Merge/rebase cleanup -- authority template by id is needed

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMake search by authority ID actually work on the first try
Lebbeous Fogle-Weekley [Tue, 5 Jul 2011 19:50:20 +0000 (15:50 -0400)]
Make search by authority ID actually work on the first try

and also show an odd number of authority record results so that
there can actually be a "middle."

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoProvide sorters for browse axes
Lebbeous Fogle-Weekley [Tue, 5 Jul 2011 18:22:38 +0000 (14:22 -0400)]
Provide sorters for browse axes

Make the default bib result sorter 'titlesort' for every
browse axis, which is what makes sense if you think about it.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoCreate facet for going right to records linked to a given authority record
Lebbeous Fogle-Weekley [Thu, 30 Jun 2011 21:25:06 +0000 (17:25 -0400)]
Create facet for going right to records linked to a given authority record

Still need an upgrade script, of course, but so does this whole branch

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoattempted to add sanity to paging, but not really there yet
Lebbeous Fogle-Weekley [Thu, 30 Jun 2011 20:54:35 +0000 (16:54 -0400)]
attempted to add sanity to paging, but not really there yet

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMake linking to bib records work better by saying any format will do.
Lebbeous Fogle-Weekley [Thu, 30 Jun 2011 19:59:07 +0000 (15:59 -0400)]
Make linking to bib records work better by saying any format will do.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoworking! with paging and linking to bibs, except:
Lebbeous Fogle-Weekley [Wed, 29 Jun 2011 23:34:56 +0000 (19:34 -0400)]
working! with paging and linking to bibs, except:

... my new facet thingy doesn't seem to work.  here's what I did
sql-wise:

    INSERT INTO config.metabib_field (
        id, field_class, name, label, xpath,
        format, search_field, facet_field
    ) VALUES (
        28, 'identifier',
        'authority_id', 'Authority Record ID',
        '//marc:datafield/marc:subfield[@code=''0'']', 'marcxml', false, true
    );

    INSERT INTO config.metabib_field_index_norm_map (field, norm)
    VALUES (28, 5);

Yet after re-ingesting my bibs I have nothing new in
metabib.facet_entry.  So the "show related bibliographic holdings" links
don't quite work (I believe they /would/, though, if I had the facet
thingy right).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoFinally starting to get somewhere: record display
Lebbeous Fogle-Weekley [Wed, 29 Jun 2011 19:45:40 +0000 (15:45 -0400)]
Finally starting to get somewhere: record display

Record display kind of works.  Need paging and links to bibs.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoCloser to being able to get authority control set from thesaurus code
Lebbeous Fogle-Weekley [Tue, 28 Jun 2011 19:28:40 +0000 (15:28 -0400)]
Closer to being able to get authority control set from thesaurus code

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agotowards using fielder in openils.AuthorityControlSet
Lebbeous Fogle-Weekley [Tue, 28 Jun 2011 15:49:17 +0000 (11:49 -0400)]
towards using fielder in openils.AuthorityControlSet

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoworking on an auth browser
Lebbeous Fogle-Weekley [Tue, 28 Jun 2011 14:43:54 +0000 (10:43 -0400)]
working on an auth browser

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoAdd function to set Control Set by Thesaurus Code
Mike Rylander [Mon, 27 Jun 2011 14:12:33 +0000 (10:12 -0400)]
Add function to set Control Set by Thesaurus Code

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoNormalize fixed field names to OCLC values where they exist (what catalogers are...
Mike Rylander [Mon, 27 Jun 2011 14:03:34 +0000 (10:03 -0400)]
Normalize fixed field names to OCLC values where they exist (what catalogers are used to)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoconfig ui trivial improvements, scratching out a place for a browse UI
Lebbeous Fogle-Weekley [Thu, 23 Jun 2011 22:04:28 +0000 (18:04 -0400)]
config ui trivial improvements, scratching out a place for a browse UI

8 years agoFix minor glitch when trying to create new authority fields
Lebbeous Fogle-Weekley [Wed, 22 Jun 2011 21:22:54 +0000 (17:22 -0400)]
Fix minor glitch when trying to create new authority fields

The Autogrid can handle empty arrays as values for acsaf.bib_fields and
acsaf.axis_maps, but can't handle undefined.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMove the authority control set config interfaces back into conify
Lebbeous Fogle-Weekley [Wed, 22 Jun 2011 20:49:35 +0000 (16:49 -0400)]
Move the authority control set config interfaces back into conify

Really, that's where they make sense.  And they're done.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoAxis-field map editor and editor for the axes themselves
Lebbeous Fogle-Weekley [Wed, 22 Jun 2011 20:25:59 +0000 (16:25 -0400)]
Axis-field map editor and editor for the axes themselves

The editor for the axes themselves is accessed directly from staff
client menu.  Everything else is reached indirectly from the control set
editor.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoAdd bib field editor. Also make all the editors written so far...
Lebbeous Fogle-Weekley [Wed, 22 Jun 2011 18:04:14 +0000 (14:04 -0400)]
Add bib field editor.  Also make all the editors written so far...

... for authority control sets-related objects do the right thing to
help users create/edit new child objects linked to the right parent
table without extra effort.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoAbility to return to specific authority.control_set or
Lebbeous Fogle-Weekley [Wed, 22 Jun 2011 14:50:06 +0000 (10:50 -0400)]
Ability to return to specific authority.control_set or

to specific authority.control_set_authority_field from a child table.
Other improvements heading toward finishing authority control set config UI

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoEditor for authority fields
Lebbeous Fogle-Weekley [Tue, 21 Jun 2011 18:22:26 +0000 (14:22 -0400)]
Editor for authority fields

Due to time constraints (and AutoGrid limitations) a click-through UI
with separate pages for separate objects used by the new authority
control sets feature is necessary for now rather than a comprehensive
interface with multiple grids on the same page.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoThesauri editor
Lebbeous Fogle-Weekley [Tue, 21 Jun 2011 18:08:55 +0000 (14:08 -0400)]
Thesauri editor

8 years agomoving stuff where it goes
Lebbeous Fogle-Weekley [Tue, 21 Jun 2011 16:43:52 +0000 (12:43 -0400)]
moving stuff where it goes

8 years agoconify type interfaces in progress.
Lebbeous Fogle-Weekley [Tue, 21 Jun 2011 14:27:11 +0000 (10:27 -0400)]
conify type interfaces in progress.

not completely deleting old unfinished ones yet; there are probably
things to salvage

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoPut thesaurus-z handling back in
Mike Rylander [Wed, 15 Jun 2011 19:45:10 +0000 (15:45 -0400)]
Put thesaurus-z handling back in

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoBeginnings of the config interfaces
Mike Rylander [Fri, 3 Jun 2011 14:29:52 +0000 (10:29 -0400)]
Beginnings of the config interfaces

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMove RULE down so that the named tables actually exist
Mike Rylander [Tue, 31 May 2011 03:49:18 +0000 (23:49 -0400)]
Move RULE down so that the named tables actually exist

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoSwitch authority startwith index back to the pre-checking-deletedness version
Mike Rylander [Mon, 30 May 2011 00:30:27 +0000 (20:30 -0400)]
Switch authority startwith index back to the pre-checking-deletedness version

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agocorrecting template generation; filter out subfields that we do not use in the author...
Mike Rylander [Sat, 28 May 2011 16:23:24 +0000 (12:23 -0400)]
correcting template generation; filter out subfields that we do not use in the authority record

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMinor bug fixes (alignment of fm classes, etc); Do not check deletedness, just remove...
Mike Rylander [Sat, 28 May 2011 15:27:04 +0000 (11:27 -0400)]
Minor bug fixes (alignment of fm classes, etc); Do not check deletedness, just remove the afr data upon "delete" of an authority; We still need the non-tpo index on afr.value

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoHeading normalization bug; Use CStoreEditor, not Editor; syntax-y bugs
Mike Rylander [Sat, 28 May 2011 01:12:18 +0000 (21:12 -0400)]
Heading normalization bug; Use CStoreEditor, not Editor; syntax-y bugs

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoGeneral bug fixes and formatting cleanup
Mike Rylander [Fri, 27 May 2011 20:38:43 +0000 (16:38 -0400)]
General bug fixes and formatting cleanup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoRepaired syntax errors in SuperCat.pm
berick [Thu, 26 May 2011 19:34:07 +0000 (15:34 -0400)]
Repaired syntax errors in SuperCat.pm

Signed-off-by: berick <berick@esilibrary.com>
8 years agoRepaired syntax errors and thinkos
berick [Thu, 26 May 2011 19:13:48 +0000 (15:13 -0400)]
Repaired syntax errors and thinkos

 * Syntax in AuthorityControlSet.js
 * Protect against empty kwargs hash
 * marcedit.js fixes: Load dojo class before use; Load in my_init(), before which dojo is not defined

Signed-off-by: berick <berick@esilibrary.com>
8 years agoProtect against empty lists of linked bib searches
berick [Thu, 26 May 2011 18:44:48 +0000 (14:44 -0400)]
Protect against empty lists of linked bib searches

Instead of returning undef when passed an empty list of bibs, always
return an array from
open-ils.cat.authority.records.count_linked_bibs
Apart from consistency, this prevents JS errors in the Manage
Authorities UI.

Signed-off-by: berick <berick@esilibrary.com>
8 years agoSQL typo cleanup
Mike Rylander [Mon, 16 May 2011 18:00:04 +0000 (14:00 -0400)]
SQL typo cleanup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUse the configured set of authority browse axes in the authority browse interfaces
Mike Rylander [Thu, 12 May 2011 15:10:42 +0000 (11:10 -0400)]
Use the configured set of authority browse axes in the authority browse interfaces

8 years agoUse the new singular methods that accept an axis as a param for browse and startwith
Mike Rylander [Thu, 12 May 2011 14:18:58 +0000 (10:18 -0400)]
Use the new singular methods that accept an axis as a param for browse and startwith

8 years agoAdd method for returning valid authority browse axes
Mike Rylander [Thu, 12 May 2011 14:18:15 +0000 (10:18 -0400)]
Add method for returning valid authority browse axes