This patch fixes a bug where AutoFieldWidget wouldn't
invoke the callback when building an org unit selector. Fixing this
allows library settings (including acq.default_owning_lib_for_auto_lids
added in the previous patch) whose datatype is link and whose fm_class
is aou to work in the Dojo Library Settings editor.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#1981714: add settings to control owning library of auto-added LIDs
Previously, when line item copies/details/items where automatically created
because the provider's default copy count is non-zero, the owning library
of those line item copies was set to the workstation library. This patch
adds two new settings to tweak this behavior:
* How to set default owning library for auto-created line item items
Stategy to use to set default owning library to set when line item items
are auto-created because the provider's default copy count has been set.
Valid values are "workstation" to use the workstation library, "blank"
to leave it blank, and "use_setting" to use the "Default owning library
for auto-created line item items" setting. If not set, the workstation
library will be used.
* Default owning library for auto-created line item items
The default owning library to set when line item items are auto-created
because the provider's default copy count has been set. This applies if
the "How to set default owning library for auto-created line item
items" setting is set to "use_setting".
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
* set 024 ind1 correctly (i.e., to '1') when applying UPC as order
identifier
* add flesh_po_items_further option to PO retrieval
This fleshes in any fund debits and debit invoice items associated
with PO direct charges
* add open-ils.acq.po_item.disencumber method
This method disencumbers a PO item by setting its fund debit's amount
to zero. Note that this can be done only for encumbrances; if the
debit is an expenditure, it cannot be changed.
* add flesh_li_details_receiver to LI retrieval
* add two additional fleshing options to LI retrieval
Specifically, flesh_copy_location and flesh_call_number. These take
effect only when flesh_copies is also true and are used to further
flesh values of items attached to line item details.
* remove cancel reason if last LID of LI is received
Otherwise, a sequence where a line item was cancelled but one of
its items was received would have the LI end up in a received
state but with a cancel reason.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Galen Charlton [Thu, 10 Feb 2022 16:00:22 +0000 (11:00 -0500)]
LP#1960526: adjust link color on Angular and AngularJS staff interfaces
Change the default link blue on the Angular and AngularJS interfaces
to #255a88. This achieves two things:
- Improves the color contrast on the AngularJS side against a white
background from AA for normal text to AAA.
- Improves the Angular side so that it meets AAA color contrast for
normal and large text, instead of meeting only AA for large text.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Wed, 14 Jul 2021 14:52:44 +0000 (10:52 -0400)]
LPLP1929741 Optional experimental Acq; seed data
Adds and org setting and a workstation setting to 1) enable display of
experimental Angular ACQ UI's and 2) enable display of links to the
experimental UI's from search results.
Display a new menu entry "Acquisitions (Experimental)" when the org
setting is enabled. This menu contains "Create Purchase Order" only for
now.
Copy seed data from upgrade file to seed data file.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Thu, 24 Jun 2021 15:30:24 +0000 (11:30 -0400)]
LP1929741 Welcome page navigates to staff w/ href
When a route failure occurs, etc. and the user is sent back to the
Welcom to Webby page, make the link to the staff page an href instead of
a routerLink, so Angular is forced to load new route data.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Tue, 22 Jun 2021 15:43:05 +0000 (11:43 -0400)]
LP1929741 Batch of PO fixes
* Avoid clearing the owning library during batch edit copy operations
* Leverage combobox startsWith for distribution formulas
* Disable the order ident selector so it cannot be modified after a PO
is activated
* Add some icons to the PO actions for more eye-grabbiness.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Mon, 14 Jun 2021 21:43:15 +0000 (17:43 -0400)]
LP1929741 ACQ order ident indicate multiples
When multiple order identifer values (e.g. ISBN's) exist on a lineitem,
the number of options is now displayed just to the left of the
identifier selector.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Mon, 14 Jun 2021 21:35:21 +0000 (17:35 -0400)]
LP1929741 Apply default lineitem order identifers
Apply a default order identifier to lineitems instead of leaving the
selector blank. Ensure the value that will display in the selector
matches what's in the database by setting the value on load when needed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Fri, 11 Jun 2021 15:29:47 +0000 (11:29 -0400)]
LP1929741 Bundle of ACQ bug fixes
* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1991444: Cleanup Build Docs Artifacts in GitHub Actions
The Build Docs GitHub action leaves the built docs behind as
artifacts. These artifacts currently use about 58MB apiece. This can
quickly consume all of the available storage spacce (500MB) for
free-tier GitHub accounts.
This commit adds a retention-days setting of 2 so that build docs
artifacts should be removed after two days.
Jason Stephenson [Sun, 18 Sep 2022 13:38:40 +0000 (09:38 -0400)]
LP1990018: Fix libdbi build
Resolve issues with finding libdbi and libdbdpgsql on ARM64 by using better
autoconf hygiene:
* Use PKG_CHECK_MODULES to find and set the dbi library flags.
* Remove the "backup" code to find a manually installed libdbi.
(This has not been needed for some time.)
* Update Makefile.ams to use the dbi LDFLAGS properly.
* Remove -ldbdpgsql from compile commands.
(It is loaded dynamically.)
I tested it on a x86_64 VM with Ubuntu 22.04. Most tests passed. Only the
remot auth and cover uploader tests failed. The latter have not passed for
some time, and I believe the former may have been affected by a recent
change unrelated to this commit.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jeff Davis [Wed, 6 Jul 2022 19:10:41 +0000 (12:10 -0700)]
LP#1980867: optionally remove traditional catalog from staff client menu
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
LP1953381 not-allowed pointer for inactive buttons
Adds a style to change the mouse pointer to the "no" symbol for disabled
buttons.
To test:
1. Apply patch.
2. Go to an item record in the staff catalog.
3. Mouse over the "Set Default View" button (disabled by default on the
Item Table tab).
4. The pointer should change to the "no" symbol.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1909583 Bootstrap Opac: Cannot edit title and description
Fixes the editing of the title and description in the Bootstrap Opac lists.
Adds and Edit List button with a collapsible form.
To Test:
1. Create several lists in the Opac.
2. Notice you are unable to edti the title or description.
3. Apply the patch
4. Use the Edit List button to display an editable form for each individual
list.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP1903767 - Bootstrap Opac: Make other formats and editions more visible.
This patch does the following:
1. Moves "Other Formats and Editions" below # of holds and available items.
2. Changes "Other Options" to "Other Formats and Editions" and makes the
header tage and <h2> tag consistent with other header tags.
3. Resizes <h2> tags.
4. Removes bullets and changes the margins of some of the table/list displays
under the <h2> headers.
5. Fixes the alignment of the button group that contains Place Hold.
For Testing:
1. Find a record that contains other formats and editions. In concerto
record #71 contains other formats and editions.
2. Notice that you have to click the More Details button to view the Other
Formats.
3. Apply the patch.
4. Other Formats and Editions now appear under the Available Copies and
Holds heading. You no longer have to push the More Details button.
Fixing "hold Type" to "Hold Type" in hold details screen
Test plan:
1. Go to the staff interface, right click a hold to see hold details,
observe that "hold Type" is not capitalized
2. Apply the patch
3. Refresh the staff interface hold details screen and observe that
the "Hold Type" is properly capitalized
Garry Collum [Tue, 2 Aug 2022 19:35:39 +0000 (19:35 +0000)]
LP1902272-Bootstrap opac needs to prompt on notification preference update
Adds the prompting of updating holds when default notification preferences
are updated in the Bootstrap opac.
To Test:
1. Place a few holds for a patron.
2. Login to the opac and change some default notification methods.
3. The opac does not prompt to update the holds.
4. Apply the patch.
5. The patron should now be prompted to update holds when default
notification methods are changed.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jane Sandberg [Thu, 11 Feb 2021 01:37:57 +0000 (17:37 -0800)]
LP1907974: Updating call numbers in course module reflected in grid
Also:
* refactors the updateItem method for more idiomatic RxJS usage (e.g.
no nested subscribes)
* corrects some Boolean, String, and Number types to boolean, string,
and number (to use the primitive types instead of objects, as
recommended by the Typescript handbook:
https://www.typescriptlang.org/docs/handbook/basic-types.html#about-number-string-boolean-symbol-and-object)
To test:
1) Go to Local Admin > Course List
2) Double click on a course
3) Go to the materials tab
4) Add an item by barcode, making sure to supply a temporary call
number, and that the call number checkbox is checked.
5) Note that the grid on the right display's the item's old call number,
not its new one.
6) Apply this patch.
7) Repeat step 4. Note that the temporary call number is reflected in
the grid now.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Update the README and server upgrade instructions for Ubuntu 22.04.
Remove or replace deprecated autoconf directives in configure.ac.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Garry Collum [Wed, 3 Aug 2022 18:00:02 +0000 (18:00 +0000)]
lp1983129-Bootstrap Opac: Inconsistent wording in My Account
Removes the word "Current" and "Currently" from the holds and items checked out
menus and pages in My Account, and fixes capitalization in the summary screen.
Also removes 'Current' from the menus and screens for E-items out, and E-items
on hold.
Michele Morgan [Thu, 12 Aug 2021 18:09:41 +0000 (14:09 -0400)]
LP#1939730 - Use original call number owning_lib when reverting items
When removing items with edited call numbers from a course, find or
create the resulting call number using the original call number's
owning_lib rather than the course owner.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
LP#1842297: Implements patron sign-on to the OpenAthens service.
For libraries who are OpenAthens customers, they can configure Evergreen to sign their patrons on to OpenAthens
either immediately when they sign on to Evergreen, or on demand when they select their library as their method
to sign on to OpenAthens-protected resources.
Signed-off-by: oajulianclementson <51331324+oajulianclementson@users.noreply.github.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Galen Charlton [Thu, 26 May 2022 15:11:59 +0000 (11:11 -0400)]
LP#1957179: improve saving of templates in Angular holdings editor
This patch makes the following improvements to the handling
of holding templates in the Angular holdings editor:
- templates are now saved to the cat.copy.templates user setting,
matching the AngularJS holdings editor
- toast is displayed upon saving or deleting a template
- upon saving a completely new template, re-style it in the
combobox so that it no longer has the new-and-freetext
styling
To test
-------
[1] Apply the patch and open the Angular holdings editor.
[2] Verify that once a template is saved or deleted, that
refreshing the Angular holdings editor will show the
updated list of templates.
[3] Verify that toast is displayed upon saving or deleting
a template.
Note that because of a quirk in how user settings are cached by
the web staff client, if you are testing in more than one browser
(but with the same user account), if you save a template in one
browser, you'll need to log out and back in with the second browser
to see the changes.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
projects / Evergreen.git / log