erickson [Wed, 9 Feb 2011 18:22:14 +0000 (18:22 +0000)]
allow item status update if either status-specific perm is allowed or UPDATE_COPY is allowed. fire off related A/T events after the initial transaction has been committed
miker [Tue, 8 Feb 2011 17:56:08 +0000 (17:56 +0000)]
Patch from Robert Soulliere to update settings-tester.pl
Changes include:
- Use Test::More perl module to replace eval/die tests for initial tests (as indicated in FIXME comment)
Note/question: should I add an install of the Test::More perl module in Makefile.install for Evergreen prerequisites?
- Add a statement to print postgresql version.
- Add an elsif during "driver" testing to say OK to SIP driver since this is used in telephony section. -- remove scary ERROR
- Add UUID::Tiny to perl module list of checks.
question: More perl module checks needed?
miker [Tue, 8 Feb 2011 17:22:00 +0000 (17:22 +0000)]
Patch from Thomas Berezansky addressing circ/hold config constraints, and their lack of usefulness.
The config.circ_matrix_matchpoint and config.hold_matrix_matchpoint tables have unique constraints that are intended to ensure that you have at most one entry in the table for each set of input conditions.
These constraints operate over a set of fields that can (in whole or part) be set to null, and thus don't do what they are intended to in most (if not basically all) cases.
[This patch] replaces the unique constraints with unique indexes. Nullable fields are coalesced into empty strings so that they can be matched against, and the index only applies to those rows set as active.
The included upgrade script cleans up the tables by taking each set of non-unique rows the unique index would fail on and setting all but the first (in id order) to active=false. If an administrator determines that the wrong row was left active they can toggle active off on the one that was left and back on for the correct one.
dbs [Tue, 8 Feb 2011 06:20:36 +0000 (06:20 +0000)]
Remove syntax error from O:A:Storage:Publisher:authority and add strict pragma
Came across a line of dead code while debugging a related problem, and
noticed that strict/warnings wasn't in place, so I culled the dead code
and added use strict/use warnings accordingly (now that we no longer
have the syntax error caused by the dead code).
dbs [Tue, 8 Feb 2011 06:12:24 +0000 (06:12 +0000)]
Create authorities that only contain controlled subfields (LP 712496)
Selecting "Create authority" on a field containing uncontrolled subfields
would generate an authority record that contained those uncontrolled
subfields. This would, in turn, prevent the "Validate" button from operating
correctly - if you added a 700 with $a and $c subfields, clicked "Create
authority", and then immediately clicked "Validate", the field would show
up as red.
Now we filter out the uncontrolled subfields before they get sent to
the "Create authority" function, avoiding this validation problem.
dbs [Tue, 8 Feb 2011 05:11:47 +0000 (05:11 +0000)]
Ensure new authority ID subfield is inserted in the correct XUL DOM location
Addresses LP 712499. After creating an authority via the context menu
in the MARC editor, the new ID subfield ($0) would be created right after
the subfield on which the context menu was invoked. It turns out that it
was being placed in the wrong location, and one symptom was that the
Validate button would not validate the controlled field against the newly
created authority.
Now we hunt through the parent DOM nodes until we find the 'sf_box' element
and then we append the ID subfield to that node. We also eliminate some
duplicate code by defining a common function so that the problem can be
fixed in one stroke...
dbs [Tue, 8 Feb 2011 03:49:36 +0000 (03:49 +0000)]
Prevent authority context menu on whitespace content
Continuing the refinement of LP 712538, if the subfield contains
only whitespace, treat it as though it were empty for the purposes
of the context menu.
dbs [Tue, 8 Feb 2011 03:43:08 +0000 (03:43 +0000)]
Prevent authority context menu from being displayed on empty content (LP 712538)
It's confusing to have the authority context menu - particularly the
"Create authority" options - appear for empty content. Check to ensure
that the subfield being clicked on actually has some content before
displaying the authority context menu.
senator [Fri, 4 Feb 2011 01:24:28 +0000 (20:24 -0500)]
started moving some inline styles into css classes
Here's the deal so far: all the inline styles are covered by one class
in semiauto.css, but those were created programatically and reflect no
understanding of the relationship between the purpose of any given
element that's styled and what its style is. These auto-generated
styles also are kind of redundant, since with many of them, instead of
using the style with a long definition, you could use a combination of
smaller styles.
The existing markup uses many slightly different style attributes, so
there's plenty of stuff like "width: 12", "width: 13", "width: 14", etc,
so there's no way to map a lot of this to semantically meaningful names.
some of these classes are just going to end up with names like
"wide-fourteen" that are no better than inline styles.
But others, as we find them manually, can be grouped and renamed into
something meaningful, and sometimes style can be put into prexisting id
and class definitions. Should be a couple more hours work.
semiauto.css reflects progress with the generated classes.
changes to style.css reflect early places where style could be moved
into pre-existing classes.
erickson [Fri, 4 Feb 2011 00:14:26 +0000 (00:14 +0000)]
ported open-ils.actor.user.transaction.[fleshed.]retrieve to CStoreEditor both for cleanup and to take advantage of .authoritative. Use authoritative version in staff client
Bill Erickson [Thu, 3 Feb 2011 21:47:59 +0000 (16:47 -0500)]
Integrate Locale::Maketext for string translations
Added support for configuring supported locales and specifying message
catalogs as gettext .po or .mo files. All locales default to native
template strings when no translation is provided.
Updated oils_web config and added some inline template examples
senator [Thu, 3 Feb 2011 20:34:19 +0000 (15:34 -0500)]
JS stubbed out, mostly. See longer commit msg.
Here's the deal with JS so far.
A few instances of onfocus, onblur, onmouseout, and onmouseover have been
left alone, as they're doing simple cosmetic things.
A lot of instances of onclick remain, and a couple onchange, but these
now either a) just do cosmetic things (hide/unhide) or b) call stubbed
out functions prepared in misc.js
That doesn't mean we won't still totally rip out lots of this JS, but
it leaves us a hint as to what is supposed to happen where. I can
easily see us losing track of that later. So anyway, many of the
stubbed functions will probably be replaced with purely server side
functionality later, but until then, they can serve as a kind of
documentation.
senator [Thu, 3 Feb 2011 16:54:23 +0000 (11:54 -0500)]
all five main parts of their myopac page
now it's on to the serious js scrubbing (dojo parts are already gone). this is
going to take more than simply removing js in many cases, though, since
so much layout is accomplished by means of JS in the kcls skin,
especially in regards to subinterfaces and nested tabbiness
dbwells [Thu, 3 Feb 2011 16:47:49 +0000 (16:47 +0000)]
Two binding fixes for manage items
The first fix is more or less cosmetic. When selecting a target unit, both areas need to refresh in order to not show the selected unit's items in the main list.
The second fix involves handling cases where moving items from one unit to another does not empty the 'donor' unit. In those cases, we need to update the contents of both the new and the old unit.
dbs [Thu, 3 Feb 2011 14:15:47 +0000 (14:15 +0000)]
Authorities: control 610/611, do not control 4xx by default
The 4xx fields in bibliographic records have not been controlled
fields for some time (1988 for CAN/MARC, 1999 for USMARC per)
http://www.loc.gov/marc/bibliographic/bd4xx.html; and
http://www.oclc.org/bibformats/en/4xx/default.shtm also lists
these as obsolete. So, remove them from the default controlled
fields in Evergreen.
Also, add 610/611 to the controlled fields list (per LP #712467).
phasefx [Wed, 2 Feb 2011 19:34:36 +0000 (19:34 +0000)]
circ.claim_return.mark_missing was superceded with circ.claim_return.copy_status. It's still lingering in 1.6.1-2.0-upgrade-db.sql, and in other branches. Thanks to bshum for noticing
dbs [Wed, 2 Feb 2011 03:28:33 +0000 (03:28 +0000)]
Apply autogenerate barcode trigger to serial.unit to enable serial checkin
Serial checkin tried to use the '@@AUTO' macro to autogenerate barcodes,
but unfortunately the required trigger had only been defined on the parent
table asset.copy and not on the child table serial.unit. Here we define the
trigger on serial.unit to resolve that problem.
erickson [Tue, 1 Feb 2011 23:39:00 +0000 (23:39 +0000)]
make sure that inline overdue fines generation completes before we attempt to void overdues fines in checkin, otherwise it's possible to create multiple services (storage and cstore) competing for the same DB row mid-transaction, resulting in cstore timeouts and rollback of checkin. This could happen with backdated or amnesty checkins
senator [Tue, 1 Feb 2011 21:39:06 +0000 (21:39 +0000)]
Acq: Improving on r19351, don't let showCreatePane() be issued repeatedly to
fill the window with redundant dialogs, since a) it looks silly, and b) the
dialogs don't work when there are more than one of them. Thanks again Dan.
senator [Tue, 1 Feb 2011 21:15:22 +0000 (21:15 +0000)]
Acq: make the "new provider" button under Admin -> Server Admin ->
Acquisitions -> Providers not produce a dialog with a ton of mysterious
whitespace. Spotted by Dan Scott.
phasefx [Mon, 31 Jan 2011 18:53:20 +0000 (18:53 +0000)]
In actor.usr_purge_data, default destination user to admin (id=1).
Destination user is where we move things like reports and acq picklists when
purging staff members. However, if we tried to purge a patron that used to be
a staff member, then destination user was being set to null, which won't work
when updating things like requestor on holds. The purge UI checks for the
STAFF_LOGIN permission on the user to be purged for determining whether to
prompt for a destination user or not.
Some alternatives to this change might include:
1) always asking for a destination user (and defaulting to admin or the
logged in staff member), or
2) robustifying the stored procedure and surrounding code to raise an
expected exception whenever this edge case hits, prompting the UI to try
again after asking for a destination user.
dbs [Mon, 31 Jan 2011 03:30:42 +0000 (03:30 +0000)]
Add basic unit tests for Evergreen Perl modules
By "basic", I mean, "Can we use them without provoking a
syntax error?" and the answer is... all but one appear to
be clean, or have a legit reason for not being able to be
used normally. Stay tuned for the culprit...
dbs [Mon, 31 Jan 2011 02:14:37 +0000 (02:14 +0000)]
Make Evergreen Perl modules installable via Module::Build to match OpenSRF
Build.PL gives us an install-time check on dependencies; right now
the required versions are not set, but we can update these easily
to start catching some of the problematic modules that have tripped
sites up in the past.
Build.PL really seems to want a top-level "OpenILS.pm" so add a placeholder
accordingly.
Adjust references to /src/perlmods/ to /src/perlmods/lib/ even though
a number of the affected scripts are probably cruft.
Use autoconf to provide the default paths in O:WWW:Web and O:WWW:Method;
next step is probably to teach autoconf to ask Build.PL to do that for
us to make the OpenILS Perl modules more independent.