Galen Charlton [Wed, 10 May 2023 14:21:35 +0000 (10:21 -0400)]
LP#2019032: restore functionality of two line item actions
The "Add Brief Record" and "Load Bibs and Items" actions in the
Angular line item manager stopped working after the upgrade
to Angular 15. It turns out that the routerLink values associated
with those two actions were always incorrect, but for some
reason Angular 12's router worked around the error. Angular 15
does not, hence this patch.
To test
-------
[1] Navigate to a pending purchase order.
[2] Attempt the "Add Brief Record" and "Load Bibs and Items" items
from the Actions drop-down. Note that the request forms
do not display and the purchase order title becomes
"Purchase Order #NaN (pending)".
[3] Apply the patch and repeat step 2. This time, the two
actions should bring up the correct forms.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Jeff Godin <jgodin@tadl.org>
Dan Briem [Sat, 4 Mar 2023 21:10:44 +0000 (21:10 +0000)]
LP#1901072 Menus Don't Recognize Max Recent Patrons Setting
On the Angular menu, both Retrieve Last Patron and Recent Patrons
links appear under Circulation, regardless of what the "Number of
Retrievable Recent Patrons" setting is set to.
On both the AngularJS and Angular menus, both links appear under
Circulation (Experimental).
On the Angular menu, Circulation->Retrieve Recent Patrons links
to the Angular interface instead of the AngularJS interface.
To test this fix:
1. Set Enable Angular Circulation Menu setting to True
2. Set Number of Retrievable Recent Patrons setting to 0
- Retrieve Last Patron and Recent Patrons links don't appear
3. Set to 1 or unset (default fallback is 1)
- Retrieve Last Patron link appears only
4. Set to greather than 1
- both links appear
- Circulation->Retrieve Recent Patrons loads the AngJS interface
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Susan Morrison <smorrison@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Stephanie Leary [Mon, 8 May 2023 22:37:27 +0000 (22:37 +0000)]
LP2015137 Tab order for admin splash link tables
Replaces row/column logic with CSS columns in the link table component
used in settings screens. This allows the user to tab through the
settings in alphabetical order, rather than the three-across groupings
that previously broke up similarly named settings.
Galen Charlton [Wed, 29 Mar 2023 16:09:32 +0000 (12:09 -0400)]
LP#2013223: quiet browser console noise from some AngularJS grids
This patch quells console error noise from certain AngularJS grids.
To test
-------
[1] Go to the AngularJS Renew Items, Holds Shelf, or patron holds list
pages.
[2] Note that the brower console has a lot of "TypeError: action.handler is undefined"
error messages.
[3] Apply the patch and repeat step 1. This time, the "action.handler"
errors should be gone.
Galen Charlton [Fri, 31 Mar 2023 22:11:36 +0000 (18:11 -0400)]
LP#1920826: ensure that some DB updates missed in 3.6.0 are included
This patch fixes a situation where an Evergreen database that had
been been upgraded to 3.6.0 at some point in its past using the
3.5.1-3.6.0 DB update script may be missing some DB revisions.
To test
-------
[1] Locate a test database that had been upgraded to 3.6.0 at some point
and is missing some or all of DB revisions 1236-1240.
[2] Run the DB update in this patch.
[3] Verify that the DB revisions are in place and that the following
bugs are resolved:
Tiffany Little [Thu, 26 Jan 2023 14:18:01 +0000 (09:18 -0500)]
LP2003946 LI ID in Search jumps to item detail page
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Christine Morgan <cmorgan@noblenet.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jane Sandberg [Fri, 3 Mar 2023 23:55:43 +0000 (15:55 -0800)]
LP1972917: fix circ modifier column in course materials grid
To test:
1. Add a circulation modifier to your system if it doesn't
already have some.
2. In Local Admin > Course Materials > Edit Course > Course
Materials, turn on the circ modifier column in the grid.
3. Associate an item with the course using its barcode.
Make sure you have selected a circulation modifier and
checked the circulation modifier box.
4. Press the "Add Material" button.
5. Note that the circulation modifier column says
"[Object object]"
6. Apply this patch and repeat steps 2-4.
7. Note that the column now has the name of the circulation
modifier.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Beth Willis <willis@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Michele Morgan [Wed, 1 Mar 2023 17:18:09 +0000 (12:18 -0500)]
LP2001728 - Don't display circ_staff for opac and autorenewals
Item Status Circ History List: Displays the placeholder <OPAC Renewal>
or <Auto-renewal> instead of the patron information in the Check Out
Staff field.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Dan Briem [Thu, 16 Mar 2023 18:21:03 +0000 (14:21 -0400)]
LP#2004052 Hold Shelf Actions Menu Includes Irrelevant Actions
Removes Activate, Suspend, Set Top of Queue, Un-Set Top of Queue,
Set Desired Item Quality, Transfer to Marked Title from the
actions menu on the Holds Shelf grid.
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jeff Davis [Thu, 4 May 2023 18:13:42 +0000 (11:13 -0700)]
LP#2018534: treat year as numeric when retrieving item circs by year
The open-ils.pcrud.search.circbyyr API uses EXTRACT to extract the year
from circulation timestamps. In recent versions of Postgres, the return
type for EXTRACT was changed from double precision to numeric (thanks to
Jason Boyer for noticing this!); for obscure reasons, this causes pcrud
to return the year as a string instead of a number. So, let's get the
staff client to force those values to be numbers before doing math with
them.
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Stephanie Leary [Wed, 3 May 2023 17:18:59 +0000 (17:18 +0000)]
LP2018208 Empty alt for result record images, icons
Adds empty alt attributes for jacket images and format icons that are
immediately followed by equivalent text representations, and are
therefore redundant for screen reader users.
Teach batch penalty processing script to accept penalty subsets,
allow alternate context location based on each patron home library,
and allow has/does-not-have penalty command line options to look up
custom system penalties by name.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Tue, 12 Jul 2022 15:10:07 +0000 (11:10 -0400)]
LP1944986 Has / No-Has Penalty filters
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>
Bill Erickson [Mon, 11 Jul 2022 20:42:20 +0000 (16:42 -0400)]
LP1944986 Patron penalty batch updater script
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>
Allow processing of penalty subsets, and the option of patron home
context rather than staff workstation location context.
Adjust Collections API to make use of the custom penalty versions
where applicable.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
This development creates a set of Library Settings that a staff
member with appropriate permissions can use to set a custom value
for a stock penalty according to the following workflow:
-- Create a new penalty in Standing Penalties
-- Set the desired penalty threshold in Group Penalty Thresholds
-- Use the Library Setting to associate your new penalty with a
stock system penalty and organizational unit context.
The custom penalty will be automatically applied in place of the
stock penalty at the specified org units, when the patrons'
account meets the penalty criteria.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Etheridge [Thu, 12 Jan 2023 06:16:29 +0000 (01:16 -0500)]
LP1965446 Option to Disable Title-Level Holds on Bib Records with Parts
This feature adds one global flag and one library setting, respectively:
* circ.holds.api_require_monographic_part_when_present
Holds: Require Monographic Part When Present for hold check.
* circ.holds.ui_require_monographic_part_when_present
Require Monographic Part when Present
Normally the selection of a monographic part during hold placement is optional if there is at least one copy
on the bib without a monographic part. A true value for this setting for any involved owning library for the
bib or for the global flag will require part selection even under this condition. This essentially removes
the All/Any Parts option from the part selection drop-down, for both versions of the public catalog (TPAC and
BOOPAC), and for the Angular staff catalog interface.
At the API level, we consider just the global flag and will throw a TITLE_HOLD_WHEN_MONOGRAPHIC_PART_REQUIRED
event for a title hold request when there are items with monographic parts on the bib. It is possible for
the library settings and the global flag to differ, but the global flag will catch every instance of hold
placement including those by third party callers, SIP, etc.
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxoli.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Galen Charlton [Wed, 3 May 2023 14:50:04 +0000 (10:50 -0400)]
LP#1901932: (follow-up) update dataset for upcoming 3.11-beta release
As it happens, very little actually changed, though a significant
chunk of make_concerto_from_evergreen_db.pl's output was not checked
it because it consisted purely of differences in timestamp columns
due to time zone differences.
Galen Charlton [Wed, 3 May 2023 14:35:28 +0000 (10:35 -0400)]
LP#1901932: (follow-up) update help in make_release
This patch clarifies the usage of make_release during
updates of Enhanced Concerto and makes it clear that
such updates are considered experimental for now.
. Adding better ECD output for master branch
. Much improved enhanced generator script
. Introducing make_release changes to incorporate the upgrade of the ECD.
Introducing a new concerto dataset. Loadable via eg_db_config.
Including the perl script and full documentation on this dataset
How to re-create it, etc.
This commit adds a new VIEW_HOLD_PULL_LIST permission. In order to view
a library's holds pull list, you need to have the new permission at that
library.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Gina Monti <gmonti@biblio.org>
Squashed commits:
* middle
* billing total in smartpay last_chance equivalent
* fix xact propagation
* remove some logging in middle layer
* increase timeout for cached object and hope it exceeds smartpay session expiry
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Jason Etheridge [Wed, 12 Apr 2023 12:09:42 +0000 (08:09 -0400)]
lp1857911 follow-up tweaks
* AdminPage component -> Return button if page was invoked with gridFilters
* AdminPage component -> options to hide delete and edit actions
* Stat cat admin pages -> disable edit and delete for stat cat entries to match behavior of legacy interfaces, until we discuss
something better
* AdminPage component -> stock delete confirmation for AdminPage component
* Stat cat admin pages -> custom delete confirmation prompts for stat cats
* AdminPage component -> sticky org selector options for org fields in fmEditor
* AdminPage component -> option for new record org fields to follow context org
* Stat cat admin pages -> enable org field follows context org featuer
* orgFamilySelect -> persistKey support
* Stat cat admin pages -> use a persistKey for main org selector
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jason Etheridge [Wed, 14 Dec 2022 05:57:25 +0000 (00:57 -0500)]
lp1857911 angularized stat cat admin interfaces
* for stat cats and stat cat entries in the IDL, make sure we have pcrud controller enabled and pcrud permissions set. Also set config_field for "entries" so that the AdminPage component can link them out to their own admin pages
* item and patron stat cat admin pages
* lp1857911 release notes
Leverages the BasicAdminPage component, with some tweaks.
Changes to the BasicAdminPage and AdminPage components all default to off, so should not affect existing interfaces:
* add an option to hide the Clear Filters action from subordinate admin pages (when you follow config fields)
* add an option to propagate recordLabel to the fmEditor component, and also use said label within the admin page
* add an option to propagate orgDefaultAllowed to the fmEditor component
For the stat cat and entry admin pages specifically, we leverage these to:
* hide Clear Filters so that we don't let the user get into a situation where they try to create a new stat cat entry but have a blank and unsettable stat cat field (because we mark that field as read-only in the fmEditor)
* default the Owner field for new stat cats and entries to the workstation library
* use Item and Patron instead of Asset and Actor in various labels (at least until we're ready to make that change wholesale in the IDL)
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Galen Charlton [Mon, 1 May 2023 15:51:42 +0000 (11:51 -0400)]
LP#1979071: (follow-up) fix various DB schema and update issues
* Incorporate the delayed reification option for search dictionary
updates derived from authority records (see bug 1997485)
* Fixed an issue that prevented propagation of changes to main
headings
* Fixed an issue introduced in bug 1977485 that prevented
authority headings from being deleted
* Remove now-disused authority.indexing_ingest_or_delete()
* Remove an older version of authority.propagate_changes()
from the base schema; this would be an issue in new databases
installed from scratch.
This feature allows for the separation of bib and authority record
updates and the search (and other) indexing that occurs when a record is
modified in some way.
The Queued Ingest mechanism consists of several parts working together:
* A set of configuration flags that control when ingest should be
performed immediately, and when it can be deferred until after the
transaction commits and control is returned to the user.
* Refactoring of the in-database ingest triggers to separate deciding
what should happen to a record given a data modification event, and
when/how that process should take place.
* A set of queuing tables used to track which records are to be
processed and in what ways, when that processing was requested, and
the ability to group processing requests into named queues that can
report who made a processing request and for what purpose.
* A Queued Ingest Coordinator that runs in the background monitoring
the queuing tables for activity and processes records as they are
enqueued. This can run on any server that can connect to the
database and has the OpenSRF Perl modules installed.
* A command line tool to be usedby administrators to enqueue records
for Queued Ingest processing, to create named queues, and to process
enqueued records either in one queue or all outstanding enqueued
entries. This tool can also report on the status of requested Queued
Ingest processing, whether pending, ongoing, or complete, either for
all time or since a particular date and time.
The queuing tables added here are not yet included in the IDL for
reporting or Staff interface construction. They can be added as the
need arises.
To test Queued Ingest:
* Upgrade the database schema using the appropriate upgrade script.
* Install OpenILS/src/support-scripts/ingest_ctl in the usual OpenSRF
bin directory.
* Start the Queued Ingest Coordinator by using the --coordinator
parameter to ingest_ctl along with the relevant database parameters.
Use the --help parameter for more details.
* Enable the Global Flag called 'ingest.queued.all'
* Edit, import, and delete some bib and authority records, and use the
--stats parameter to ingest_ctl to see entries being processed.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Stephanie Leary [Mon, 12 Dec 2022 20:27:26 +0000 (14:27 -0600)]
LP1615707 ARIA landmarks for staff interface
Adds the following ARIA landmarks and roles to the Angular staff
interface:
* <main> and role="main" for the content container
* <nav> and role="navigation" for the navbar
* role="form" for the catalog search form (which lacks a <form> tag)
* role="search" for the search tab panel inside the form
* type="search" and role="searchbox" for the search term input field
* a custom region for the bib record summary box
* <aside> and role="complementary" for the facet sidebar
To construct the ARIA label for the bib record summary, I've added an ID
to the header row of the bib summary component so the screen reader can
use the localized text.
Since the staff interface doesn't really have a header section other
than the navigation, and there is no footer, I've left out these
landmarks.
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
This patch fixes a regression introduced by the authority heading
update patches in this branch and ensures that updates to
authority records participate in the option to delay
suggestion dictionary reification.
Co-authored-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Scott Angel [Thu, 23 Mar 2023 21:27:05 +0000 (16:27 -0500)]
LP1977554 - Add Password visibility toggle on login screens
Changed the <span> tags to <button> tags so it can be reached via
keyboard navigation.
Added a few more attributes to the password input tag.
autocapitalize="none"
spellcheck="false"
aria-description so screen readers can describe to the user what
the current state is.
Added aria-checked to the button for screen readers
Added a new css file for the login.component with a little styling.
Scott [Wed, 1 Mar 2023 17:12:29 +0000 (11:12 -0600)]
LP1977554 - Add Password visibility toggle on login screens
Added an icon to each login input of a closed eye when input type is set to password.
If you click the icon it switches to an open eye and the input type is set to text.
It's a pretty standard way to allow people to view their password before submitting it.
Scott Angel [Tue, 24 Jan 2023 17:26:17 +0000 (11:26 -0600)]
LP1977554 - Add Password visibility toggle on login screens
Added an icon to each login input of a closed eye when input type is set to password.
If you click the icon it switches to an open eye and the input type is set to text.
It's a pretty standard way to allow people to view their password before submitting it.
LP#1997485: (follow-up) fixes to the authority suggestions updates
* Fix a long-standing issue where a stored procedure used in
search suggestion dictionary generation was not included in
baseline.
* Fix an error in direct reingest query.
LP#1997485: (follow-up) fix propagation of settings
Ensures if the search suggestions library settings have not been
set, that the attempt to copy them over to the search classes
will not display error messages.
Mike Rylander [Wed, 26 Apr 2023 17:53:45 +0000 (13:53 -0400)]
LP#1997485: Include authority headings in symspell dict
This patch adjusts the generation of search suggestions
based on authority headings by:
* Including all indexed authority headings (1XX, 4XX, and 5XX) from
authority records for author, title, and subject headings in the
search suggestion dictionary.
* As a consequence, suggestions can be based entirely on headings
found in authority 4XX and 5XX fields without those headings
also needing to be directly in at least one bibliographic record.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Expanding on the previous single-class, single-term search suggestion
development, this feature provides suggestions for single-class searches
with multiple terms.
* The Library Settings that were previously used to control the global
behavior of search suggestions have been moved to search class
configuration fields. This was done because the data in each search
class benefits from different setting values.
* If a patron's search brings back a suggestion that matches an authority
variant heading, the system will provide the main heading as a suggestion
as well, along with spelling-corrected suggestions.
* Quoated phrases in user input require strict term order and adjacency
for the phrase portion of the suggestion generated for the phrase(s),
whereas unquoted input (or the portion that is not quoted) does not.
MARC Search/Facet Class (config.metabib_class) field additions:
* variant_authority_suggestion Whether this class should attempt variant authority suggestions based on search-class/browse-axis mapping
* symspell_transfer_case Whether suggestions should retain user-supplied letter case
* symspell_skip_correct Only supply suggestions to misspelled words
* symspell_suggestion_verbosity Setting that controls the amount of effort, and therefore time, spent on suggestion generation
* max_phrase_edit_distance Maximum average per-word edit distance when evaluating suggestions
* suggestion_word_option_count Maximum alternate suggestions per word
* max_suggestions Maximum suggstions to present
* low_result_threshold Maximum hit count beyond which suggestions are not provided
* min_suggestion_use_threshold Minimum number of times a suggestion must exist in the corpus
* pg_trgm_weight Weight of the trigram similarity metric; 0 avoids calculation costs
* soundex_weight Weight of the soundex similarity metric; 0 avoids calculation costs
* keyboard_distance_weight Weight of the keyboard distance similarity metric; 0 avoids calculation costs
Jane Sandberg [Tue, 25 Apr 2023 13:23:30 +0000 (06:23 -0700)]
LP2000482: Get tests passing
* Update karma config
* Update Patron Barcode Validator directive due to a breaking change in rxjs single()
* Update test assertion to match new ar-JO localization
Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 30 Mar 2023 18:11:26 +0000 (14:11 -0400)]
LP#1791791: remove a regression regression on bug 1923225
This was introduced on the Bootstrap side by the patch for
bug 1955403.
To test:
[0] This applies to the Bootstrap OPAC skin.
[1] Perform a search on ISBN.
[2] Note that on the record page, the ISBN (under more details)
is not properly highlighted.
[3] Apply the patch and repeat step 1. This time, the ISBN
should be highlighted.
Garry Collum [Sun, 19 Dec 2021 01:31:22 +0000 (20:31 -0500)]
LP1791791: Google book previews not displaying from a bib linked from a search.
The javascript that queries Google Books Preview looks for ISBN(s) wrapped in
a rdetail_value class. There was a line of code in which the isbn variable
was not enclosed in this class. This patch just wraps that stray variable
into a <span> with the class.
To test:
0. Use the TPAC skin - this bug does not affect the Bootstrap skin
1. Perform a keyword search for an bib that should have a google book's link.
As of March 2023, ISBN 9780786496570 has previews enabled.
2. Go to the bib display and notice that there is no link.
3. Remove the ';query=something' text from the url and notice that the
google book information displays.
4. Apply the patch.
5. Perform the same search. The google book information should now display.
LP#1863387: multi-select now allows filtering shelving locations by owner
The Angular multi-select component now has a special case for
shelving locations: when the IDL class of "acpl" is selected,
rather than just displaying a combobox, the item-location-select
component followed by an org selector is displayed and checkbox.
The org selector defaults to workstation OU and is used to restrict
the list of shelving locations displayed in the shelving location
combobox to the context org unit and its ancestors. If the checkbox
is also selected, descendants of the context OU are included as well.
The effect of this is to allow large consortial to more efficiently
select the shelving locations to be used by a carousel.
To test
-------
[1] Apply the patch.
[2] Create or edit carousel definitions. Verify that the widget
for the carousel's shelving locations now displays both a
combobox for the location selector as well as one for the
location owning library. Further verify that when the OU
selector for the owning library is changed, that the list
of available shelving locations reflects the locations available
at the ancestors of the filter OU. Also verify that the
"Include descendants?" checkbox updates the list of available
locations as well.
Stephanie Leary [Mon, 9 Jan 2023 19:46:53 +0000 (13:46 -0600)]
LP1970946 Adjust color contrast in result highlights
Lowers the contrast on search result match highlights in the staff
catalog, and changes the highlight tag from <b> (PostgreSQL's default),
to <mark> (new in HTML5).
As an additional consequence, the color contrast for highlighted
search terms in the Bootstrap OPAC (using default styles) improves
from 4.38 to 17.12.
projects / Evergreen.git / log