10 years agoMake Evergreen link to the OpenSRF JavaScript files, rather than copy them.
dbs [Thu, 4 Feb 2010 05:00:54 +0000 (05:00 +0000)]
Make Evergreen link to the OpenSRF JavaScript files, rather than copy them.

This means that if you upgrade OpenSRF, you will automatically get the
upgraded OpenSRF JavaScript in your Evergreen instance without having to
manually copy the files into the multiple places they live. Your Dojo
layer will still need to be recreated, however.

Also, use the autoconf AC_PROG_LN_S and AC_PROG_MKDIR_P macros to provide
better cross-platform support for these commands.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15446 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoenabled pagination for circ mod list
erickson [Wed, 3 Feb 2010 23:11:09 +0000 (23:11 +0000)]
enabled pagination for circ mod list

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15443 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago1. Back off the function acq.attribute_debits, along with three
scottmk [Wed, 3 Feb 2010 18:34:31 +0000 (18:34 +0000)]
1. Back off the function acq.attribute_debits, along with three
associated type definitions, for attributing debits to funding
source credits.  This function used some features not supported
by PostgreSQL 8.2.

2. Add some functions for rolling over funds at the end of the year:


Note that the diffs are misleadingly confusing because of a
bunch of spurious matches.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0148.schema.acq.rollover-fund.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15442 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Bill Ott (after problem identification by Dan Wells) to address styling...
miker [Wed, 3 Feb 2010 15:26:10 +0000 (15:26 +0000)]
Patch from Bill Ott (after problem identification by Dan Wells) to address styling of shadowed records in the staff client

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15439 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix survey JS for the new PermaCrud CUD semantics in the oncomplete handler
miker [Tue, 2 Feb 2010 21:56:21 +0000 (21:56 +0000)]
fix survey JS for the new PermaCrud CUD semantics in the oncomplete handler

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15437 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoupdated oncomplete handlers for new PermaCrud CUD response style
erickson [Tue, 2 Feb 2010 21:38:19 +0000 (21:38 +0000)]
updated oncomplete handlers for new PermaCrud CUD response style

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15436 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agopermacrud CUD actions support an oncomplete handler, but the request object passed...
erickson [Tue, 2 Feb 2010 21:25:44 +0000 (21:25 +0000)]
permacrud CUD actions support an oncomplete handler, but the request object passed as the argument already had it's responses pulled from the wire.  pass the return_list as a second param to CUD onhandler functions.  updated auto widgets to match

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15435 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd a function acq.transfer_fund to transfer money from one fund
scottmk [Tue, 2 Feb 2010 18:44:24 +0000 (18:44 +0000)]
Add a function acq.transfer_fund to transfer money from one fund
to another (or to none).  The result is entries in acq.fund_allocation
and acq.fund_transfer.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0147.schema.acq.transfer-fund.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15434 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd the acq.fund_allocation_percent table.
scottmk [Tue, 2 Feb 2010 15:59:11 +0000 (15:59 +0000)]
Add the acq.fund_allocation_percent table.

I had installed this table and the associated triggers via an
upgrade script, but neglected to add them to the baseline
schema script.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15431 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoretrieve_purchase_order now handles multiple PO requests
sboyette [Tue, 2 Feb 2010 15:08:04 +0000 (15:08 +0000)]
retrieve_purchase_order now handles multiple PO requests

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15430 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd active flag to acq.fund table. If a fund is not active,
scottmk [Tue, 2 Feb 2010 14:56:16 +0000 (14:56 +0000)]
Add active flag to acq.fund table.  If a fund is not active,
then you shouldn't be able to spend money from it.

See KCLS ticket 4201.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0146.schema.acq.fund-active.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15429 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoTypo spotted by Bill Ott: infomation -> information
miker [Tue, 2 Feb 2010 01:31:17 +0000 (01:31 +0000)]
Typo spotted by Bill Ott: infomation -> information

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15426 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadding a note for future (Jason?) work -- use the time from the original due date...
miker [Tue, 2 Feb 2010 01:22:49 +0000 (01:22 +0000)]
adding a note for future (Jason?) work -- use the time from the original due date if the circ interval is day-granular

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15425 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoInclude support for public notes in the formatted display
djfiander [Tue, 2 Feb 2010 00:49:09 +0000 (00:49 +0000)]
Include support for public notes in the formatted display

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15424 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFix the leader to ensure that holdings can be compressed.
djfiander [Tue, 2 Feb 2010 00:35:05 +0000 (00:35 +0000)]
Fix the leader to ensure that holdings can be compressed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15423 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoforward porting r15420: add overlooked MERGE_USERS permission
miker [Mon, 1 Feb 2010 21:25:33 +0000 (21:25 +0000)]
forward porting r15420: add overlooked MERGE_USERS permission

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15422 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofixing namespace array handling in PG 8.3 transitional XML wrapper functions
miker [Mon, 1 Feb 2010 20:59:14 +0000 (20:59 +0000)]
fixing namespace array handling in PG 8.3 transitional XML wrapper functions

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15419 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Doug Kyle to address transit-related deficiency in the reshelving-complete...
miker [Mon, 1 Feb 2010 17:24:21 +0000 (17:24 +0000)]
Patch from Doug Kyle to address transit-related deficiency in the reshelving-complete query.

Previously, items that transited for reshelving at their circulating library would be flipped from Reshelving to Available almost immediately in most cases.  Doug taught the "find copies to flip to Available" query about transit receive times, allowing them to stay in Reshelving status for as long as copies returned directly to the circulating library.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15416 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoForward porting r15413: Patch from Ben Ostrowsky updating the list of supported linux...
miker [Mon, 1 Feb 2010 15:29:50 +0000 (15:29 +0000)]
Forward porting r15413: Patch from Ben Ostrowsky updating the list of supported linux distributions in the README

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15415 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorepaired hold queue position logic to account for holds that have no potential copies...
erickson [Mon, 1 Feb 2010 15:10:57 +0000 (15:10 +0000)]
repaired hold queue position logic to account for holds that have no potential copies assigned

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15412 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAvoid i18n breakage due to trailing ampersand in translation
dbs [Mon, 1 Feb 2010 06:22:19 +0000 (06:22 +0000)]
Avoid i18n breakage due to trailing ampersand in translation

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15411 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoForward-port r15406 from rel_1_6: Fix occurrences parsing in i18n build
dbs [Mon, 1 Feb 2010 06:00:06 +0000 (06:00 +0000)]
Forward-port r15406 from rel_1_6: Fix occurrences parsing in i18n build

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15408 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCommit updates to translations from Launchpad
dbs [Mon, 1 Feb 2010 04:37:11 +0000 (04:37 +0000)]
Commit updates to translations from Launchpad

Welcome to Brazilian Portugese, British English, and Spanish!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15403 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAlso remove fm_IDL from the Makefile; fm_IDL.dtd is what we want
dbs [Mon, 1 Feb 2010 04:32:18 +0000 (04:32 +0000)]
Also remove fm_IDL from the Makefile; fm_IDL.dtd is what we want

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15402 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoDelete this vestigial directory left from the file reorganization
dbs [Mon, 1 Feb 2010 04:29:45 +0000 (04:29 +0000)]
Delete this vestigial directory left from the file reorganization

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15401 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoC-style comment was terminated prematurely by XPath expression in old biblio.flatten_...
dbs [Mon, 1 Feb 2010 01:49:51 +0000 (01:49 +0000)]
C-style comment was terminated prematurely by XPath expression in old biblio.flatten_marc()

SQL-style comments will avoid that problem and let us keep the old function around
for awhile for easy comparison with the new version.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15400 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothis papers over the transitional differences in XML and XSLT support in postgres...
miker [Fri, 29 Jan 2010 20:36:26 +0000 (20:36 +0000)]
this papers over the transitional differences in XML and XSLT support in postgres from version 8.2 through 8.4.  For 8.2, we depend completely on contrib/xml2; for 8.3, we only use contrib/xml2 for the xslt_process function; and finally, for 8.4 we remove contrib/xml2 as a requirement altogether, as it is mostly broken in 8.4

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15399 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd machinery for attributing debits to funding source credits,
scottmk [Fri, 29 Jan 2010 19:46:40 +0000 (19:46 +0000)]
Add machinery for attributing debits to funding source credits,
and thereby to funding sources.

1. New table, acq.debit_attribution.

2. Create three new types, to be used internally by:

3. New function acq.attribute_debits().

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0143.schema.debit_attribution.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15398 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodon't assume a null org unit value should default to the users workstation org unit...
erickson [Thu, 28 Jan 2010 15:43:31 +0000 (15:43 +0000)]
don't assume a null org unit value should default to the users workstation org unit.  that's misleading.  created a new flag to force this assumption.  when not set, the value remains null

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15397 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agowhen getDisplayString() is called without ever having built a true widget, the code...
erickson [Thu, 28 Jan 2010 15:22:13 +0000 (15:22 +0000)]
when getDisplayString() is called without ever having built a true widget, the code needs to be prepared to deal with raw values.  in this case, 't' and 'f' are valid values for bool fields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15396 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodo not promote a number widget's value to '0' when the value is null/isNaN. that...
erickson [Thu, 28 Jan 2010 15:13:28 +0000 (15:13 +0000)]
do not promote a number widget's value to '0' when the value is null/isNaN.  that's equivalent to assuming the value is 37.  if the value needs to be zero, make it so, otherwise assume non-numeric values should translate to null.  will backport after checking for code that functions based on this assumption

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15395 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoOops: need to coalesce before summing, not after.
scottmk [Thu, 28 Jan 2010 14:06:23 +0000 (14:06 +0000)]
Oops: need to coalesce before summing, not after.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0142.schema.acq.fund_debit_total_view.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15394 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRedefine the view acq.fund_debit_total:
scottmk [Wed, 27 Jan 2010 21:31:12 +0000 (21:31 +0000)]
Redefine the view acq.fund_debit_total:

1. Correct the mistaken use of acq.fund_debit.id for fund,
instead of acq.fund_debit.fund.

2. Join to acq.fund so that we get a zero total for a fund
with no debits in acq.fund_debit.

Four other views are affected indirectly because they are defined
in terms of acq.fund_debit_total:


M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0141.schema.acq.fund_debit_total_view.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15393 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd history tables, in the acq schema, for acq.purchase_order
scottmk [Tue, 26 Jan 2010 21:40:32 +0000 (21:40 +0000)]
Add history tables, in the acq schema, for acq.purchase_order
and acq.lineitem.

See KCLS tickets 4304 and 2172.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0140.schema.acq-audit-funcs.sql
A    Open-ILS/src/sql/Pg/201.acq.audit-functions.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15390 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoDedup recs from open-ils.search.biblio.isbn_list. Consistent whitespace with the...
phasefx [Tue, 26 Jan 2010 16:35:37 +0000 (16:35 +0000)]
Dedup recs from open-ils.search.biblio.isbn_list.  Consistent whitespace with the rest of Biblio.pm

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15387 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoopen-ils.search.biblio.isbn_list [ isbn1, isbn2, ... ]. This is making multiple...
phasefx [Mon, 25 Jan 2010 21:08:05 +0000 (21:08 +0000)]
open-ils.search.biblio.isbn_list [ isbn1, isbn2, ... ].  This is making multiple calls to storage; we may want to implement it with one SQL query.  May also want to rename the method from .isbn_list to .isbn.batch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15384 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix regression killing transit list interface
phasefx [Mon, 25 Jan 2010 19:31:26 +0000 (19:31 +0000)]
fix regression killing transit list interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15383 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger to address a number of small issues, including better repo...
erickson [Mon, 25 Jan 2010 18:00:02 +0000 (18:00 +0000)]
Patch from Joe Atzberger to address a number of small issues, including better repo update handling and flexibility enhancements for better staff client bundles

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15381 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger to allow db update script to run from the ILS base directory
erickson [Mon, 25 Jan 2010 17:48:40 +0000 (17:48 +0000)]
Patch from Joe Atzberger to allow db update script to run from the ILS base directory

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15380 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoprovide a --max-sleep=<seconds> option for use in --process-hooks mode to wait on...
miker [Mon, 25 Jan 2010 17:38:38 +0000 (17:38 +0000)]
provide a --max-sleep=<seconds> option for use in --process-hooks mode to wait on the lock file to go away, and default to 1 hour (3600)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15378 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoI noticed in xulrunner 1.9.2rc1 that menu labels in menubar widgets were being render...
phasefx [Mon, 25 Jan 2010 17:22:54 +0000 (17:22 +0000)]
I noticed in xulrunner 1.9.2rc1 that menu labels in menubar widgets were being rendered as if they were disabled.  This coming from a theme change in Firefox 3.5 that is looking for an @active in window for styling menus.  I don't know if this is the correct way to
"activate" our windows, but seems to work.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15377 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRough cut at providing the staff client as a Firefox extension.
phasefx [Sat, 23 Jan 2010 15:25:29 +0000 (15:25 +0000)]
Rough cut at providing the staff client as a Firefox extension.

If you do:    make STAFF_CLIENT_BUILD_ID=trunk extension

Then there will be a   build/evergreen.xpi

TODO: Work out how to handle automatic upgrades, etc.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15374 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd the ability to renew via SIP 1 method used by 3M self-checks
dbs [Sat, 23 Jan 2010 00:44:06 +0000 (00:44 +0000)]
Add the ability to renew via SIP 1 method used by 3M self-checks

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15371 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFix up minor (but fatal) typo for the birthday boy :)
dbs [Fri, 22 Jan 2010 22:50:34 +0000 (22:50 +0000)]
Fix up minor (but fatal) typo for the birthday boy :)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15370 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoShould address https://bugs.launchpad.net/bugs/506827 by looking for the position...
miker [Fri, 22 Jan 2010 21:18:10 +0000 (21:18 +0000)]
Should address https://bugs.launchpad.net/bugs/506827 by looking for the position of the first : after a known key

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15369 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoforward-porting r15367: correct billing timestamp and count calculation issues introd...
miker [Fri, 22 Jan 2010 20:28:28 +0000 (20:28 +0000)]
forward-porting r15367: correct billing timestamp and count calculation issues introduced by "push day-granular circs to end of calendar day" trigger

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15368 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMake developer-oriented preferences for the staff client optional, since some of...
phasefx [Fri, 22 Jan 2010 15:40:55 +0000 (15:40 +0000)]
Make developer-oriented preferences for the staff client optional, since some of them can impact performance.

I couldn't figure out how to get something like

make DEBUG=1 build

to work, so I went with

make devbuild

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15365 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger, with modification to max log size, to add a sample logrotat...
erickson [Fri, 22 Jan 2010 14:30:00 +0000 (14:30 +0000)]
Patch from Joe Atzberger, with modification to max log size, to add a sample logrotate config for /openils/var/log

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15364 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger to verify custom filter file opened successfully
erickson [Thu, 21 Jan 2010 18:06:26 +0000 (18:06 +0000)]
Patch from Joe Atzberger to verify custom filter file opened successfully

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15359 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger that does several things:
erickson [Thu, 21 Jan 2010 17:58:44 +0000 (17:58 +0000)]
Patch from Joe Atzberger that does several things:

1. Iniatial API calls for managing EDI documents at the server.  EDI file fetching script to come soon.
2. Creates OpenILS::Utils::Cronscript and Lockfile modules to share and abstract the common setup tasks for Evergreen cron jobs
3. Creates a OpenILS::Utils::RemoteAccount module for managing access to remote services via ftp/scp.  This is mostly taken from the SendFile reactor
4. Updates sendfile to use remoteaccount

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15358 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoupgrade script to accompany r15353
miker [Thu, 21 Jan 2010 16:43:26 +0000 (16:43 +0000)]
upgrade script to accompany r15353

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15354 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Dan Wells to address a thinko in the use of the queue ownership field...
miker [Thu, 21 Jan 2010 16:43:04 +0000 (16:43 +0000)]
Patch from Dan Wells to address a thinko in the use of the queue ownership field for a Vandelay queue:

I have been doing a lot of experimenting with Vandelay the last few weeks and have traced many of my failures to one distinct bug.  I finally noticed yesterday why Item Import worked for the 'admin' user but for nobody else.  It turns out there is a bug in one of the database functions where it treats the queue 'owner' column as an org_unit ID when in fact it is a usr id.  Of course since 'admin' is ID 1 out of the box and there is an org_unit 1 as well, this bug is transparent to admin and easy to miss.

Well, I started by making a few changes to the function to address this, but soon realized that what we really wanted to do was base the import on the Import Def chosen by the user when the records are loaded, and it would be ideal if the Import Def was somehow associated with the queue at the time of import.  I started poking around in the schema, and lo and behold, the vandelay.bib_queue table already had an 'item_attr_def' linking column for this very purpose which was going unused!

So, the attached patch finally puts this column to use by doing the following:

1) Edits the create_bib_queue() sub in Vandelay.pm to accept the item import attribute definition ID as an argument and save it appropriately.

2) Edits the vandelay.js interface file to accept and send the import definition ID to create_bib_queue() when creating a queue.

3) Edits fm_IDL.xml to add the 'item_attr_def' field (and fix a small labeling error).

4) Edits 012.schema.vandelay.sql to replace the buggy function that started all this with a now simpler, working version.  The change is actually smaller than it looks due removing one nested loop and the resulting indentation change.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
  have the right to submit it under the open source license
  indicated in the file; or

(b) The contribution is based upon previous work that, to the best
  of my knowledge, is covered under an appropriate open source
  license and I have the right under that license to submit that
  work with modifications, whether created in whole or in part
  by me, under the same open source license (unless I am
  permitted to submit under a different license), as indicated
  in the file; or

(c) The contribution was provided directly to me by some other
  person who certified (a), (b) or (c) and I have not modified

(d) I understand and agree that this project and the contribution
  are public and that a record of the contribution (including all
  personal information I submit with it, including my sign-off) is
  maintained indefinitely and may be redistributed consistent with
  this project or the open source license(s) involved.

Signed-off-by: Daniel B. Wells

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15353 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd the schema upgrade corresponding to r15351 in-db ingest encoding fixes
dbs [Thu, 21 Jan 2010 02:18:40 +0000 (02:18 +0000)]
Add the schema upgrade corresponding to r15351 in-db ingest encoding fixes

Ensure MARC::File::XML treats the content as UTF-8; then follow
recommended practice of explicitly decoding the UTF-8 string to a
bytes string before operating on it, then encoding it back to UTF8
when it's returned.

'Québec' now gets naco-normalized to 'quebec' as one would expect. YAY!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15352 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCorrect Unicode handling for in-db ingest
dbs [Wed, 20 Jan 2010 23:15:10 +0000 (23:15 +0000)]
Correct Unicode handling for in-db ingest

Ensure MARC::File::XML treats the content as UTF-8; then follow
recommended practice of explicitly decoding the UTF-8 string to a
bytes string before operating on it, then encoding it back to UTF8
when it's returned.

'Québec' now gets naco-normalized to 'quebec' as one would expect. YAY!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15351 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoprotect standard numbers from NACO normalization; make sure normalized text is proper...
miker [Wed, 20 Jan 2010 21:40:05 +0000 (21:40 +0000)]
protect standard numbers from NACO normalization; make sure normalized text is properly utf8-ized

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15350 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agotypo/thinko -- no s modifier for regex in PG
miker [Wed, 20 Jan 2010 19:05:59 +0000 (19:05 +0000)]
typo/thinko -- no s modifier for regex in PG

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15349 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomake maximized versus non-maximized state of main window sticky, as well as the windo...
phasefx [Wed, 20 Jan 2010 18:02:50 +0000 (18:02 +0000)]
make maximized versus non-maximized state of main window sticky, as well as the window dimensions in non-maximized mode

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15347 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoupdate circ xact_finish value after all billing for the transactions have been assess...
erickson [Wed, 20 Jan 2010 15:27:33 +0000 (15:27 +0000)]
update circ xact_finish value after all billing for the transactions have been assessed.  In particular, after lost item handling.  Thanks to Dan Wells for identifying the bug

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15344 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoStart making autoconf more tolerant of other distributions (looking at you, Fedora)
dbs [Tue, 19 Jan 2010 20:38:17 +0000 (20:38 +0000)]
Start making autoconf more tolerant of other distributions (looking at you, Fedora)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15342 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSubstitute configure variables appropriately in fast-extract
dbs [Tue, 19 Jan 2010 19:34:46 +0000 (19:34 +0000)]
Substitute configure variables appropriately in fast-extract

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15341 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomove the removal of an optional trigger outside the transaction so it won't fail...
erickson [Tue, 19 Jan 2010 17:02:13 +0000 (17:02 +0000)]
move the removal of an optional trigger outside the transaction so it won't fail and roll back the transaction when the trigger is not present

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15340 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomissing semicolon
phasefx [Tue, 19 Jan 2010 16:30:08 +0000 (16:30 +0000)]
missing semicolon

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15339 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoResolve a conflict from the in-db ingest merge
dbs [Tue, 19 Jan 2010 03:47:36 +0000 (03:47 +0000)]
Resolve a conflict from the in-db ingest merge

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15338 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoGive sites the ability to easily display due dates and times in the OPAC under "copy...
dbs [Tue, 19 Jan 2010 03:14:06 +0000 (03:14 +0000)]
Give sites the ability to easily display due dates and times in the OPAC under "copy details"

We add two new variables to copy_details.js:
  * showDueDate - this needs to be set to a non-false value to display the
    due date in the OPAC
  * showDueTime - this needs to be set to a non-false value to display the
    due time in the OPAC, along with the due date. If showDueDate is false,
    then the value of this variable is ignored.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15336 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAddress long-standing typo: clense_ISO8601, matching change to OpenSRF-trunk.
dbs [Tue, 19 Jan 2010 02:07:45 +0000 (02:07 +0000)]
Address long-standing typo: clense_ISO8601, matching change to OpenSRF-trunk.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15335 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothrowing the switch to go to in-db ingest ... expect bugs, but that is why we have...
miker [Fri, 15 Jan 2010 21:31:33 +0000 (21:31 +0000)]
throwing the switch to go to in-db ingest ... expect bugs, but that is why we have trunk, eh?

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15333 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothrowing the switch to go to in-db ingest ... expect bugs, but that is why we have...
miker [Fri, 15 Jan 2010 21:30:59 +0000 (21:30 +0000)]
throwing the switch to go to in-db ingest ... expect bugs, but that is why we have trunk, eh?

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15332 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Lebbeous Fogle-Weekley to add access keys to the ACQ menu
erickson [Fri, 15 Jan 2010 21:15:10 +0000 (21:15 +0000)]
Patch from Lebbeous Fogle-Weekley to add access keys to the ACQ menu

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15331 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Dan Wells to make the results returned when using in-db circ look more...
erickson [Fri, 15 Jan 2010 21:06:00 +0000 (21:06 +0000)]
Patch from Dan Wells to make the results returned when using in-db circ look more like those of the legacy circ scripts.  For more details plus DCO, see libmail.georgialibraries.org/pipermail/open-ils-dev/2010-January/005703.html

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15328 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agopatch from Lebbeous Fogle-Weekley to exit gracefully from timestamp display when...
erickson [Fri, 15 Jan 2010 20:47:36 +0000 (20:47 +0000)]
patch from Lebbeous Fogle-Weekley to exit gracefully from timestamp display when the timestamp value is null/empty

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15325 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorepaired copy/paste thinko in edi_account provider link
erickson [Fri, 15 Jan 2010 16:20:28 +0000 (16:20 +0000)]
repaired copy/paste thinko in edi_account provider link

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15324 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoIn acq.fund_transfer: make the dest_fund and dest_amount columns nullable.
scottmk [Fri, 15 Jan 2010 16:10:49 +0000 (16:10 +0000)]
In acq.fund_transfer: make the dest_fund and dest_amount columns nullable.
That way they can accommodate deallocations, where we move money out of a
fund without moving it into another fund.

A    upgrade/0135.schema.acq.fund_transfer_nulls.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15323 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Joe Atzberger, with some IDL additions, to add a new generic remote_accoun...
erickson [Fri, 15 Jan 2010 15:57:49 +0000 (15:57 +0000)]
Patch from Joe Atzberger, with some IDL additions, to add a new generic remote_account table for managing ftp/scp/etc logins and a subclass table specific to ACQ providers, initially for EDI retrieval and delivery.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15322 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMove the decode_utf8() call for various feeds to entityize()
dbs [Thu, 14 Jan 2010 04:54:48 +0000 (04:54 +0000)]
Move the decode_utf8() call for various feeds to entityize()

decode_utf8() is special in that it won't transform any string once
its 'utf8' flag has been set, so it is a safe subroutine to call
multiple times for a given string.

As it turns out, SRU (and in turn Z39.50) is suffering from a double-encoding
of the search terms, so we have to forcefully double-decode the terms with
the decode('utf8') variation that does not respect the 'utf8' string.

This will enable Z39.50 and SRU queries to actually return results for
queries like 'Montréal' and 'Québec'. Eventually we need to figure out
where in the SRU/CGI stack the strings are being incorrectly encoded in
the first place, but for now a much-improved Z39.50 server seems acceptable.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15320 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCall decode_utf8() to generate clean output in HTML feeds
dbs [Thu, 14 Jan 2010 04:22:13 +0000 (04:22 +0000)]
Call decode_utf8() to generate clean output in HTML feeds

Tested on Debian Lenny and Ubuntu Karmic

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15319 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFactor out the aou-fetching code into a useful subroutine, get_ou($org)
dbs [Thu, 14 Jan 2010 03:21:25 +0000 (03:21 +0000)]
Factor out the aou-fetching code into a useful subroutine, get_ou($org)

Then use get_ou to make the bookbag_feed and changes_feed marginally smarter,
so that you can now pass ?searchOrg=BR1 or ?searchOrg=4 to limit the holdings
display scope.

Useful stuff if you're plodding along with bookbags-as-reserves in a
consortial environment.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15318 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoThis adds the ability to specify courier codes in transit and hold/transit slip templ...
phasefx [Wed, 13 Jan 2010 20:25:51 +0000 (20:25 +0000)]
This adds the ability to specify courier codes in transit and hold/transit slip templates via a %courier_code% macro and a lib.courier_code org unit setting.

So if an item at library BR1 is to be routed to library BR2, the org unit setting for BR2 is retrieved and that value is used for %courier_code%.

POSSIBLE TODO: Add simple interface-scoped caching for the courier code lookup (and perhaps for the mailing address lookup as well)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15315 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Lebbeous Fogle-Weekley providing final, cut-1 cleanup of booking
miker [Wed, 13 Jan 2010 14:59:47 +0000 (14:59 +0000)]
Patch from Lebbeous Fogle-Weekley providing final, cut-1 cleanup of booking

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15309 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Galen Charlton fixing two typos in the fast-extract support script
miker [Tue, 12 Jan 2010 20:38:10 +0000 (20:38 +0000)]
Patch from Galen Charlton fixing two typos in the fast-extract support script

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15306 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomove load_MARC_rec into separate package to prep for creating new test scripts
djfiander [Tue, 12 Jan 2010 02:14:38 +0000 (02:14 +0000)]
move load_MARC_rec into separate package to prep for creating new test scripts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15302 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomove test data into external file to prep for creating additional test files
djfiander [Tue, 12 Jan 2010 02:03:25 +0000 (02:03 +0000)]
move test data into external file to prep for creating additional test files

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15301 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoGet consistent about "title : subtitle" in mods_slim
dbs [Mon, 11 Jan 2010 19:17:05 +0000 (19:17 +0000)]
Get consistent about "title : subtitle" in mods_slim

By teaching get_field_value() to prepend " : " to our incoming value
if the element name is "subTitle", we can ensure that records with a
title / subtitle structure have a consistent structure. Academics love
subtitles, so this was pretty glaring at Conifer.

This has a bonus effect of not appending colons after leading articles
(nonSort elements), which was annoying for "Der schutz" and the like.
Academics have a number of non-English / non-French / non-Spanish titles;
the MODS transform honours the non-filing indicator so this is a more
consistent method of generating the appropriate result.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15299 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd a boolean "propagate" column to acq.fund, to denote whether
scottmk [Mon, 11 Jan 2010 16:55:39 +0000 (16:55 +0000)]
Add a boolean "propagate" column to acq.fund, to denote whether
the fund should be propagated from one year to the next.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0132.schema.acq.fund-propagable.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15298 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCorrect the value of upgrade_log.version to match file name
scottmk [Mon, 11 Jan 2010 15:11:19 +0000 (15:11 +0000)]
Correct the value of upgrade_log.version to match file name

M    upgrade/0131.schema.serials.protect-delete.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15295 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRemove serial ingest references and services
dbs [Mon, 11 Jan 2010 00:39:25 +0000 (00:39 +0000)]
Remove serial ingest references and services

The references and services for serial (MFHD) support are not
necessary in 1.6, as we are working directly with the MFHD as
maintained in serial.record_entry.marc; the services and
references being removed never could have been used in the release and should have been removed prior to the
release when I removed the corresponding database structures.

Also updating the README to reflect the proper loading method for
serial records, dropping direct_ingest.pl invocation and noting the
limitation on the org_unit identification.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15292 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFirst pass at formatting holdings properly, including textual holdings statements
djfiander [Sun, 10 Jan 2010 21:50:21 +0000 (21:50 +0000)]
First pass at formatting holdings properly, including textual holdings statements

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15291 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoquicker entry point for Add Volumes action, by virtue of assuming Workstation Library
phasefx [Fri, 8 Jan 2010 21:30:10 +0000 (21:30 +0000)]
quicker entry point for Add Volumes action, by virtue of assuming Workstation Library

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15290 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Lebbeous Fogle-Weekley adding non-menu entry points for critical reservati...
miker [Fri, 8 Jan 2010 21:13:56 +0000 (21:13 +0000)]
Patch from Lebbeous Fogle-Weekley adding non-menu entry points for critical reservation (booking) interfaces (side-step a new staff client, for now), patron interface integration, and I18n

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15289 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix overdu_circs thinkos from reservation work
miker [Fri, 8 Jan 2010 20:58:30 +0000 (20:58 +0000)]
fix overdu_circs thinkos from reservation work

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15288 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSupport for Fast Item Add in MARC Editor for existing records. Removed a speedbump...
phasefx [Fri, 8 Jan 2010 20:21:58 +0000 (20:21 +0000)]
Support for Fast Item Add in MARC Editor for existing records.  Removed a speedbump.  Clear fast item barcode field after record save.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15286 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Lebbeous Fogle-Weekley implementing pickup and return interfaces for booki...
miker [Fri, 8 Jan 2010 16:15:47 +0000 (16:15 +0000)]
Patch from Lebbeous Fogle-Weekley implementing pickup and return interfaces for booking reservations ... WE ARE SO CLOSE I CAN TASTE IT.  Minor reworking of Circulate.pm changes.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15285 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoA/T penalty.* hooks now have a core_type of 'ausp', not 'au'. pass the ausp (user...
erickson [Fri, 8 Jan 2010 14:20:45 +0000 (14:20 +0000)]
A/T penalty.* hooks now have a core_type of 'ausp', not 'au'.  pass the ausp (user penalty) object during event autocreate instead of the user

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15278 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBucket related enhancements:
phasefx [Thu, 7 Jan 2010 21:17:03 +0000 (21:17 +0000)]
Bucket related enhancements:
* Add to Record Bucket action for Item Status interface
* Authoritative methods in bucket interfaces immune to database replication lag
* Removed a CGI param for better caching of the quick Add to Record Bucket interface
* Added a cat.util.add_titles_to_bucket utility method (but forgot to put it into cat.util.EXPORT_OK, though harmless)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15271 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix Edit MARC Order Record action for Acquisitions within the staff client
phasefx [Thu, 7 Jan 2010 17:01:46 +0000 (17:01 +0000)]
fix Edit MARC Order Record action for Acquisitions within the staff client

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15270 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoThis fixes the checkbox selector in Vandelay's Inspect Queue interface, so you can...
phasefx [Thu, 7 Jan 2010 16:14:25 +0000 (16:14 +0000)]
This fixes the checkbox selector in Vandelay's Inspect Queue interface, so you can, for example, check a specific record in the queue and do Actions ->
Import Selected without the progressmeter hanging with a dojo.byId() is null error.  The formatter for the checkbox column in the table gets called
multiple times for a given row, and the first time it gets called it's using an id of null.  Subsequent calls with a real id replace the HTML generated.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15269 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoWe don't actually have access to the config from $self, but we can get it from OpenIL...
dbs [Thu, 7 Jan 2010 00:19:56 +0000 (00:19 +0000)]
We don't actually have access to the config from $self, but we can get it from OpenILS::SIP

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15268 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoTypo: in theory fixing this will eliminate some calls
dbs [Thu, 7 Jan 2010 00:00:53 +0000 (00:00 +0000)]
Typo: in theory fixing this will eliminate some calls

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15267 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoProtect serials from being deleted with ye olde ON DELETE rule
dbs [Wed, 6 Jan 2010 22:16:45 +0000 (22:16 +0000)]
Protect serials from being deleted with ye olde ON DELETE rule

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15266 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix dojo columnpicker glitches for restrained window dimensions
phasefx [Wed, 6 Jan 2010 21:48:40 +0000 (21:48 +0000)]
fix dojo columnpicker glitches for restrained window dimensions

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15265 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Lebbeous Fogle-Weekley to reservation pull list and resource capture inter...
miker [Wed, 6 Jan 2010 18:13:28 +0000 (18:13 +0000)]
Patch from Lebbeous Fogle-Weekley to reservation pull list and resource capture interfaces, and supporting backend and ML changes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15264 dcc99617-32d9-48b4-a31d-7c20da2025e4