]> git.evergreen-ils.org Git - Evergreen.git/commit
Fix LP1180140, View Holds not working for a serial with subscription and no issuances
authorSteven Chan <schan@sitka.bclibraries.ca>
Wed, 15 May 2013 21:30:15 +0000 (14:30 -0700)
committerLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Thu, 12 Dec 2013 21:43:40 +0000 (16:43 -0500)
commit95ae747f0e0317013dd6838b65187544769b092c
tree235b53d41a404b053e3e298a460e9c2f390ed03b
parentb22be745f55541d841c20ce98d2f98db03012f57
Fix LP1180140, View Holds not working for a serial with subscription and no issuances

A request is made to
open-ils.circ.holds.retrieve_all_from_title,
which is the function Circ/Holds.pm/all_rec_holds().

In the function, when checking for issuance holds, there is a missing @
to dereference the list of issuance IDs, so that the ahr table is search
with badly formed input, which results in returning an undefined list
instead of an empty list.  The error will occur for any record with a
serial.subscription entry but with no related entries in
serial.issuance.

We also recode the initialization of the response object in order to
clarify its expected structure, a hash of array references.

Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm