]> git.evergreen-ils.org Git - Evergreen.git/commit
LP2030915: Restrain creation of AutorenewNotify events
authorJason Stephenson <jason@sigio.com>
Thu, 10 Aug 2023 13:09:45 +0000 (09:09 -0400)
committerJason Stephenson <jason@sigio.com>
Fri, 25 Aug 2023 15:57:14 +0000 (11:57 -0400)
commit635cc3971e11f883a2db7d25276b47248960e9ac
tree4e26ae29235f5000350d64c4b94308cbf7e31475
parente1dccfb02086fbe25265a3d17f3c999313d38dc9
LP2030915: Restrain creation of AutorenewNotify events

Using a connected open-ils.trigger session to create AutorenewNotify
events without gathering the results can overwhelm the
open-ils.trigger drones leading to errors while processing the
Autorenew events. These errors may cascade causing additional
Autorenew events to error.

By switching from calling request() on a connected open-ils.trigger
session to using the simplereq() function from AppUtils, we cause the
event creation code to 1) gather the results, thus waiting on the call
to finish before making another, and 2) make a new connection to
open-ils.trigger for each AutorenewNotify event creation. The latter
leads to fewer drones being used and avoids a case where a connected
drone may disappear without notifying the connected client.

Co-authored-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/Circ/AutoRenew.pm