LP#
2044051: fix item alerts dialog in various interfaces
This patch removes the dependency of CopyAlertsDialogComponent on
VolCopyService introduced in the patch for bug
2017673. While the
attempt avoided repeating logic for getting the default value
from the holdings editor settings, it created a set of unresolved
dependency injection issues that prevented various Angular
circulation interfaces from loading.
Some refactoring is in order so that management of user and workstation
settings that require a bit more than just simple fetch logic don't
require tight coupling between large modules.
To test
-------
[1] Attempt to open (say) the Angular check in page. Note that
the page does not load and there are console warnings about
dependencies.
[2] Apply the page and repeat step 1. This time, the page should
load.
[3] Verify that setting the default item alert type in the Angular
holdings editor will set the default type in _Angular_ interfaces
that invoke the item alert management dialog. (Note when testing
that the server-side eg.cat.volcopy.defaults setting can get
cached on a per-tab basis by ServerStorageService, so tab
refreshes can be needed to see a new default item alert type
take effect.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Steven Mayo <smayo@georgialibraries.org>