]> git.evergreen-ils.org Git - Evergreen.git/commit
LP 115706: Avoid Internal Server Errors with Hold Count Retrieval
authorJason Stephenson <jason@sigio.com>
Tue, 7 Aug 2018 14:02:10 +0000 (10:02 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Fri, 31 May 2019 14:44:01 +0000 (10:44 -0400)
commit3c83c709aef2252ea186fc495511f3353d3de39e
treead1fd395857611dd7338a803b78518bc66b08f95
parentf9d0c91b0a8868f8606a5d9ae169f18ed4ef05e7
LP 115706: Avoid Internal Server Errors with Hold Count Retrieval

It can happen that the query to get a record's hold count can run too
long and timeout or fail for some other reason.  When this happens,
the user sees an Internal Server Error.  The underlying cause is the
following Perl error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.22.1/OpenILS/Application/Circ/Holds.pm line
4264.

This commit rearranges the code around that line to avoid this
particular undefined value reference error.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm