]> git.evergreen-ils.org Git - Evergreen.git/commit
Lp 1835620: Require some Storage submodules instead of use them
authorJason Stephenson <jason@sigio.com>
Sun, 7 Jul 2019 11:18:01 +0000 (07:18 -0400)
committerJason Boyer <jboyer@equinoxinitiative.org>
Wed, 23 Oct 2019 14:33:01 +0000 (10:33 -0400)
commit2c4667fed9ad332866df5e655f967953a9dd8de5
treef1207e59d9a78f573e1007e3fc224ca0e036d993
parent1de4eaa247a144c03e775a566da2452192807ce2
Lp 1835620: Require some Storage submodules instead of use them

Switch from "use" to "require" for submodules in OpenILS::Application
::Storage::CDBI and OpenILS::Application::Storage::Driver::Pg.
Circular dependencies and other issues cause the following errors at
compile time for those modules:

Compilation failed in require at
/usr/local/share/perl/5.28.1/OpenILS/Application/Storage/CDBI.pm line
9.

Compilation failed in require at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Driver/Pg.pm
line 15.

Require loads the submodules at run time and does not attempt to
import any methods.  This is the behavior we want, eliminates the
above errors, and everything still works.

Add comments above the required modules explaining why require is
needed and not use.

Enable and reorder all of the tests in Open-ILS/src/perlmods/t/
09-OpenILS-Application-Storage-Driver.t.  Repairing the above issue
also repairs these tests.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg.pm
Open-ILS/src/perlmods/t/09-OpenILS-Application-Storage-Driver.t