]> git.evergreen-ils.org Git - Evergreen.git/commit - Open-ILS/web/conify/global/actor/org_unit.js
replace Cookie.js/cookieManager with dojo.cookie. Some things to watch out for as...
authorphasefx <phasefx@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Wed, 10 Nov 2010 20:51:23 +0000 (20:51 +0000)
committerphasefx <phasefx@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Wed, 10 Nov 2010 20:51:23 +0000 (20:51 +0000)
commit2cebe64791d112d3061d25c828b837e11b308ec8
treef54381f960230d447bbcfbff191f298eb3b2890b
parentf98b556f193f5ce179c785e88aa027a959e5c082
replace Cookie.js/cookieManager with dojo.cookie.  Some things to watch out for as we review this changeset:

In Cookie.js, a -1 passed as the expires parameter indicated a session cookie.  We could also specify such things as "+1y" or a specific date.  With dojo.cookie, an expires value of -1 deletes a cookie.  Not specifying an expires option will create a session cookie.  We can enter a date or a number days from today.  For the case in the code where we had "+1y", I supplied a value of 365.

In the previous code, we used empty strings for a lot of cookie deletion.  The canonical dojo example has us using null (with an expires of -1).  There were also some cases where it seemed obvious that we were deleting cookies, but were at the same passing an actual value (see base.js).  I changed these to nulls.

In opac_utils.js, grabFleshedUser(), I fixed a dead code path where a cookie deletion attempt came after a return statement.

I ran through the opac within and outside of the staff client, tried all of the acquisition UI's from the Acq menu, and most of the interfaces under Admin, and didn't find any auth cookie errors.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18687 dcc99617-32d9-48b4-a31d-7c20da2025e4
36 files changed:
Open-ILS/web/conify/global/actor/org_unit.html
Open-ILS/web/conify/global/actor/org_unit.js
Open-ILS/web/conify/global/actor/org_unit_type.html
Open-ILS/web/conify/global/actor/org_unit_type.js
Open-ILS/web/conify/global/config/copy_status.html
Open-ILS/web/conify/global/config/copy_status.js
Open-ILS/web/conify/global/config/marc_code_maps.html
Open-ILS/web/conify/global/permission/grp_tree.html
Open-ILS/web/conify/global/permission/grp_tree.js
Open-ILS/web/conify/global/permission/perm_list.html
Open-ILS/web/conify/global/permission/perm_list.js
Open-ILS/web/js/ui/base.js
Open-ILS/web/opac/common/js/RemoteRequest.js
Open-ILS/web/opac/common/js/opac_utils.js
Open-ILS/web/opac/extras/bbags.xml
Open-ILS/web/opac/extras/circ/alt_holds_print.html
Open-ILS/web/opac/extras/selfcheck/selfcheck.js
Open-ILS/web/opac/extras/selfcheck/selfcheck.xml
Open-ILS/web/opac/skin/craftsman/js/sidebar.js
Open-ILS/web/opac/skin/default/js/adv_global.js
Open-ILS/web/opac/skin/default/js/mresult.js
Open-ILS/web/opac/skin/default/js/rresult.js
Open-ILS/web/opac/skin/default/js/sidebar.js
Open-ILS/web/opac/skin/default/xml/common/js_common.xml
Open-ILS/web/reports/oils_rpt.js
Open-ILS/web/reports/oils_rpt_common.xhtml
Open-ILS/web/reports/xul/template_builder.xul
Open-ILS/xul/staff_client/server/admin/cash_reports.xhtml
Open-ILS/xul/staff_client/server/admin/closed_dates.xhtml
Open-ILS/xul/staff_client/server/admin/copy_locations.xhtml
Open-ILS/xul/staff_client/server/admin/hold_pull_list.xhtml
Open-ILS/xul/staff_client/server/admin/hold_pull_list_classic.xhtml
Open-ILS/xul/staff_client/server/admin/non_cat_types.xhtml
Open-ILS/xul/staff_client/server/admin/stat_cat_editor.xhtml
Open-ILS/xul/staff_client/server/main/data.xul
Open-ILS/xul/staff_client/server/patron/ue.xhtml