]> git.evergreen-ils.org Git - evergreen/pines.git/commit
LP#1944601: Checkout Fails Silently if Operating Hours Set to Closed 7 Days a Week
authorSteven Mayo <smayo@georgialibraries.org>
Wed, 27 Sep 2023 20:27:03 +0000 (16:27 -0400)
committerChris Sharp <csharp@georgialibraries.org>
Fri, 3 Nov 2023 14:35:02 +0000 (10:35 -0400)
commitd91f4b3774a3ad5b8857d309d1703f7692865c64
tree9eb59ba7361c8540e34edffcd38eb8260db15230
parent6198a2eb0bc8d5feede76630f2f0f3bec14c9570
LP#1944601: Checkout Fails Silently if Operating Hours Set to Closed 7 Days a Week

This fixed an issue where a checkout or renewal would timeout and fail
without an error message if attempted from an org unit where
all hours of operation were closed, every day of the week. This
would cause open-ils.storage.actor.org_unit.closed_date.overlap to infinitely recurse without throwing an
error.

-- How to test
[1] Go to Administration -> Server Administration-> Organizational Units
[2] Select an Org Unit and the Hours of Operation tab
[3] Click on closed button or manually set start and end times to 12:00
AM for all days and apply changes
[4] Observe pretty new warning
[5] Ensure link in pretty new warning leads to the right page
[6] Using a workstation at the affected org unit, attempt to check out a
book and renew a checked out book.
[7] Go to the page the new warning links to: Administration -> Local Administration ->
Closed Dates Editor
[8] Add a closing of whatever length you desire, including now
and/or the date an item would be due if checked out today.
[9] Using a workstation at the affected org unit, attempt to check out a
book and renew a checked out book.

Signed-off-by: Steven Mayo <smayo@georgialibraries.org>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm