]> git.evergreen-ils.org Git - evergreen/pines.git/commit
Quipu Online Account Renewal - Squashed
authorTerran McCanna <tmccanna@georgialibraries.org>
Thu, 5 Aug 2021 22:36:17 +0000 (18:36 -0400)
committerChris Sharp <csharp@georgialibraries.org>
Mon, 12 Dec 2022 15:26:00 +0000 (10:26 -0500)
commitc7f6e10541b96742ade840654c31d195de53cc30
tree9c0f40fb26139c70e885d09562f5597c313c6442
parent73ceba993f847d70f0ba82beab692b1823a86319
Quipu Online Account Renewal - Squashed

Online Renewal - Start of working branch

- Creates placeholders for new English & Spanish pages
- Adds ability for those pages to load
- Create div on My Account main page & prefs page to hold renewal message or button
- Adds code to check whether or not patron is eligible to renew online or not:
* patron has not already had one temporary renewal
* patron account is still active
* patron account expiration date is no more than 30 days in the future
* patron account is not barred
* patron account does not have a staff-added blocking alert
* patron does not owe any fines
* patron is not in collections (even if patron pays fines, staff still need
to remove collections note)
* patron is in one of these perm groups: Patron (2), Friend (14), GLS (56),
Homebound (53), Trustee (22), Quipu (64), Digital Only (60)
* patron has a valid billing address
* patron has a valid day phone

NOTE: New standing penalty needs to be created called PATRON_TEMP_RENEWAL.
It should display a staff alert and have the label "Patron was given a 30-day temporary account renewal. Please archive this message after the account is fully renewed." It should not create any type of block on its own. The ID of
the new standing penalty needs to be updated in the Account.pm file.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Add standing penalty

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal: Flesh out patron info in API

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Create new API instead of piggybacking on vital_stats

New api: open-ils.actor.user.opac.renewal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Create page to hold embedded form

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - First stab at adding erenew to Ecard.pm

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
further typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
even further typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
even FURTHER typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
declare the variable, and update it if needed

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
declare the variable once, then update the values

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Online Renewal - Remove old subroutines we don't use

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Add page routing to EGCatLoader

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Retrieve patron then update fields to push back

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Exceptions for temp renewal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Fix msg declaration error

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Get URL path in a different way

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - fix typos

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Progress on writing quipu into to db

Still to do:
* Actor.pm - failing on standing penalties line 597
* sub update_addresses - creating separate addresses works if mailing & billing are different,
   but it is not checking the right checkbox
* writing new home ou is failing on terran-test, but should work on pines data
* after update, opac page doesn't refresh
* if this is a temporary (30 day) renewal, need to pass message to quipu telling patron to come to the library
* if temp renewal, need to add alert to patron account to inform staff to get proof of identity to do full renewal
* need to test voter registration survey on pines test server since I don't have that on my test server

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Show Updated Expire Date

Without this, the page loads the initial patron expiration date
and continues to show the button to renew the account.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Document which patron groups are eligible in code

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Now saving and responding okay

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
add column to permission.grp_tree to account for e-renew

Online Renewal - tweak SQL

- Parentheses on first SQL generated error.
- Set erenew default to FALSE instead of TRUE.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - See & update permission group setting through staff client

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Tweak new standing penalty

The ID of the standing penalty has to be under 100 to prevent
staff from manually adding it to patron accounts through the
client interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Add Standing Penalty when Temp Renewal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Use standing penalty names instead of IDs

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - add temp renewal flag to quipu response

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Remove perm group ID references

Look up permission groups by name or by e-renewal eligibility flag
instead of by specific permission group ID.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Got surveys working

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Progress on updating addresses

(still issues with checkmarks when changing from 1 to 2
addresses or from 2 to 1 address)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Got address changes to save in the right way

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - add date to quipu name keyword entry

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Add check for valid mailing address

Only allow renewal option if neither mailing nor billing
addresses have been marked invalid.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Cleanup

- Get rid of subroutine I didn't end up using
- Make sure a user is logged in before showing the renewal form.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Prevent user from re-submitting renewal after complete

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
15 files changed:
Open-ILS/examples/fm_IDL.xml
Open-ILS/src/eg2/src/app/staff/admin/server/perm-group-tree.component.html
Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI/permission.pm
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm
Open-ILS/src/sql/Pg/006.schema.permissions.sql
Open-ILS/src/sql/Pg/950.data.seed-values.sql
Open-ILS/src/sql/Pg/upgrade/XXXX-quipu-standing_penalty.sql [new file with mode: 0644]
Open-ILS/src/sql/Pg/upgrade/XXXX.schema.erenew_column_pgt.sql [new file with mode: 0644]
Open-ILS/src/templates-bootstrap/opac/myopac/main.tt2
Open-ILS/src/templates-bootstrap/opac/myopac/prefs.tt2
Open-ILS/src/templates-bootstrap/opac/renew-account-sp.tt2 [new file with mode: 0644]
Open-ILS/src/templates-bootstrap/opac/renew-account.tt2 [new file with mode: 0644]