Tidying up various things; nothing very substantial.

Tidying up various things; nothing very substantial.

1. Added newlines and indentation within long macros to make them look
more like real code.

2. The OSRF_METHOD_VERIFY_DESCRIPTION macro is not used anywhere.  I
moved it from the header into the implementation file and commented it
out, preserving it like a fly in amber in case we ever want to revive it.

3. Moved the definition of the struct osrfApplication from the header
into the application file, since no other file references it.

4. Moved the OSRF_SYSMETHOD_* macros from the header into the implementation
file, since they are not referenced elsewhere.

5. Turned _osrfAppFindApplication() and osrfAppFindMethod into inline
functions, since each is a trivial wrapper for another function.

6. Added a formal void parameter to osrfAppRunExitCode, so that its
signature is a prototype rather than a mere declaration.

7. Removed a couple of redundant sanity checks.

8. Further tinkered with comments and white space.

M    include/opensrf/osrf_application.h
M    src/libopensrf/osrf_application.c

git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1933 9efc2488-bf62-4759-914b-345cdb29e865